fix #435 (part 2, closes it): attribute the unowned probes — delete 7, reclassify 8, restore 1

Part 1 deleted probes whose owning issues were closed. These 14 named no
issue at all, so each was traced to its introducing commit
(git log -S) instead of guessed at. Attribution split them three ways:

DELETED (7, investigations closed): ACDREAM_A8_DUMP_PV and
ACDREAM_DUMP_LIVE_SPAWNS (Phase A8), ACDREAM_DUMP_CLOTHING (#37),
ACDREAM_DUMP_EDGE_SLIDE (#32), ACDREAM_DUMP_STEPUP (L.2.3d-f),
ACDREAM_DUMP_VENDOR (the vendor campaign, 25 call sites across 8 files),
ACDREAM_DUMP_VITALS (#5, four independent read sites). VendorDiagnostics.cs
went entirely.

RECLASSIFIED (8, tools misfiled as probes): the DUMP_CELLS/DUMP_GFXOBJS
fixture-extraction family (replay-harness tooling with a roundtrip test),
PROBE_CELL (standing cell-transit tracer, pair of the permanent
PROBE_RESOLVE), DUMP_SKY and HIDE_PART (generic isolation tools), and
DUMP_STEEP_ROOF — which looked like an L.4 relic but observes LIVE
divergence-register row AD-56; deleting it would have removed the only
runtime lens on an active divergence. All moved to Permanent diagnostics
with their attribution recorded.

RESTORED (1): ACDREAM_DUMP_MOVE_TRUTH was deleted and un-deleted the same
day. It is not a probe — the canonical nine-stop soak
(run-connected-r6-soak.ps1) hard-fails every destination without its
'move-truth OUT' records, with a message that would misdirect the next
operator. Under the no-workarounds rule the gate's mechanism is restored,
not left broken with an IOU (#437, closed). Process lesson recorded on
both issues: a closed owning issue is NOT sufficient to delete a probe —
grep tools/ and the contract tests for consumers first.

Also lands the owner-requested default-off invariant: every diagnostic in
the codebase is inert until its env var is explicitly set. Exactly four
flags default ON and none is a diagnostic — RETAIL_CHASE, CAMERA_COLLIDE,
CAMERA_ALIGN_SLOPE, RETAIL_CLOSE_DEGRADES are retail behaviors wearing an
A/B off-switch. That set is now FROZEN by
LaunchOptionsDocumentationTests.OnlyTheFourRetailBehaviorFlagsDefaultOn;
docs/launch-options.md's Conventions and CLAUDE.md state the rule, and
CLAUDE.md now binds future probes to a documented row in the same commit.

The client reads 137 environment variables (161 at audit start); 40
temporary probes remain, every one attributed. Full hermetic suite 15,322
passed / 0 failed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/AcDream.App/Interaction/PlayerInteractionMovementSink.cs

@@ -61,14 +61,6 @@ internal sealed class PlayerInteractionMovementSink(
             Height = approach.TargetHeight,
         };
 
-        if (VendorDiagnostics.DumpVendorEnabled)
-        {
-            Console.WriteLine(
-                $"[vendor-diag] BeginApproach guid=0x{approach.Target.ServerGuid:X8} "
-                + $"movementType={movement.Type} distanceToObject={parameters.DistanceToObject} "
-                + $"canCharge={parameters.CanCharge} target=0x{movement.ObjectId:X8}");
-        }
-
         // PerformMovement cancels at its head. Do it explicitly before the
         // intent is armed so cancellation of the preceding move cannot clear
         // the new request; the internal second call is then a retail no-op.

src/AcDream.App/Interaction/SelectionInteractionController.cs

@@ -181,11 +181,6 @@ internal sealed class SelectionInteractionController
         // ships with it.
         if (useImmediately && !_query.IsWieldedByPlayer(guid))
         {
-            if (VendorDiagnostics.DumpVendorEnabled)
-            {
-                Console.WriteLine(
-                    $"[vendor-diag] route=dblclick-world PickAndStoreSelection guid=0x{guid:X8} enqueue=Activate");
-            }
             EnqueueIdentityBound(
                 RuntimeQueuedInteractionKind.Activate,
                 guid,
@@ -221,11 +216,6 @@ internal sealed class SelectionInteractionController
             _toast?.Invoke("Nothing selected");
             return;
         }
-        if (VendorDiagnostics.DumpVendorEnabled)
-        {
-            Console.WriteLine(
-                $"[vendor-diag] route=keyboard-use UseCurrentSelection guid=0x{selected:X8} enqueue=Use");
-        }
         EnqueueIdentityBound(
             RuntimeQueuedInteractionKind.Use,
             selected,
@@ -292,22 +282,10 @@ internal sealed class SelectionInteractionController
         bool ownedByPlayer = _items.IsOwnedByPlayer(serverGuid);
         bool useable = ownedByPlayer || _query.IsUseable(serverGuid);
 
-        if (VendorDiagnostics.DumpVendorEnabled)
-        {
-            Console.WriteLine(
-                $"[vendor-diag] RequestUse entry guid=0x{serverGuid:X8} ownedByPlayer={ownedByPlayer} useable={useable}");
-        }
-
         if (useable
             && _query.TryGetApproach(serverGuid, out InteractionApproach approach)
             && !approach.IsCloseRange)
         {
-            if (VendorDiagnostics.DumpVendorEnabled)
-            {
-                Console.WriteLine(
-                    $"[vendor-diag] RequestUse guid=0x{serverGuid:X8} branch=approach-armed useRadius={approach.UseRadius} isCloseRange={approach.IsCloseRange}");
-            }
-
             // Genuinely out of range (a real walk, not just a turn) —
             // mirror SendPickup's arrival-gated shape: arm the transaction
             // on the approach token BEFORE the movement starts (so a
@@ -327,17 +305,7 @@ internal sealed class SelectionInteractionController
                             token.ControllerLifetime,
                             token.ApproachGeneration),
                         out _);
-                    if (VendorDiagnostics.DumpVendorEnabled)
-                    {
-                        Console.WriteLine(
-                            $"[vendor-diag] TryArmPostArrivalUse guid=0x{serverGuid:X8} armed={armed} approachToken=({token.ControllerLifetime},{token.ApproachGeneration})");
-                    }
                 });
-            if (VendorDiagnostics.DumpVendorEnabled)
-            {
-                Console.WriteLine(
-                    $"[vendor-diag] BeginApproach-result guid=0x{serverGuid:X8} started={started} armed={armed} stopDistance={approach.UseRadius} target=0x{approach.Target.ServerGuid:X8}");
-            }
             if (!started || !armed)
             {
                 // Release whatever got captured (or the caller's own
@@ -360,11 +328,6 @@ internal sealed class SelectionInteractionController
         // — keep retail's immediate send; ACE's own "already within use
         // distance" branch (Player_Move.cs:65-87) calls back synchronously,
         // so there is no arrival gap to race here.
-        if (VendorDiagnostics.DumpVendorEnabled)
-        {
-            Console.WriteLine(
-                $"[vendor-diag] RequestUse guid=0x{serverGuid:X8} branch=immediate-dispatch ownedByPlayer={ownedByPlayer} useable={useable}");
-        }
         RuntimeInteractionDispatchResult result =
             _transactions.TryDispatchUse(
                 serverGuid,
@@ -373,11 +336,6 @@ internal sealed class SelectionInteractionController
                 reservation,
                 _transport,
                 out uint sequence);
-        if (VendorDiagnostics.DumpVendorEnabled)
-        {
-            Console.WriteLine(
-                $"[vendor-diag] RequestUse guid=0x{serverGuid:X8} TryDispatchUse verdict={result} seq={sequence}");
-        }
         if (result == RuntimeInteractionDispatchResult.NotInWorld)
             _toast?.Invoke("Not in world");
         if (result == RuntimeInteractionDispatchResult.Dispatched)
@@ -609,22 +567,6 @@ internal sealed class SelectionInteractionController
         RuntimePendingUse pending,
         bool accepted)
     {
-        if (VendorDiagnostics.DumpVendorEnabled)
-        {
-            // Diagnostic-only re-query — TryGetApproach is a pure read with
-            // no side effects, so an extra call here (gated off in
-            // production) cannot change RequestUse's own dispatch outcome.
-            string distanceText = "n/a";
-            if (_query.TryGetApproach(pending.ServerGuid, out InteractionApproach diagApproach))
-            {
-                float dx = diagApproach.Target.Entity.Position.X - diagApproach.Player.Position.X;
-                float dy = diagApproach.Target.Entity.Position.Y - diagApproach.Player.Position.Y;
-                distanceText = MathF.Sqrt(dx * dx + dy * dy).ToString("F2");
-            }
-            Console.WriteLine(
-                $"[vendor-diag] HandleUseApproachCompletion guid=0x{pending.ServerGuid:X8} accepted={accepted} playerToTargetDist={distanceText}");
-        }
-
         if (!accepted)
         {
             pending.Reservation?.CancelBeforeDispatch();

src/AcDream.App/Interaction/WorldSelectionQuery.cs

@@ -571,12 +571,6 @@ internal sealed class WorldSelectionQuery
         bool haveSpawn = _liveEntities.TryGetSnapshot(serverGuid, out var spawn);
         bool fromWire = haveSpawn && spawn.UseRadius is > 0f;
         float radius = fromWire ? spawn.UseRadius!.Value : DefaultUseRadius;
-        if (VendorDiagnostics.DumpVendorEnabled)
-        {
-            Console.WriteLine(
-                $"[vendor-diag] GetUseRadius guid=0x{serverGuid:X8} radius={radius} "
-                + $"source={(fromWire ? "wire" : "fallback-0.6")}");
-        }
         return radius;
     }
 }