fix(chargen): Campaign CC gate round 1 closeout — Group 3: round review fixes (F4-F11, F14, F16)
The remaining code-bearing findings from the round review, F4-F16 minus the doc-only items (batched separately): - F4: three client-wide UiButton corpus sweeps (LabelBox path — exactly the 4 Town buttons, confined to chargen; conflicting custom-selection- pair + standard Normal/Highlight media — zero found, no gate tightening needed; per-state label-color map — 209 matches beyond chargen, confirming AP-222's mechanism has always been broadly active since it shipped generically in DatWidgetFactory). - F5/F6: LayoutImporter's Batch C un-consumed-children carve-out now honors a child's own AuthoredInvisible flag (a narrow honor scoped to exactly that carve-out, not the general #408 client-wide one) — the chat transcript's new-text indicator (0x1000048C) was building as a visible phantom element retail never shows; verified both directions against the gold-frame pieces, which do not author Invisible. - F7: BoundedProcessOutputCapture.AppendLine combines the line text and its trailing newline into one buffer and one file open/write/close instead of two. - F9: corrected a stale comment in RuntimeSettingsTargets — #407 split DisplayModeCatalog's Resolutions/WindowedResolutions in two, so the fullscreen validator's own narrower list is now DELIBERATELY different from the Config dropdown's fuller offering, not the "must match" bug the comment described. - F10: documented (not changed) why the LabelBox path's default 3px inset and the face-relative +4px gap in DatWidgetFactory.BuildButton are deliberately different numbers — neither carries a retail citation, and moving either to match the other would be an unfounded guess on a button that currently works correctly. - F11: Heritage/Profession/Summary/Town description pages now compose DatRichText.Compose's result ONCE inside their already revision-gated Refresh, caching the built line list instead of re-wrapping on every draw call. - F14: documented (not changed) why PrivateEntityViewportRenderer's _animatedIds set carrying a reserved-but-never-drawn backdrop id is harmless — BuildDrawEntities already excludes a null/empty backdrop from the actual draw list, so the id is never looked up. - F16: the Summary preview now uses its own render-id pair (SummaryPreviewRenderId/SummaryPreviewBackdropRenderId, 0xDA11D035/ 0xDA11D036) instead of sharing the Appearance page's (0xDA11D032/0xDA11D034) — confirmed by tracing FixedEntityTextureOwnerLease through TextureCache to CompositeTextureArrayCache's shared owner tracker that both pages' previews share ONE process-wide TextureCache, so sharing render ids was a real cross-page texture-release collision (either page's own re-dress or disposal could release the OTHER page's still-active textures), not a theoretical one. F3's own register bookkeeping (AP-229 addendum) and F12's register/AD header-count corrections land in the docs-only commit alongside F15. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
0fed5fdd91
commit
bd359d5181
17 changed files with 636 additions and 37 deletions
|
|
@ -87,12 +87,23 @@ internal sealed class SilkRuntimeDisplayWindowTarget : IRuntimeDisplayWindowTarg
|
|||
: this(
|
||||
new SilkWindowSizeSurface(window),
|
||||
new GlfwDisplayModeSwitcher(window),
|
||||
// #391's catalog is the validation source. With no catalog
|
||||
// installed, the dropdown falls back to the static preset
|
||||
// ladder — the validator must fall back to the SAME list
|
||||
// (blast M2: an asymmetric fallback made Full Screen a permanent
|
||||
// silent no-op on catalog-less hosts). The switcher's own
|
||||
// monitor-mode-list check remains the hard guard either way.
|
||||
// F9 correction (Campaign CC gate round 1 closeout, 2026-08-16):
|
||||
// this used to claim the validator "must fall back to the SAME
|
||||
// list" the Config dropdown offers — true when this comment was
|
||||
// written (#391, one catalog for both), but #407 split the
|
||||
// catalog in two: WindowedResolutions (the dropdown's fuller
|
||||
// union offering, since a windowed pick needs no real video
|
||||
// mode) versus Resolutions (the narrower, fullscreen-SAFE
|
||||
// hardware list this validator deliberately reads). Post-#407 a
|
||||
// windowed-only entry submitted for fullscreen is EXPECTED to
|
||||
// fail this check and refuse gracefully (log-and-stay,
|
||||
// #388/#392's own documented behavior) — that is no longer the
|
||||
// blast-M2 silent-no-op bug, it is the correct outcome. With no
|
||||
// catalog installed at all (fixture/headless/UI-Studio hosts),
|
||||
// Resolutions is null and this still falls back to the static
|
||||
// preset ladder, matching every offering DisplayModeCatalog
|
||||
// makes in that state. The switcher's own monitor-mode-list
|
||||
// check remains the hard guard either way.
|
||||
spec => (Rendering.DisplayModeCatalog.Resolutions
|
||||
?? DisplaySettings.AvailableResolutions).Contains(spec))
|
||||
{
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue