fix(ui,runtime): OP4 review fixes — live re-seed, enable-gating, Combat panel re-point, universal timestamps

Both OP4 reviews converged on one headline bug (Character-tab rows never
re-read live server truth after their pre-login constructor-word seed) plus
overlapping MUST-FIXes. All ten converged/consolidated findings land here:

MUST-FIX:
- BoolOptionRow.SaveCurrentValue now re-reads its live binding (retail's
  GetValue()-into-SaveCurrentValue) on every OnShown — panel open, tab
  switch in, initial activation — instead of trusting the pre-login
  constructor word it was built with. Reset/tab-switch can now only
  restore values that were actually live at the last show. LockUI's
  host.Root.UiLocked one-shot mount seed now also converges on every
  PlayerDescription via the existing OnCharacterOptionsChanged hook.
- Apply/Reset are wired to OptionPage.OnOptionChanged in production
  (Ghosted when nothing changed, Normal when dirty, run once at bind so
  both start disabled per retail's PostInit); Defaults stays ungated.
- The Combat panel's three LEDs (Repeat Attacks/Auto Target/Keep in View)
  now read/write the same RuntimeCharacterOptionsState seam the Character
  tab uses instead of a disconnected client-local GameplaySettings copy —
  closes the "two writable copies" divergence. The three now-orphaned
  GameplaySettings fields and RuntimeSettingsController's mirror
  properties/SetCombatGameplay are deleted outright; the headless host's
  hardcoded AutoRepeatAttack/AutoTarget now read the live option bit.
- RuntimeSettingsController.SetUiLocked's convergence guard now compares
  against the last value actually applied to the runtime target instead
  of the persisted GameplaySettings.LockUI snapshot, which could already
  match a server-derived request without ever having been pushed.

SHOULD-FIX:
- DisplayTimeStamps now prefixes every chat producer (ChatLog.Append is
  the one seam all of them funnel through), not just AddText's own
  callers — heard speech, emotes, Turbine channels, and combat text were
  previously missed. The prefix format escapes its colons and forces
  InvariantCulture instead of the culture-dependent TimeSeparator
  placeholder.
- sky.frag now honors uFogParams.w (fog mode) like the mesh/terrain
  shaders, so Disable Distance Fog stops the sky dome's horizon band from
  blending toward fog color too.
- Corrected the "byte-verified" overclaim on the timestamp format string
  doc comment (BN-sourced, wire doc U6) and the AP-194 anchor-column
  class-name typo; the RunAsDefaultMovement doc comments now cite retail's
  actual acclient.h enumerator name.
- Added: DispatcherMovementInputSource's option x modifier truth table
  (incl. || AutoRunActive with the option off), the per-page Apply/Reset
  enable-gate tests, a real checkbox.OnClick/ToggleBehavior-driven click
  test, and hash-pins for the six header string keys.
- Gate script step 8 corrected for the logout-flush false-failure
  (closing the panel before relogging is load-bearing); a new step
  documents the enable-gate sequence and the Combat-panel/Character-tab
  cross-check.

Register: AP-196 (the Group-C default-source change + GameplaySettings
retirement) and AP-197 (the ignored per-character timestamp format
override) filed in this commit.

Full Release suite: 13,044 passed / 4 skipped / 0 failed (was 13,008/4/0;
net +36 tests from new coverage and legitimate assertion updates from the
GameplaySettings retirement).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tests/AcDream.Core.Tests/Chat/ChatLogTests.cs

@@ -1,3 +1,5 @@
+using System.Globalization;
+using System.Threading;
 using AcDream.Core.Chat;
 using AcDream.Core.Combat;
 using Xunit;
@@ -336,4 +338,83 @@ public sealed class ChatLogTests
         log.OnCombatLine("You hit Mosswart for 5 slashing damage (50.0%).", logTextType: 0x06u);
         Assert.Equal(0x06u, log.Snapshot()[0].LogTextType);
     }
+
+    // ── SF-1/S1 (OP4 review-fix round, 2026-08-11): DisplayTimestampsSource
+    //    prefixes EVERY producer through the shared Append seam, not just
+    //    RuntimeCommunicationState.AddText's own subset of callers. ────────
+
+    [Fact]
+    public void DisplayTimestampsSource_Unbound_NoPrefix()
+    {
+        var log = new ChatLog();
+        log.OnLocalSpeech("Alice", "hi", 0xAAu, isRanged: false, logTextType: 0x02u);
+        Assert.Equal("hi", log.Snapshot()[0].Text);
+    }
+
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public void DisplayTimestampsSource_GatesThePrefix(bool timestampsOn)
+    {
+        var log = new ChatLog { DisplayTimestampsSource = () => timestampsOn };
+        log.OnLocalSpeech("Alice", "hi", 0xAAu, isRanged: false, logTextType: 0x02u);
+
+        string text = log.Snapshot()[0].Text;
+        if (timestampsOn)
+            Assert.Matches(@"^\d{1,2}:\d{2}:\d{2} hi$", text);
+        else
+            Assert.Equal("hi", text);
+    }
+
+    [Theory]
+    // Every public ingestion method — proving the prefix applies at the
+    // ONE shared Append seam, not per-caller.
+    [InlineData("OnEmote")]
+    [InlineData("OnSoulEmote")]
+    [InlineData("OnChannelBroadcast")]
+    [InlineData("OnTellReceived")]
+    [InlineData("OnSystemMessage")]
+    [InlineData("OnPopup")]
+    [InlineData("OnCombatLine")]
+    [InlineData("OnSelfSent")]
+    [InlineData("OnPlayerKilled")]
+    public void DisplayTimestampsSource_AppliesToEveryProducer(string method)
+    {
+        var log = new ChatLog { DisplayTimestampsSource = () => true };
+
+        switch (method)
+        {
+            case "OnEmote": log.OnEmote("Caith", "waves", 0xCAFEu); break;
+            case "OnSoulEmote": log.OnSoulEmote("Bob", "dances", 0xBEEFu); break;
+            case "OnChannelBroadcast": log.OnChannelBroadcast(42u, "Alice", "motd"); break;
+            case "OnTellReceived": log.OnTellReceived("Alice", "psst", 0xAAu, logTextType: 0x03u); break;
+            case "OnSystemMessage": log.OnSystemMessage("fizzled", chatType: 5); break;
+            case "OnPopup": log.OnPopup("modal"); break;
+            case "OnCombatLine": log.OnCombatLine("hit", logTextType: 0x06u); break;
+            case "OnSelfSent": log.OnSelfSent(ChatKind.Tell, "hey", logTextType: 0x04u, targetOrChannel: "Alice"); break;
+            case "OnPlayerKilled": log.OnPlayerKilled("died", 0x1u, 0x2u); break;
+        }
+
+        string text = log.Snapshot()[0].Text;
+        Assert.Matches(@"^\d{1,2}:\d{2}:\d{2} .+$", text);
+    }
+
+    [Fact]
+    public void DisplayTimestampsSource_UsesLiteralColons_RegardlessOfCurrentCulture()
+    {
+        CultureInfo original = Thread.CurrentThread.CurrentCulture;
+        try
+        {
+            Thread.CurrentThread.CurrentCulture = CultureInfo.GetCultureInfo("fi-FI");
+            var log = new ChatLog { DisplayTimestampsSource = () => true };
+
+            log.OnSystemMessage("fizzled", chatType: 0);
+
+            Assert.Matches(@"^\d{1,2}:\d{2}:\d{2} fizzled$", log.Snapshot()[0].Text);
+        }
+        finally
+        {
+            Thread.CurrentThread.CurrentCulture = original;
+        }
+    }
 }