fix(ui,runtime): OP4 review fixes — live re-seed, enable-gating, Combat panel re-point, universal timestamps
Both OP4 reviews converged on one headline bug (Character-tab rows never re-read live server truth after their pre-login constructor-word seed) plus overlapping MUST-FIXes. All ten converged/consolidated findings land here: MUST-FIX: - BoolOptionRow.SaveCurrentValue now re-reads its live binding (retail's GetValue()-into-SaveCurrentValue) on every OnShown — panel open, tab switch in, initial activation — instead of trusting the pre-login constructor word it was built with. Reset/tab-switch can now only restore values that were actually live at the last show. LockUI's host.Root.UiLocked one-shot mount seed now also converges on every PlayerDescription via the existing OnCharacterOptionsChanged hook. - Apply/Reset are wired to OptionPage.OnOptionChanged in production (Ghosted when nothing changed, Normal when dirty, run once at bind so both start disabled per retail's PostInit); Defaults stays ungated. - The Combat panel's three LEDs (Repeat Attacks/Auto Target/Keep in View) now read/write the same RuntimeCharacterOptionsState seam the Character tab uses instead of a disconnected client-local GameplaySettings copy — closes the "two writable copies" divergence. The three now-orphaned GameplaySettings fields and RuntimeSettingsController's mirror properties/SetCombatGameplay are deleted outright; the headless host's hardcoded AutoRepeatAttack/AutoTarget now read the live option bit. - RuntimeSettingsController.SetUiLocked's convergence guard now compares against the last value actually applied to the runtime target instead of the persisted GameplaySettings.LockUI snapshot, which could already match a server-derived request without ever having been pushed. SHOULD-FIX: - DisplayTimeStamps now prefixes every chat producer (ChatLog.Append is the one seam all of them funnel through), not just AddText's own callers — heard speech, emotes, Turbine channels, and combat text were previously missed. The prefix format escapes its colons and forces InvariantCulture instead of the culture-dependent TimeSeparator placeholder. - sky.frag now honors uFogParams.w (fog mode) like the mesh/terrain shaders, so Disable Distance Fog stops the sky dome's horizon band from blending toward fog color too. - Corrected the "byte-verified" overclaim on the timestamp format string doc comment (BN-sourced, wire doc U6) and the AP-194 anchor-column class-name typo; the RunAsDefaultMovement doc comments now cite retail's actual acclient.h enumerator name. - Added: DispatcherMovementInputSource's option x modifier truth table (incl. || AutoRunActive with the option off), the per-page Apply/Reset enable-gate tests, a real checkbox.OnClick/ToggleBehavior-driven click test, and hash-pins for the six header string keys. - Gate script step 8 corrected for the logout-flush false-failure (closing the panel before relogging is load-bearing); a new step documents the enable-gate sequence and the Combat-panel/Character-tab cross-check. Register: AP-196 (the Group-C default-source change + GameplaySettings retirement) and AP-197 (the ignored per-character timestamp format override) filed in this commit. Full Release suite: 13,044 passed / 4 skipped / 0 failed (was 13,008/4/0; net +36 tests from new coverage and legitimate assertion updates from the GameplaySettings retirement). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik
parent
85afaae5fd
commit
bc43fb1d1d
36 changed files with 923 additions and 220 deletions
|
|
@ -100,16 +100,32 @@ public sealed class RuntimeCommunicationState : IDisposable
|
|||
/// DisplayTimeStamps</c> — <c>ClientSystem::AddTextToScroll
|
||||
/// @0x00563C50</c> (character-options-map.md §2.2, "Display
|
||||
/// Timestamps") prefixes each transcript line with
|
||||
/// <c>PlayerModule::m_TimeStampFormat</c> (ctor default the byte-
|
||||
/// verified CRT strftime string <c>"%#H:%M:%S "</c> — non-zero-padded
|
||||
/// 24h hour, then zero-padded minute:second, trailing space) when the
|
||||
/// option is on. Polled — see <see cref="AcDream.Core.World.
|
||||
/// WeatherSystem.DisableDistanceFogSource"/> for why. Applied only to
|
||||
/// the persisted <see cref="Chat"/> transcript (matching retail's own
|
||||
/// <c>ClientLocal</c> exemption in <see cref="AddText"/> below — the
|
||||
/// transient <see cref="SpewBox"/> is never timestamped).
|
||||
/// <c>PlayerModule::m_TimeStampFormat</c> (ctor default the
|
||||
/// BN-sourced CRT strftime string <c>"%#H:%M:%S "</c> — wire research
|
||||
/// doc U6, NOT byte-verified — non-zero-padded 24h hour, then
|
||||
/// zero-padded minute:second, trailing space) when the option is on.
|
||||
/// Polled — see <see cref="AcDream.Core.World.
|
||||
/// WeatherSystem.DisableDistanceFogSource"/> for why.
|
||||
///
|
||||
/// <para>
|
||||
/// SHOULD-FIX S1 (OP4 review-fix round, 2026-08-11): the actual
|
||||
/// prefixing now happens inside <see cref="Chat"/>'s own
|
||||
/// <c>Append</c> — the ONE seam every chat producer funnels through,
|
||||
/// not just this class's own <see cref="AddText"/> callers (a strict
|
||||
/// subset that missed heard speech, emotes, Turbine channels, and
|
||||
/// combat text). This property forwards to
|
||||
/// <see cref="ChatLog.DisplayTimestampsSource"/> so existing callers
|
||||
/// (<c>GameWindow</c>'s one-time bind) keep working unchanged. The
|
||||
/// transient <see cref="SpewBox"/> never touches <see cref="Chat"/>
|
||||
/// at all, so it stays exempt automatically — matching retail's own
|
||||
/// <c>ClientLocal</c> exemption without a special case here.
|
||||
/// </para>
|
||||
/// </summary>
|
||||
public Func<bool>? DisplayTimestampsSource { get; set; }
|
||||
public Func<bool>? DisplayTimestampsSource
|
||||
{
|
||||
get => Chat.DisplayTimestampsSource;
|
||||
set => Chat.DisplayTimestampsSource = value;
|
||||
}
|
||||
|
||||
public ChatCommandTargetState CommandTargets { get; }
|
||||
public TurbineChatState TurbineChat { get; }
|
||||
|
|
@ -216,14 +232,9 @@ public sealed class RuntimeCommunicationState : IDisposable
|
|||
return;
|
||||
}
|
||||
|
||||
// OP4: DisplayTimeStamps — see DisplayTimestampsSource's doc
|
||||
// comment. Prefixed AFTER the trim above (retail's own order:
|
||||
// AddTextToScroll trims first, then ClientSystem's caller-side
|
||||
// timestamp prepend applies to the transcript line, never to the
|
||||
// ClientLocal/SpewBox branch already returned above).
|
||||
if (DisplayTimestampsSource?.Invoke() == true)
|
||||
text = DateTime.Now.ToString("H:mm:ss ") + text;
|
||||
|
||||
// S1 (OP4 review-fix round, 2026-08-11): the DisplayTimeStamps
|
||||
// prefix now applies inside Chat's own Append — see
|
||||
// DisplayTimestampsSource's doc comment.
|
||||
Chat.OnSystemMessage(text, (uint)type);
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -145,8 +145,11 @@ public sealed class RuntimeLocalPlayerMovementState
|
|||
public bool AutoRunActive => _autoRunActive;
|
||||
|
||||
/// <summary>
|
||||
/// Campaign OP slice OP4 (2026-08-11): retail <c>PlayerOption
|
||||
/// RunAsDefaultMovement</c> (<c>ACCmdInterp::UITogglesRun</c>) —
|
||||
/// Campaign OP slice OP4 (2026-08-11): retail <c>PlayerOption</c> id
|
||||
/// <c>0xA</c> — <c>acclient.h</c>'s own enumerator spelling is
|
||||
/// <c>ToggleRun_PlayerOption</c>; "RunAsDefaultMovement" is ACE's name
|
||||
/// for the same bit, corrected here at the OP4 review-fix round
|
||||
/// (2026-08-11, N7) — read via <c>ACCmdInterp::UITogglesRun</c> —
|
||||
/// whether an ordinary held movement key runs by default (retail's own
|
||||
/// client default: <see langword="true"/>) or walks by default,
|
||||
/// requiring the walk-mode modifier to be held to invert. Distinct
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue