fix(ui,runtime): OP4 review fixes — live re-seed, enable-gating, Combat panel re-point, universal timestamps

Both OP4 reviews converged on one headline bug (Character-tab rows never
re-read live server truth after their pre-login constructor-word seed) plus
overlapping MUST-FIXes. All ten converged/consolidated findings land here:

MUST-FIX:
- BoolOptionRow.SaveCurrentValue now re-reads its live binding (retail's
  GetValue()-into-SaveCurrentValue) on every OnShown — panel open, tab
  switch in, initial activation — instead of trusting the pre-login
  constructor word it was built with. Reset/tab-switch can now only
  restore values that were actually live at the last show. LockUI's
  host.Root.UiLocked one-shot mount seed now also converges on every
  PlayerDescription via the existing OnCharacterOptionsChanged hook.
- Apply/Reset are wired to OptionPage.OnOptionChanged in production
  (Ghosted when nothing changed, Normal when dirty, run once at bind so
  both start disabled per retail's PostInit); Defaults stays ungated.
- The Combat panel's three LEDs (Repeat Attacks/Auto Target/Keep in View)
  now read/write the same RuntimeCharacterOptionsState seam the Character
  tab uses instead of a disconnected client-local GameplaySettings copy —
  closes the "two writable copies" divergence. The three now-orphaned
  GameplaySettings fields and RuntimeSettingsController's mirror
  properties/SetCombatGameplay are deleted outright; the headless host's
  hardcoded AutoRepeatAttack/AutoTarget now read the live option bit.
- RuntimeSettingsController.SetUiLocked's convergence guard now compares
  against the last value actually applied to the runtime target instead
  of the persisted GameplaySettings.LockUI snapshot, which could already
  match a server-derived request without ever having been pushed.

SHOULD-FIX:
- DisplayTimeStamps now prefixes every chat producer (ChatLog.Append is
  the one seam all of them funnel through), not just AddText's own
  callers — heard speech, emotes, Turbine channels, and combat text were
  previously missed. The prefix format escapes its colons and forces
  InvariantCulture instead of the culture-dependent TimeSeparator
  placeholder.
- sky.frag now honors uFogParams.w (fog mode) like the mesh/terrain
  shaders, so Disable Distance Fog stops the sky dome's horizon band from
  blending toward fog color too.
- Corrected the "byte-verified" overclaim on the timestamp format string
  doc comment (BN-sourced, wire doc U6) and the AP-194 anchor-column
  class-name typo; the RunAsDefaultMovement doc comments now cite retail's
  actual acclient.h enumerator name.
- Added: DispatcherMovementInputSource's option x modifier truth table
  (incl. || AutoRunActive with the option off), the per-page Apply/Reset
  enable-gate tests, a real checkbox.OnClick/ToggleBehavior-driven click
  test, and hash-pins for the six header string keys.
- Gate script step 8 corrected for the logout-flush false-failure
  (closing the panel before relogging is load-bearing); a new step
  documents the enable-gate sequence and the Combat-panel/Character-tab
  cross-check.

Register: AP-196 (the Group-C default-source change + GameplaySettings
retirement) and AP-197 (the ignored per-character timestamp format
override) filed in this commit.

Full Release suite: 13,044 passed / 4 skipped / 0 failed (was 13,008/4/0;
net +36 tests from new coverage and legitimate assertion updates from the
GameplaySettings retirement).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/AcDream.App/Settings/RuntimeSettingsController.cs

@@ -1,4 +1,3 @@
-using AcDream.App.Combat;
 using AcDream.Core.Net.Messages;
 using AcDream.UI.Abstractions.Input;
 using AcDream.UI.Abstractions.Panels.Settings;
@@ -168,8 +167,7 @@ internal interface IRuntimeSettingsPreviewSource
 /// are never constructed or disposed here.
 /// </summary>
 internal sealed class RuntimeSettingsController :
-    IRuntimeSettingsPreviewSource,
-    ICombatGameplaySettingsSource
+    IRuntimeSettingsPreviewSource
 {
     private const string DefaultToonKey = "default";
 
@@ -183,6 +181,11 @@ internal sealed class RuntimeSettingsController :
     private bool _startupAudioApplied;
     private bool _startupApplied;
     private bool _uiLockConverged = true;
+    // MUST-FIX 4 (OP4 review-fix round, 2026-08-11, blast M3): the last
+    // `locked` value actually pushed to `_runtimeTargets.ApplyUiLock` —
+    // the guard `SetUiLocked` compares against, decoupled from whatever
+    // `Gameplay.LockUI`'s own persisted/draft snapshot currently holds.
+    private bool? _lastAppliedUiLocked;
 
     public RuntimeSettingsController(
         IRuntimeSettingsStorage storage,
@@ -233,12 +236,6 @@ internal sealed class RuntimeSettingsController :
 
     public AudioSettings AudioPreview => _viewModel?.AudioDraft ?? Audio;
 
-    public bool AutoTarget => Gameplay.AutoTarget;
-
-    public bool AutoRepeatAttack => Gameplay.AutoRepeatAttack;
-
-    public bool ViewCombatTarget => Gameplay.ViewCombatTarget;
-
     public void ApplyStartup(IRuntimeSettingsStartupTarget target)
     {
         ArgumentNullException.ThrowIfNull(target);
@@ -352,12 +349,22 @@ internal sealed class RuntimeSettingsController :
 
     public void SetUiLocked(bool locked)
     {
-        if (Gameplay.LockUI == locked && _uiLockConverged)
+        // MUST-FIX 4 (OP4 review-fix round, 2026-08-11, blast M3): the
+        // guard used to compare `locked` against `Gameplay.LockUI` — valid
+        // only while `ToggleUiLock` computed `locked` AS `!Gameplay.LockUI`
+        // (pre-OP4). OP4 re-pointed `ToggleUiLock` to derive `locked` from
+        // the SERVER bit (`RuntimeCharacterOptionsState.GetOptionBit`)
+        // instead, a DIFFERENT store that can already equal the persisted
+        // `Gameplay.LockUI` without this method ever having pushed that
+        // value to `_runtimeTargets` — the guard must compare against what
+        // was ACTUALLY applied, not a value from an unrelated store.
+        if (_lastAppliedUiLocked == locked && _uiLockConverged)
             return;
 
         _uiLockConverged = false;
         Gameplay = Gameplay with { LockUI = locked };
         _runtimeTargets?.ApplyUiLock(locked);
+        _lastAppliedUiLocked = locked;
         _viewModel?.SetGameplay(
             _viewModel.GameplayDraft with { LockUI = locked });
 
@@ -412,35 +419,6 @@ internal sealed class RuntimeSettingsController :
         }
     }
 
-    public void SetCombatGameplay(GameplaySettings gameplay)
-    {
-        Gameplay = gameplay ?? throw new ArgumentNullException(nameof(gameplay));
-        if (_viewModel is not null)
-        {
-            _viewModel.SetGameplay(_viewModel.GameplayDraft with
-            {
-                AutoTarget = gameplay.AutoTarget,
-                AutoRepeatAttack = gameplay.AutoRepeatAttack,
-                ViewCombatTarget = gameplay.ViewCombatTarget,
-            });
-        }
-
-        try
-        {
-            _storage.SaveGameplay(gameplay);
-            _viewModel?.ApplyExternalGameplayChange(current => current with
-            {
-                AutoTarget = gameplay.AutoTarget,
-                AutoRepeatAttack = gameplay.AutoRepeatAttack,
-                ViewCombatTarget = gameplay.ViewCombatTarget,
-            });
-        }
-        catch (Exception ex)
-        {
-            _log($"settings: combat option save failed: {ex.Message}");
-        }
-    }
-
     /// <summary>
     /// Campaign OP slice OP3: the five client-local preferences the "Use
     /// Mouse Turning Settings" Gameplay-tab macro reads/writes. Read
@@ -545,6 +523,7 @@ internal sealed class RuntimeSettingsController :
             Gameplay = gameplay;
             _uiLockConverged = false;
             _runtimeTargets?.ApplyUiLock(gameplay.LockUI);
+            _lastAppliedUiLocked = gameplay.LockUI;
             _uiLockConverged = true;
             _log($"settings: gameplay saved to {_storage.Location}");
         }