erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Revert "fix(render): Phase A8 R3.5 — gate stencil branch on PointInCell containment"

Browse source 
This reverts commit 38d537491f.
This commit is contained in:
Erik 2026-05-27 10:07:15 +02:00
parent 664ca9cb16
commit b93103885a
1 changed files with 1 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/AcDream.App/Rendering/GameWindow.cs
View file

@ -7179,29 +7179,7 @@ public sealed class GameWindow : IDisposable
animatedIds.Add(k);
}
// Phase A8 R3.5 — transition-flicker fix. `cameraInsideCell`
// stays true for ~3 grace frames after the camera physically
// exits a cell (see CellVisibility._cellSwitchGraceFrames).
// The grace mechanism prevents lighting/sky flicker at the
// doorway threshold, but if the stencil pipeline runs during
// grace frames it marks/punches at the OLD cell's portal
// silhouettes — which are now behind/beside the camera — and
// the subsequent IndoorPass + stencil-gated outdoor produce
// a brief frame of "walls disappear + buildings under ground"
// garbage. Gate the stencil branch on the stricter
// `PointInCell` containment check so the pipeline only runs
// when the camera is ACTUALLY inside its cell volume; sky /
// lighting / depth-clear continue to use `cameraInsideCell`
// for their smoother grace-aware behavior.
bool cameraReallyInside = visibility?.CameraCell is not null
&& CellVisibility.PointInCell(camPos, visibility.CameraCell);
// The `visibility?.CameraCell is not null` repeat is for the
// compiler's null-flow analysis: `cameraReallyInside` already
// implies it, but flow doesn't propagate through a separate
// local. Restating it inside the if condition lets the branch
// body use the un-`?`d form without null-forgiving.
if (cameraReallyInside && _indoorStencilPipeline is not null
if (cameraInsideCell && _indoorStencilPipeline is not null
&& visibility?.CameraCell is not null)
{
if (AcDream.Core.Rendering.RenderingDiagnostics.ProbeVisibilityEnabled)