Record final lighting correctness lanes and unchanged remaining gates

This commit is contained in:
Erik 2026-09-05 15:33:49 +02:00
parent b2bdb09ccb
commit b7cb6886c5
5 changed files with 83 additions and 4 deletions

View file

@ -90,8 +90,10 @@ produced eight inspected narrow PASS PNGs, both clients exited0/gracefully.
and limits. Observer cleanup integrated0ae2666ef; final unchanged routes also
produced eight inspected provisional PASS PNGs with both clients exiting0
gracefully. `research/2026-09-01-overhaul/478-observer-removal-verification.md`.
Two stale full-lane checksum/count test expectations are being reconciled;
owner brightness acceptance and G4 remain owed.
Two stale full-lane checksum/count expectations were corrected test-only at
b2bdb09cc. Literal-hermetic17028/0/0; canonical InstalledDat371pass with the
same8failures/1skip. `research/2026-09-01-overhaul/478-final-correctness-lanes.md`.
Owner brightness acceptance and G4 remain owed.
Original owner report during the `de427d2c0` gate on2026-09-05:
Town Network was barely visible; the run includes indoor00070143. The current
High-profile indoor authored-light/material path needs comparison with retail.

View file

@ -835,6 +835,14 @@ The two stale expectations are corrected from reviewed scratch05d0cc302,
exact blobs, Release0W0E/74+2PASS and lead76/76. No production change since
the final0ae2666ef graphical gates. Full integrated correctness lanes next.
**Final correctness lanes atb2bdb09cc:** locked restore/Release0W0E;
literal-hermetic17028pass/0fail/0skip (manifest32/32). Canonical InstalledDat
371pass/8knownfail/1knownskip (manifest30/30), exact nonpassing identities
unchanged from C1c. `478-final-correctness-lanes.md`; #478 verification complete,
owner gate owed. No production changes since graphical0ae2666ef. C1a's
unresolved AP159 bridge mismatch is not blessed by a four-cell golden;
read-only audit continues. FPS/C2 deferred; G4FAIL/no main merge.
## 14. Risk register (condensed)
- **R1 second scene graph.** Graph records own only topology/membership facts;

View file

@ -0,0 +1,58 @@
# #478 final integrated correctness lanes
Exact clean commit `b2bdb09ccbd515f180b4fb3b7159de4d3913e68d`, campaign
branch. Only tests/docs changed since graphically checked0ae2666ef; lead
confirmed no `src`, `samples` or `tools` diff. Earlier graphical evidence
still names its actual0ae2666ef binary, not this newly built executable.
No FPS profiling, comparisons, optimization or renderer changes in this tail.
Both client names were absent before execution. Each lane ran once, using
new artifact directories; no old report was overwritten and no failed test
was retried until green. The earlier17026/2/0 report at0ae2666ef is retained;
its two stale expected values were corrected under the separate reviewed
test-only contract, not by changing production or weakening unrelated pins.
## Literal-hermetic — PASS
`artifacts/s5-final-hermetic-expectations/`, `tools/run-release-gate.ps1` with
literal filter `Lane!=InstalledDat&Lane!=Linux&Lane!=Manual&Lane!=Timing&Lane!=Live&Lane!=PreparedPackage`.
Fresh locked restore and full Release build:0warnings/0errors. All14test
assemblies: **17028passed/0failed/0skipped**; App7126/7126. No timeouts.
Lead independently verified all32manifest entries.
Summary SHA2563E2FA482FBA01E358CCC7357C29056647B451155D27381F315E7523ED2E9A2F2;
manifest E98291235CA9CBEDCF08273D1C48A4C3C2CACB4EAEF14FB82108F6AE6FE460DB.
Built App DLL5692DF7F1495D235351CF87C8741781260B4243E6922476F7A23B8F2B025F305;
Core DLLD4F15FEB44F99DBC257DF5911D302E82FC7FAB9BB549590B06FFE28E8685BF9B.
## Canonical InstalledDat — known nonpassing lane, not PASS
Same commit/binary, explicit `ACDREAM_RUN_INSTALLED_DAT_TESTS=1` and installed
Documents/Asheron's Call DAT directory. `tools/run-release-gate.ps1` with
`-SkipRestore -SkipBuild -TestFilter 'Lane=InstalledDat&Purpose!=Diagnostic'`.
Artifact `artifacts/s5-final-installeddat-b2bdb09cc/`:
**371passed/8failed/1skipped**, script correctly exits1. No timeouts.
All30manifest entries independently verified. Some assemblies contain no
InstalledDat tests; their zero-test output is not counted as coverage.
Lead compared actual nonpassing TRX identities against
`artifacts/c1c-installeddat-r2-42afec614/`: the same eight failures and one
skip, no new identity. Six `WalkTraceConformanceTests.AlphaFlushCounts` rows
remain: CathedralArrival, CathedralLeak, CathedralStairArch, FoundryDeep,
HoltburgDoorwayStill, TerraceEdge (`_MatchesRetailFrame2`). Two existing UI
rows remain: `LayoutImporterMediaBearingChildSweepTests.MainGameUiAndChatInput_MediaBearingChildrenNowBuildAsRealWidgets`
and `LayoutImporterInvisibleSweepTests.EveryAuthoredInvisibleWidget_StartsHiddenAcrossAllLayouts`.
The unchanged skip is `WalkLookInGateSweepTests.Sweep_the_lookin_gate_decodes_against_the_street_fixture`.
The new actual Town authored-type/root-origin fixture passes, accounting for
the increase from370 to371passed. C1c's prior classification remains valid.
Summary SHA256F485169B85DB661AB0F517B9D7541B9B70E93C1E628A27D8A5E0521B09B95F35;
manifest AEC2E8AB0C19AACFA39363ED538617BBF9DBC0374CEA5D5174CC98B8A89A57F5.
These close the #478 repair/cleanup/test-maintenance verification, not G4.
Owner brightness/held-item/stability acceptance remains owed; Rynthid's
affected part is unidentified. C1a's full-world three-vs-four-cell assertion
remains preserved and its golden unpinned; a bounded read-only audit of the
existing AP-159 bridge evidence is in progress. No production repair is
authorized by that test-only diagnostic. FPS/#481/C2 comparison deferred.
No main merge.

View file

@ -1,13 +1,15 @@
# #478 final-lane expectation correction — bounded test-only contract
IMPLEMENTED and lead-verified from scratch `05d0cc302180bc34d6460dc9941cd73ac7c50379`.
COMPLETE and lead-verified from scratch `05d0cc302180bc34d6460dc9941cd73ac7c50379`,
integrationb2bdb09cc. Full literal-hermetic17028/0/0; canonical InstalledDat
371pass/8unchanged failures/1unchanged skip. `478-final-correctness-lanes.md`.
Exactly two test files,10insertions/5deletions; the expected-value changes and
clarifying name/comment match the contract. All other pins remain unchanged.
Lead rechecked both raw hashes and integration Git blobs; no production change.
Scratch Release0W0E, whole classes74/74 and native2/2, actual reports inspected.
Lead independently repeated76/76, both client names absent. Artifacts:
`s5-478-expectations/artifacts/478-expectations/` (`affected-classes`,
`native-pixels`, `root-expectations`). Final integrated full lanes next.
`native-pixels`, `root-expectations`). Final integrated full lanes recorded above.
At clean0ae2666ef the literal-hermetic lane completed once with17026pass,
2fail,0skip,14assemblies. Artifact `artifacts/s5-final-hermetic-0ae2666ef/`.

View file

@ -5010,3 +5010,12 @@ with exact blobs. Release0W0E; affected classes74/native2 PASS, lead independent
AP68retirement and reviewed EnvCell47shader are the specific amendments.
Original full-lane failure evidence retained/30manifest entries verified.
Fresh integrated Release and unchanged full correctness lanes next; FPS deferred.
Final cleanb2bdb09cc full locked restore/Release0W0E and literal-hermetic
17028/0/0 PASS,32manifest entries independently matched. Canonical InstalledDat
371pass/8unchanged failures/1unchanged skip,30manifest entries matched; exact
TRX identity comparison against C1c has no new failure/skip. New Town fixture
passes. `478-final-correctness-lanes.md`. No src/samples/tools changes since
graphical0ae2666ef, no FPS work. #478 verification complete, owner acceptance
still owed. C1a remains unpinned with its original three-cell assertion intact;
read-only AP159/primitive/closure audit, not a production repair, continues.