erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

feat(ui): preserve exact retail shortcut records

Browse source 
Carry signed index, object id, and raw spell word losslessly through PlayerDescription, session storage, drag mutation, and AddShortcut wire serialization while keeping gmToolbarUI object-only. Retire AP-103 and record the live ACE relog persistence gate.

Co-Authored-By: Codex <codex@openai.com>
This commit is contained in:
Erik 2026-07-11 09:17:33 +02:00
parent e65119f0c6
commit b5b230c860
21 changed files with 271 additions and 181 deletions
Download patch file Download diff file Expand all files Collapse all files

21
tests/AcDream.Core.Tests/Items/ShortcutStoreTests.cs
View file

@ -6,34 +6,39 @@ namespace AcDream.Core.Tests.Items;
public class ShortcutStoreTests
{
[Fact]
public void Load_mapsSlotToObjId_skipsEmptyAndOutOfRange()
public void Load_preservesAllRawFieldsAndRejectsOutOfRangeIndex()
{
var store = new ShortcutStore();
store.Load(new (int, uint)[]
store.Load(new[]
{
(0, 0x5001u),
(3, 0x5002u),
(5, 0u), // empty/spell → skipped
(99, 0x5003u), // out of range → skipped
new ShortcutEntry(0, 0x5001u, 0x11223344u),
new ShortcutEntry(3, 0x5002u, 0u),
new ShortcutEntry(5, 0u, 0xA5C31234u),
new ShortcutEntry(-1, 0x5003u, 1u),
new ShortcutEntry(18, 0x5004u, 2u),
});
Assert.Equal(0x5001u, store.Get(0));
Assert.Equal(0x5002u, store.Get(3));
Assert.Equal(0u, store.Get(5));
Assert.Equal(new ShortcutEntry(5, 0u, 0xA5C31234u), store.GetEntry(5));
Assert.Equal(0x11223344u, store.GetEntry(0)!.Value.SpellId);
Assert.True(store.IsEmpty(1));
Assert.Null(store.GetEntry(-1));
Assert.Null(store.GetEntry(18));
}
[Fact]
public void SetRemoveGet_roundtrip_andBoundsSafe()
{
var store = new ShortcutStore();
store.Set(4, 0xABCDu);
store.SetItem(4, 0xABCDu);
Assert.Equal(0xABCDu, store.Get(4));
Assert.False(store.IsEmpty(4));
store.Remove(4);
Assert.True(store.IsEmpty(4));
Assert.Equal(0u, store.Get(-1));
Assert.Equal(0u, store.Get(18));
store.Set(18, 1u); // no-op, no throw
store.SetItem(18, 1u); // no-op, no throw
store.Remove(-1); // no-op, no throw
}
}