erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(ui): restore radar, retail wield switching, and protection meshes

Browse source 
Late-bind radar snapshots to the canonical LiveEntityRuntime maps so the retained radar survives bootstrap and session replacement instead of capturing empty sentinels.

Route paperdoll drops through the retail AutoWield blocker transaction. Move conflicting held weapons, shields, explicit jewelry destinations, and mismatched ammo to the backpack one authoritative confirmation at a time; preserve compatible arrows when switching to melee.

Render mode-1 and no-degrade particle GfxObjs as their authored modern-pipeline meshes, retain Always2D billboards, interleave both paths back-to-front, balance emitter mesh ownership, and fail safely on corrupt DAT material metadata. This restores the closed apex on Armor Self/protection effects.

Retain Studio fixture controller lifetimes, add installed-DAT and adversarial regression coverage, synchronize retail research/divergence bookkeeping, and pass all three review tracks plus the full Release suite.

Co-Authored-By: Codex <noreply@openai.com>
This commit is contained in:
Erik 2026-07-14 20:52:45 +02:00
parent 8d63e5c28a
commit b26f84cc69
26 changed files with 1361 additions and 141 deletions
Download patch file Download diff file Expand all files Collapse all files

61
tests/AcDream.App.Tests/UI/Layout/RadarSnapshotProviderTests.cs
View file

@ -1,4 +1,5 @@
using System.Numerics;
using AcDream.App.UI;
using AcDream.App.UI.Layout;
using AcDream.Core.Items;
using AcDream.Core.Net;
@ -35,7 +36,7 @@ public sealed class RadarSnapshotProviderTests
uint? selected = monster;
var provider = new RadarSnapshotProvider(
objects, entities, spawns,
objects, () => entities, () => spawns,
playerGuid: () => player,
playerYawRadians: () => MathF.PI / 2f, // retail heading 0 degrees
playerCellId: () => 0xA9B40001u,
@ -81,7 +82,7 @@ public sealed class RadarSnapshotProviderTests
[hidden] = Spawn(hidden),
};
var provider = new RadarSnapshotProvider(
objects, entities, spawns,
objects, () => entities, () => spawns,
playerGuid: () => player,
playerYawRadians: () => 0f,
playerCellId: () => 0xA9B40100u, // EnvCell: no landscape coordinate
@ -120,15 +121,15 @@ public sealed class RadarSnapshotProviderTests
};
var provider = new RadarSnapshotProvider(
objects,
interactionVisible,
spawns,
() => interactionVisible,
() => spawns,
playerGuid: () => player,
playerYawRadians: () => 0f,
playerCellId: () => 0xA9B40001u,
selectedGuid: () => hiddenTarget,
coordinatesOnRadar: () => true,
uiLocked: () => false,
playerEntities: canonical);
playerEntities: () => canonical);
var snapshot = provider.BuildSnapshot();
@ -136,6 +137,56 @@ public sealed class RadarSnapshotProviderTests
Assert.Empty(snapshot.Blips);
}
[Fact]
public void BuildSnapshot_ResolvesLiveViewsAfterRuntimeBootstraps()
{
const uint player = 30u;
const uint monster = 31u;
var objects = new ClientObjectTable();
objects.Ingest(Weenie(player, "Player", ItemType.Creature));
objects.Ingest(Weenie(monster, "Drudge", ItemType.Creature) with
{
RadarBehavior = (byte)RadarBehavior.ShowAlways,
});
IReadOnlyDictionary<uint, WorldEntity> visible =
new Dictionary<uint, WorldEntity>();
IReadOnlyDictionary<uint, WorldEntity> canonical =
new Dictionary<uint, WorldEntity>();
IReadOnlyDictionary<uint, WorldSession.EntitySpawn> spawns =
new Dictionary<uint, WorldSession.EntitySpawn>();
var provider = new RadarSnapshotProvider(
objects,
() => visible,
() => spawns,
playerGuid: () => player,
playerYawRadians: () => MathF.PI / 2f,
playerCellId: () => 0xA9B40001u,
selectedGuid: () => null,
coordinatesOnRadar: () => true,
uiLocked: () => false,
playerEntities: () => canonical);
Assert.Null(provider.BuildSnapshot().CoordinatesText);
visible = new Dictionary<uint, WorldEntity>
{
[player] = Entity(player, Vector3.Zero, Quaternion.Identity),
[monster] = Entity(monster, new Vector3(0f, 15f, 0f), Quaternion.Identity),
};
canonical = visible;
spawns = new Dictionary<uint, WorldSession.EntitySpawn>
{
[player] = Spawn(player),
[monster] = Spawn(monster) with { ObjectDescriptionFlags = 0x00000010u },
};
UiRadarSnapshot snapshot = provider.BuildSnapshot();
Assert.NotNull(snapshot.CoordinatesText);
Assert.Equal(monster, Assert.Single(snapshot.Blips).ObjectId);
}
private static WorldEntity Entity(uint guid, Vector3 position, Quaternion rotation) => new()
{
Id = guid,