fix(render): Campaign V slice V7 commit 1 - world anisotropy, and the sky's second clock
Two changes, one measurement. The V6m smoke pair put GL versus Vulkan at Holtburg at 18.52% of the frame differing at tolerance 2 with MSAA off. The same stop on the same instrument now measures 9.05%, and the two populations these address are gone from the difference map rather than merely smaller. 1. THE WORLD ATLASES WERE SAMPLED WITHOUT ANISOTROPY ON VULKAN, AND WITH THE DEVICE MAXIMUM ON GL. RhiWorldTextureArray -- the backend-neutral shared object/material atlas, and the only IWorldTextureArray the Vulkan arm ever constructs -- registered its clamp and repeat slots with GpuSamplerDescription.WorldClamp/WorldRepeat as written, which carry MaxAnisotropy 1. The GL arm asks for the driver's own GL_MAX_TEXTURE_MAX_ANISOTROPY twice over: ManagedGLTextureArray sets GL_TEXTURE_MAX_ANISOTROPY on the image, and the two sampler objects its resident bindless handles are built from (OpenGLGraphicsDevice.WrapSampler/ClampSampler) set it again, which is the one that actually wins. V6i-2 knew it was asking for 1 and said so in a comment -- "the world arm that draws through these arrays is the next slice, and it is the one that can gate a filtering change visually." That slice was V6j, the gate is V7, and this is it. Retail settles the question rather than the GL arm settling it. RenderDeviceD3D::SetDefaultD3DStates (0x005a3800) loops all sixteen sampler stages and issues SetSamplerState(stage, 0xA, this->m_D3DCaps.MaxAnisotropy) at 0x005a4230. 0xA is D3DSAMP_MAXANISOTROPY and the argument is the device's reported cap, not a setting -- so "as much anisotropy as this device has" is retail's own rule, the GL arm is faithful to it, and asking for 1 diverged from retail as well as from the shipping backend. No divergence-register row is owed in either direction: this retires a Vulkan-only gap and lands on retail's value. The fix asks for a ceiling rather than reading a limit back, because the pinned RHI contract (plan section 3.3) carries no anisotropy field and is frozen. It does not need one: VulkanGpuSampler already clamps MaxAnisotropy to VkPhysicalDeviceLimits.maxSamplerAnisotropy, Vulkan guarantees that limit is at least 16 wherever the samplerAnisotropy feature is supported -- which this backend requires -- and 16 is where every desktop driver caps. The request and the GL arm's read therefore land on the same number. What it was worth, from the difference map at the same stop: the roof shingles of both Holtburg cottages, which had been dense hatching across the whole surface, and the stone courses of the near building are now black. Measured as high-frequency energy (mean absolute neighbour difference, GL versus Vulkan) the right-hand roof went from visibly blurred to a ratio of 0.999 and the wall to 1.023; every other textured region in the frame is between 0.99 and 1.02. Grazing-angle surfaces are where anisotropy is the whole difference, which is why a roof was the loudest thing in the frame. 2. THE SKY HAS TWO CLOCKS AND ONLY ONE OF THEM WAS PINNABLE. ACDREAM_DAY_GROUP and the route's AcdreamCycleTimeOfDay presses pin the Dereth date, which chooses the day group, the keyframe and the sun angle. The cloud sheet does not read that clock: SkyRenderer accumulates TexVelocityX/Y against DateTime.UtcNow minus its own construction time, by design, because retail's clouds drift with real time regardless of the date. Two launches minutes apart therefore cannot agree about where the clouds are no matter what the route does, and the V6m smoke measured the cost -- 89% of its 18.52% sat in the top 240 rows. ACDREAM_SKY_PHASE_SECONDS (RuntimeOptions.SkyAnimationPhaseSeconds -> SkyRenderer.AnimationPhaseSecondsOverride) replaces that elapsed-seconds value with a fixed one. Unset -- the default, and every ordinary run -- keeps the wall clock, so nothing a user or the offline gate sees changes. The differential gate forces it on both launches alongside MSAA and the day group; the offline gate keeps its top-280 mask, because a same-commit GL pair still has the sun to disagree about. This is instrument determinism on the same footing as ACDREAM_DAY_GROUP, not a workaround: it is one input to a UV offset, it is off by default, and no shipping path reads it. The alternative on the table was -MaskTopPixels, which would have permanently blinded the campaign's strictest instrument to the entire sky -- one of the five surfaces the offline gate already cannot see. Rows 0-32 of the Holtburg pair went from 23,090 differing pixels to 1,211, and what remains up there is roof and portal rather than cloud. WHAT THE SAME PAIR STILL SHOWS, unattributed and carried to the next commit: the distant treeline, the player and the NPCs, and the animated portal. The portal is phase and expected. The treeline is not filtering -- sharpness now matches within 5% and a shift search finds no sub-pixel offset -- and the two runs entered the world at different last-logout positions (0xC95B0001 versus 0x09040008), so the far-tier streaming history differed. That is the next thing to prove or refute. Gates. Release build green. App tests 4,133 passed / 3 skipped against the 4,132/3 baseline (one new: the sky-phase parse). GL offline pixel gate against the pre-change tree: 2.31e-05, 13 pixels of 563,200, inside the documented 9-31 band -- GL did not move. One offline Vulkan run with VK_LAYER_KHRONOS_validation proven inserted by the loader: zero validation errors, zero warnings. Full three-stop differential recorded at artifacts/v7-diff-c1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
a7529a975a
commit
ad5f8b68dc
8 changed files with 206 additions and 16 deletions
|
|
@ -15,7 +15,7 @@
|
|||
MSAA off, ACDREAM_DAY_GROUP pinned,
|
||||
at every deterministic checkpoint of the connected route.
|
||||
|
||||
THREE THINGS ARE FORCED, and each is load-bearing.
|
||||
FOUR THINGS ARE FORCED, and each is load-bearing.
|
||||
|
||||
1. ACDREAM_MSAA_SAMPLES=0 ON BOTH LAUNCHES. Multisample resolve positions
|
||||
are explicitly unspecified across implementations. Plan section 5.5.16
|
||||
|
|
@ -31,7 +31,20 @@
|
|||
with wall time; two launches minutes apart cannot agree about either.
|
||||
The route additionally pins the client-only time-of-day override.
|
||||
|
||||
3. A DESKTOP WITNESS per run, with the guards the repeat-run gate
|
||||
3. ACDREAM_SKY_PHASE_SECONDS pinned ON BOTH LAUNCHES. The day group and the
|
||||
time-of-day override pin ONE of the sky's two clocks -- the one that
|
||||
chooses the keyframe and the sun angle. The cloud sheet runs on the
|
||||
other: TexVelocityX/Y accumulate against real elapsed time by design,
|
||||
because retail's clouds drift independently of the date, so no amount of
|
||||
world-clock pinning makes two launches agree about where they are. The
|
||||
V6m smoke pair measured the cost of leaving it: 89% of an 18.52%
|
||||
whole-frame difference lived in the top 240 rows. Pinning the phase is
|
||||
instrument determinism -- it is off in every ordinary run, it changes one
|
||||
input to a UV offset, and it is what lets this gate keep the SKY under
|
||||
strict comparison instead of masking it, which is what -MaskTopPixels
|
||||
would have cost.
|
||||
|
||||
4. A DESKTOP WITNESS per run, with the guards the repeat-run gate
|
||||
(run-repeat-connected-gate.ps1) learned the hard way. The client's own
|
||||
capture is the differential's subject, but a blank frame reads back as a
|
||||
valid PNG (plan section 5.5.2), so a second instrument that shares
|
||||
|
|
@ -71,6 +84,11 @@
|
|||
.PARAMETER DayGroup
|
||||
Sky day-group index pinned on both launches. Default 0.
|
||||
|
||||
.PARAMETER SkyPhaseSeconds
|
||||
Elapsed-seconds value the sky's UV scroll is pinned to on both launches.
|
||||
Default 0 -- the cloud sheet's authored origin. Any finite value works: the
|
||||
offset is taken modulo 1 per axis. See forced item 3 above.
|
||||
|
||||
.PARAMETER MaskTopPixels
|
||||
Height in pixels of a top band excluded from every comparison. DEFAULT 0 --
|
||||
nothing is masked, and the gate is a strict identity check on the whole
|
||||
|
|
@ -112,6 +130,7 @@ param(
|
|||
[int]$Tolerance = 2,
|
||||
[double]$MaxDifferentFraction = 0.001,
|
||||
[int]$DayGroup = 0,
|
||||
[double]$SkyPhaseSeconds = 0,
|
||||
[int]$MaskTopPixels = 0,
|
||||
[int]$MinRenderedBytes = 500000,
|
||||
[int]$CooldownSeconds = 15,
|
||||
|
|
@ -191,8 +210,10 @@ function Invoke-BackendRun([string]$Backend) {
|
|||
$env:ACDREAM_RETAIL_UI = '1'
|
||||
$env:ACDREAM_DEVTOOLS = '0'
|
||||
$env:ACDREAM_DAY_GROUP = "$DayGroup"
|
||||
# Both launches, always. See the .DESCRIPTION note 1.
|
||||
# Both launches, always. See the .DESCRIPTION notes 1 and 3.
|
||||
$env:ACDREAM_MSAA_SAMPLES = '0'
|
||||
$env:ACDREAM_SKY_PHASE_SECONDS =
|
||||
$SkyPhaseSeconds.ToString([System.Globalization.CultureInfo]::InvariantCulture)
|
||||
$env:ACDREAM_RENDER_BACKEND = $Backend
|
||||
$env:ACDREAM_UI_PROBE_SCRIPT = $effectiveRoute
|
||||
$env:ACDREAM_AUTOMATION_ARTIFACT_DIR = $dir
|
||||
|
|
@ -253,6 +274,7 @@ function Invoke-BackendRun([string]$Backend) {
|
|||
|
||||
Remove-Item Env:\ACDREAM_RENDER_BACKEND -ErrorAction SilentlyContinue
|
||||
Remove-Item Env:\ACDREAM_MSAA_SAMPLES -ErrorAction SilentlyContinue
|
||||
Remove-Item Env:\ACDREAM_SKY_PHASE_SECONDS -ErrorAction SilentlyContinue
|
||||
|
||||
$strayInput = @(Select-String -Path $log -Pattern 'ScrollUp|ScrollDown|ZoomIn|ZoomOut|CameraZoom' `
|
||||
-CaseSensitive -ErrorAction SilentlyContinue)
|
||||
|
|
@ -362,6 +384,7 @@ $report = [pscustomobject][ordered]@{
|
|||
MaxDifferentPixelFraction = $MaxDifferentFraction
|
||||
MsaaSamples = 0
|
||||
DayGroup = $DayGroup
|
||||
SkyPhaseSeconds = $SkyPhaseSeconds
|
||||
MaskTopPixels = $MaskTopPixels
|
||||
Runs = @($gl, $vk)
|
||||
Pairs = @($pairs)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue