erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

fix(ui,runtime): OP4 re-review residuals R1-R4 (coordinator pass) — OP4 CLOSED

Browse source 
R1: the timestamp prefix moves from ChatLog.Append (which stamped the
stored BODY, rendering 'Alice says, "13:05:09 hi"') to ChatVM's display
composition — FormatTimestampPrefix(entry.Received) prepends the COMPOSED
line, matching retail's separate-leading-string model (fprintf("%ls%ls",
ts, text) @0x00563e5b; AddTextToScroll receives composed lines). The
prefix renders entry.Received in LOCAL time (retail strftime), invariant
literal colons. The ten defect-pinning test cases across
ChatLogTests/RuntimeCommunicationStateTests are rewritten to pin the
corrected contract (stored bodies stay clean; the composed line carries
the stamp outside the quotes — ChatVMTests).

R2: open option-bearing panels converge on every PlayerDescription seed:
OptionPage.ReloadFromLive (per-row live re-read + gating re-eval, NO
AfterApply flush — the seed just cleared the dirty module),
OptionsPanelController.OnServerOptionsSeeded (active page),
CombatUiController.OnServerOptionsSeeded (SyncControls), wired through
RuntimeSettingsController.ServerOptionsSeeded from the same factory hook
LockUI already uses. Retail cannot reach this state (its panels close
across login); the adaptation exists because retained panels survive the
session boundary — documented at the seam.

R3: tests drive the refresh widget push (model AND checkbox converge) and
ReloadFromLive's no-flush contract. R4: AP-196 addendum names the
headless AutoRepeatAttack false->true effective-default flip and the
characterOptions escape hatch.

Full Release suite: 13,083 passed / 4 skipped / 0 failed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-11 06:36:14 +02:00
parent e71e5a9614
commit ac0304dcf0
13 changed files with 216 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

69
tests/AcDream.Core.Tests/Chat/ChatLogTests.cs
View file

@ -339,78 +339,39 @@ public sealed class ChatLogTests
Assert.Equal(0x06u, log.Snapshot()[0].LogTextType);
}
// ── SF-1/S1 (OP4 review-fix round, 2026-08-11): DisplayTimestampsSource
// prefixes EVERY producer through the shared Append seam, not just
// RuntimeCommunicationState.AddText's own subset of callers. ────────
[Fact]
public void DisplayTimestampsSource_Unbound_NoPrefix()
{
var log = new ChatLog();
log.OnLocalSpeech("Alice", "hi", 0xAAu, isRanged: false, logTextType: 0x02u);
Assert.Equal("hi", log.Snapshot()[0].Text);
}
// ── OP4 re-review R1 (2026-08-11): the timestamp NEVER touches the stored
// body — retail composes the display line first and prepends the stamp
// as a separate leading string at display time (fprintf("%ls%ls", ts,
// text) @0x00563e5b). ChatVM's display composition owns the prefix;
// these tests pin that the LOG stays clean and the format is invariant.
[Theory]
[InlineData(false)]
[InlineData(true)]
public void DisplayTimestampsSource_GatesThePrefix(bool timestampsOn)
public void StoredEntryText_NeverCarriesTheTimestampPrefix(bool timestampsOn)
{
var log = new ChatLog { DisplayTimestampsSource = () => timestampsOn };
log.OnLocalSpeech("Alice", "hi", 0xAAu, isRanged: false, logTextType: 0x02u);
string text = log.Snapshot()[0].Text;
if (timestampsOn)
Assert.Matches(@"^\d{1,2}:\d{2}:\d{2} hi$", text);
else
Assert.Equal("hi", text);
}
[Theory]
// Every public ingestion method — proving the prefix applies at the
// ONE shared Append seam, not per-caller.
[InlineData("OnEmote")]
[InlineData("OnSoulEmote")]
[InlineData("OnChannelBroadcast")]
[InlineData("OnTellReceived")]
[InlineData("OnSystemMessage")]
[InlineData("OnPopup")]
[InlineData("OnCombatLine")]
[InlineData("OnSelfSent")]
[InlineData("OnPlayerKilled")]
public void DisplayTimestampsSource_AppliesToEveryProducer(string method)
{
var log = new ChatLog { DisplayTimestampsSource = () => true };
switch (method)
{
case "OnEmote": log.OnEmote("Caith", "waves", 0xCAFEu); break;
case "OnSoulEmote": log.OnSoulEmote("Bob", "dances", 0xBEEFu); break;
case "OnChannelBroadcast": log.OnChannelBroadcast(42u, "Alice", "motd"); break;
case "OnTellReceived": log.OnTellReceived("Alice", "psst", 0xAAu, logTextType: 0x03u); break;
case "OnSystemMessage": log.OnSystemMessage("fizzled", chatType: 5); break;
case "OnPopup": log.OnPopup("modal"); break;
case "OnCombatLine": log.OnCombatLine("hit", logTextType: 0x06u); break;
case "OnSelfSent": log.OnSelfSent(ChatKind.Tell, "hey", logTextType: 0x04u, targetOrChannel: "Alice"); break;
case "OnPlayerKilled": log.OnPlayerKilled("died", 0x1u, 0x2u); break;
}
string text = log.Snapshot()[0].Text;
Assert.Matches(@"^\d{1,2}:\d{2}:\d{2} .+$", text);
// The stored body is ALWAYS the raw message — the option gates the
// display composition (ChatVM), never the log content.
Assert.Equal("hi", log.Snapshot()[0].Text);
}
[Fact]
public void DisplayTimestampsSource_UsesLiteralColons_RegardlessOfCurrentCulture()
public void FormatTimestampPrefix_UsesLiteralColons_RegardlessOfCurrentCulture()
{
CultureInfo original = Thread.CurrentThread.CurrentCulture;
try
{
Thread.CurrentThread.CurrentCulture = CultureInfo.GetCultureInfo("fi-FI");
var log = new ChatLog { DisplayTimestampsSource = () => true };
log.OnSystemMessage("fizzled", chatType: 0);
string prefix = ChatLog.FormatTimestampPrefix(
new DateTime(2026, 8, 11, 13, 5, 9, DateTimeKind.Utc));
Assert.Matches(@"^\d{1,2}:\d{2}:\d{2} fizzled$", log.Snapshot()[0].Text);
// fi-FI's time separator is '.', so a culture-dependent format
// would emit "16.05.09 " here; retail's strftime is a literal ':'.
Assert.Matches(@"^\d{1,2}:\d{2}:\d{2} $", prefix);
}
finally
{