erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

fix(ui,runtime): OP4 re-review residuals R1-R4 (coordinator pass) — OP4 CLOSED

Browse source 
R1: the timestamp prefix moves from ChatLog.Append (which stamped the
stored BODY, rendering 'Alice says, "13:05:09 hi"') to ChatVM's display
composition — FormatTimestampPrefix(entry.Received) prepends the COMPOSED
line, matching retail's separate-leading-string model (fprintf("%ls%ls",
ts, text) @0x00563e5b; AddTextToScroll receives composed lines). The
prefix renders entry.Received in LOCAL time (retail strftime), invariant
literal colons. The ten defect-pinning test cases across
ChatLogTests/RuntimeCommunicationStateTests are rewritten to pin the
corrected contract (stored bodies stay clean; the composed line carries
the stamp outside the quotes — ChatVMTests).

R2: open option-bearing panels converge on every PlayerDescription seed:
OptionPage.ReloadFromLive (per-row live re-read + gating re-eval, NO
AfterApply flush — the seed just cleared the dirty module),
OptionsPanelController.OnServerOptionsSeeded (active page),
CombatUiController.OnServerOptionsSeeded (SyncControls), wired through
RuntimeSettingsController.ServerOptionsSeeded from the same factory hook
LockUI already uses. Retail cannot reach this state (its panels close
across login); the adaptation exists because retained panels survive the
session boundary — documented at the seam.

R3: tests drive the refresh widget push (model AND checkbox converge) and
ReloadFromLive's no-flush contract. R4: AP-196 addendum names the
headless AutoRepeatAttack false->true effective-default flip and the
characterOptions escape hatch.

Full Release suite: 13,083 passed / 4 skipped / 0 failed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-11 06:36:14 +02:00
parent e71e5a9614
commit ac0304dcf0
13 changed files with 216 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/AcDream.UI.Abstractions/Panels/Chat/ChatVM.cs
View file

@ -236,10 +236,16 @@ public sealed class ChatVM : IDisposable
int count = snap.Length - start;
if (count <= 0) return Array.Empty<string>();
// OP4 re-review R1: read the option once per snapshot so every line
// in one frame renders consistently.
bool timestamps = _log.DisplayTimestampsSource?.Invoke() == true;
var lines = new string[count];
for (int i = 0; i < count; i++)
{
lines[i] = FormatEntry(snap[start + i]);
var entry = snap[start + i];
lines[i] = timestamps
? ChatLog.FormatTimestampPrefix(entry.Received) + FormatEntry(entry)
: FormatEntry(entry);
}
return lines;
}
@ -338,12 +344,20 @@ public sealed class ChatVM : IDisposable
int count = snap.Length - start;
if (count <= 0) return Array.Empty<FormattedLine>();
// OP4 re-review R1: retail prepends the timestamp to the COMPOSED
// display line (a separate leading string — fprintf("%ls%ls", ts,
// text) @0x00563e5b), never to the message body, so tells/says render
// '13:05:09 Alice says, "hi"' and not 'Alice says, "13:05:09 hi"'.
bool timestamps = _log.DisplayTimestampsSource?.Invoke() == true;
var lines = new FormattedLine[count];
for (int i = 0; i < count; i++)
{
var entry = snap[start + i];
string text = FormatEntry(entry);
if (timestamps)
text = ChatLog.FormatTimestampPrefix(entry.Received) + text;
lines[i] = new FormattedLine(
Text: FormatEntry(entry),
Text: text,
Kind: entry.Kind,
CombatKind: entry.CombatKind,
LogTextType: entry.LogTextType);