From ab7c04fb4ffe213c71cd29d27193829b8685b5b5 Mon Sep 17 00:00:00 2001 From: Erik Date: Thu, 14 May 2026 17:04:44 +0200 Subject: [PATCH] docs(M1): reflect chat/toast revert + the actual B.5 polish (creature pickup guard) --- docs/plans/2026-05-12-milestones.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/plans/2026-05-12-milestones.md b/docs/plans/2026-05-12-milestones.md index f1c9e49..78a8c67 100644 --- a/docs/plans/2026-05-12-milestones.md +++ b/docs/plans/2026-05-12-milestones.md @@ -107,7 +107,7 @@ up an item from the ground. | 1 | Walk through Holtburg without getting stuck | ✅ met | L.2a/d/g shipped 2026-05-12; Holtburg doorway verified | | 2 | Open the inn door | ✅ met | B.4b (interaction) + B.4c (swing animation) shipped 2026-05-13 | | 3 | Click an NPC and see selection feedback | ✅ met | B.4b chain + chat handlers; verified 2026-05-14 (Tirenia + Royal Guard double-click → NPC dialogue in chat panel) | -| 4 | Pick up an item from the ground | ✅ met (close-range path) | B.5 + post-B.5 PickupEvent fix shipped 2026-05-14; visual-verified at Holtburg; pickup chat/toast feedback added in `87ba5c9` | +| 4 | Pick up an item from the ground | ✅ met (close-range path) | B.5 + post-B.5 `PickupEvent (0xF74A)` fix shipped 2026-05-14; visual-verified at Holtburg; creature-pickup guard added in `a01ebd5` | **What's left to formally land M1:** - Record ~30s demo video of the four-target scenario end-to-end. @@ -140,8 +140,14 @@ up an item from the ground. - **B.5** — `BuildPickUp` (PutItemInContainer 0x0019) + `SendPickUp` helper + F-key wiring + new `PickupEvent (0xF74A)` despawn handler. Shipped 2026-05-14. -- **B.5 polish** (`87ba5c9`) — pickup feedback chat line + toast so the - M1 demo's "pick up" target has visible payoff. +- **B.5 polish** (`a01ebd5`) — guard `SendPickUp` against creature + targets so F-on-NPC produces a "Can't pick that up" toast instead of + the malformed pickup that triggered ACE's `WeenieError 0x0029` + NPC + emote chain. (Briefly visited adding "You pick up the X." chat / + toast feedback for ground pickups in `87ba5c9`, then reverted in + `20ecb23` — retail doesn't show that line for ground pickups; only + for items received from NPCs / other characters, and that path is + separate.) **Freeze on landing:** - L.2 zone (collision, cell ownership, transition parity, wire authority)