From a32f56955df7f0c059515fc993c777a1ab067ed3 Mon Sep 17 00:00:00 2001
From: Erik <erik.nihlen@gmail.com>
Date: Fri, 22 May 2026 08:54:43 +0200
Subject: [PATCH] =?UTF-8?q?fix(test):=20A6.P3=20slice=201=20T3=20=E2=80=94?=
 =?UTF-8?q?=20code-review=20nits?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Code-review feedback on commit 36975ef:
  - Remove redundant SetCheckPos call in BuildGroundedTransition
    (InitPath already set CheckPos to begin; the second call was a
    no-op that misled readers into thinking it was load-bearing).
  - Correct the class-level fixture-pattern attribution: pattern is
    a blend of FindEnvCollisionsMultiCellTests (engine+DataCache
    setup) and IndoorWalkablePlaneTests (sphere radius 0.48f +
    BuildCellWithFloor pattern). Comment was misleading by naming
    only the first.

Test still fails today with 'got 60. Finding 2 fix not complete.'
No functional change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../Physics/IndoorContactPlaneRetentionTests.cs     | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/tests/AcDream.Core.Tests/Physics/IndoorContactPlaneRetentionTests.cs b/tests/AcDream.Core.Tests/Physics/IndoorContactPlaneRetentionTests.cs
index fadfc7a..a8e24a0 100644
--- a/tests/AcDream.Core.Tests/Physics/IndoorContactPlaneRetentionTests.cs
+++ b/tests/AcDream.Core.Tests/Physics/IndoorContactPlaneRetentionTests.cs
@@ -26,9 +26,12 @@ namespace AcDream.Core.Tests.Physics;
 /// </para>
 ///
 /// <para>
-/// Template: fixture pattern matches <see cref="FindEnvCollisionsMultiCellTests"/>
-/// (engine + DataCache + RegisterCellStructForTest + AddLandblock + MakeGroundedTransition).
-/// Tested cell cell ID 0xA9B40166 (low 16 bits = 0x0166 ≥ 0x0100 → indoor branch fires).
+/// Fixture pattern is a blend of <see cref="FindEnvCollisionsMultiCellTests"/>
+/// (engine + DataCache + <c>RegisterCellStructForTest</c> + <c>AddLandblock</c> setup)
+/// and <see cref="IndoorWalkablePlaneTests"/> (sphere radius 0.48f matching
+/// <c>TryFindIndoorWalkablePlane</c>'s probe thresholds + <c>BuildCellWithFloor</c>
+/// floor polygon pattern).
+/// Tested cell ID 0xA9B40166 (low 16 bits = 0x0166 ≥ 0x0100 → indoor branch fires).
 /// </para>
 ///
 /// <para>
@@ -186,7 +189,9 @@ public class IndoorContactPlaneRetentionTests
     {
         var t = new Transition();
         t.SpherePath.InitPath(worldPos, worldTarget, cellId, SphereRadius);
-        t.SpherePath.SetCheckPos(worldPos, cellId);
+        // InitPath above already set CheckPos = begin; no second SetCheckPos
+        // needed because this test doesn't move the sphere from begin to a
+        // different destination (unlike multi-cell tests that walk a path).
 
         // Grounded state — mirrors BSPStepUpFixtures.MakeGroundedTransition.
         t.ObjectInfo.State          = ObjectInfoState.Contact | ObjectInfoState.OnWalkable;