erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

fix(ui): Campaign AS AS5 fix round — "retires AP-109" corrected to "narrows" at 6 sites

Browse source 
The AS5 review verified the port exhaustively (170/170 strings, 20
dispatch arms, 17 bounds tests, both call sites) and found one docs-class
defect: five code comments plus the plan slice text claimed AP-109 was
RETIRED while the register correctly keeps the row ACTIVE-narrowed (CT4
FormatXp GetNumberFormatA approximation sliver survives). Comment-only
edits; compile-checked; no behavior change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-25 10:30:53 +02:00
parent 8f8c0c3a07
commit 9f3e326374
6 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/AcDream.App.Tests/UI/Layout/AppraisalUiControllerTests.cs
View file

@ -461,7 +461,7 @@ public sealed class AppraisalUiControllerTests
// ── Campaign AS slice AS5: title-bar allegiance rank-title prefix ─────
// Ground truth: docs/research/2026-08-25-campaign-as-ground-truth.md
// §2a's title-bar row, gap G9, ruling R8. Retires register row AP-109.
// §2a's title-bar row, gap G9, ruling R8. Closes AP-109's rank-prefix residual (the row survives, narrowed to its FormatXp sliver).
[Fact]
public void CharacterResponse_TitleBarPrefixesAllegianceRankTitle()

2
tests/AcDream.App.Tests/UI/Layout/CharacterSheetProviderTests.cs
View file

@ -105,7 +105,7 @@ public sealed class CharacterSheetProviderTests
}
// ── Campaign AS slice AS5: name-line allegiance rank-title prefix ──────
// Retires register row AP-109. Same GetFullName port + rank-property id
// Closes AP-109's rank-prefix residual (row survives, narrowed). Same GetFullName port + rank-property id
// (props.GetInt(0x1E)) as the examination window's title bar
// (AppraisalUiControllerTests.CharacterResponse_TitleBarPrefixes*).