erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

fix(ui): Campaign AS AS5 fix round — "retires AP-109" corrected to "narrows" at 6 sites

Browse source 
The AS5 review verified the port exhaustively (170/170 strings, 20
dispatch arms, 17 bounds tests, both call sites) and found one docs-class
defect: five code comments plus the plan slice text claimed AP-109 was
RETIRED while the register correctly keeps the row ACTIVE-narrowed (CT4
FormatXp GetNumberFormatA approximation sliver survives). Comment-only
edits; compile-checked; no behavior change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-25 10:30:53 +02:00
parent 8f8c0c3a07
commit 9f3e326374
6 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/AcDream.App/UI/Layout/AllegianceRankTitleTable.cs
View file

@ -1,7 +1,7 @@
namespace AcDream.App.UI.Layout;
/// <summary>
/// Campaign AS slice AS5 (2026-08-25, retires register row AP-109): the
/// Campaign AS slice AS5 (2026-08-25, narrows register row AP-109 — its FormatXp sliver survives): the
/// retail allegiance rank-title table and its name-composition wrapper.
///
/// <para><b>Dispatch — <c>AllegianceSystem::GetTitle @0x005B8DD0</c>.</b>

2
src/AcDream.App/UI/Layout/CharacterIdentityText.cs
View file

@ -13,7 +13,7 @@ namespace AcDream.App.UI.Layout;
/// </summary>
/// <remarks>
/// <b>Name-line ruling (CT4, 2026-08-24; CLOSED at Campaign AS slice AS5,
/// 2026-08-25 — retires AP-109).</b> Retail's NAME line
/// 2026-08-25 — narrows AP-109; its FormatXp sliver survives).</b> Retail's NAME line
/// (<c>AllegianceData::GetFullName @0x005b6950</c>) prefixes an allegiance
/// RANK title ("&lt;RankTitle&gt; &lt;Name&gt;", same space separator, PE-read
/// @data_794098) when <c>AllegianceSystem::GetTitle(rank, heritage, gender)

2
src/AcDream.App/UI/Layout/CharacterSheetProvider.cs
View file

@ -164,7 +164,7 @@ public sealed class CharacterSheetProvider
return new CharacterSheet
{
// Campaign AS slice AS5 (retires AP-109): retail's NAME line
// Campaign AS slice AS5 (narrows AP-109 — its FormatXp sliver survives): retail's NAME line
// (gmStatManagementUI::UpdateCharacterInfo @0x004F0770,
// @0x004f0807-@0x004f0895) prefixes AllegianceData::GetFullName
// @0x005B6950's rank title exactly like the examination window's