docs(architecture): close selection extraction slice
Record the measured GameWindow reduction, final review and test gates, durable selection/inventory ownership rules, and live animation presentation as Slice 2. Co-authored-by: OpenAI Codex <codex@openai.com>
This commit is contained in:
Erik
parent
5acc3f01cf
commit
9ad8113c79
10 changed files with 141 additions and 52 deletions
|
|
@ -833,7 +833,10 @@ Current movement/collision ownership:
|
|||
two-client observer gate; Track LH is the future presentation-independent
|
||||
Linux/headless extraction.
|
||||
- **The behavior-preserving thin-`GameWindow` ownership campaign is the active
|
||||
prerequisite before new M4 subsystem bodies.** Its reconciled ledger and
|
||||
prerequisite before new M4 subsystem bodies.** Selection/interaction Slice 1
|
||||
landed 2026-07-21 with `WorldSelectionQuery`,
|
||||
`SelectionInteractionController`, and the shared retail inventory-request
|
||||
owner; live animation presentation is next. The reconciled ledger and
|
||||
sequence live in `docs/architecture/code-structure.md`. This decision does
|
||||
not reclassify the remaining L.2 conformance work or Track LH.
|
||||
|
||||
|
|
|
|||
|
|
@ -1,8 +1,8 @@
|
|||
# acdream — code structure & extraction sequence
|
||||
|
||||
**Status:** Living document. Created 2026-05-16; implementation reconciliation
|
||||
completed 2026-07-21. This is the active structural program before new M4
|
||||
subsystems enter the App layer.
|
||||
completed 2026-07-21; Slice 1 landed the same day. This is the active
|
||||
structural program before new M4 subsystems enter the App layer.
|
||||
**Purpose:** Describe the desired structural state of the App layer,
|
||||
explain the rules we've adopted, and lay out the safe extraction
|
||||
sequence from today's reality (one 15,723-line `GameWindow.cs` at the
|
||||
|
|
@ -22,8 +22,8 @@ layer is wire-compatible, the UI has a stable contract, plugins load.
|
|||
The structural debt is concentrated in **one file**:
|
||||
|
||||
```
|
||||
src/AcDream.App/Rendering/GameWindow.cs 15,723 lines (2026-07-21)
|
||||
258 fields / ~259 methods
|
||||
baseline cf50ee3d 15,723 lines / 278 fields / 205 methods
|
||||
after Slice 1 14,912 lines / 278 fields / 191 methods
|
||||
```
|
||||
|
||||
`GameWindow` is the single object that:
|
||||
|
|
@ -35,9 +35,9 @@ src/AcDream.App/Rendering/GameWindow.cs 15,723 lines (2026-07-21)
|
|||
`LiveSessionController` owns the socket/session shell.
|
||||
- Owns the adapters that hydrate canonical `LiveEntityRuntime` records into
|
||||
animation, collision, rendering, and DAT-backed appearance resources.
|
||||
- Still drives selection / interaction (`WorldPicker`, target classification,
|
||||
`SendUse`, `SendPickUp`, auto-walk deferral) despite the shipped item and
|
||||
combat controllers.
|
||||
- Composes the shipped `WorldSelectionQuery` and
|
||||
`SelectionInteractionController`; it no longer owns world-picking,
|
||||
selection intent, Use/PickUp, or auto-walk deferral algorithms.
|
||||
- Drives per-frame render orchestration (sky → terrain → opaque mesh →
|
||||
transparent mesh → particles → debug lines → UI).
|
||||
- Builds and applies streamed landblock presentation (DAT decode, scenery,
|
||||
|
|
@ -391,7 +391,7 @@ useful ordering seam, but its ownership status is **partial**.
|
|||
| Inbound/object-frame order | **Partial** | `RetailInboundEventDispatcher`, `RetailLiveFrameCoordinator`, `LiveEntityAnimationScheduler`, static scheduler, remote/projectile updaters, and teleport owners are shipped. `AdvanceLiveObjectRuntimeCore`, final part/mesh/effect composition, and several integration tails remain in `GameWindow`. |
|
||||
| World reveal | **Complete** | `WorldRevealCoordinator` owns login/portal readiness and reveal lifetime (`a4ef5788`). The accepted deterministic lifecycle trace did not change after extraction. |
|
||||
| Retained gameplay UI | **Mostly complete feature ownership** | `RetailUiRuntime` and focused panel/controllers own layout and behavior. `GameWindow.OnLoad` still performs substantial service composition, which is allowed until the final composition cleanup. |
|
||||
| Selection/interaction | **Partial** | `ItemInteractionController`, `CombatTargetController`, and `CombatAttackController` own focused rules. `GameWindow` still owns picking, target queries, selection intent, Use/PickUp sends, range/auto-walk deferral, and related input cases. |
|
||||
| Selection/interaction | **Complete** | `WorldSelectionQuery` owns read-only picking/classification/range queries; `SelectionInteractionController` owns selection intent, Use/PickUp transport, exact-incarnation queues, and auto-walk deferral; `ItemInteractionController` owns ItemHolder policy plus the shared retail inventory-request transaction. `GameWindow` retains construction and narrow lifecycle forwarding only. |
|
||||
| Landblock presentation | **Not extracted** | Residency scheduling is extracted, but DAT build, scenery/EnvCell construction, apply, collision/resource publication, and retirement glue remain a large `GameWindow` body. |
|
||||
| Render-frame orchestration | **Not extracted** | `OnRender` plus its portal/PView/alpha/particle helpers still own the draw graph and frame-local scratch state. There is no `RenderFrameOrchestrator` yet. |
|
||||
| Unified `GameEntity` | **Deferred target** | `LiveEntityRuntime` already supplies the critical canonical owner. Full type aggregation is a separate high-risk migration and is not required to make `GameWindow` thin. |
|
||||
|
|
@ -409,7 +409,7 @@ two-client portal observer gate form the pre-refactor baseline. Each later
|
|||
slice runs the subset capable of detecting its risk; render/session slices run
|
||||
the complete connected lifecycle gate.
|
||||
|
||||
#### Slice 1 — finish selection/interaction ownership — NEXT
|
||||
#### Slice 1 — finish selection/interaction ownership — COMPLETE 2026-07-21
|
||||
|
||||
Detailed execution plan:
|
||||
[`docs/plans/2026-07-21-gamewindow-slice-1-selection-interaction.md`](../plans/2026-07-21-gamewindow-slice-1-selection-interaction.md).
|
||||
|
|
@ -429,11 +429,21 @@ Split the old Step 4 into three reviewable commits:
|
|||
Tests cover read-only query classification separately from stateful intents,
|
||||
including direct use, distant auto-walk completion, corpse/container opening,
|
||||
pickup placement, hostile-only targeting, Hidden objects, and same-GUID reuse.
|
||||
The connected gate is select → use door/NPC → distant corpse → loot/pickup →
|
||||
combat target. This is the safest next slice because its outbound boundaries
|
||||
are typed and existing controllers already hold most retail rules.
|
||||
The cutover landed in `047a4c83`, `52dbb574`, `e74f2ca9`, `fa8d5232`,
|
||||
`d2bb5af4`, and review-correction commit `5acc3f01`. The final review also
|
||||
ported the shared `ACCWeenieObject::prevRequest` transaction shape across
|
||||
inventory, toolbar, paperdoll, external-container, give, split, merge, and
|
||||
drop routes. Queued actions, pending placements, and responses are bound to
|
||||
exact object incarnations/tokens; optimistic projection, rollback projection,
|
||||
and authoritative response notices are distinct.
|
||||
|
||||
#### Slice 2 — finish live animation presentation
|
||||
Measured against `cf50ee3d`, `GameWindow` fell from 15,723 to 14,912 lines and
|
||||
from 205 to 191 methods; field count stayed at 278 because the slice exchanged
|
||||
legacy state for composed owners. Three independent retail, architecture, and
|
||||
adversarial review loops finished clean. Release build passed; 6,558 tests
|
||||
passed and five fixture/conformance tests skipped intentionally.
|
||||
|
||||
#### Slice 2 — finish live animation presentation — NEXT
|
||||
|
||||
Move `TickAnimations`, final rigid/visual part composition, effect-pose
|
||||
publication, and motion-done binding into `LiveEntityAnimationPresenter`.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue