erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(net): #13 read options2 gated on CHARACTER_OPTIONS2 flag

Browse source 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Erik 2026-05-10 08:46:32 +02:00
parent b17dc3b152
commit 98eebef740
2 changed files with 34 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/AcDream.Core.Net/Messages/PlayerDescriptionParser.cs
View file

@ -398,6 +398,9 @@ public static class PlayerDescriptionParser
// to 0 if EOF. // to 0 if EOF.
if (payload.Length - pos >= 4) if (payload.Length - pos >= 4)
spellbookFilters = ReadU32(payload, ref pos); spellbookFilters = ReadU32(payload, ref pos);
if (optionFlags.HasFlag(CharacterOptionDataFlag.CharacterOptions2))
options2 = ReadU32(payload, ref pos);
} }
} }
catch (FormatException ex) catch (FormatException ex)

31
tests/AcDream.Core.Net.Tests/PlayerDescriptionParserTests.cs
View file

@ -593,4 +593,35 @@ public sealed class PlayerDescriptionParserTests
Assert.NotNull(parsed); Assert.NotNull(parsed);
Assert.Equal(0xF00DBA42u, parsed!.Value.SpellbookFilters); Assert.Equal(0xF00DBA42u, parsed!.Value.SpellbookFilters);
} }
[Fact]
public void TryParse_TrailerOptions2_GatedOnCharacterOptions2Bit()
{
var sb = new MemoryStream();
using var writer = new BinaryWriter(sb);
writer.Write(0u); // propertyFlags
writer.Write(0x52u); // weenieType
writer.Write(0x201u); // ATTRIBUTE | ENCHANTMENT
writer.Write(1u); // has_health
writer.Write(0u); // empty attribute_flags
writer.Write(0u); // empty enchantment mask
// option_flags = CHARACTER_OPTIONS2 (0x40)
writer.Write(0x40u);
writer.Write(0u); // options1
// Legacy hotbar list: count=0.
writer.Write(0u);
// spellbook_filters
writer.Write(0u);
// options2 sentinel
writer.Write(0xC0FFEE01u);
var parsed = PlayerDescriptionParser.TryParse(sb.ToArray());
Assert.NotNull(parsed);
Assert.Equal(0xC0FFEE01u, parsed!.Value.Options2);
}
} }