fix(chat): Campaign CH round 3 — SpewBox flush-top/font, /help exact print sequence
User-gate round 3 findings (a)-(c):
(a) SpewBox: TopOffset moves from the round-1 60px placeholder to 0 (flush
to the viewport top). SpewBoxController never wired DatFont/Font at all
before this round, so it silently rendered through the 15px debug
BitmapFont fallback; it now resolves retail dat Font 0x40000025
(MaxCharHeight=11px) through a new RetailUiRuntime.Assets accessor —
the smallest font id confirmed in use by any currently-imported retail
LayoutDesc fixture, cross-referenced against every
tests/AcDream.App.Tests/UI/Layout/fixtures/*.json dump and confirmed
against the installed DAT via AcDream.Cli dump-font-atlas. It is also the
chat window's own smallest font (the 0x2100006F floating-window 1/2/3/4
indicator badges), so both selection criteria the brief offered agree.
Both remain best-available approximations, not resolved retail values —
register row AP-178 updated accordingly.
(b)/(c) /help and /help death: round 2 extracted the individual retail
strings byte-exact but never traced ClientCommunicationSystem::DoHelp's
complete print sequence. Byte-swept DoHelp's own range plus the five
Summary-branch functions it calls into (HelpEmote/HelpSquelch/
HelpStatusGroup/HelpTextGroup/HelpAllGroup) against the PDB-paired
acclient.exe. Retail's real shape: bare /help prints exactly TWO scroll
entries (HelpPrefixNote, then the 13-item AvailableHelpListing built from
DoHelp's own literals and each group's Summary_HelpType branch, in exact
source order) — not the acdream-invented cheat sheet BuildHelpText()
built before. Any resolved /help <verb> gets the SAME two-entry shape:
HelpPrefixNote, then ForMoreInformationPrefix concatenated directly onto
the verb's own Detail text (retail's own unsubstituted "<command>"
literal, ported verbatim). ChatCommandRouter.EmitVerbHelp applies this
uniformly to every resolved verb, not just death. An unresolved verb now
shows retail's real "Unknown command" fallback text; that fallback types
0x1A (ClientLocal), which retail routes to the SpewBox exclusively — a
gap ChatVM's UI.Abstractions layer can't yet reach, filed as ISSUES #367
/ register AP-186 rather than left silently unregistered.
Jump-in-air (round 2's open item 1) was root-caused and fixed separately
at a5a7eb4f between rounds — recorded in the campaign ledger.
Debug suite (all projects): 12,329 passed / 4 skipped / 1 failed — the
one failure is issue #351, a pre-existing Debug-only streaming flake
confirmed reproducing identically on the pristine pre-round-3 commit via
git stash, not a regression. Release verification covers every project
reachable without rebuilding AcDream.App: a live client process (PID
15064) held its own Release binaries locked for the session and was not
killed per project policy — AcDream.UI.Abstractions.Tests (867/867, the
layer both /help fixes live in) plus every other non-App-dependent
project, all 0 failed. AcDream.App/AcDream.App.Tests/AcDream.Core.Tests
(the SpewBox fix's layer) are green in Debug only this session.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
parent
a5a7eb4fb6
commit
98de4f5ab3
14 changed files with 665 additions and 105 deletions
|
|
@ -8,14 +8,18 @@ FEEL right".
|
|||
## 1. On-screen interface text (CH2 — the SpewBox)
|
||||
|
||||
- Jump, and press jump again while airborne → **"You can't jump while in
|
||||
the air"** appears as transient text near the top of the viewport, NOT
|
||||
in the chat window. Chat gets no line at all.
|
||||
the air"** appears as transient text flush to the very TOP of the
|
||||
viewport (round 3, 2026-08-10 — moved off the earlier 60px-down
|
||||
placeholder), NOT in the chat window. Chat gets no line at all.
|
||||
- Spam it 5+ times fast: the line refreshes in place (no stacking of
|
||||
identical text); distinct refusals stack newest-on-top, max 4 lines.
|
||||
- Try `@version` → its output goes to CHAT (green), not the SpewBox.
|
||||
- **Report presentation impressions**: position, color, and how long lines
|
||||
linger are placeholders pending measurement (register AP-177/AP-178) —
|
||||
say what looks wrong vs your retail memory.
|
||||
- The SpewBox text should now read visibly SMALLER than round 2 (retail
|
||||
dat Font `0x40000025`, 11px, replacing the earlier 15px debug font).
|
||||
- **Report presentation impressions**: position and font are now
|
||||
best-available approximations, not resolved retail values (register
|
||||
AP-178); line lifetime is still a placeholder (AP-177) — say what looks
|
||||
wrong vs your retail memory.
|
||||
|
||||
## 2. Chat colors (CH1)
|
||||
|
||||
|
|
@ -58,11 +62,31 @@ Side-by-side vs retail if possible:
|
|||
- An unknown verb like `@somenonsense` → passes through to ACE (server
|
||||
answers, client does not swallow it).
|
||||
|
||||
## 5. Help text (round 3, 2026-08-10)
|
||||
|
||||
- `/help` (no args) → TWO lines in the chat window: a "Note: You may
|
||||
substitute a forward slash..." line, then "Available help:" followed by
|
||||
13 real retail topic one-liners (allegiances/channels/chatting/death/
|
||||
emote/fillcomps/friends/house/squelch/status/text/commands). This
|
||||
replaced an acdream-invented cheat sheet ("Chat: /say...", "Client:
|
||||
/help...") — that text should no longer appear at all.
|
||||
- `/help death` → the SAME "Note:" line first, then a SECOND line starting
|
||||
"For more information, type @help <command>." immediately followed by
|
||||
the 8-line corpse/death command listing — not just the 8 lines alone.
|
||||
- `/help somenonsenseverb` → "Unknown command" (no "Note:" line before it;
|
||||
retail's fallback skips the wrapper). This still shows in the CHAT
|
||||
window rather than the SpewBox — a known, tracked gap (#367/AP-186), not
|
||||
a new bug to report.
|
||||
|
||||
## Known-open, do not report as new
|
||||
|
||||
- Ctrl+M mute chord (#358) — still broken, separate from this campaign.
|
||||
- SpewBox lifetime/position/color are registered placeholders
|
||||
(AP-177/AP-178) pending a retail measurement session.
|
||||
- SpewBox line lifetime is still a placeholder (AP-177) pending a retail
|
||||
measurement session; position/font are now best-available
|
||||
approximations (AP-178), not confirmed retail pixel values.
|
||||
- `/help <verb>` fallback ("Unknown command") shows in the chat window,
|
||||
not the SpewBox — retail types it for the SpewBox exclusively, but
|
||||
`ChatCommandRouter` has no path there yet (#367/AP-186).
|
||||
- Allegiance management subcommands print the help refusal instead of
|
||||
executing (#360); `@day`/`@log`/`@render` deferred (#361); four request
|
||||
commands send but responses aren't rendered yet (#362).
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue