fix(chat): Campaign CH round 3 — SpewBox flush-top/font, /help exact print sequence

User-gate round 3 findings (a)-(c):

(a) SpewBox: TopOffset moves from the round-1 60px placeholder to 0 (flush
to the viewport top). SpewBoxController never wired DatFont/Font at all
before this round, so it silently rendered through the 15px debug
BitmapFont fallback; it now resolves retail dat Font 0x40000025
(MaxCharHeight=11px) through a new RetailUiRuntime.Assets accessor —
the smallest font id confirmed in use by any currently-imported retail
LayoutDesc fixture, cross-referenced against every
tests/AcDream.App.Tests/UI/Layout/fixtures/*.json dump and confirmed
against the installed DAT via AcDream.Cli dump-font-atlas. It is also the
chat window's own smallest font (the 0x2100006F floating-window 1/2/3/4
indicator badges), so both selection criteria the brief offered agree.
Both remain best-available approximations, not resolved retail values —
register row AP-178 updated accordingly.

(b)/(c) /help and /help death: round 2 extracted the individual retail
strings byte-exact but never traced ClientCommunicationSystem::DoHelp's
complete print sequence. Byte-swept DoHelp's own range plus the five
Summary-branch functions it calls into (HelpEmote/HelpSquelch/
HelpStatusGroup/HelpTextGroup/HelpAllGroup) against the PDB-paired
acclient.exe. Retail's real shape: bare /help prints exactly TWO scroll
entries (HelpPrefixNote, then the 13-item AvailableHelpListing built from
DoHelp's own literals and each group's Summary_HelpType branch, in exact
source order) — not the acdream-invented cheat sheet BuildHelpText()
built before. Any resolved /help <verb> gets the SAME two-entry shape:
HelpPrefixNote, then ForMoreInformationPrefix concatenated directly onto
the verb's own Detail text (retail's own unsubstituted "<command>"
literal, ported verbatim). ChatCommandRouter.EmitVerbHelp applies this
uniformly to every resolved verb, not just death. An unresolved verb now
shows retail's real "Unknown command" fallback text; that fallback types
0x1A (ClientLocal), which retail routes to the SpewBox exclusively — a
gap ChatVM's UI.Abstractions layer can't yet reach, filed as ISSUES #367
/ register AP-186 rather than left silently unregistered.

Jump-in-air (round 2's open item 1) was root-caused and fixed separately
at a5a7eb4f between rounds — recorded in the campaign ledger.

Debug suite (all projects): 12,329 passed / 4 skipped / 1 failed — the
one failure is issue #351, a pre-existing Debug-only streaming flake
confirmed reproducing identically on the pristine pre-round-3 commit via
git stash, not a regression. Release verification covers every project
reachable without rebuilding AcDream.App: a live client process (PID
15064) held its own Release binaries locked for the session and was not
killed per project policy — AcDream.UI.Abstractions.Tests (867/867, the
layer both /help fixes live in) plus every other non-App-dependent
project, all 0 failed. AcDream.App/AcDream.App.Tests/AcDream.Core.Tests
(the SpewBox fix's layer) are green in Debug only this session.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-10 10:40:19 +02:00
parent a5a7eb4fb6
commit 98de4f5ab3
14 changed files with 665 additions and 105 deletions

View file

@ -192,6 +192,49 @@ click — not decoded by CH6a.
`src/AcDream.App/UI/Layout/LayoutImporter.cs`
(`BuildWidget`/`ConsumesDatChildren` handling); `src/AcDream.App/UI/UiText.cs`.
## #367 — ChatCommandRouter's local-presentation fallbacks type-0x1A text still lands in the chat scroll, never the SpewBox
**Status:** OPEN — filed 2026-08-10, Campaign CH user-gate round 3, while
tracing `ClientCommunicationSystem::DoHelp @0x0057f9e0`'s complete print
sequence for findings (b)/(c). Retail's DoHelp fallback for an unresolved
`/help <verb>` is `AddTextToScroll(u"Unknown command", 0x1A, 1, 0)` — type
`0x1A` (`ClientLocal`) is HARDCODED to the SpewBox, never the chat window
(`docs/research/2026-08-09-chat-retail-interface-text.md` §2.1/§2.2, the
same routing rule Campaign CH user-gate round 2 item 2 already ported for
the portal-space notice). `RuntimeCommunicationState.AddText` (Runtime
layer) implements this rule correctly — `type == ClientLocal` routes to
`SpewBox` only. But `ChatCommandRouter`/`ChatVM` live in
`AcDream.UI.Abstractions`, a layer beneath Runtime that must stay
presentation/Runtime-independent (Code Structure Rules), so they have no
path to the SpewBox at all — every local-presentation fallback
(`RetailCommandHelpTable.UnknownCommand` now; also the pre-existing
"Unknown command: {verb}." command-shaped-input refusal in
`ChatCommandRouter.Submit`'s main body) still writes through
`ChatVM.ShowSystemMessage`, which only ever reaches `ChatLog`. Not a
regression this round — the fallback text was already wrong AND
already routed to the chat window before this round's fix; this round
corrected the TEXT ("Unknown command", byte-exact) and traced the
routing divergence clearly enough to file it. Register row AP-186.
**Fix shape:** either (a) give `ChatVM` (or a sibling in UI.Abstractions)
an optional `Action<string>? OnClientLocalText` hook the App-layer host
wires to `RuntimeCommunicationState.AddText(text, RetailLogTextType.ClientLocal)`
the same way `ChatWindowController`/other retained-UI controllers already
receive delegates from the composition layer, or (b) accept the
divergence permanently as an acdream simplification (all local-presentation
refusals show in the chat window instead of splitting across two surfaces)
and retire AP-186 as an accepted Intentional Architecture row instead. Needs
a product decision, not just an implementation — small either way once
decided.
**Where:** `src/AcDream.UI.Abstractions/Panels/Chat/ChatCommandRouter.cs`;
`src/AcDream.UI.Abstractions/Panels/Chat/ChatVM.cs`;
`src/AcDream.Runtime/Gameplay/RuntimeCommunicationState.cs` (`AddText`, the
correctly-implemented Runtime-layer oracle this should eventually reach).
**Campaign:** `docs/plans/2026-08-09-chat-parity-campaign.md` (Campaign CH,
user gate round 3).
## #364 — Three `/help` group topics still partial: HelpStupidChannelHack unresolved
**Status:** OPEN — filed 2026-08-09, Campaign CH user-gate round 2, item 3.