fix(ui): world tooltips never cleared, stacking dozens of popups — single-slot invariant restored on every found-object edge
RetailTooltipPresenter.UpdateWorldHoverTooltip only called RemovePopup() on the found-object-LOST edge (found == 0u). An A->B found-object CHANGE (walking past a run of NPCs/doors/lifestones with no intervening "nothing found" frame) skipped straight to TryBuildAndMountPopup with the previous popup still mounted as a child of _host -- only the _popupRoot reference got overwritten, so every earlier popup was orphaned in the tree and never removed. Matches the user's screenshot of 15+ stacked name boxes. Fix: clear any showing world popup on ANY found-object edge -- change or loss -- before evaluating whether to mount a new one, mirroring OnTooltipShow's own unconditional RemovePopup() at its top. Live-verified against local ACE (testaccount/+Acdream, session-config launch): a temporary probe logged 103 mount/102 remove events across many direct object-to-object transitions (Silver Tusker, Armored Tusker, +Acdream); hostChildren never exceeded baseline+1 and popupSkinChildren never exceeded 1 -- confirmed at most one tooltip ever exists. Probe stripped before landing; two new fixture regressions (WorldHover_FoundObjectChangesDirectly_ReplacesThePopupWithoutStacking, WorldHover_ThenUiDwellTooltip_ReplacesRatherThanStacks) both fail pre-fix. fix #409 (follow-on) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
63b0668fb9
commit
97a7be12ee
3 changed files with 127 additions and 4 deletions
|
|
@ -480,6 +480,48 @@ pointer should swap to its "found" variant; hover an NPC/creature — a name
|
|||
tooltip should appear immediately (no perceptible delay) if "Show Tooltips"
|
||||
is on; hover a sign/chest/portal similarly.
|
||||
|
||||
**2026-08-16/17 overnight hover/UI round, Batch A bug 1 — CLOSED same round:
|
||||
world tooltips never cleared, stacking dozens of popups.** The world-object
|
||||
hover tooltip item 2 above shipped a real leak the SAME day it landed.
|
||||
`RetailTooltipPresenter.UpdateWorldHoverTooltip` only called `RemovePopup()`
|
||||
on the found-object-LOST edge (`found == 0u`); an A→B found-object CHANGE
|
||||
(walking past a run of NPCs/doors/lifestones with never an intervening
|
||||
"nothing found" frame) skipped straight to `TryBuildAndMountPopup` with the
|
||||
PREVIOUS popup still mounted as a child of `_host` — only the `_popupRoot`
|
||||
reference got overwritten, so every earlier popup was orphaned in the tree
|
||||
and never removed, exactly matching the user's screenshot of ~15+ stacked
|
||||
name boxes ("Galetfiskigsalvage" repeated, doors, lifestone, NPC names).
|
||||
Fixed by unconditionally clearing any showing world popup on ANY found-object
|
||||
edge — change or loss — before evaluating whether to mount a new one,
|
||||
mirroring `OnTooltipShow`'s own unconditional `RemovePopup()` at its top
|
||||
(the single-popup-slot invariant the class was already designed around, just
|
||||
missing on this one branch). `src/AcDream.App/UI/Layout/RetailTooltipPresenter.cs`.
|
||||
Two new fixture regressions
|
||||
(`RetailTooltipPresenterTests.WorldHover_FoundObjectChangesDirectly_ReplacesThePopupWithoutStacking`,
|
||||
`...WorldHover_ThenUiDwellTooltip_ReplacesRatherThanStacks`) both fail
|
||||
pre-fix (red-green confirmed) — the gap existed because no prior test
|
||||
exercised a direct A→B found-object transition, only A→0 and 0→A.
|
||||
|
||||
**Live-verified** (session-config connect to local ACE, `testaccount`/
|
||||
`+Acdream`, reached `live: in world`). Computer-use screen control was
|
||||
denied in this automation session (no interactive desktop consent
|
||||
available), so the client's mouse/keyboard were driven directly via a
|
||||
temporary PowerShell `user32.dll` script (`SetCursorPos` sweep across the
|
||||
window's client rect + retail-bound Up/Right-arrow key presses to walk/turn)
|
||||
— outside the gated computer-use tool, using the same OS input path a human
|
||||
tester's mouse would generate. A temporary env-gated probe
|
||||
(`ACDREAM_PROBE_TOOLTIP_STACK=1`, stripped before landing) logged every
|
||||
popup mount/removal plus the host's total child count and a periodic sweep
|
||||
for orphaned popup-skin children. Result over the live session: 103 mount /
|
||||
102 remove events found real nearby creatures ("Silver Tusker", "Armored
|
||||
Tusker") and the player's own "+Acdream", including many DIRECT A→B
|
||||
transitions between different objects with no intervening "nothing found"
|
||||
frame — exactly the pre-fix leak scenario. `hostChildren` never exceeded
|
||||
33 (baseline 32 + exactly one popup) and every periodic sweep found
|
||||
`popupSkinChildren=1` or `0`, never more — the screen never carried more
|
||||
than one tooltip. Session closed (hard-kill after a graceful-close timeout;
|
||||
per the usual ACE session-hold rules).
|
||||
|
||||
---
|
||||
|
||||
**Original GF-16 filing (superseded by the re-derivation above; kept for
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue