feat(player): #5 PlayerDescription parser — Stam/Mana via attribute block

Visual-verified — Vitals window now shows three bars (HP/Stam/Mana)
with live values. Closes ISSUES.md #5; ~95% reading on Stam/Mana
traced to active buff multipliers, filed as #6.

Why the rewrite

The first attempt (commit d42bf57) routed PlayerDescription (0x0013)
through AppraiseInfoParser, trusting a misleading xmldoc claim.
Live diagnostics proved the format is wrong — ACE source
(GameEventPlayerDescription.WriteEventBody) hand-writes a body
distinct from IdentifyObjectResponse's AppraiseInfo: property
hashtables gated on DescriptionPropertyFlag, vector-flag-gated
attribute / skill / spell blocks, then a long options + inventory
trailer. Vitals only arrive via the attribute block at login.
Holtburger's events.rs:220-625 has the canonical client-side
unpacker; this commit ports the early-section walker through spells.

What landed

  PlayerDescriptionParser.cs (new — 350 LOC):
    Walks propertyFlags + weenieType, then property hashtables
    (Int32/Int64/Bool/Double/String/Did/Iid) + Position table —
    each gated on a property flag bit, header is `u16 count, u16
    buckets`. Then vectorFlags + has_health + the attribute block
    (primary attrs 1..6 = 12 B each, vitals 7..9 = 16 B with
    `current`), then optional Skill + Spell tables. Stops cleanly
    before the options/shortcuts/hotbars/inventory trailer (filed
    as #7 — heuristic alignment search needed for gameplay_options).

  PrivateUpdateVital.cs (new — 95 LOC):
    Wire parsers for the GameMessage opcodes 0x02E7 (full snapshot)
    and 0x02E9 (current-only delta), per holtburger UpdateVital +
    UpdateVitalCurrent. WorldSession dispatches each to a session-
    level event the GameWindow forwards into LocalPlayerState.

  LocalPlayerState (full redesign):
    VitalKind (Health/Stamina/Mana) + AttributeKind (six primary).
    VitalSnapshot stores ranks/start/xp/current; AttributeSnapshot
    stores ranks/start/xp with `Current = ranks+start` per
    holtburger. GetMaxApprox computes the retail formula
        vital.(ranks+start) + attribute_contribution
    where the contribution is hardcoded from retail's
    SecondaryAttributeTable: Endurance/2 for Health, Endurance for
    Stamina, Self for Mana. Enchantment buffs not yet folded in
    (filed as #6). VitalIdToKind now accepts both ID systems
    (1..6 wire, 7..9 PD attribute block); AttributeIdToKind covers
    primary attrs 1..6.

  GameEventWiring:
    PlayerDescription handler. Walks parsed.Attributes, routes
    primary attrs (id 1..6) to OnAttributeUpdate and vitals
    (id 7..9) to OnVitalUpdate. Player's full learned spellbook
    also lands here. ACDREAM_DUMP_VITALS=1 traces every PD attribute
    + every PrivateUpdateVital(Current) opcode for diagnostics.

  WorldSession:
    Dispatch chain re-ordered — the diagnostic else-if for
    ACDREAM_DUMP_OPCODES=1 was originally placed before
    GameEventEnvelope.Opcode, which silently intercepted 0xF7B0 and
    broke UpdateHealth dispatch when the env var was set. Moved to
    the very end of the chain so it only fires for genuinely
    unhandled opcodes. (Diagnostic-only regression; production
    launches without the env var were unaffected.)

Test deltas

  Added:
    - PlayerDescriptionParserTests (6 — empty header, full attribute
      block, partial flags, post-property-table walk, spell table)
    - PrivateUpdateVitalTests (7 — fixture round-trip, vital ID
      coverage, opcode rejection, truncation)
    - LocalPlayerStateTests rewritten (20 — VitalIdToKind +
      AttributeIdToKind theories, Endurance/Self formula coverage,
      delta semantics, change events)
    - GameEventWiringTests for PlayerDescription dispatch (2 —
      end-to-end populate + spellbook feed)
  Updated:
    - VitalsVMTests rephrased onto the new OnVitalUpdate API.
  Total: 765 → 817 tests passing.

Diagnostics

  ACDREAM_DUMP_VITALS=1 — log every PD attribute extracted,
    every 0x02E7/0x02E9 dispatch.
  ACDREAM_DUMP_OPCODES=1 — log first occurrence of any unhandled
    GameMessage opcode (now correctly placed at end of chain).

Visual verify

  $env:ACDREAM_DEVTOOLS = "1"
  dotnet run --project src\AcDream.App\AcDream.App.csproj -c Debug

  Vitals window shows three bars; HP at 100%, Stam/Mana at ~95%
  (the gap is buff enchantments — filed as #6 with the holtburger
  multiplier+additive aggregator pattern as the reference for the
  fix).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/AcDream.Core.Net/WorldSession.cs

@@ -109,6 +109,23 @@ public sealed class WorldSession : IDisposable
     /// </summary>
     public event Action<HearSpeech.Parsed>? SpeechHeard;
 
+    /// <summary>
+    /// Issue #5: fires when a <c>PrivateUpdateVital (0x02E7)</c> arrives
+    /// — full per-vital snapshot (ranks / start / xp / current).
+    /// Subscribers typically feed
+    /// <see cref="AcDream.Core.Player.LocalPlayerState.OnVitalUpdate"/>.
+    /// Wire layout: see <see cref="PrivateUpdateVital"/>.
+    /// </summary>
+    public event Action<PrivateUpdateVital.ParsedFull>? VitalUpdated;
+
+    /// <summary>
+    /// Issue #5: fires when a <c>PrivateUpdateVitalCurrent (0x02E9)</c>
+    /// arrives — current-only delta (regen ticks, drains).
+    /// Subscribers typically feed
+    /// <see cref="AcDream.Core.Player.LocalPlayerState.OnVitalCurrent"/>.
+    /// </summary>
+    public event Action<PrivateUpdateVital.ParsedCurrent>? VitalCurrentUpdated;
+
     /// <summary>
     /// Phase 6 — server-broadcast PhysicsScript trigger. Fires when the
     /// server sends a <c>PlayScriptId</c> (opcode 0xF754) packet —
@@ -209,6 +226,15 @@ public sealed class WorldSession : IDisposable
     private readonly IPEndPoint _connectEndpoint;
     private readonly FragmentAssembler _assembler = new();
 
+    // Issue #5 diagnostics (env-var-gated):
+    //   ACDREAM_DUMP_OPCODES=1 → log first occurrence of each unhandled opcode
+    //   ACDREAM_DUMP_VITALS=1  → log every PrivateUpdateVital(Current) parse
+    private static readonly bool DumpOpcodesEnabled =
+        Environment.GetEnvironmentVariable("ACDREAM_DUMP_OPCODES") == "1";
+    private static readonly bool DumpVitalsEnabled =
+        Environment.GetEnvironmentVariable("ACDREAM_DUMP_VITALS") == "1";
+    private readonly System.Collections.Generic.HashSet<uint> _seenUnhandledOpcodes = new();
+
     private IsaacRandom? _inboundIsaac;
     private IsaacRandom? _outboundIsaac;
     private ushort _sessionClientId;
@@ -589,6 +615,27 @@ public sealed class WorldSession : IDisposable
                 if (parsed is not null)
                     SpeechHeard?.Invoke(parsed.Value);
             }
+            else if (op == PrivateUpdateVital.FullOpcode)
+            {
+                // Issue #5: full per-vital snapshot from the server. Wire
+                // format per holtburger UpdateVital<false> — see
+                // PrivateUpdateVital.TryParseFull.
+                var parsed = PrivateUpdateVital.TryParseFull(body);
+                if (DumpVitalsEnabled)
+                    Console.WriteLine($"vitals: 0x02E7 PrivateUpdateVital body.len={body.Length} parsed={(parsed is null ? "null" : $"v{parsed.Value.VitalId} ranks={parsed.Value.Ranks} start={parsed.Value.Start} cur={parsed.Value.Current}")}");
+                if (parsed is not null)
+                    VitalUpdated?.Invoke(parsed.Value);
+            }
+            else if (op == PrivateUpdateVital.CurrentOpcode)
+            {
+                // Issue #5: current-only delta (regen ticks / drains).
+                // Wire format per holtburger UpdateVitalCurrent<false>.
+                var parsed = PrivateUpdateVital.TryParseCurrent(body);
+                if (DumpVitalsEnabled)
+                    Console.WriteLine($"vitals: 0x02E9 PrivateUpdateVitalCurrent body.len={body.Length} parsed={(parsed is null ? "null" : $"v{parsed.Value.VitalId} cur={parsed.Value.Current}")}");
+                if (parsed is not null)
+                    VitalCurrentUpdated?.Invoke(parsed.Value);
+            }
             else if (op == GameEventEnvelope.Opcode)
             {
                 // Phase F.1: 0xF7B0 is the GameEvent envelope. Parse the
@@ -645,6 +692,15 @@ public sealed class WorldSession : IDisposable
                 _teleportSequence = sequence;  // track for outbound movement messages
                 TeleportStarted?.Invoke(sequence);
             }
+            else if (DumpOpcodesEnabled)
+            {
+                // ACDREAM_DUMP_OPCODES=1 — emit a one-line trace per
+                // genuinely-unhandled opcode (deduped to first occurrence).
+                // MUST be the LAST else-if so it doesn't intercept handled
+                // opcodes when the env var is set.
+                if (_seenUnhandledOpcodes.Add(op))
+                    Console.WriteLine($"opcodes: unhandled 0x{op:X4} (body.len={body.Length})");
+            }
         }
     }