perf(diag): per-frame history export + checkpoint LOH/cache counters + soak capped mode (2026-07-24 audit review)
An adversarial performance review found our own instruments cannot measure the project's own performance gates: - FrameProfiler aggregated CPU/GPU/alloc/stage samples into ~5-second windows and reset the ring buffers after each report, so route-wide p50/p95/p99 distributions across a whole soak could not be reconstructed after the fact. ACDREAM_FRAME_HISTORY=<path> now opts into a separate per-frame history (one record per frame, ~72 bytes/record, accumulated in memory with zero frame-thread I/O) that a shutdown-only Dispose() writes as CSV. The aggregated [frame-prof] report format and its existing metrics are unchanged. - The canonical checkpoint JSON tracked cache residency (entry/byte counts) but never LOH size/fragmentation, process-wide allocated bytes, or cache hit/miss/eviction traffic — a committed audit JSON showed 65% LOH fragmentation that no tracked instrument recorded, and "does a revisit portal hit or miss the caches" was unanswerable from an artifact alone. WorldLifecycleResourceSnapshot now carries loh_size_bytes/loh_fragmentation_bytes (GCMemoryInfo.GenerationInfo index 3), process_total_allocated_bytes (GC.GetTotalAllocatedBytes), and Interlocked hit/miss/eviction counters for the CPU mesh cache, decoded-texture cache, and the four bounded DAT-object caches (portal/cell/highRes/language, aggregated). - run-connected-r6-soak.ps1 unconditionally forced ACDREAM_UNCAPPED_RENDER=1 with no capped mode, while its sibling lifecycle-gate script correctly gated it behind a switch. Added -Uncapped (default capped, matching the sibling script's pattern), fixed the stationary dwell (12s -> 26s, past the 25s LiveEntityLivenessController deadline the adjacent comment already cited), and now write an env-disclosure.json into the automation artifact directory before every launch listing every ACDREAM_* var the script sets plus -Uncapped, since the prior audit could only see ACDREAM_DUMP_MOVE_TRUTH and nothing else was ever recorded anywhere. Cache counters are wired via the existing composition path (ObjectMeshManager already owns the CPU mesh cache and the mesh extractor directly; content.Dats is threaded into WorldLifecycleResourceSnapshotSource the same way every other composition consumer receives it). The DAT-object cache lives behind IDatReaderWriter, a third-party interface from the DatReaderWriter package that cannot be extended; RuntimeDatCollection (the one production implementation) exposes the aggregate stats directly and a pattern match reads them, degrading to zero for any test double — no new static registry was introduced (GpuMemoryTracker remains the one precedented process-wide static). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 1da2c33c875b41fa383dd79694ee2765f0e21896)
This commit is contained in:
parent
bfc5e47365
commit
7b456b49d6
20 changed files with 477 additions and 9 deletions
|
|
@ -1,3 +1,4 @@
|
|||
using System.Globalization;
|
||||
using AcDream.App.Diagnostics;
|
||||
using Xunit;
|
||||
|
||||
|
|
@ -5,6 +6,35 @@ namespace AcDream.App.Tests;
|
|||
|
||||
public class FrameProfilerReportTests
|
||||
{
|
||||
[Fact]
|
||||
public void WriteHistoryCsv_WritesHeaderThenOneInvariantRowPerRecord()
|
||||
{
|
||||
// 2026-07-24 measurement-tooling review: ACDREAM_FRAME_HISTORY export.
|
||||
// FrameBoundary itself needs a live GL context (GpuFrameTimer), so —
|
||||
// matching FormatReport's precedent above — the CSV writer is a pure
|
||||
// static method tested directly rather than driven through FrameBoundary.
|
||||
var records = new[]
|
||||
{
|
||||
new FrameHistoryRecord(0, 12.5, 1000, 500, 2048, 100, 200, 30, 40),
|
||||
new FrameHistoryRecord(1, 18.75, 1200, -1, -256, 110, 210, 31, 41),
|
||||
};
|
||||
var buffer = new StringWriter(CultureInfo.InvariantCulture);
|
||||
|
||||
FrameProfiler.WriteHistoryCsv(records, buffer);
|
||||
|
||||
string[] lines = buffer.ToString().Split(
|
||||
Environment.NewLine, StringSplitOptions.RemoveEmptyEntries);
|
||||
Assert.Equal(3, lines.Length);
|
||||
Assert.Equal(
|
||||
"frame,timestamp_ms,cpu_us,gpu_us,alloc_bytes,update_us,upload_us,imgui_us,pacing_us",
|
||||
lines[0]);
|
||||
Assert.Equal("0,12.500,1000,500,2048,100,200,30,40", lines[1]);
|
||||
// gpu_us=-1 marks "no GPU sample available"; alloc_bytes can go
|
||||
// negative (documented alloc-channel behavior, matches FrameStatsBuffer.Max).
|
||||
Assert.Equal("1,18.750,1200,-1,-256,110,210,31,41", lines[2]);
|
||||
}
|
||||
|
||||
|
||||
[Fact]
|
||||
public void FormatReport_IsInvariantAndComplete()
|
||||
{
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue