chore(chat): CT-D1/D2 — delete the dead ChatPanel, reconcile the stale digest
Campaign CT Group D, closing the campaign. D1. The ImGui-era ChatPanel has not been constructed anywhere in src/ since Campaign V deleted AcDream.UI.ImGui. Verified that directly rather than on the audit's word, then removed it with its three panel-only test files. Those tests passed, which is exactly the problem: they made the real input surface look better covered than it is. ChatVMCombatTests was KEPT — three of its four tests are genuine ChatVM coverage and only one exercised ChatPanel, so just that method went. Deleting the file would have quietly dropped real coverage along with the dead kind. Three doc comments referencing the deleted type were rewritten rather than left as dangling crefs. D2. docs/ISSUES.md turned out to be ACCURATE already — #358 and #363 are recorded CLOSED there, contrary to the audit's summary. What was stale was the chat DIGEST's "Open" section, which still named four closed issues and claimed Campaign CH's connected gate was owed. Corrected against ISSUES: genuinely open are #359, #360, #361 and #366. The digest also gained a Campaign CT section (the tag mechanism, the MEASURED tag colour, and what shipped) and three DO-NOT-RETRY rows earned this session: - Do not model authored state media with one image per state — the unseen indicator's Normal state carries SIX frames and that IS retail's blink. - Do not read an element's role from a Binary Ninja field NAME — the names in ChatInterface's binder are shifted badly enough to assign a UIElement* into a float field. - Do not assume our side has a gap because retail has a mechanism. That cost this campaign twice in one session: the transcript was claimed unbounded when ChatLog has always capped at 500 entries, and C1's auto-scroll was planned as a port when UiScrollable already did it. CT-C4 is deferred and marked so: pure test coverage over behaviour the audit confirmed already works, changing nothing a user can see. Solution builds clean; full hermetic gate green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
parent
cbab79d70c
commit
7aae5ba939
9 changed files with 30 additions and 844 deletions
|
|
@ -1,6 +1,14 @@
|
|||
# Campaign CT — complete chat parity (system + GUI)
|
||||
|
||||
**Status:** PROPOSED (2026-08-21). Not started.
|
||||
**Status:** Groups A, B, C and D COMPLETE 2026-08-21, each user-gated. Two
|
||||
items deliberately not shipped: CT-B3 (word filtering — dropped by user
|
||||
direction, register row CT-2) and CT-B4 (session chat log — research-blocked).
|
||||
|
||||
**Carried forward:** multi-frame state media. Retail's unseen-text indicator
|
||||
blinks because its `Normal` state authors SIX image frames; our importer keeps
|
||||
one file per state, so nothing authored can animate. The indicator is
|
||||
state-driven and correct today and gains the blink for free once that
|
||||
capability lands. It is the first known customer, not the only one.
|
||||
|
||||
**Goal, set by the user 2026-08-21: complete retail parity for the chat
|
||||
system AND the chat GUI.** Not "fix the green name" — that was the symptom
|
||||
|
|
@ -135,16 +143,21 @@ Nothing is user-visible until A4.
|
|||
grey), gated on `PlayerModule::DisplayTimeStamps()`.
|
||||
- **CT-C4** Input-bar editing parity: clipboard and selection paths
|
||||
(Ctrl+C/X/V, shift-selection) work but are untested; `ToggleMaximize` and the
|
||||
floating-window Close button have zero coverage.
|
||||
floating-window Close button have zero coverage. **DEFERRED** — pure test
|
||||
coverage over behaviour the audit confirmed already works, so it changes
|
||||
nothing a user can see. Worth doing; not worth blocking the campaign on.
|
||||
|
||||
### Group D — hygiene
|
||||
|
||||
- **CT-D1** Delete the dead ImGui-era `ChatPanel` (never constructed since
|
||||
Campaign V deleted `AcDream.UI.ImGui`), and its three test files, which
|
||||
currently make the real input surface look better covered than it is.
|
||||
- **CT-D2** Reconcile the chat digest and `docs/ISSUES.md`: #358, #362, #363,
|
||||
#367, #372, #379, #380, #382 are DONE in code but still listed open. #359,
|
||||
#360, #361, #366 remain genuinely open.
|
||||
- **CT-D1** ~~Delete the dead ImGui-era `ChatPanel`~~ **DONE.** Verified never
|
||||
constructed in `src/`, then removed with its three panel-only test files.
|
||||
`ChatVMCombatTests` was KEPT — three of its four tests are real `ChatVM`
|
||||
coverage; only the one `ChatPanel` render test went.
|
||||
- **CT-D2** ~~Reconcile the chat digest and `docs/ISSUES.md`~~ **DONE.**
|
||||
`docs/ISSUES.md` turned out to be ACCURATE already — #358 and #363 are
|
||||
recorded CLOSED there. Only the chat digest's "Open" section was stale, and
|
||||
it is corrected: genuinely open are #359, #360, #361, #366. The digest also
|
||||
gained a Campaign CT section and three new DO-NOT-RETRY rows.
|
||||
|
||||
## Research still owed before the affected slices
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue