feat(render): Vulkan campaign V11 step 3 — drop the GL packages and shaders

Commit 2 deleted the GL rendering backend's implementations; this step
removes the package references and shader vocabulary they leave behind,
so nothing in the App project still spells Silk.NET.OpenGL.

Silk.NET.OpenGL and Silk.NET.OpenGL.Extensions.ARB are dropped from
AcDream.App.csproj. Chorizite.Core stays — the audit is NOT clean: its
Render.Enums (TextureFormat, BufferUsage) and Lib.BoundingBox types are
used directly and extensively across the Wb texture/mesh pipeline,
independent of the deleted GL IUniformBuffer implementers the package
comment used to cite. The stale comment is corrected in place.

IMeshPipelineDevice.Gl is removed along with the GL? gl parameter
threaded through WbMeshAdapter's four constructors, WorldRenderComposition's
CreateMeshAdapter, and VulkanMeshPipelineDevice's Gl => null
implementation — nothing read any of them once the legacy per-mesh
upload bodies were gone (confirmed by grep: the sole non-doc-comment hit
was a test assertion). While in WbMeshAdapter.Dispose(), found and fixed
a real bug along the way: its teardown still pattern-matched the deleted
GL GpuFrameFlightController to decide whether to wait for submitted work,
which VulkanFrameFlightController replaced at slice V6a without this site
being updated — so the wait had been silently dead on every Vulkan run
since then. Retargeted to VulkanFrameFlightController, which carries the
same WaitForSubmittedWork().

The GL pixel-format vocabulary (Silk.NET.OpenGL.PixelFormat/PixelType) that
WorldTextureArray/TextureFormatExtensions/TextureAtlasManager used for
upload validation is replaced by AcDream.Content's existing Silk.NET-free
UploadPixelFormat/UploadPixelType enums (added at MP1a to keep the bake
tool GL-free); two new members (Rgb, Red, Float) extend that enum with
their GL ABI constants to cover the full vocabulary WorldTextureArray
needs, since MP1a's original set only covered what the extractor itself
emits. ObjectMeshManager's App-boundary cast
`(Silk.NET.OpenGL.PixelFormat?)batch.UploadPixelFormat` becomes a direct
pass-through now that both sides share the type.

GpuBindingModel.StorageTextureTable (the GL-only binding=9 emulation of
the Vulkan texture table) is deleted and StorageBindingCount drops from
10 to 9; the descriptor-set-layout code that builds from that count
(VulkanPipelineLayouts, VulkanFrameBindings) is untouched and just
allocates one fewer always-dummy-seeded, always-unused binding.

Several fully dead GL-only classes came along for the ride, confirmed by
zero construction sites: SilkFramebufferViewportTarget
(NullFramebufferViewportTarget is the sole production
IFramebufferViewportTarget), SilkRenderGlStateReader
(NullRenderGlStateReader.Instance is the sole IRenderGlStateReader),
RuntimeRenderFrameClearPhase (VulkanRenderFrameClearPhase is the sole
IRenderFrameClearPhase, expressing the same atmosphere-clear logic as a
pass load-op instead), and GpuFrameTimer plus FrameProfiler's
GL-owning FrameBoundary(GL) overload and BeginGpuFrame/EndGpuFrame
bracket (RecordGpuSample is the only GPU-timing path any backend uses
now — the ACDREAM_WB_DIAG nested-query exclusion these existed for no
longer applies, since WbDrawDispatcher's own diagnostic GPU sampling
already moved to the device's Vulkan timer pool). GpuFrameFlightController
itself stays (never constructed with a real fence API in production, but
its retirement-ledger/serial-ring logic is backend-neutral and still
covered by its own unit tests) — only its GL-specific parts (the public
GL constructor overload, SilkGpuFenceApi) are deleted, since removing the
whole class would mean restructuring the frozen Slice-8 composition
shape's GpuFrameFlightController? threading, which is out of this
commit's scope. TextureParameters.cs and BufferUsageExtensions.cs
(zero callers each) are deleted outright.

common.glsl is deleted: nothing in the actual Vulkan .spv build reads
it. tools/ShaderCompiler/Program.cs compiles each .vert/.frag pair
directly and tools/ShaderCompiler/VulkanGlslPreamble.cs injects its own
complete self-contained preamble per file; common.glsl's textual
concatenation was exclusively Shader.cs's GL-only mechanism, deleted at
Commit 2. The five shader files that named it in comments
(mesh_modern.vert, particle.vert, particle.frag, sky.frag,
terrain_modern.frag) are corrected to point at VulkanGlslPreamble.cs
instead. mesh.vert/mesh.frag — the pre-N.5 legacy shader pair the
mandatory modern path already made unreachable, with zero C# consumers
and no compiled .spv — are deleted too. Regenerated via
tools/compile-shaders.ps1: 9/9 remaining shader pairs compile
(previously 9/10, with mesh the sole failure — the VulkanShaderManifestTests
doc comment's "nine of ten are not Vulkan-expressible" was already
stale before this commit).

Test fallout: dead-subject test methods/files are deleted rather than
patched (TextRendererFailureSafetyTests.cs, ClipFrameUploadTests.cs,
GpuResourceRetirementTransactionTests.cs's GL queue tests, one
WorldRenderDiagnosticsTests source-order test, one
RenderFrameResourceControllerTests clear-phase-order test); tests whose
subject moved or was renamed are updated in place rather than deleted
(GpuContractTests, VulkanCapabilityGateTests, MeshPipelineDeviceSeamTests'
pinned seven-member surface now reads six, ParticleBindlessInstanceTests'
cross-dialect check now covers the one surviving dialect,
WbMeshAdapterTests' misleadingly-named null-gl test — gpuDevice was
always the parameter that actually threw).

Build: `dotnet build AcDream.slnx -c Release` — 0 warnings, 0 errors,
with the Silk.NET.OpenGL/.Extensions.ARB package references physically
removed from the csproj (not just unreferenced in code).
Tests: full-solution `dotnet test` green across every project.
Zero remaining `using Silk.NET.OpenGL` anywhere in src/ or tests/.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tests/AcDream.App.Tests/Rendering/Wb/MeshPipelineDeviceSeamTests.cs

@@ -7,7 +7,6 @@ using System.Threading;
 using AcDream.Content;
 using Chorizite.Core.Render.Enums;
 using Microsoft.Extensions.Logging.Abstractions;
-using Silk.NET.OpenGL;
 
 namespace AcDream.App.Tests.Rendering.Wb;
 
@@ -16,17 +15,18 @@ namespace AcDream.App.Tests.Rendering.Wb;
 ///
 /// <para>Plan §5.5.10 recorded the blocker as a fact about types — "WbMeshAdapter
 /// owns an OpenGLGraphicsDevice, so it is not constructible on Vulkan" — which is
-/// why <c>NullWbMeshAdapter</c> exists. §5.5.12 item 6 measured how wide the
-/// dependency really is: a GL context, the retirement queue, the instance VBO,
+/// why <c>NullWbMeshAdapter</c> existed. §5.5.12 item 6 measured how wide the
+/// dependency really was: a GL context, the retirement queue, the instance VBO,
 /// and two capability flags. This suite proves the interface at that surface is
 /// load-bearing rather than cosmetic, by building the object graph against a
 /// device that has NO GL context at all.</para>
 ///
-/// <para>It deliberately proves construction and nothing more. The upload bodies
-/// are still raw GL and the world renderers still bind a GL handle table; both
-/// belong to the slice that draws Dereth on Vulkan. What matters here is that
-/// each of those now fails at the site that needs GL, naming why, instead of
-/// throwing a cast before the constructor has run a statement.</para>
+/// <para>It originally proved construction and nothing more, back when the
+/// upload bodies were still raw GL and the world renderers still bound a GL
+/// handle table. Campaign V slice V11 deleted both along with the rest of the
+/// raw-GL arm (and the interface's own <c>Gl</c> member, which nothing read any
+/// more once they were gone) — the arena-build and upload tests below now cover
+/// what those slices only asserted would eventually fail loudly.</para>
 /// </summary>
 public sealed class MeshPipelineDeviceSeamTests
 {
@@ -36,8 +36,6 @@ public sealed class MeshPipelineDeviceSeamTests
         bool modernPath = false)
         : IMeshPipelineDevice
     {
-        public GL? Gl => null;
-
         public IGpuResourceRetirementQueue ResourceRetirement { get; } = retirement;
 
         public uint InstanceVBO => 0;
@@ -120,8 +118,9 @@ public sealed class MeshPipelineDeviceSeamTests
     }
 
     /// <summary>
-    /// The seam's whole value is that it is NARROW — seven members measured out
-    /// of a 760-line class. A later slice that quietly widens it back out would
+    /// The seam's whole value is that it is NARROW — six members measured out
+    /// of a 760-line class (seven until Campaign V slice V11 deleted the unread
+    /// <c>Gl</c> member). A later slice that quietly widens it back out would
     /// re-couple the mesh pipeline to a backend without any other gate noticing,
     /// so the member set is pinned rather than described.
     /// </summary>
@@ -143,7 +142,6 @@ public sealed class MeshPipelineDeviceSeamTests
 
         Assert.Equal(
             [
-                "Gl",
                 "HasBindless",
                 "HasOpenGL43",
                 "HasPendingWork",
@@ -244,7 +242,6 @@ public sealed class MeshPipelineDeviceSeamTests
         using var vulkanDevice =
             new AcDream.App.Rendering.Gpu.Vk.VulkanMeshPipelineDevice(device.Retirement);
 
-        Assert.Null(vulkanDevice.Gl);
         Assert.True(vulkanDevice.HasBindless);
         Assert.True(vulkanDevice.HasOpenGL43);
         Assert.False(vulkanDevice.HasPendingWork);

tests/AcDream.App.Tests/Rendering/Wb/TextureAtlasCapacityTests.cs

@@ -1,6 +1,6 @@
 using AcDream.App.Rendering.Wb;
+using AcDream.Content;
 using Chorizite.Core.Render.Enums;
-using Silk.NET.OpenGL;
 
 namespace AcDream.App.Tests.Rendering.Wb;
 
@@ -33,7 +33,7 @@ public sealed class TextureAtlasCapacityTests
     public void DirectUploadAcceptsExactRgbaPayload()
     {
         RhiWorldTextureArray.ValidateUploadPayload(
-            TextureFormat.RGBA8, 2, 2, 16, PixelFormat.Rgba, PixelType.UnsignedByte);
+            TextureFormat.RGBA8, 2, 2, 16, UploadPixelFormat.Rgba, UploadPixelType.UnsignedByte);
     }
 
     [Theory]
@@ -43,7 +43,7 @@ public sealed class TextureAtlasCapacityTests
     {
         Assert.Throws<ArgumentException>(() =>
             RhiWorldTextureArray.ValidateUploadPayload(
-                TextureFormat.RGBA8, 2, 2, bytes, PixelFormat.Rgba, PixelType.UnsignedByte));
+                TextureFormat.RGBA8, 2, 2, bytes, UploadPixelFormat.Rgba, UploadPixelType.UnsignedByte));
     }
 
     [Fact]
@@ -51,10 +51,10 @@ public sealed class TextureAtlasCapacityTests
     {
         Assert.Throws<ArgumentException>(() =>
             RhiWorldTextureArray.ValidateUploadPayload(
-                TextureFormat.RGBA8, 2, 2, 16, PixelFormat.Rgb, PixelType.UnsignedByte));
+                TextureFormat.RGBA8, 2, 2, 16, UploadPixelFormat.Rgb, UploadPixelType.UnsignedByte));
         Assert.Throws<ArgumentException>(() =>
             RhiWorldTextureArray.ValidateUploadPayload(
-                TextureFormat.RGBA8, 2, 2, 16, PixelFormat.Rgba, PixelType.Float));
+                TextureFormat.RGBA8, 2, 2, 16, UploadPixelFormat.Rgba, UploadPixelType.Float));
     }
 
     [Fact]
@@ -63,7 +63,7 @@ public sealed class TextureAtlasCapacityTests
         int bytes = RhiWorldTextureArray.CalculateExpectedDataSize(TextureFormat.DXT1, 4, 4);
         Assert.Throws<ArgumentException>(() =>
             RhiWorldTextureArray.ValidateUploadPayload(
-                TextureFormat.DXT1, 4, 4, bytes, PixelFormat.Rgba, PixelType.UnsignedByte));
+                TextureFormat.DXT1, 4, 4, bytes, UploadPixelFormat.Rgba, UploadPixelType.UnsignedByte));
     }
 
     [Fact]
@@ -71,6 +71,6 @@ public sealed class TextureAtlasCapacityTests
     {
         Assert.Equal(18, RhiWorldTextureArray.CalculateExpectedDataSize(TextureFormat.RGB8, 3, 2));
         RhiWorldTextureArray.ValidateUploadPayload(
-            TextureFormat.RGB8, 3, 2, 18, PixelFormat.Rgb, PixelType.UnsignedByte);
+            TextureFormat.RGB8, 3, 2, 18, UploadPixelFormat.Rgb, UploadPixelType.UnsignedByte);
     }
 }