erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(ui): tabbed Settings shell — IPanelRenderer tab API + 6 placeholder tabs

Browse source 
Phase L.0 — foundation for the complete retail-style Settings interface
agreed in the 2026-04-26 brainstorm. Splits Phase K's keybind-only F11
panel into a tabbed shell whose first tab wraps the existing keybinds
content unchanged; the other five tabs (Display / Audio / Gameplay /
Chat / Character) render "Coming soon" placeholders so the shape the
user approved is visible immediately and gets filled in over the L.x
sub-phases (Display first per Easy-wins build order).

Why a tab API extension: retail had distinct Options UIs
(gmGameplayOptionsUI / gmChatOptionsUI / gmCharacterSettingsUI per the
PDB at acclient_2013_pseudo_c.txt:170739+) and the existing
IPanelRenderer only exposed CollapsingHeader. ImGui maps
BeginTabBar / BeginTabItem / EndTabItem / EndTabBar 1:1, so the new
primitives stay backend-friendly — the future D.2b custom retail-look
backend implements them via the retail tab UIs without panel changes.

Save / Cancel / Reset-all stay above the tab bar so they remain global
across all tabs (Phase K's UX preserved). FakePanelRenderer grows
matching tab calls + an ActiveTabLabel knob so tests can target a
specific tab's content; default behavior treats the first tab item
seen as active so existing tests keep passing without changes.

5 new SettingsPanelTests assertions: tab bar opens once, six expected
tab labels emitted in order, Keybinds-tab section headers only render
when active, placeholders show "Coming soon" text on inactive-content
tabs, and Save/Cancel buttons render BEFORE the tab bar (regression
guard against accidentally moving them inside a tab item).

dotnet build green (0 warnings); dotnet test 1,227 / 1,227 green
(243 Core.Net + 311 UI.Abstractions + 673 Core).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Erik 2026-04-26 17:39:36 +02:00
parent 5145938d06
commit 7665cdf642
5 changed files with 235 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

33
tests/AcDream.UI.Abstractions.Tests/FakePanelRenderer.cs
View file

@ -198,4 +198,37 @@ internal sealed class FakePanelRenderer : IPanelRenderer
Calls.Add(("MenuItem", new object?[] { label, shortcut }));
return MenuItemReturns;
}
// -- Tab bar -----------------------------------------------------------
/// <summary>Pre-set return for <see cref="BeginTabBar"/>.</summary>
public bool TabBarReturns { get; set; } = true;
/// <summary>The label of the tab the next <see cref="BeginTabItem"/>
/// call should report as "selected" (return true). All other tab
/// items return false. Defaults to null = the FIRST tab item rendered
/// is the selected one.</summary>
public string? ActiveTabLabel { get; set; }
private string? _firstTabSeen;
public bool BeginTabBar(string id)
{
Calls.Add(("BeginTabBar", new object?[] { id }));
_firstTabSeen = null;
return TabBarReturns;
}
public void EndTabBar() => Calls.Add(("EndTabBar", Array.Empty<object?>()));
public bool BeginTabItem(string label)
{
Calls.Add(("BeginTabItem", new object?[] { label }));
_firstTabSeen ??= label;
return ActiveTabLabel is null
? string.Equals(label, _firstTabSeen, StringComparison.Ordinal)
: string.Equals(label, ActiveTabLabel, StringComparison.Ordinal);
}
public void EndTabItem() => Calls.Add(("EndTabItem", Array.Empty<object?>()));
}