feat(core): D.5.3/B.2 — ShortcutStore + AddShortcut/RemoveShortcut wire + senders

ShortcutStore lands in AcDream.Core.Net.Items (not AcDream.Core.Items) because
it depends on PlayerDescriptionParser.ShortcutEntry; placing it in AcDream.Core
would create a circular dependency (Core.Net already references Core). The test
lives in AcDream.Core.Tests which gets Core.Net transitively via App.

BuildAddShortcut signature corrected from the old (seq, slotIndex, objectType,
targetId) 4×u32 layout to the retail ShortCutData wire format confirmed in the
action-bar deep-dive: Index(u32), ObjectId(u32), SpellId(u16), Layer(u16).
The old BuildAddShortcut_ThreeFields test is replaced by two new tests that
verify both item and spell shortcut packing.

WorldSession gains SendAddShortcut / SendRemoveShortcut following the
SendChangeCombatMode sender pattern.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tests/AcDream.Core.Net.Tests/Messages/InventoryActionsTests.cs

@@ -74,18 +74,25 @@ public sealed class InventoryActionsTests
     }
 
     [Fact]
-    public void BuildAddShortcut_ThreeFields()
+    public void BuildAddShortcut_ItemShortcut_FieldLayout()
     {
-        byte[] body = InventoryActions.BuildAddShortcut(
-            seq: 1, slotIndex: 0, objectType: 1, targetId: 0x3E1);
+        // ShortCutData = Index(u32), ObjectId(u32), SpellId(u16), Layer(u16). Item → spell/layer 0.
+        byte[] body = InventoryActions.BuildAddShortcut(seq: 1, index: 0, objectGuid: 0x3E1, spellId: 0, layer: 0);
+        Assert.Equal(24, body.Length);
         Assert.Equal(InventoryActions.AddShortcutOpcode,
-            BinaryPrimitives.ReadUInt32LittleEndian(body.AsSpan(8)));
-        Assert.Equal(0u,
-            BinaryPrimitives.ReadUInt32LittleEndian(body.AsSpan(12)));
-        Assert.Equal(1u,
-            BinaryPrimitives.ReadUInt32LittleEndian(body.AsSpan(16)));
-        Assert.Equal(0x3E1u,
-            BinaryPrimitives.ReadUInt32LittleEndian(body.AsSpan(20)));
+            System.Buffers.Binary.BinaryPrimitives.ReadUInt32LittleEndian(body.AsSpan(8)));
+        Assert.Equal(0u,      System.Buffers.Binary.BinaryPrimitives.ReadUInt32LittleEndian(body.AsSpan(12))); // index
+        Assert.Equal(0x3E1u,  System.Buffers.Binary.BinaryPrimitives.ReadUInt32LittleEndian(body.AsSpan(16))); // objectGuid
+        Assert.Equal((ushort)0, System.Buffers.Binary.BinaryPrimitives.ReadUInt16LittleEndian(body.AsSpan(20))); // spellId
+        Assert.Equal((ushort)0, System.Buffers.Binary.BinaryPrimitives.ReadUInt16LittleEndian(body.AsSpan(22))); // layer
+    }
+
+    [Fact]
+    public void BuildAddShortcut_SpellShortcut_PacksSpellAndLayerAsU16s()
+    {
+        byte[] body = InventoryActions.BuildAddShortcut(seq: 1, index: 2, objectGuid: 0, spellId: 0x1234, layer: 3);
+        Assert.Equal(0x1234, System.Buffers.Binary.BinaryPrimitives.ReadUInt16LittleEndian(body.AsSpan(20)));
+        Assert.Equal(3,      System.Buffers.Binary.BinaryPrimitives.ReadUInt16LittleEndian(body.AsSpan(22)));
     }
 
     [Fact]

tests/AcDream.Core.Tests/Items/ShortcutStoreTests.cs

@@ -0,0 +1,42 @@
+using System.Collections.Generic;
+using AcDream.Core.Net.Items;
+using AcDream.Core.Net.Messages;
+using Xunit;
+
+namespace AcDream.Core.Tests.Items;
+
+public class ShortcutStoreTests
+{
+    [Fact]
+    public void Load_mapsIndexToObjId_skipsEmptyAndOutOfRange()
+    {
+        var store = new ShortcutStore();
+        var entries = new List<PlayerDescriptionParser.ShortcutEntry>
+        {
+            new(Index: 0,  ObjectGuid: 0x5001u, SpellId: 0, Layer: 0),
+            new(Index: 3,  ObjectGuid: 0x5002u, SpellId: 0, Layer: 0),
+            new(Index: 5,  ObjectGuid: 0u,      SpellId: 7, Layer: 1),   // spell-only → skipped (item store)
+            new(Index: 99, ObjectGuid: 0x5003u, SpellId: 0, Layer: 0),   // out of range → skipped
+        };
+        store.Load(entries);
+        Assert.Equal(0x5001u, store.Get(0));
+        Assert.Equal(0x5002u, store.Get(3));
+        Assert.Equal(0u, store.Get(5));
+        Assert.True(store.IsEmpty(1));
+    }
+
+    [Fact]
+    public void SetRemoveGet_roundtrip_andBoundsSafe()
+    {
+        var store = new ShortcutStore();
+        store.Set(4, 0xABCDu);
+        Assert.Equal(0xABCDu, store.Get(4));
+        Assert.False(store.IsEmpty(4));
+        store.Remove(4);
+        Assert.True(store.IsEmpty(4));
+        Assert.Equal(0u, store.Get(-1));
+        Assert.Equal(0u, store.Get(18));
+        store.Set(18, 1u);     // no-op, no throw
+        store.Remove(-1);      // no-op, no throw
+    }
+}