feat(physics): C4 route 4b-3 — remote teleport + cell-less through the canonical placement
Flips the last remote classification (SetPosition: teleport-advanced and
cell-less) onto 4b-1's RuntimeRemotePlacementDriveController, runs retail's
teleport_hook before the placement, and deletes the legacy remote-teleport
machinery. Contract: docs/research/2026-08-04-c4-route-4b-3-contract.md.
Retail: MoveOrTeleport @0x00516330's branch @0x00516386 -> teleport_hook
@0x005163EF -> SetFlags(0x1012) @0x00516414 -> SetPosition @0x00516420 ->
return 1 @0x00516438. The hook @0x00514ED0 runs BEFORE the placement and
regardless of its outcome. Retail places this branch unconditionally, at any
distance and any contact state (arg4 is read only @0x0051638E, after the
branch) — which is what retires AP-137's cell-less enqueue-vs-place delta.
D1 — the classifier's cell-less input is now the PRE-merge committed cell.
Retail's predicate is `this_1->cell == 0`, the BODY's own cell at
MoveOrTeleport entry (this_1 is assigned from this @0x00516334). acdream fed
the POST-merge canonical.FullCellId, which RefreshSnapshot ->
RefreshDerivedState -> SetFullCell has already stamped with the accepted wire
cell; a zero wire cell fails validation into RejectedData first. The shipped
remote cell-less predicate was therefore dead code, not merely different from
remotePlacementRequired. Threaded via a builder overload; route 1's overload
is untouched. The graphical !IsSpatiallyVisible arm of
projectionRequiresTeleportHook is deleted — a presentation predicate with no
retail analogue that fired the teleport machinery on a routine hot path.
Deleted: RemoteTeleportController (605), RemoteTeleportPlacement (85),
RemoteShadowPlacementSynchronizer (49), their 1,709 lines of tests, the
remotePlacementRequired predicate, the TeleportHookRequired plumbing, the
legacy pre-operation ConstrainTo fallback, and the player arm's legacy
!IsGrounded fallback. Net -2,030 lines.
Structural fix (two independent Opus reviews, round 1 FAIL/FAIL): three of the
four MAJORs were one defect — OnPosition carried two parallel inline copies of
the routing tail (player-guid, NPC-guid) that had drifted. Extracted
RunRemoteArmTail (3 call sites) and ApplyWireAirborneLeftoverBookkeeping (2),
both branches now share one implementation.
A1 ToConstraintArm mapped AirborneSnap -> AirborneNoOperation, so the NPC
arm armed ConstrainTo ZERO times for an out-of-contact wire-grounded
creature — a regression this slice introduced while closing a
structurally identical hole. Now maps to NearInterpolate; switch made
total with a throwing default proven unreachable.
R1 D2's write-nothing shape existed on the player arm only; NPC packets
fell through and wrote the body. Retail makes no player/NPC distinction.
R2 report_collision_end(this,1) @0x00514F31 was bound to
ShadowObjects.Suspend, a port of a DIFFERENT retail function
(remove_shadows_from_cells) that teleport_hook never calls. Now routes
to RuntimeCollisionReportingState.LeaveWorld, which wraps the private
ForceEnd in an admission-blocking transaction so a DoCollisionEnd
callback cannot recreate the contact table.
R3/A2 A teleported NPC synthesized ServerVelocity from the teleport distance
(~1,000+ m/s) and planned a run cycle from it. Both the install and
RemoteServerControlledVelocityCycle.Apply now gate on !isTeleportRoute.
BISECT HAZARD — A1's fix is correct only BECAUSE R1 landed. AirborneSnap is
reachable wire-airborne on the NPC arm only while D2's shape is missing there.
Reverting R1 alone silently inverts A1 into the opposite divergence: arming
where retail returns 0. Revert both or neither.
Also in the velocity hunk: the NPC block's two !IsPlayerGuid(update.Guid)
guards were dropped when it was wrapped in `if (!isTeleportRoute)`. Safe — all
five exit paths of the enclosing IsPlayerGuid block return, so the predicate is
unconditionally false below it — but it was unremarked by both reviews.
Register: AP-137 REWRITTEN (not deleted) to the surviving acdream-only
divergences — null classification during the login window and Rejected*
through UnroutedCatchUp keep a row. AD-42's RemoteTeleportController citation
retired; AP-136/AP-138 writer lists corrected to the two surviving non-Position
rebucket writers; AP-138 gains the teleport arm as a second producer of the
visible-without-collision residual (retirement path remains #309). AP-135 is
untouched and its two airborne bookkeeping writes are preserved on both arms.
AP-131 does not retire; #276 does not close.
Proof obligation 1: ParkCollisionResidents' overlap throw stays unreachable —
the teleport arm adds packets to the same TryBeginExclusiveAuthoredPlacement
one-operation-per-key machinery the far arm uses, opens no new operation shape,
and every DeferredCell outcome cancels synchronously with
restoreCancelledPark: true. The guarded property remains
HasOldPrefixPlacementDebt's stall, not a throw (4b-1's B2 caveat stands).
Correction to an earlier claim: LiveEntityPresentationController's
_activePlacementOwners was NOT write-never at HEAD —
remotePlacementRequired -> BeginPlacement -> Begin -> BeginAuthoritativePlacement
was a live writer chain. It becomes write-never BECAUSE this slice deletes that
chain, which is why deleting the dead half is behaviour-preserving.
Probe: ACDREAM_PROBE_REMOTE_TELEPORT=1 emits one [remote-teleport] line per
routed arm (guid, cause, hook-ran, placement status). TEMPORARY, strip with the
probe family.
Carried, disclosed not fixed: no dedicated bidirectional collision-partner test
for R2 (the wiring, not LeaveWorld itself, is what lacks coverage); the
stress test's teleport step drives hand-written field assignments rather than
the canonical arm; the per-packet runTeleportHook closure allocation (network
path, not the resolve path Slice I's 0 B discipline governs — file before
route 5 adds a fourth call site). B2: IRuntimeCollisionReportObserver has zero
production implementations, so retail's bidirectional DoCollisionEnd half still
reaches no gameplay consumer — this fix closes the wrong-function binding, not
that nobody listens.
Complete Release suite MEASURED at 11,013 passed / 4 skipped / 0 failed
(baseline 11,027/4/0; net -14 = ~33 deleted test cases against ~19 added).
Neither known flake fired (#302 PortalProjectionTests GC-allocation, #308
NakEmissionTests wall-clock).
STILL OWED: the two-client connected gate, which MUST use an NPC/creature
teleport target. Both round-1 MAJORs lived on the NPC arm and the velocity
cycle early-returns for 0x50xxxxxx guids, so a player target structurally
cannot observe A1, A2, or R3.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Erik
parent
3e002993dd
commit
6dc7ba51ee
53 changed files with 2980 additions and 3372 deletions
|
|
@ -225,7 +225,6 @@ public sealed class LiveSessionResetPlanTests
|
|||
},
|
||||
SessionIdentityPresentation = _ =>
|
||||
calls.Add("session identity presentation"),
|
||||
RemoteTeleport = Stage("remote teleport"),
|
||||
NetworkEffects = Stage("network effects"),
|
||||
AnimationHookFrames = Stage("animation hook frames"),
|
||||
LivePresentation = Stage("live presentation"),
|
||||
|
|
@ -306,7 +305,6 @@ public sealed class LiveSessionResetPlanTests
|
|||
"live liveness",
|
||||
"runtime generation",
|
||||
"session identity presentation",
|
||||
"remote teleport",
|
||||
"network effects",
|
||||
"animation hook frames",
|
||||
"live presentation",
|
||||
|
|
|
|||
|
|
@ -56,7 +56,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 200f),
|
||||
DecoyWirePose,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.FarSnapPlacement,
|
||||
|
|
@ -105,7 +106,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 200f),
|
||||
DecoyWirePose,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.False(remote.Interp.IsActive);
|
||||
fixture.DrainPlacementFifo();
|
||||
|
|
@ -146,7 +148,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 200f),
|
||||
DecoyWirePose,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.FarSnapPlacement,
|
||||
|
|
@ -214,7 +217,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 200f),
|
||||
DecoyWirePose,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.Refused,
|
||||
|
|
@ -254,7 +258,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
route: null,
|
||||
target,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.UnroutedCatchUp,
|
||||
|
|
@ -294,7 +299,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
route: null,
|
||||
target,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.UnroutedCatchUp,
|
||||
|
|
@ -327,7 +333,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
rejected,
|
||||
target,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.UnroutedCatchUp,
|
||||
|
|
@ -337,13 +344,16 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
}
|
||||
|
||||
/// <summary>
|
||||
/// Retail's cell-less body takes <c>this_1->cell == 0</c> @0x00516386
|
||||
/// (<c>SetPosition</c>), never the far branch — and route 4b-3, not this
|
||||
/// slice, owns it. Claiming it here would be exactly route 4a's
|
||||
/// "'not Interpolate' is not 'far'" finding one level up.
|
||||
/// C4 route 4b-3 (D1/D5): retail's cell-less body takes
|
||||
/// <c>this_1->cell == 0</c> @0x00516386 — the SAME teleport branch as a
|
||||
/// fresh TELEPORT_TS — never the far/near/leftover arms. The hook runs
|
||||
/// (before the placement, per D3) and the body ends at the canonical
|
||||
/// RESOLVED destination, not at the caller's separately-supplied
|
||||
/// <paramref name="target"/> wire pose (the decoy discriminates the same
|
||||
/// way the far-snap test above does).
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void CellLessRemote_TakesTheUnroutedCatchUp_AndNeverThePlacementOwner()
|
||||
public void CellLessRemote_TakesTheTeleportArm_RunsTheHookAndPlacesCanonically()
|
||||
{
|
||||
using var fixture = new RemotePlacementDriveFixture();
|
||||
fixture.PublishDestinationCollision();
|
||||
|
|
@ -360,6 +370,7 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
cellLess.Disposition);
|
||||
|
||||
int hookCalls = 0;
|
||||
LiveEntityNetworkUpdateController.RemoteContactRouting routing =
|
||||
LiveEntityNetworkUpdateController.ApplyRemoteContactRouting(
|
||||
fixture.Drive,
|
||||
|
|
@ -368,12 +379,27 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
cellLess,
|
||||
target,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () =>
|
||||
{
|
||||
hookCalls++;
|
||||
return true;
|
||||
});
|
||||
|
||||
Assert.Equal(1, hookCalls);
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.UnroutedCatchUp,
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.TeleportPlacement,
|
||||
routing.Arm);
|
||||
Assert.Equal(target, body.Position);
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.Committed,
|
||||
routing.Placement);
|
||||
Assert.Equal(
|
||||
Destination + RemotePlacementDriveFixture.DestinationWorldOffset,
|
||||
body.Position);
|
||||
Assert.NotEqual(target, body.Position);
|
||||
Assert.Equal(RemotePlacementDriveFixture.DestinationCell, record.FullCellId);
|
||||
|
||||
fixture.DrainPlacementFifo();
|
||||
Assert.Equal(0, fixture.LiveOperationCount);
|
||||
Assert.Equal(0, fixture.RemotePlacementLedger);
|
||||
}
|
||||
|
|
@ -409,7 +435,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 200f),
|
||||
target,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.AirborneSnap,
|
||||
|
|
@ -418,6 +445,77 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Assert.Equal(0, fixture.LiveOperationCount);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// C4 route 4b-3, test-plan item 6 / contract D5: the teleport/cell-less
|
||||
/// classification is decided BEFORE <c>ApplyRemoteContactRouting</c> ever
|
||||
/// reads <c>remote.Body.InContact</c> — retail's <c>MoveOrTeleport</c>
|
||||
/// tests <c>this_1->cell == 0 || newer_event(TELEPORT_TS)</c>
|
||||
/// @0x00516375-@0x00516386 strictly before the wire-contact branch at
|
||||
/// @0x0051638E. A mid-arc body's teleport packet must therefore still
|
||||
/// place canonically — the OPPOSITE outcome of
|
||||
/// <see cref="AirborneBody_OutranksTheFarSnap"/> above, which proves the
|
||||
/// far arm defers to airborne precedence while this proves the teleport
|
||||
/// arm does not. Fails against a broken ordering that lets the airborne
|
||||
/// carve-out claim the packet first: <paramref name="body"/> would then
|
||||
/// sit at the raw <c>target</c> wire pose the airborne branch writes,
|
||||
/// never resolved through the canonical destination.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void AirborneBody_TeleportOutranksAirborneSnap()
|
||||
{
|
||||
using var fixture = new RemotePlacementDriveFixture();
|
||||
fixture.PublishDestinationCollision();
|
||||
fixture.AllowDestination();
|
||||
(RuntimeEntityRecord record, RemoteMotion remote, PhysicsBody body) =
|
||||
fixture.AddRemote(0x7000400Cu, Destination);
|
||||
// Same mid-arc state as AirborneBody_OutranksTheFarSnap: no wire
|
||||
// contact, free flight in both the old and new terms of the gate.
|
||||
remote.Airborne = true;
|
||||
remote.Body.TransientState = TransientStateFlags.Active;
|
||||
var target = new Vector3(60f, 10f, 7f);
|
||||
|
||||
RuntimeAuthoritativePositionRoute cellLess = Classify(
|
||||
hasContact: false,
|
||||
playerDistance: 200f,
|
||||
committedCellId: 0u);
|
||||
Assert.Equal(
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
cellLess.Disposition);
|
||||
|
||||
int hookCalls = 0;
|
||||
LiveEntityNetworkUpdateController.RemoteContactRouting routing =
|
||||
LiveEntityNetworkUpdateController.ApplyRemoteContactRouting(
|
||||
fixture.Drive,
|
||||
record,
|
||||
remote,
|
||||
cellLess,
|
||||
target,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () =>
|
||||
{
|
||||
hookCalls++;
|
||||
return true;
|
||||
});
|
||||
|
||||
Assert.Equal(1, hookCalls);
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.TeleportPlacement,
|
||||
routing.Arm);
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.Committed,
|
||||
routing.Placement);
|
||||
Assert.Equal(
|
||||
Destination + RemotePlacementDriveFixture.DestinationWorldOffset,
|
||||
body.Position);
|
||||
Assert.NotEqual(target, body.Position);
|
||||
Assert.Equal(RemotePlacementDriveFixture.DestinationCell, record.FullCellId);
|
||||
|
||||
fixture.DrainPlacementFifo();
|
||||
Assert.Equal(0, fixture.LiveOperationCount);
|
||||
Assert.Equal(0, fixture.RemotePlacementLedger);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Per-entity independence across the two arms in the same tick: one
|
||||
/// remote's committed placement must not touch another's body or leak
|
||||
|
|
@ -444,7 +542,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 200f),
|
||||
DecoyWirePose,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true).Arm);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true).Arm);
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm
|
||||
.SteadyStateInterpolate,
|
||||
|
|
@ -455,7 +554,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 10f),
|
||||
nearBefore + new Vector3(0.5f, 0f, 0f),
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true).Arm);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true).Arm);
|
||||
|
||||
Assert.Equal(
|
||||
Destination + RemotePlacementDriveFixture.DestinationWorldOffset,
|
||||
|
|
@ -497,7 +597,8 @@ public sealed class LiveEntityNetworkRemoteFarSnapIntegrationTests
|
|||
airborne,
|
||||
new Vector3(60f, 10f, 7f),
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true));
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true));
|
||||
|
||||
Assert.Equal(before, body.Position);
|
||||
Assert.False(remote.Interp.IsActive);
|
||||
|
|
|
|||
|
|
@ -177,7 +177,8 @@ public sealed class LiveEntityNetworkRemoteSteadyStateIntegrationTests
|
|||
route,
|
||||
landing,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.AirborneSnap,
|
||||
|
|
@ -207,7 +208,8 @@ public sealed class LiveEntityNetworkRemoteSteadyStateIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 10f),
|
||||
target,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm
|
||||
|
|
@ -263,7 +265,8 @@ public sealed class LiveEntityNetworkRemoteSteadyStateIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 10f),
|
||||
before + new Vector3(0.5f, 0f, 0f),
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm
|
||||
|
|
@ -302,7 +305,8 @@ public sealed class LiveEntityNetworkRemoteSteadyStateIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 10f),
|
||||
landing,
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm.AirborneSnap,
|
||||
|
|
@ -338,7 +342,8 @@ public sealed class LiveEntityNetworkRemoteSteadyStateIntegrationTests
|
|||
Classify(hasContact: true, playerDistance: 10f),
|
||||
before + new Vector3(0.5f, 0f, 0f),
|
||||
Quaternion.Identity,
|
||||
willBeDrTicked: true);
|
||||
willBeDrTicked: true,
|
||||
runTeleportHook: () => true);
|
||||
|
||||
Assert.Equal(
|
||||
LiveEntityNetworkUpdateController.RemoteContactArm
|
||||
|
|
|
|||
File diff suppressed because it is too large
Load diff
File diff suppressed because it is too large
Load diff
|
|
@ -1,194 +0,0 @@
|
|||
using System.Numerics;
|
||||
using AcDream.App.Physics;
|
||||
using AcDream.Core.Physics;
|
||||
using Xunit;
|
||||
|
||||
namespace AcDream.App.Tests.Physics;
|
||||
|
||||
public sealed class RemoteTeleportPlacementTests
|
||||
{
|
||||
[Fact]
|
||||
public void Apply_HardSnapsFullFrameAndPhysicsClock()
|
||||
{
|
||||
var body = new PhysicsBody
|
||||
{
|
||||
Orientation = Quaternion.Identity,
|
||||
LastUpdateTime = 2.0,
|
||||
};
|
||||
body.SnapToCell(
|
||||
0x01010001u,
|
||||
new Vector3(3f, 4f, 5f),
|
||||
new Vector3(3f, 4f, 5f));
|
||||
var remote = new AcDream.Runtime.Physics.RemoteMotion(body);
|
||||
Quaternion orientation = Quaternion.CreateFromAxisAngle(Vector3.UnitZ, 0.75f);
|
||||
|
||||
RemoteTeleportPlacement.Apply(
|
||||
remote,
|
||||
body,
|
||||
new ResolveResult(
|
||||
new Vector3(210f, 220f, 12f),
|
||||
0x02020123u,
|
||||
IsOnGround: false),
|
||||
new Vector3(18f, 28f, 12f),
|
||||
orientation,
|
||||
17.5,
|
||||
previousContact: body.InContact,
|
||||
previousOnWalkable: body.OnWalkable);
|
||||
|
||||
Assert.Equal(new Vector3(210f, 220f, 12f), body.Position);
|
||||
Assert.Equal(0x02020123u, body.CellPosition.ObjCellId);
|
||||
Assert.Equal(new Vector3(18f, 28f, 12f), body.CellPosition.Frame.Origin);
|
||||
Assert.Equal(orientation, body.Orientation);
|
||||
Assert.Equal(17.5, body.LastUpdateTime);
|
||||
Assert.True(body.InWorld);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Apply_InstallsPlacementDerivedContactAndSynchronizesAirborneState()
|
||||
{
|
||||
var velocity = new Vector3(1f, 2f, 3f);
|
||||
var body = new PhysicsBody
|
||||
{
|
||||
Velocity = velocity,
|
||||
TransientState = TransientStateFlags.Active,
|
||||
State = PhysicsStateFlags.Gravity | PhysicsStateFlags.ReportCollisions,
|
||||
};
|
||||
var contactPlane = new Plane(Vector3.UnitZ, 0f);
|
||||
var remote = new AcDream.Runtime.Physics.RemoteMotion(body)
|
||||
{
|
||||
Airborne = true,
|
||||
};
|
||||
|
||||
RemoteTeleportPlacement.Apply(
|
||||
remote,
|
||||
body,
|
||||
new ResolveResult(
|
||||
new Vector3(200f, 200f, 50f),
|
||||
0x02020001u,
|
||||
IsOnGround: true,
|
||||
InContact: true,
|
||||
OnWalkable: true,
|
||||
ContactPlane: contactPlane,
|
||||
ContactPlaneCellId: 0x02020001u),
|
||||
new Vector3(8f, 8f, 50f),
|
||||
Quaternion.Identity,
|
||||
9.0,
|
||||
previousContact: false,
|
||||
previousOnWalkable: false);
|
||||
|
||||
Assert.Equal(Vector3.Zero, body.Velocity);
|
||||
Assert.True(body.InContact);
|
||||
Assert.True(body.OnWalkable);
|
||||
Assert.True(body.ContactPlaneValid);
|
||||
Assert.Equal(contactPlane, body.ContactPlane);
|
||||
Assert.False(remote.Airborne);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Apply_PendingHydrationUsesPreservedSourceFlagsBeforeCollisionResponse()
|
||||
{
|
||||
var originalVelocity = new Vector3(-3f, 0f, 0f);
|
||||
var body = new PhysicsBody
|
||||
{
|
||||
Velocity = originalVelocity,
|
||||
State = PhysicsStateFlags.Gravity | PhysicsStateFlags.ReportCollisions,
|
||||
};
|
||||
// ParkPending deliberately clears these flags while the destination
|
||||
// landblock is absent. SetPositionInternal must still receive the
|
||||
// grounded source edge captured before parking.
|
||||
body.TransientState &= ~(TransientStateFlags.Contact | TransientStateFlags.OnWalkable);
|
||||
var remote = new AcDream.Runtime.Physics.RemoteMotion(body)
|
||||
{
|
||||
Airborne = true,
|
||||
};
|
||||
|
||||
RemoteTeleportPlacement.Apply(
|
||||
remote,
|
||||
body,
|
||||
new ResolveResult(
|
||||
new Vector3(200f, 200f, 50f),
|
||||
0x02020001u,
|
||||
IsOnGround: true,
|
||||
CollisionNormalValid: true,
|
||||
CollisionNormal: Vector3.UnitX,
|
||||
InContact: true,
|
||||
OnWalkable: true,
|
||||
ContactPlane: new Plane(Vector3.UnitZ, 0f),
|
||||
ContactPlaneCellId: 0x02020001u),
|
||||
new Vector3(8f, 8f, 50f),
|
||||
Quaternion.Identity,
|
||||
9.0,
|
||||
previousContact: true,
|
||||
previousOnWalkable: true);
|
||||
|
||||
// Staying on walkable ground suppresses reflection. If the parked
|
||||
// false/false flags were used, the -X velocity would reflect to +X.
|
||||
Assert.Equal(originalVelocity, body.Velocity);
|
||||
Assert.True(body.OnWalkable);
|
||||
Assert.False(remote.Airborne);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Apply_PendingGroundToSteepContact_RestoresSourceWalkabilityForFirstAcceleration()
|
||||
{
|
||||
var body = new PhysicsBody
|
||||
{
|
||||
Omega = new Vector3(0f, 0f, 3f),
|
||||
State = PhysicsStateFlags.Gravity | PhysicsStateFlags.ReportCollisions,
|
||||
};
|
||||
// The unloaded-destination parking frame cleared both bits. Retail
|
||||
// restores the captured source OnWalkable bit through the first
|
||||
// calc_acceleration, which clears grounded angular drift, before
|
||||
// set_on_walkable installs the steep destination's false value.
|
||||
body.TransientState &= ~(TransientStateFlags.Contact | TransientStateFlags.OnWalkable);
|
||||
var remote = new AcDream.Runtime.Physics.RemoteMotion(body);
|
||||
|
||||
RemoteTeleportPlacement.Apply(
|
||||
remote,
|
||||
body,
|
||||
new ResolveResult(
|
||||
new Vector3(200f, 200f, 50f),
|
||||
0x02020001u,
|
||||
IsOnGround: false,
|
||||
InContact: true,
|
||||
OnWalkable: false,
|
||||
ContactPlane: new Plane(Vector3.Normalize(new Vector3(1f, 0f, 0.2f)), 0f),
|
||||
ContactPlaneCellId: 0x02020001u),
|
||||
new Vector3(8f, 8f, 50f),
|
||||
Quaternion.Identity,
|
||||
9.0,
|
||||
previousContact: true,
|
||||
previousOnWalkable: true);
|
||||
|
||||
Assert.Equal(Vector3.Zero, body.Omega);
|
||||
Assert.True(body.InContact);
|
||||
Assert.False(body.OnWalkable);
|
||||
Assert.True(remote.Airborne);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Apply_RejectsMalformedPlacementWithoutMutatingBody()
|
||||
{
|
||||
var original = new Vector3(7f, 8f, 9f);
|
||||
var body = new PhysicsBody { Position = original };
|
||||
var remote = new AcDream.Runtime.Physics.RemoteMotion(body);
|
||||
|
||||
Assert.Throws<ArgumentOutOfRangeException>(() =>
|
||||
RemoteTeleportPlacement.Apply(
|
||||
remote,
|
||||
body,
|
||||
new ResolveResult(
|
||||
new Vector3(float.NaN, 0f, 0f),
|
||||
0,
|
||||
IsOnGround: false,
|
||||
Ok: false),
|
||||
Vector3.Zero,
|
||||
Quaternion.Identity,
|
||||
double.NaN,
|
||||
previousContact: false,
|
||||
previousOnWalkable: false));
|
||||
|
||||
Assert.Equal(original, body.Position);
|
||||
Assert.Equal(0u, body.CellPosition.ObjCellId);
|
||||
}
|
||||
}
|
||||
|
|
@ -850,7 +850,6 @@ public sealed class CurrentGameRuntimeAdapterTests
|
|||
LiveLiveness = noop,
|
||||
RuntimeGeneration = _ => { },
|
||||
SessionIdentityPresentation = _ => { },
|
||||
RemoteTeleport = noop,
|
||||
NetworkEffects = noop,
|
||||
AnimationHookFrames = noop,
|
||||
LivePresentation = noop,
|
||||
|
|
|
|||
|
|
@ -263,12 +263,8 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
Assert.Equal(1, fixture.Presentation.DeferredShadowRestoreCount);
|
||||
|
||||
fixture.BeginDeferredTeleport();
|
||||
Assert.Equal(1, fixture.Teleport.PendingPlacementCount);
|
||||
Assert.Equal(1, fixture.Presentation.ActivePlacementCount);
|
||||
|
||||
fixture.LoadDestination();
|
||||
Assert.Equal(0, fixture.Teleport.PendingPlacementCount);
|
||||
Assert.Equal(0, fixture.Presentation.ActivePlacementCount);
|
||||
Assert.Equal(1, fixture.Presentation.DeferredShadowRestoreCount);
|
||||
|
||||
fixture.ApplyVisible();
|
||||
|
|
@ -293,10 +289,8 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
Assert.Equal(0, fixture.ParticleSink.ActiveBindingCount);
|
||||
Assert.Equal(0, fixture.Poses.Count);
|
||||
Assert.Equal(0, fixture.Engine.ShadowObjects.RetainedRegistrationCount);
|
||||
Assert.Equal(0, fixture.Teleport.PendingPlacementCount);
|
||||
Assert.Equal(0, fixture.Presentation.ReadyOwnerCount);
|
||||
Assert.Equal(0, fixture.Presentation.DeferredShadowRestoreCount);
|
||||
Assert.Equal(0, fixture.Presentation.ActivePlacementCount);
|
||||
Assert.Equal(0, fixture.Spatial.PendingLiveEntityCount);
|
||||
Assert.Equal(0, fixture.Spatial.PendingBucketCount);
|
||||
}
|
||||
|
|
@ -590,7 +584,6 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
|
||||
EntityEffectController? effects = null;
|
||||
LiveEntityPresentationController? presentation = null;
|
||||
RemoteTeleportController? teleport = null;
|
||||
Runtime = LiveEntityRuntimeFixture.Create(
|
||||
Spatial,
|
||||
new DelegateLiveEntityResourceLifecycle(
|
||||
|
|
@ -609,7 +602,6 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
{
|
||||
effects?.OnLiveEntityUnregistered(record);
|
||||
presentation?.Forget(record);
|
||||
teleport?.Forget(record);
|
||||
if (record.WorldEntity is { } entity)
|
||||
Engine.ShadowObjects.Deregister(entity.Id);
|
||||
});
|
||||
|
|
@ -669,25 +661,6 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
liveCenter: () => (1, 1));
|
||||
Assert.True(Presentation.OnLiveEntityReady(Guid));
|
||||
|
||||
Teleport = teleport = new RemoteTeleportController(
|
||||
Engine,
|
||||
Runtime,
|
||||
(_, _) => (0.48f, 1.835f),
|
||||
(position, _) => position,
|
||||
(_, _, _) => { },
|
||||
(guid, generation, defer) =>
|
||||
Presentation.CompleteAuthoritativePlacement(guid, generation, defer),
|
||||
(guid, generation) =>
|
||||
Presentation.BeginAuthoritativePlacement(guid, generation),
|
||||
resolvePlacement: (position, cell, _, _, _, _) => new ResolveResult(
|
||||
position,
|
||||
cell,
|
||||
IsOnGround: true,
|
||||
InContact: true,
|
||||
OnWalkable: true,
|
||||
ContactPlane: new Plane(Vector3.UnitZ, 0f),
|
||||
ContactPlaneCellId: cell));
|
||||
|
||||
Runtime.ProjectionVisibilityChanged += OnProjectionVisibilityChanged;
|
||||
_hookQueue = new AnimationHookFrameQueue(Router, Poses);
|
||||
}
|
||||
|
|
@ -703,7 +676,6 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
internal EntityEffectController Effects { get; }
|
||||
internal WorldEntity Entity { get; }
|
||||
internal LiveEntityPresentationController Presentation { get; }
|
||||
internal RemoteTeleportController Teleport { get; }
|
||||
internal List<uint> TypedScripts { get; } = [];
|
||||
internal int RecallHookCount { get; private set; }
|
||||
|
||||
|
|
@ -735,25 +707,27 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
Assert.True(Presentation.OnStateAccepted(Guid));
|
||||
}
|
||||
|
||||
// C4 route 4b-3 deleted the standalone RemoteTeleportController this
|
||||
// step used to drive. The scenario this fixture exists to cover —
|
||||
// Hidden/DeferredShadowRestore correctness across a landblock churn
|
||||
// while an entity is mid-teleport — does not depend on that
|
||||
// controller's own bookkeeping (BeginAuthoritativePlacement/
|
||||
// CompleteAuthoritativePlacement are confirmed dead: their only
|
||||
// production caller was the deleted presentation adapter). This
|
||||
// reproduces the same observable state the canonical teleport arm's
|
||||
// tail produces: the destination cell adopted and the body/entity
|
||||
// moved to the destination pose, still Hidden.
|
||||
internal void BeginDeferredTeleport()
|
||||
{
|
||||
_destinationCell = _currentCell == CellOne ? CellTwo : CellOne;
|
||||
Assert.False(Spatial.IsLoaded((_destinationCell & 0xFFFF0000u) | 0xFFFFu));
|
||||
Teleport.BeginPlacement(Guid, generation: 1);
|
||||
Assert.True(Runtime.RebucketLiveEntity(Guid, _destinationCell));
|
||||
RemoteTeleportController.Result result = Teleport.TryApply(
|
||||
_remote,
|
||||
Entity,
|
||||
new Vector3(Entity.Position.X + 3f, Entity.Position.Y, Entity.Position.Z),
|
||||
_destinationCell,
|
||||
Entity.Position,
|
||||
Quaternion.Identity,
|
||||
gameTime: _stateSequence,
|
||||
destinationProjectionVisible: false,
|
||||
generation: 1,
|
||||
positionSequence: 1);
|
||||
Assert.True(result.Applied);
|
||||
Assert.False(result.ContactResolved);
|
||||
var destination = new Vector3(
|
||||
Entity.Position.X + 3f, Entity.Position.Y, Entity.Position.Z);
|
||||
_remote.Body.Position = destination;
|
||||
_remote.CellId = _destinationCell;
|
||||
Entity.SetPosition(destination);
|
||||
Entity.ParentCellId = _destinationCell;
|
||||
}
|
||||
|
||||
internal void LoadDestination()
|
||||
|
|
@ -797,7 +771,6 @@ public sealed class LiveEntityLifecycleStressTests
|
|||
{
|
||||
Clear();
|
||||
Runtime.ProjectionVisibilityChanged -= OnProjectionVisibilityChanged;
|
||||
Teleport.Dispose();
|
||||
Presentation.Dispose();
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -596,51 +596,12 @@ public sealed class LiveEntityPresentationControllerTests
|
|||
controller.Dispose();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ActivePlacement_IsGenerationScopedAndClearsOnTeardownAndReset()
|
||||
{
|
||||
Fixture fixture = new(PhysicsStateFlags.ReportCollisions);
|
||||
Assert.True(fixture.Controller.OnLiveEntityReady(Fixture.Guid));
|
||||
Assert.True(fixture.Controller.BeginAuthoritativePlacement(Fixture.Guid, 1));
|
||||
Assert.True(fixture.Controller.HasActivePlacement(Fixture.Guid));
|
||||
Assert.True(fixture.Runtime.TryGetRecord(Fixture.Guid, out LiveEntityRecord oldRecord));
|
||||
|
||||
fixture.Controller.Forget(oldRecord);
|
||||
Assert.True(fixture.Runtime.UnregisterLiveEntity(
|
||||
new DeleteObject.Parsed(Fixture.Guid, 1),
|
||||
isLocalPlayer: false));
|
||||
Assert.False(fixture.Controller.HasActivePlacement(Fixture.Guid));
|
||||
|
||||
fixture.Runtime.RegisterLiveEntity(Fixture.Spawn(
|
||||
PhysicsStateFlags.ReportCollisions,
|
||||
instanceSequence: 2));
|
||||
fixture.Runtime.MaterializeLiveEntity(
|
||||
Fixture.Guid,
|
||||
0x01010001u,
|
||||
id => new WorldEntity
|
||||
{
|
||||
Id = id,
|
||||
ServerGuid = Fixture.Guid,
|
||||
SourceGfxObjOrSetupId = 0x02000001u,
|
||||
Position = new Vector3(10f, 10f, 5f),
|
||||
Rotation = Quaternion.Identity,
|
||||
MeshRefs = Array.Empty<MeshRef>(),
|
||||
});
|
||||
Assert.True(fixture.Controller.OnLiveEntityReady(Fixture.Guid));
|
||||
|
||||
Assert.False(fixture.Controller.CompleteAuthoritativePlacement(
|
||||
Fixture.Guid,
|
||||
generation: 1,
|
||||
deferShadowRestore: true));
|
||||
Assert.False(fixture.Controller.HasDeferredShadowRestore(Fixture.Guid));
|
||||
Assert.True(fixture.Controller.BeginAuthoritativePlacement(Fixture.Guid, 2));
|
||||
Assert.True(fixture.Controller.HasActivePlacement(Fixture.Guid));
|
||||
|
||||
fixture.Controller.Clear();
|
||||
|
||||
Assert.False(fixture.Controller.HasActivePlacement(Fixture.Guid));
|
||||
Assert.False(fixture.Controller.HasDeferredShadowRestore(Fixture.Guid));
|
||||
}
|
||||
// C4 route 4b-3: ActivePlacement_IsGenerationScopedAndClearsOnTeardownAndReset
|
||||
// deleted — BeginAuthoritativePlacement/CompleteAuthoritativePlacement/
|
||||
// HasActivePlacement/DeferShadowRestore and the backing
|
||||
// _activePlacementOwners set are dead (their only production caller was
|
||||
// the deleted RemoteTeleportPlacementPresentation); see
|
||||
// docs/research/2026-08-04-c4-route-4b-3-contract.md's deletion inventory.
|
||||
|
||||
private sealed class Fixture
|
||||
{
|
||||
|
|
|
|||
|
|
@ -1785,11 +1785,25 @@ public sealed class LiveEntityRuntimeTests
|
|||
out AcceptedPhysicsTimestamps timestamps));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
Assert.False(timestamps.TeleportAdvanced);
|
||||
Assert.True(timestamps.TeleportHookRequired);
|
||||
// C4 route 4b-3 (D1): the pickup left the record cell-less
|
||||
// (FullCellId == 0, unwield-to-3D), and TryApplyPosition measures
|
||||
// that PRE-merge value — the classifier's remote cell-less predicate
|
||||
// reads this, not the post-merge canonical.FullCellId.
|
||||
Assert.Equal(0u, timestamps.PreMergeCommittedCellId);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// C4 route 4b-3 (D1): before this slice, losing spatial visibility alone
|
||||
/// (no cell-less body, no fresh TELEPORT_TS) flagged
|
||||
/// <c>projectionRequiresTeleportHook</c> — a presentation predicate with
|
||||
/// no retail analogue (the deleted D1 evidence-chain arm). This is the
|
||||
/// regression guard: a record that is still resident at a real cell
|
||||
/// (materialized at 0x01010001u) but has lost spatial projection reports
|
||||
/// its HONEST pre-merge committed cell, not a fabricated cell-less
|
||||
/// signal — visibility is presentation-only now.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void PositionFromPendingProjection_RequiresTeleportHookWithEqualTeleportStamp()
|
||||
public void PositionFromPendingProjection_ReportsTheHonestPreMergeCellNotVisibility()
|
||||
{
|
||||
const uint guid = 0x70000044u;
|
||||
var spatial = new GpuWorldState();
|
||||
|
|
@ -1824,7 +1838,7 @@ public sealed class LiveEntityRuntimeTests
|
|||
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
Assert.False(timestamps.TeleportAdvanced);
|
||||
Assert.True(timestamps.TeleportHookRequired);
|
||||
Assert.Equal(0x01010001u, timestamps.PreMergeCommittedCellId);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
|
|
|
|||
|
|
@ -122,9 +122,7 @@ public sealed class RuntimeEntityOwnershipTests
|
|||
AssertExactKeyFields(
|
||||
typeof(LiveEntityPresentationController),
|
||||
"_readyOwners",
|
||||
"_suspendedShadowOwners",
|
||||
"_activePlacementOwners");
|
||||
AssertExactKeyFields(typeof(RemoteTeleportController), "_pending");
|
||||
"_suspendedShadowOwners");
|
||||
AssertExactKeyFields(typeof(LiveRenderProjectionJournal), "_byKey");
|
||||
AssertExactKeyFields(
|
||||
typeof(EntityEffectController),
|
||||
|
|
@ -185,7 +183,6 @@ public sealed class RuntimeEntityOwnershipTests
|
|||
[
|
||||
typeof(LiveEntityProjectionStore),
|
||||
typeof(LiveEntityPresentationController),
|
||||
typeof(RemoteTeleportController),
|
||||
typeof(LiveRenderProjectionJournal),
|
||||
typeof(LiveEntityLightController),
|
||||
typeof(EquippedChildRenderController),
|
||||
|
|
|
|||
|
|
@ -911,8 +911,6 @@ public sealed class UpdateFrameOrchestratorTests
|
|||
typeof(LiveSessionLocalPhysicsTimestampPublisher),
|
||||
typeof(AcDream.App.Physics.LiveEntityNetworkUpdateController),
|
||||
typeof(AcDream.App.Rendering.LiveEntityPartArrayLifecycle),
|
||||
typeof(AcDream.App.Physics.RemoteShadowPlacementSynchronizer),
|
||||
typeof(AcDream.App.Physics.RemoteTeleportPlacementPresentation),
|
||||
typeof(AcDream.App.Net.LiveEntitySessionController),
|
||||
];
|
||||
foreach (Type owner in typedProductionOwners)
|
||||
|
|
@ -965,8 +963,11 @@ public sealed class UpdateFrameOrchestratorTests
|
|||
StringComparison.Ordinal);
|
||||
Assert.Contains("d.WorldOrigin.GetCenter", livePresentation,
|
||||
StringComparison.Ordinal);
|
||||
Assert.Contains("d.WorldOrigin.CellLocalForSeed", livePresentation,
|
||||
StringComparison.Ordinal);
|
||||
// C4 route 4b-3 deleted the sole consumer of
|
||||
// d.WorldOrigin.CellLocalForSeed in this file — the standalone
|
||||
// RemoteTeleportController construction. LiveWorldOriginState.
|
||||
// CellLocalForSeed itself is not deleted (LocalPlayerTeleportController
|
||||
// still uses it).
|
||||
Assert.DoesNotContain("CreateLiveSessionEventRouter", source,
|
||||
StringComparison.Ordinal);
|
||||
Assert.Contains("_world.EntitySession.CreateSink()", sessionRuntime,
|
||||
|
|
|
|||
|
|
@ -508,7 +508,6 @@ public sealed class HeadlessSessionHostTests
|
|||
isLocalPlayer: true,
|
||||
forcePositionRotation: Quaternion.Identity,
|
||||
currentLocalVelocity: controller.BodyVelocity,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
|
|
|
|||
|
|
@ -1239,7 +1239,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 15f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, false, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -1286,7 +1286,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 1, forcePositionSequence: 0, positionX: 40f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, true, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -1344,7 +1344,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 25f, isGrounded: true);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: false, null, null, false, null,
|
||||
update, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -1391,7 +1391,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 15f,
|
||||
isGrounded: true);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, false, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -1432,7 +1432,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 25f,
|
||||
isGrounded: false);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: false, null, null, false, null,
|
||||
update, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -1468,7 +1468,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 25f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: false, null, null, false, null,
|
||||
update, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -1558,7 +1558,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 1, positionX: 40f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, false, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.ForcePosition, disposition);
|
||||
|
||||
|
|
@ -1626,7 +1626,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 25f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: false, null, null, false, null,
|
||||
update, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -1727,7 +1727,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 25f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: false, null, null, false, null,
|
||||
update, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -3940,7 +3940,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 1, forcePositionSequence: 0, positionX: 40f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, true, null, out _, out _, out _));
|
||||
update, isLocalPlayer: true, null, null, null, out _, out _, out _));
|
||||
|
||||
RuntimeInitialCreateExecutionStatus status = lifetime.InitialCreateExecution.Execute(
|
||||
canonical, lease.Token, NoContact, out _);
|
||||
|
|
@ -4007,7 +4007,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 1, forcePositionSequence: 0, positionX: 40f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, true, null, out _, out _, out _));
|
||||
update, isLocalPlayer: true, null, null, null, out _, out _, out _));
|
||||
|
||||
RuntimeInitialCreateExecutionStatus status = lifetime.InitialCreateExecution.Execute(
|
||||
canonical, lease.Token, NoContact, out _);
|
||||
|
|
@ -4072,7 +4072,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 1, forcePositionSequence: 0, positionX: 40f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, true, null, out _, out _, out _));
|
||||
update, isLocalPlayer: true, null, null, null, out _, out _, out _));
|
||||
|
||||
RuntimeInitialCreateExecutionStatus status = lifetime.InitialCreateExecution.Execute(
|
||||
canonical, lease.Token, NoContact, out _);
|
||||
|
|
@ -4149,7 +4149,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, positionSequence: 2, teleportSequence: 0, forcePositionSequence: 0, positionX: 25f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: false, null, null, false, null,
|
||||
update, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -4289,7 +4289,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
guid, positionSequence: 2, teleportSequence: 1,
|
||||
forcePositionSequence: 0, positionX: 40f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, true, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -4392,7 +4392,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
guid, positionSequence: 2, teleportSequence: 1,
|
||||
forcePositionSequence: 0, positionX: 40f);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, true, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -4750,7 +4750,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
guid, positionSequence: 2, teleportSequence: 0,
|
||||
forcePositionSequence: 0, positionX: 15f, isGrounded: true);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, false, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -4806,7 +4806,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
secondGuid, positionSequence: 2, teleportSequence: 0,
|
||||
forcePositionSequence: 0, positionX: 16f, isGrounded: true);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
secondUpdate, isLocalPlayer: true, null, null, false, null,
|
||||
secondUpdate, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition secondDisposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, secondDisposition);
|
||||
RuntimeInitialCreateExecutionReceipt secondReceipt = RunToCompletion(
|
||||
|
|
@ -4847,7 +4847,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
guid, positionSequence: 2, teleportSequence: 0,
|
||||
forcePositionSequence: 0, positionX: 15f, isGrounded: true);
|
||||
Assert.True(unbound.TryApplyPosition(
|
||||
update, isLocalPlayer: true, null, null, false, null,
|
||||
update, isLocalPlayer: true, null, null, null,
|
||||
out PositionTimestampDisposition disposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
|
||||
|
|
@ -4896,7 +4896,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
nearGuid, positionSequence: 2, teleportSequence: 0,
|
||||
forcePositionSequence: 0, positionX: 25f, isGrounded: true);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
nearUpdate, isLocalPlayer: false, null, null, false, null,
|
||||
nearUpdate, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition nearDisposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, nearDisposition);
|
||||
var farStruct = new RuntimeInitialCreateExecutionInputs(
|
||||
|
|
@ -4936,7 +4936,7 @@ public sealed class RuntimeInitialCreateContinuationExecutorTests
|
|||
farGuid, positionSequence: 2, teleportSequence: 0,
|
||||
forcePositionSequence: 0, positionX: 25f, isGrounded: true);
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
farUpdate, isLocalPlayer: false, null, null, false, null,
|
||||
farUpdate, isLocalPlayer: false, null, null, null,
|
||||
out PositionTimestampDisposition farDisposition, out _, out _));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, farDisposition);
|
||||
|
||||
|
|
|
|||
|
|
@ -532,7 +532,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: _ => callbacks++,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
|
|
@ -1126,7 +1125,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
teleportSequence: 0,
|
||||
forcePositionSequence: 0,
|
||||
positionX: 20f,
|
||||
projectionRequiresTeleportHook: false,
|
||||
() => callbacks++);
|
||||
ApplyQueuedPosition(
|
||||
lifetime,
|
||||
|
|
@ -1135,7 +1133,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
teleportSequence: 1,
|
||||
forcePositionSequence: 0,
|
||||
positionX: 30f,
|
||||
projectionRequiresTeleportHook: true,
|
||||
() => callbacks++);
|
||||
ApplyQueuedPosition(
|
||||
lifetime,
|
||||
|
|
@ -1144,7 +1141,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
teleportSequence: 2,
|
||||
forcePositionSequence: 0,
|
||||
positionX: 40f,
|
||||
projectionRequiresTeleportHook: false,
|
||||
() => callbacks++);
|
||||
|
||||
Assert.True(lifetime.TryGetInitialCreateResidence(
|
||||
|
|
@ -1167,10 +1163,15 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
Assert.Equal([(ushort)0, (ushort)1, (ushort)2],
|
||||
retained.Continuations.Select(
|
||||
static item => PositionAction(item).Position!.Value.TeleportSequence));
|
||||
Assert.False(PositionAction(retained.Continuations[0])
|
||||
.AcceptedTimestamps.TeleportHookRequired);
|
||||
Assert.False(PositionAction(retained.Continuations[1])
|
||||
.AcceptedTimestamps.TeleportHookRequired);
|
||||
// C4 route 4b-3 (D1): the deferred initial-residence FIFO
|
||||
// (RuntimeEntities.TryAcceptDeferredPosition) never runs
|
||||
// TryApplyPosition's pre-merge-cell measurement — that is the direct
|
||||
// accepted-Position path's own bookkeeping. A queued continuation's
|
||||
// timestamps therefore carry the honest "not measured here" value.
|
||||
Assert.Null(PositionAction(retained.Continuations[0])
|
||||
.AcceptedTimestamps.PreMergeCommittedCellId);
|
||||
Assert.Null(PositionAction(retained.Continuations[1])
|
||||
.AcceptedTimestamps.PreMergeCommittedCellId);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
|
|
@ -1199,7 +1200,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
|
|
@ -1219,7 +1219,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
teleportSequence: 0,
|
||||
forcePositionSequence: 0,
|
||||
positionX: 25f,
|
||||
projectionRequiresTeleportHook: false,
|
||||
callback: null,
|
||||
isLocalPlayer: false);
|
||||
Assert.True(lifetime.TryGetInitialCreateResidence(
|
||||
|
|
@ -1374,7 +1373,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
teleportSequence: 1,
|
||||
forcePositionSequence: 0,
|
||||
positionX: 55f,
|
||||
projectionRequiresTeleportHook: true,
|
||||
callback: null);
|
||||
Assert.Equal(
|
||||
RuntimeInitialCreateResidenceCompletionStatus.Completed,
|
||||
|
|
@ -1555,7 +1553,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: true,
|
||||
acknowledgeProjection: _ => callbacks++,
|
||||
out _,
|
||||
out _,
|
||||
|
|
@ -2557,7 +2554,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
ushort teleportSequence,
|
||||
ushort forcePositionSequence,
|
||||
float positionX,
|
||||
bool projectionRequiresTeleportHook,
|
||||
Action? callback,
|
||||
bool isLocalPlayer = true)
|
||||
{
|
||||
|
|
@ -2572,7 +2568,6 @@ public sealed class RuntimeInitialCreateResidenceStateTests
|
|||
isLocalPlayer,
|
||||
forcePositionRotation: Quaternion.Identity,
|
||||
currentLocalVelocity: new Vector3(1f, 2f, 3f),
|
||||
projectionRequiresTeleportHook,
|
||||
acknowledgeProjection: callback is null
|
||||
? null
|
||||
: _ => callback(),
|
||||
|
|
|
|||
|
|
@ -478,7 +478,6 @@ public sealed class RuntimeRemoteFirstEntryStateTests
|
|||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
|
|
|
|||
|
|
@ -0,0 +1,242 @@
|
|||
using AcDream.Core.Net;
|
||||
using AcDream.Core.Net.Messages;
|
||||
using AcDream.Core.Physics;
|
||||
using AcDream.Runtime.Entities;
|
||||
using AcDream.Runtime.Physics;
|
||||
|
||||
namespace AcDream.Runtime.Tests.Entities;
|
||||
|
||||
/// <summary>
|
||||
/// C4 route 4b-3 (D1): the load-bearing evidence chain for the whole slice —
|
||||
/// <see cref="RuntimeEntityObjectLifetime.TryApplyPosition"/> measures the
|
||||
/// PRE-merge committed cell (<c>beforeCell</c>/<c>wasCellless</c>) before
|
||||
/// <c>RefreshSnapshot</c> stamps the accepted wire cell onto the canonical
|
||||
/// record, and <see cref="RuntimeEntityObjectLifetime.ClassifyRemoteAcceptedPosition"/>
|
||||
/// must read THAT value, not the post-merge <c>canonical.FullCellId</c> every
|
||||
/// other classifier caller reads. Reverting the fix (feeding the classifier
|
||||
/// <c>canonical.FullCellId</c> after the merge instead of the pre-merge value)
|
||||
/// must fail <see cref="CompanionTest_NonzeroPreMergeCellWithNoTeleportAdvance_DoesNotClassifySetPosition"/>
|
||||
/// — that is the ONE test that discriminates the fix from the shipped dead
|
||||
/// predicate, because both predicates agree whenever the pre-merge cell truly
|
||||
/// was zero.
|
||||
/// </summary>
|
||||
public sealed class RuntimeRemoteTeleportClassificationTests
|
||||
{
|
||||
private const uint Cell = 0x0101FFFFu;
|
||||
private const uint OtherCell = 0x0102FFFFu;
|
||||
|
||||
[Fact]
|
||||
public void CellLessRecord_ClassifiesSetPosition_EvenWithoutATeleportAdvance()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime();
|
||||
lifetime.BindEventContext(static () => new RuntimeGenerationToken(1), static () => 1UL);
|
||||
const uint guid = 0x70005001u;
|
||||
RuntimeEntityRecord canonical =
|
||||
lifetime.RegisterEntity(Spawn(guid, Cell, instance: 1)).Canonical!;
|
||||
Assert.Equal(Cell, canonical.FullCellId);
|
||||
|
||||
// The unwield-to-3D shape (AP-137's citation): a canonical withdrawal
|
||||
// zeroes the committed cell without any wire packet.
|
||||
lifetime.Entities.SetFullCell(canonical, 0u, 0u);
|
||||
Assert.Equal(0u, canonical.FullCellId);
|
||||
|
||||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, OtherCell, positionSequence: 2, teleportSequence: 0);
|
||||
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update,
|
||||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
out AcceptedPhysicsTimestamps timestamps));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
// The measured pre-merge value is the honest 0 — not a fabrication,
|
||||
// and not re-read after the merge (which would already show OtherCell).
|
||||
Assert.Equal(0u, timestamps.PreMergeCommittedCellId);
|
||||
Assert.False(timestamps.TeleportAdvanced);
|
||||
|
||||
Assert.True(lifetime.Entities.TryGetActive(guid, out RuntimeEntityRecord after));
|
||||
RuntimeAuthoritativePositionRoute? route = lifetime.ClassifyRemoteAcceptedPosition(
|
||||
after, update, disposition, timestamps, playerDistance: 10f);
|
||||
|
||||
Assert.NotNull(route);
|
||||
Assert.Equal(
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
route!.Value.Disposition);
|
||||
Assert.True(
|
||||
(route.Value.SetPositionFlags & PhysicsSetPositionFlags.Teleport) != 0);
|
||||
Assert.True(RuntimeRemoteTeleportPosition.OwnsTeleportPlacement(route));
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The discriminator (contract's test plan item 4, companion half): the
|
||||
/// SAME shape but WITHOUT the cell-less reset and WITHOUT a TELEPORT_TS
|
||||
/// advance must NOT classify <c>SetPosition</c>. Under the shipped dead
|
||||
/// predicate (reading <c>canonical.FullCellId</c> AFTER the merge) this
|
||||
/// would ALSO pass, because the merge always stamps a nonzero wire cell —
|
||||
/// the predicate was unreachable, not merely conservative. This test only
|
||||
/// distinguishes the fix once <see cref="CellLessRecord_ClassifiesSetPosition_EvenWithoutATeleportAdvance"/>
|
||||
/// establishes the positive case is reachable at all.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void CompanionTest_NonzeroPreMergeCellWithNoTeleportAdvance_DoesNotClassifySetPosition()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime();
|
||||
lifetime.BindEventContext(static () => new RuntimeGenerationToken(1), static () => 1UL);
|
||||
const uint guid = 0x70005002u;
|
||||
RuntimeEntityRecord canonical =
|
||||
lifetime.RegisterEntity(Spawn(guid, Cell, instance: 1)).Canonical!;
|
||||
Assert.Equal(Cell, canonical.FullCellId);
|
||||
// Deliberately NO SetFullCell(0, 0) — the record stays resident.
|
||||
|
||||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, OtherCell, positionSequence: 2, teleportSequence: 0);
|
||||
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update,
|
||||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
out AcceptedPhysicsTimestamps timestamps));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
// Honest pre-merge value: still resident at the ORIGINAL cell, not
|
||||
// the just-merged wire cell (which would be OtherCell) and not 0.
|
||||
Assert.Equal(Cell, timestamps.PreMergeCommittedCellId);
|
||||
Assert.False(timestamps.TeleportAdvanced);
|
||||
|
||||
Assert.True(lifetime.Entities.TryGetActive(guid, out RuntimeEntityRecord after));
|
||||
RuntimeAuthoritativePositionRoute? route = lifetime.ClassifyRemoteAcceptedPosition(
|
||||
after, update, disposition, timestamps, playerDistance: 10f);
|
||||
|
||||
Assert.NotNull(route);
|
||||
Assert.NotEqual(
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
route!.Value.Disposition);
|
||||
Assert.False(RuntimeRemoteTeleportPosition.OwnsTeleportPlacement(route));
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// A fresh TELEPORT_TS still classifies <c>SetPosition</c> even when the
|
||||
/// pre-merge cell was resident — the OTHER half of retail's predicate
|
||||
/// (<c>newer_event(TELEPORT_TS) || this_1->cell == 0</c>), unaffected by
|
||||
/// D1's plumbing change.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void FreshTeleportTimestamp_ClassifiesSetPosition_WithAResidentPreMergeCell()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime();
|
||||
lifetime.BindEventContext(static () => new RuntimeGenerationToken(1), static () => 1UL);
|
||||
const uint guid = 0x70005003u;
|
||||
RuntimeEntityRecord canonical =
|
||||
lifetime.RegisterEntity(Spawn(guid, Cell, instance: 1)).Canonical!;
|
||||
Assert.Equal(Cell, canonical.FullCellId);
|
||||
|
||||
WorldSession.EntityPositionUpdate update = PositionUpdate(
|
||||
guid, OtherCell, positionSequence: 2, teleportSequence: 5);
|
||||
|
||||
Assert.True(lifetime.TryApplyPosition(
|
||||
update,
|
||||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
out AcceptedPhysicsTimestamps timestamps));
|
||||
Assert.Equal(PositionTimestampDisposition.Apply, disposition);
|
||||
Assert.Equal(Cell, timestamps.PreMergeCommittedCellId);
|
||||
Assert.True(timestamps.TeleportAdvanced);
|
||||
|
||||
Assert.True(lifetime.Entities.TryGetActive(guid, out RuntimeEntityRecord after));
|
||||
RuntimeAuthoritativePositionRoute? route = lifetime.ClassifyRemoteAcceptedPosition(
|
||||
after, update, disposition, timestamps, playerDistance: 10f);
|
||||
|
||||
Assert.NotNull(route);
|
||||
Assert.Equal(
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
route!.Value.Disposition);
|
||||
Assert.True(RuntimeRemoteTeleportPosition.OwnsTeleportPlacement(route));
|
||||
}
|
||||
|
||||
private static WorldSession.EntityPositionUpdate PositionUpdate(
|
||||
uint guid,
|
||||
uint cellId,
|
||||
ushort positionSequence,
|
||||
ushort teleportSequence) =>
|
||||
new(
|
||||
guid,
|
||||
new CreateObject.ServerPosition(
|
||||
cellId, 12f, 14f, 7f, 1f, 0f, 0f, 0f),
|
||||
Velocity: null,
|
||||
PlacementId: null,
|
||||
IsGrounded: true,
|
||||
InstanceSequence: 1,
|
||||
PositionSequence: positionSequence,
|
||||
TeleportSequence: teleportSequence,
|
||||
ForcePositionSequence: 0);
|
||||
|
||||
private static WorldSession.EntitySpawn Spawn(
|
||||
uint guid,
|
||||
uint cellId,
|
||||
ushort instance)
|
||||
{
|
||||
var position = new CreateObject.ServerPosition(
|
||||
cellId, 10f, 20f, 5f, 1f, 0f, 0f, 0f);
|
||||
var timestamps = new PhysicsTimestamps(
|
||||
Position: 1,
|
||||
Movement: 1,
|
||||
State: 1,
|
||||
Vector: 1,
|
||||
Teleport: 0,
|
||||
ServerControlledMove: 1,
|
||||
ForcePosition: 0,
|
||||
ObjDesc: 1,
|
||||
Instance: instance);
|
||||
var physics = new PhysicsSpawnData(
|
||||
RawState: 0x408u,
|
||||
Position: position,
|
||||
Movement: null,
|
||||
AnimationFrame: null,
|
||||
SetupTableId: 0x02000001u,
|
||||
MotionTableId: 0x09000001u,
|
||||
SoundTableId: null,
|
||||
PhysicsScriptTableId: null,
|
||||
Parent: null,
|
||||
Children: null,
|
||||
Scale: null,
|
||||
Friction: null,
|
||||
Elasticity: null,
|
||||
Translucency: null,
|
||||
Velocity: null,
|
||||
Acceleration: null,
|
||||
AngularVelocity: null,
|
||||
DefaultScriptType: null,
|
||||
DefaultScriptIntensity: null,
|
||||
Timestamps: timestamps);
|
||||
return new WorldSession.EntitySpawn(
|
||||
guid,
|
||||
position,
|
||||
0x02000001u,
|
||||
Array.Empty<CreateObject.AnimPartChange>(),
|
||||
Array.Empty<CreateObject.TextureChange>(),
|
||||
Array.Empty<CreateObject.SubPaletteSwap>(),
|
||||
null,
|
||||
null,
|
||||
"remote-teleport-classification",
|
||||
null,
|
||||
null,
|
||||
0x09000001u,
|
||||
PhysicsState: 0x408u,
|
||||
InstanceSequence: instance,
|
||||
MovementSequence: 1,
|
||||
ServerControlSequence: 1,
|
||||
PositionSequence: 1,
|
||||
Physics: physics);
|
||||
}
|
||||
}
|
||||
|
|
@ -241,7 +241,6 @@ public sealed class RuntimeLocalPlayerFirstEntryStateTests
|
|||
isLocalPlayer: true,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: true,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
|
|
|
|||
|
|
@ -1139,7 +1139,6 @@ public sealed class RuntimeLocalPlayerPhysicsPublicationStateTests
|
|||
isLocalPlayer: true,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: null,
|
||||
out _,
|
||||
out _,
|
||||
|
|
|
|||
|
|
@ -207,13 +207,11 @@ public sealed class RuntimeRemoteFarSnapPositionTests
|
|||
RuntimeRemoteFarSnapPosition.ResolveArm(
|
||||
Classify(hasContact: true, playerDistance: 200f)));
|
||||
|
||||
// The acdream-only leftovers, all four shapes. This is the stated
|
||||
// policy: they are NOT far. Reading "not Interpolate" as "far" is
|
||||
// route 4a's own review finding, one level up.
|
||||
Assert.Equal(
|
||||
RuntimeRemoteAcceptedPositionArm.UnroutedCatchUp,
|
||||
RuntimeRemoteFarSnapPosition.ResolveArm(
|
||||
Classify(hasContact: true, playerDistance: 10f, committedCellId: 0u)));
|
||||
// The acdream-only leftovers left in THIS arm after C4 route 4b-3
|
||||
// moved the cell-less/fresh-teleport shapes onto the teleport arm
|
||||
// (RuntimeRemoteTeleportPosition.OwnsTeleportPlacement — see that
|
||||
// class's own tests). What remains: no classification at all, and
|
||||
// the two rejections.
|
||||
Assert.Equal(
|
||||
RuntimeRemoteAcceptedPositionArm.UnroutedCatchUp,
|
||||
RuntimeRemoteFarSnapPosition.ResolveArm(
|
||||
|
|
@ -230,31 +228,6 @@ public sealed class RuntimeRemoteFarSnapPositionTests
|
|||
RuntimeRemoteFarSnapPosition.ResolveArm(null));
|
||||
}
|
||||
|
||||
// ── The single ConstrainTo site's gate ──────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void OwnsAfterOperationConstraint_CoversTheThreeArmsThatRunAnOperation()
|
||||
{
|
||||
// Retail arms @0x00454272 for every nonzero MoveOrTeleport return.
|
||||
// The airborne no-op returns 0 @0x0051636D, so it is excluded — and
|
||||
// that exclusion is route 4a's, carried forward unchanged.
|
||||
Assert.True(RuntimeRemoteFarSnapPosition.OwnsAfterOperationConstraint(
|
||||
Classify(hasContact: true, playerDistance: 10f)));
|
||||
Assert.True(RuntimeRemoteFarSnapPosition.OwnsAfterOperationConstraint(
|
||||
Classify(hasContact: true, playerDistance: 200f)));
|
||||
Assert.True(RuntimeRemoteFarSnapPosition.OwnsAfterOperationConstraint(
|
||||
Classify(hasContact: false, playerDistance: 10f)));
|
||||
|
||||
// The leftovers still arm through the App's legacy pre-operation
|
||||
// site; claiming them here would double-arm them.
|
||||
Assert.False(RuntimeRemoteFarSnapPosition.OwnsAfterOperationConstraint(
|
||||
Classify(hasContact: true, playerDistance: 10f, committedCellId: 0u)));
|
||||
Assert.False(RuntimeRemoteFarSnapPosition.OwnsAfterOperationConstraint(
|
||||
Classify(hasContact: true, playerDistance: float.NaN)));
|
||||
Assert.False(
|
||||
RuntimeRemoteFarSnapPosition.OwnsAfterOperationConstraint(null));
|
||||
}
|
||||
|
||||
private static RuntimeAuthoritativePositionAuthority Authority(
|
||||
PositionTimestampDisposition disposition,
|
||||
ushort previousTeleport,
|
||||
|
|
|
|||
|
|
@ -291,83 +291,45 @@ public sealed class RuntimeRemoteSteadyStatePositionTests
|
|||
Assert.Equal(0f, constraint.ConstraintPosOffset, 3);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void TryArmConstraintAfterOperation_ArmsForTheNearInterpolateBranch()
|
||||
{
|
||||
(RemoteMotion remote, EntityPhysicsHost host) = MakeRemoteWithHost(
|
||||
new Vector3(1f, 2f, 3f));
|
||||
|
||||
Assert.True(RuntimeRemoteSteadyStatePosition.TryArmConstraintAfterOperation(
|
||||
Classify(hasContact: true, playerDistance: 10f),
|
||||
remote));
|
||||
Assert.True(host.PositionManager.Constraint?.IsConstrained);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void TryArmConstraintAfterOperation_SkipsTheAirborneNoOperation()
|
||||
{
|
||||
// MoveOrTeleport returns 0 for arg4 == 0, so HandleReceivedPosition's
|
||||
// `if (MoveOrTeleport(...) != 0)` never reaches ConstrainTo.
|
||||
(RemoteMotion remote, EntityPhysicsHost host) = MakeRemoteWithHost(
|
||||
new Vector3(1f, 2f, 3f));
|
||||
|
||||
Assert.False(RuntimeRemoteSteadyStatePosition.TryArmConstraintAfterOperation(
|
||||
Classify(hasContact: false, playerDistance: 10f),
|
||||
remote));
|
||||
Assert.Null(host.PositionManager.Constraint);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// C4 route 4b-2: the far branch moved onto the post-operation arm with
|
||||
/// route 4a's two. Retail's `MoveOrTeleport` returns 1 @0x005163E8 there,
|
||||
/// so `HandleReceivedPosition`'s single `ConstrainTo` @0x00454272 runs —
|
||||
/// and the App's legacy PRE-operation call site now reads the same
|
||||
/// predicate and skips it, so it is armed exactly once.
|
||||
/// C4 route 4b-3 (D4): the complete arm-count partition, proof obligation
|
||||
/// 3 — one assertion per row of the contract's partition table, on the
|
||||
/// OBSERVABLE (whether <c>ConstrainTo</c> actually armed), not the code
|
||||
/// shape. <see cref="RuntimeRemoteAcceptedPositionArm.TeleportPlacement"/>
|
||||
/// and <see cref="RuntimeRemoteAcceptedPositionArm.FarSnapPlacement"/>
|
||||
/// arm unconditionally (retail discards the placement error and returns
|
||||
/// 1 either way, @0x00516438/@0x005163E8);
|
||||
/// <see cref="RuntimeRemoteAcceptedPositionArm.UnroutedCatchUp"/> arms
|
||||
/// too — it is only ever reached here when the caller's free-flight
|
||||
/// carve-out has already confirmed the body is in contact; only
|
||||
/// <see cref="RuntimeRemoteAcceptedPositionArm.AirborneNoOperation"/>
|
||||
/// does not (retail's <c>arg4 == 0</c> branch returns 0 @0x0051636D).
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void TryArmConstraintAfterOperation_ArmsForTheFarSnapBranch()
|
||||
[Theory]
|
||||
[InlineData("TeleportPlacement", true)]
|
||||
[InlineData("FarSnapPlacement", true)]
|
||||
[InlineData("NearInterpolate", true)]
|
||||
[InlineData("UnroutedCatchUp", true)]
|
||||
[InlineData("AirborneNoOperation", false)]
|
||||
public void TryArmConstraintAfterOperation_MatchesTheCompletePartition(
|
||||
string armName,
|
||||
bool expectedArmed)
|
||||
{
|
||||
// RuntimeRemoteAcceptedPositionArm is internal; xUnit's [InlineData]
|
||||
// requires public-visible argument types, so the arm travels as its
|
||||
// name and is parsed back here.
|
||||
var arm = (RuntimeRemoteAcceptedPositionArm)Enum.Parse(
|
||||
typeof(RuntimeRemoteAcceptedPositionArm), armName);
|
||||
(RemoteMotion remote, EntityPhysicsHost host) = MakeRemoteWithHost(
|
||||
new Vector3(1f, 2f, 3f));
|
||||
|
||||
RuntimeAuthoritativePositionRoute far =
|
||||
Classify(hasContact: true, playerDistance: 200f);
|
||||
bool armed = RuntimeRemoteSteadyStatePosition
|
||||
.TryArmConstraintAfterOperation(arm, remote);
|
||||
|
||||
Assert.Equal(expectedArmed, armed);
|
||||
Assert.Equal(
|
||||
RuntimeAuthoritativePositionDisposition.SetPositionSimple,
|
||||
far.Disposition);
|
||||
|
||||
Assert.True(RuntimeRemoteSteadyStatePosition.TryArmConstraintAfterOperation(
|
||||
far,
|
||||
remote));
|
||||
Assert.True(host.PositionManager.Constraint?.IsConstrained);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void TryArmConstraintAfterOperation_SkipsClassificationsNoArmOwns()
|
||||
{
|
||||
// The cell-less half, the two rejections, and "no classification at
|
||||
// all" still arm their leash through the untouched legacy
|
||||
// PRE-operation call site, not through here. Arming here too would
|
||||
// double-arm them.
|
||||
(RemoteMotion remote, EntityPhysicsHost host) = MakeRemoteWithHost(
|
||||
new Vector3(1f, 2f, 3f));
|
||||
|
||||
Assert.False(RuntimeRemoteSteadyStatePosition.TryArmConstraintAfterOperation(
|
||||
Classify(hasContact: true, playerDistance: 10f, committedCellId: 0u),
|
||||
remote));
|
||||
Assert.False(RuntimeRemoteSteadyStatePosition.TryArmConstraintAfterOperation(
|
||||
Classify(
|
||||
hasContact: true,
|
||||
playerDistance: 10f,
|
||||
disposition: PositionTimestampDisposition.Rejected),
|
||||
remote));
|
||||
Assert.False(RuntimeRemoteSteadyStatePosition.TryArmConstraintAfterOperation(
|
||||
Classify(hasContact: true, playerDistance: float.NaN),
|
||||
remote));
|
||||
Assert.False(RuntimeRemoteSteadyStatePosition.TryArmConstraintAfterOperation(
|
||||
null,
|
||||
remote));
|
||||
Assert.Null(host.PositionManager.Constraint);
|
||||
expectedArmed,
|
||||
host.PositionManager.Constraint?.IsConstrained == true);
|
||||
}
|
||||
|
||||
private static RuntimeAuthoritativePositionRoute Classify(
|
||||
|
|
|
|||
|
|
@ -1772,7 +1772,6 @@ public sealed class RuntimeSetPositionStateTests
|
|||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: null,
|
||||
out _,
|
||||
out _,
|
||||
|
|
@ -3194,7 +3193,6 @@ public sealed class RuntimeSetPositionStateTests
|
|||
isLocalPlayer: false,
|
||||
forcePositionRotation: null,
|
||||
currentLocalVelocity: null,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: null,
|
||||
out _,
|
||||
out _,
|
||||
|
|
|
|||
|
|
@ -1237,7 +1237,6 @@ public sealed class RuntimeAcceptedPositionDriveControllerTests
|
|||
isLocalPlayer: true,
|
||||
forcePositionRotation: controller.BodyOrientation,
|
||||
currentLocalVelocity: controller.BodyVelocity,
|
||||
projectionRequiresTeleportHook: false,
|
||||
acknowledgeProjection: null,
|
||||
out PositionTimestampDisposition disposition,
|
||||
out _,
|
||||
|
|
@ -1306,7 +1305,6 @@ public sealed class RuntimeAcceptedPositionDriveControllerTests
|
|||
Teleport: teleport,
|
||||
ForcePosition: 1,
|
||||
TeleportAdvanced: false,
|
||||
TeleportHookRequired: false,
|
||||
PreviousTeleport: teleport);
|
||||
|
||||
/// <summary>
|
||||
|
|
|
|||
|
|
@ -1935,6 +1935,327 @@ public sealed class RuntimeRemotePlacementDriveControllerTests
|
|||
}
|
||||
}
|
||||
|
||||
// ── C4 route 4b-3: the teleport/cell-less arm ───────────────────────────
|
||||
// TryExecuteAcceptedRemotePosition/SubmitAndResolve's own mechanics
|
||||
// (commit/park/reject dispatch, currency, ledger convergence) are already
|
||||
// exhaustively proven above for SetPosition-disposition routes — several
|
||||
// far-snap tests already construct SetPosition routes because
|
||||
// TryExecuteAcceptedRemotePosition is disposition-agnostic. What is new
|
||||
// here is ApplyAcceptedRemoteTeleport's OWN behaviour: the route guard,
|
||||
// the store_position fallback wired for the teleport disposition
|
||||
// specifically, and (D3) that it does NOT clear the interpolation queue
|
||||
// itself — unlike the far arm, retail's clear for this branch lives
|
||||
// inside teleport_hook, not in MoveOrTeleport.
|
||||
|
||||
/// <summary>
|
||||
/// Mirrors <see cref="Committed_WhenDestinationIsWithinServiceWindowAndCollisionGenerationCommitted"/>
|
||||
/// through the teleport arm specifically.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void Teleport_Committed_PlacesFromCanonicalDestination()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime(FlatEngine());
|
||||
CommitLandblockCollision(lifetime, DestinationLandblock);
|
||||
RuntimeEntityRecord record = CreateRemoteRecord(lifetime, 0x70003040u);
|
||||
PhysicsBody body = AttachBody(lifetime, record, SourceCell);
|
||||
RemoteMotion remote = lifetime.Physics.GetOrCreateRemoteMotion(record);
|
||||
var window = new FakeServiceWindow();
|
||||
window.Allow(DestinationLandblock);
|
||||
RuntimeRemotePlacementDriveController drive = CreateDrive(lifetime, window);
|
||||
|
||||
var destination = new Vector3(12f, 14f, SpawnHeight);
|
||||
RuntimeAuthoritativePositionRoute route = MakeRoute(
|
||||
record,
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
DestinationCell,
|
||||
destination);
|
||||
|
||||
RuntimeRemotePlacementExecutionStatus status =
|
||||
drive.ApplyAcceptedRemoteTeleport(record, remote, route);
|
||||
|
||||
Assert.Equal(RuntimeRemotePlacementExecutionStatus.Committed, status);
|
||||
Assert.Equal(destination + new Vector3(192f, 0f, 0f), body.Position);
|
||||
DrainPlacementFifo(lifetime);
|
||||
Assert.Equal(
|
||||
0, lifetime.Physics.CaptureOwnership().SetPositionOperationCount);
|
||||
AssertConverged(lifetime);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Invariant 1: a teleport whose destination the service window declines
|
||||
/// still advances the body to the accepted destination — retail's
|
||||
/// no-transition <c>store_position</c> branch, identical to the far arm's
|
||||
/// own fallback.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void Teleport_RefusedByServiceWindow_StillStoresTheDestinationPose()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime(FlatEngine());
|
||||
// The world frame must still be published (store_position resolves
|
||||
// through it); the service window is what refuses — mirrors
|
||||
// FarSnap_ClearsTheInterpolationQueue_IndependentlyOfThePlacementOutcome's
|
||||
// setup, which is the far arm's own Refused-fallback test.
|
||||
CommitLandblockCollision(lifetime, DestinationLandblock);
|
||||
RuntimeEntityRecord record = CreateRemoteRecord(lifetime, 0x70003041u);
|
||||
PhysicsBody body = AttachBody(lifetime, record, SourceCell);
|
||||
RemoteMotion remote = lifetime.Physics.GetOrCreateRemoteMotion(record);
|
||||
Vector3 positionBefore = body.Position;
|
||||
// Deliberately does not Allow(DestinationLandblock) — the service
|
||||
// window refuses.
|
||||
var window = new FakeServiceWindow();
|
||||
RuntimeRemotePlacementDriveController drive = CreateDrive(lifetime, window);
|
||||
|
||||
var destination = new Vector3(12f, 14f, SpawnHeight);
|
||||
RuntimeAuthoritativePositionRoute route = MakeRoute(
|
||||
record,
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
DestinationCell,
|
||||
destination);
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.Refused,
|
||||
drive.ApplyAcceptedRemoteTeleport(record, remote, route));
|
||||
|
||||
Assert.NotEqual(positionBefore, body.Position);
|
||||
Assert.True(body.InWorld);
|
||||
AssertConverged(lifetime);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The non-storing half of retail's partition, through the teleport arm:
|
||||
/// the engine's own sweep refused the destination
|
||||
/// (<c>RejectedByPlacement</c>), so the body must be left exactly where
|
||||
/// it was — mirrors
|
||||
/// <see cref="FarSnap_EngineRefusedTheDestination_LeavesTheBodyWhereItWas"/>.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void Teleport_EngineRefusedTheDestination_LeavesTheBodyWhereItWas()
|
||||
{
|
||||
PhysicsEngine engine = FlatEngine();
|
||||
using var lifetime = new RuntimeEntityObjectLifetime(engine);
|
||||
CommitLandblockCollision(lifetime, DestinationLandblock);
|
||||
RuntimeEntityRecord record = CreateRemoteRecord(lifetime, 0x70003042u);
|
||||
PhysicsBody body = AttachBody(lifetime, record, SourceCell);
|
||||
RemoteMotion remote = lifetime.Physics.GetOrCreateRemoteMotion(record);
|
||||
Vector3 positionBefore = body.Position;
|
||||
var window = new FakeServiceWindow();
|
||||
window.Allow(DestinationLandblock);
|
||||
RuntimeRemotePlacementDriveController drive = CreateDrive(lifetime, window);
|
||||
|
||||
engine.TransitionCellCollisionTestHook =
|
||||
static (_, _, _, _) => TransitionState.Collided;
|
||||
|
||||
var destination = new Vector3(12f, 14f, SpawnHeight);
|
||||
RuntimeAuthoritativePositionRoute route = MakeRoute(
|
||||
record,
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
DestinationCell,
|
||||
destination);
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.RejectedByPlacement,
|
||||
drive.ApplyAcceptedRemoteTeleport(record, remote, route));
|
||||
|
||||
Assert.Equal(positionBefore, body.Position);
|
||||
Assert.NotEqual(destination + new Vector3(192f, 0f, 0f), body.Position);
|
||||
AssertConverged(lifetime);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// D3: unlike the far arm, <c>ApplyAcceptedRemoteTeleport</c> must NOT
|
||||
/// clear the interpolation queue itself — the classifier's teleport
|
||||
/// branch carries <c>StopInterpolating: false</c> on purpose, because
|
||||
/// retail's clear for this branch lives inside <c>teleport_hook</c>'s
|
||||
/// <c>PositionManager::StopInterpolating</c> @0x00514EFD, which the
|
||||
/// CALLER (<c>ApplyRemoteContactRouting</c>) runs before this method. If
|
||||
/// this method also cleared the queue, the two would race on which side
|
||||
/// "owns" the retail action.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void Teleport_DoesNotClearTheInterpolationQueueItself()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime(FlatEngine());
|
||||
CommitLandblockCollision(lifetime, DestinationLandblock);
|
||||
RuntimeEntityRecord record = CreateRemoteRecord(lifetime, 0x70003043u);
|
||||
PhysicsBody body = AttachBody(lifetime, record, SourceCell);
|
||||
RemoteMotion remote = lifetime.Physics.GetOrCreateRemoteMotion(record);
|
||||
remote.Interp.Enqueue(
|
||||
new Vector3(40f, 40f, SpawnHeight),
|
||||
Quaternion.Identity,
|
||||
isMovingTo: false,
|
||||
currentBodyPosition: body.Position,
|
||||
currentBodyOrientation: body.Orientation);
|
||||
Assert.True(remote.Interp.IsActive);
|
||||
var window = new FakeServiceWindow();
|
||||
window.Allow(DestinationLandblock);
|
||||
RuntimeRemotePlacementDriveController drive = CreateDrive(lifetime, window);
|
||||
|
||||
RuntimeAuthoritativePositionRoute route = MakeRoute(
|
||||
record,
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
DestinationCell,
|
||||
new Vector3(12f, 14f, SpawnHeight));
|
||||
Assert.False(route.StopInterpolating);
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.Committed,
|
||||
drive.ApplyAcceptedRemoteTeleport(record, remote, route));
|
||||
|
||||
Assert.True(remote.Interp.IsActive);
|
||||
DrainPlacementFifo(lifetime);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The teleport arm must never be handed a route it does not own — the
|
||||
/// caller selects with
|
||||
/// <c>RuntimeRemoteTeleportPosition.OwnsTeleportPlacement</c>. Mirrors
|
||||
/// <see cref="FarSnap_ThrowsForARouteThisArmDoesNotOwn"/>.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void Teleport_ThrowsForARouteThisArmDoesNotOwn()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime(FlatEngine());
|
||||
RuntimeEntityRecord record = CreateRemoteRecord(lifetime, 0x70003044u);
|
||||
AttachBody(lifetime, record, SourceCell);
|
||||
RemoteMotion remote = lifetime.Physics.GetOrCreateRemoteMotion(record);
|
||||
RuntimeRemotePlacementDriveController drive =
|
||||
CreateDrive(lifetime, new FakeServiceWindow());
|
||||
|
||||
foreach (RuntimeAuthoritativePositionDisposition disposition in
|
||||
new[]
|
||||
{
|
||||
RuntimeAuthoritativePositionDisposition.SetPositionSimple,
|
||||
RuntimeAuthoritativePositionDisposition.Interpolate,
|
||||
RuntimeAuthoritativePositionDisposition.NoPositionOperation,
|
||||
RuntimeAuthoritativePositionDisposition.RejectedData,
|
||||
})
|
||||
{
|
||||
RuntimeAuthoritativePositionRoute route = MakeRoute(
|
||||
record, disposition, DestinationCell);
|
||||
Assert.Throws<ArgumentException>(
|
||||
() => drive.ApplyAcceptedRemoteTeleport(record, remote, route));
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Test-plan item 7 / contract D3's currency rule, "now for the teleport
|
||||
/// arm" — the R5 shape
|
||||
/// <see cref="FarSnap_SupersededIncarnation_DoesNotStoreThroughTheStaleRecord"/>
|
||||
/// already pins for <c>ApplyAcceptedRemoteFarSnap</c>. Retail's
|
||||
/// <c>store_position</c> fallback is the SAME method
|
||||
/// (<c>StoreAcceptedDestinationPose</c>) both arms call through, but that
|
||||
/// sharing is exactly why it needs its own pin: a future edit could special-
|
||||
/// case one arm's call site without the other, and only a same-shaped test
|
||||
/// for each caller catches that. Reaches the stale-record state the same
|
||||
/// deterministic way — dropping the record from the active directory while
|
||||
/// its body/key/snapshot stay exactly as the packet left them, so the
|
||||
/// currency guard (not a null check) is what's under test.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void Teleport_SupersededIncarnation_DoesNotStoreThroughTheStaleRecord()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime(FlatEngine());
|
||||
CommitLandblockCollision(lifetime, DestinationLandblock);
|
||||
RuntimeEntityRecord record = CreateRemoteRecord(lifetime, 0x70003045u);
|
||||
PhysicsBody body = AttachBody(lifetime, record, SourceCell);
|
||||
RemoteMotion remote = lifetime.Physics.GetOrCreateRemoteMotion(record);
|
||||
Vector3 positionBefore = body.Position;
|
||||
// Deliberately does not Allow(DestinationLandblock) — the service
|
||||
// window refuses, landing on the SAME store_position fallback the far
|
||||
// arm's currency test exercises.
|
||||
RuntimeRemotePlacementDriveController drive =
|
||||
CreateDrive(lifetime, new FakeServiceWindow());
|
||||
|
||||
var destination = new Vector3(12f, 14f, SpawnHeight);
|
||||
RuntimeAuthoritativePositionRoute route = MakeRoute(
|
||||
record,
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
DestinationCell,
|
||||
destination);
|
||||
|
||||
Assert.True(lifetime.Entities.RemoveActive(record));
|
||||
Assert.False(lifetime.Entities.IsCurrent(record));
|
||||
Assert.NotNull(record.PhysicsBody);
|
||||
Assert.NotNull(record.Key);
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.Refused,
|
||||
drive.ApplyAcceptedRemoteTeleport(record, remote, route));
|
||||
|
||||
Assert.Equal(positionBefore, body.Position);
|
||||
Assert.NotEqual(destination + new Vector3(192f, 0f, 0f), body.Position);
|
||||
AssertConverged(lifetime);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Test-plan item 8 / proof obligation 2: teardown, session reset, and
|
||||
/// generation change all converge <c>RemotePlacementDrivePendingCount</c>
|
||||
/// to zero — driven through <see cref="ApplyAcceptedRemoteTeleport"/>
|
||||
/// itself, not assumed transitively from
|
||||
/// <see cref="LedgerConverges_AfterDetachRouteClearsTrackedEntries"/>
|
||||
/// (which seeds its retained entry through the lower shared
|
||||
/// <c>TryExecuteAcceptedRemotePosition</c> entry point, bypassing the
|
||||
/// teleport arm's own route-ownership check entirely). <c>DetachRoute</c>
|
||||
/// is the one production convergence hook this controller exposes —
|
||||
/// <c>GameRuntime</c>'s teardown, session reset, and generation-change
|
||||
/// paths all funnel through it, exactly as they do for the far arm's own
|
||||
/// already-covered case; there is no separate per-cause API to test
|
||||
/// independently at this layer.
|
||||
///
|
||||
/// <para>
|
||||
/// Retains via the SAME "retryable preparation" shape
|
||||
/// <see cref="FarSnap_RetryablePreparation_StoresThePoseAndStillRetainsTheRetry"/>
|
||||
/// uses (an unresolved Setup collision reports <c>Contention</c> and
|
||||
/// parks an entry in <c>_pending</c> for the cadence pump) — so the
|
||||
/// convergence this test proves is genuinely draining a LIVE retained
|
||||
/// teleport retry, not an already-empty ledger.
|
||||
/// </para>
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void Teleport_LedgerConverges_AfterDetachRouteClearsARetainedRetry()
|
||||
{
|
||||
using var lifetime = new RuntimeEntityObjectLifetime(FlatEngine());
|
||||
CommitLandblockCollision(lifetime, DestinationLandblock);
|
||||
RuntimeEntityRecord record = CreateRemoteRecord(
|
||||
lifetime, 0x70003046u, setupTableId: 0x02000001u);
|
||||
PhysicsBody body = AttachBody(lifetime, record, SourceCell);
|
||||
RemoteMotion remote = lifetime.Physics.GetOrCreateRemoteMotion(record);
|
||||
Vector3 positionBefore = body.Position;
|
||||
var window = new FakeServiceWindow();
|
||||
window.Allow(DestinationLandblock);
|
||||
RuntimeRemotePlacementDriveController drive = CreateDrive(lifetime, window);
|
||||
var route = new object();
|
||||
drive.AttachRoute(route);
|
||||
|
||||
var destination = new Vector3(12f, 14f, SpawnHeight);
|
||||
RuntimeAuthoritativePositionRoute teleportRoute = MakeRoute(
|
||||
record,
|
||||
RuntimeAuthoritativePositionDisposition.SetPosition,
|
||||
DestinationCell,
|
||||
destination,
|
||||
stopInterpolating: true);
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeRemotePlacementExecutionStatus.Contention,
|
||||
drive.ApplyAcceptedRemoteTeleport(record, remote, teleportRoute));
|
||||
// The retained retry is live (not assumed) — a second call through
|
||||
// the arm proves it, mirroring the far arm's own
|
||||
// FarSnap_RetryablePreparation test's shape.
|
||||
Assert.Equal(1, drive.PendingCount);
|
||||
Assert.Equal(
|
||||
1, lifetime.CaptureOwnership().RemotePlacementDrivePendingCount);
|
||||
Assert.Equal(
|
||||
destination + new Vector3(192f, 0f, 0f), body.Position);
|
||||
Assert.NotEqual(positionBefore, body.Position);
|
||||
|
||||
drive.DetachRoute(route);
|
||||
|
||||
Assert.Equal(0, drive.PendingCount);
|
||||
Assert.Equal(
|
||||
0, lifetime.CaptureOwnership().RemotePlacementDrivePendingCount);
|
||||
AssertConverged(lifetime);
|
||||
}
|
||||
|
||||
// ── Fixture ──────────────────────────────────────────────────────────
|
||||
|
||||
/// <summary>
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue