From 6d65177357e94254d4cd1e6454cd618c5f37ca34 Mon Sep 17 00:00:00 2001 From: Erik Date: Mon, 22 Jun 2026 22:01:07 +0200 Subject: [PATCH] =?UTF-8?q?style(D.2b):=20EquipMask=20polish=20=E2=80=94?= =?UTF-8?q?=20align=20FingerWearRight,=20note=20bit=2031=20(code=20review)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code-quality review minors on Task 2: fix the missing space in the FingerWearRight= alignment and document why bit 31 (0x80000000, present only in the header's CLOTHING_LOC composite) has no named member. Co-Authored-By: Claude Opus 4.8 (1M context) --- src/AcDream.Core/Items/ClientObject.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/AcDream.Core/Items/ClientObject.cs b/src/AcDream.Core/Items/ClientObject.cs index cc3695b6..b058bf20 100644 --- a/src/AcDream.Core/Items/ClientObject.cs +++ b/src/AcDream.Core/Items/ClientObject.cs @@ -61,6 +61,8 @@ public enum ItemType : uint /// (docs/research/named-retail/acclient.h:3193; identical to ACE's EquipMask). /// The wire (ValidLocations / CurrentWieldedLocation / WieldObject EquipLoc) delivers /// these exact bits. Pinned by EquipMaskTests — do NOT renumber. +/// (The header's CLOTHING_LOC composite also sets bit 31, 0x80000000, which is +/// not a named INVENTORY_LOC primitive and has no member here; ALL_LOC tops out at bit 30.) /// [Flags] public enum EquipMask : uint @@ -85,7 +87,7 @@ public enum EquipMask : uint WristWearLeft = 0x00010000, WristWearRight = 0x00020000, FingerWearLeft = 0x00040000, - FingerWearRight= 0x00080000, + FingerWearRight = 0x00080000, MeleeWeapon = 0x00100000, Shield = 0x00200000, MissileWeapon = 0x00400000,