erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

fix(vtank): slice 7 fix round B item 3 — bottom-band clipping on notice labels

Browse source 
AssertWithinParent (MossTankMarkupContractTests) already checks a child's
y+h against its parent's declared height, but only when h>0 — most notice/
status labels have no explicit h attribute (Height defaults to 0 in
MarkupDocument.F), so the check silently never fired for them even though
they visually clip the tab's 194px content band.

Fix: give the two labels that actually overflow an explicit h="16" and
raise them so 194-16=178 is their max y (item 3's "a full 16px line fits"
rule) — Consumables' ProfileNotice (184 -> 178; also trimmed the "Add
Selected" button above it from h=25 to h=24 so the two touch at y=178
without overlapping) and Meta's MetaNotice (already at the correct y=178,
just needed the explicit w/h so the existing pin actually applies to it).
Buffs' Coverage label already landed at y=178/h=16 in item 2's Buffs
redesign. The Loot Editor popup's own bottom row (LootRangeText/-/+) was
already explicit and already fit (282+16=298<=300) — no change needed.

Mutation check: reverting ProfileNotice to y=184 turned
AuthoredShellFitsTheMinimumCanvasAndEverySizedChildFitsItsParent red
("<label> crosses the bottom edge of <group>"); restoring y=178 turns it
green again.

tests/AcDream.Plugins.MossTank.Tests: 665/665 (unchanged count — no new
pins added, the existing one now actually fires).
tests/AcDream.App.Tests --filter Markup|Plugin|UiMenu|Slider: 276/3 skipped/279 (unchanged).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-09-07 11:36:27 +02:00
parent 0c2c3b572d
commit 687f420d02
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/AcDream.Plugins.MossTank/mosstank.xml
View file

@ -444,9 +444,9 @@
onclick="{AddAllPeas}" />
<button x="306" y="154" w="104" h="25" text="Remove"
onclick="{RemoveSelectedConsumable}" />
<button x="438" y="154" w="176" h="25" text="Add Selected"
<button x="438" y="154" w="176" h="24" text="Add Selected"
onclick="{AddSelectedComponent}" />
<label x="438" y="184" text="{ProfileNotice}" color="#FF9B9072" />
<label x="438" y="178" w="176" h="16" text="{ProfileNotice}" color="#FF9B9072" />
</group>
<!-- Buffs: VTank's REAL Buffs tab (docs/research/vtank-kb/08-ui-views.md
@ -708,7 +708,7 @@
<button x="516" y="151" w="28" h="21" icon="0x060028FD" iconkind="did"
onclick="{MoveMetaRuleDown}" tooltip="Move the selected meta rule down." />
<label x="558" y="156" text="{MetaStatus}" color="#FFC7B98F" />
<label x="4" y="178" text="{MetaNotice}" color="#FF9B9072" />
<label x="4" y="178" w="500" h="16" text="{MetaNotice}" color="#FF9B9072" />
</group>
</panel>