erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs(vt): slice-1 ledger — Part A fix round 1 (3/12) and round 1b dispatched

Browse source 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-09-06 21:55:10 +02:00
parent 208599fae7
commit 68627a873b
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/plans/2026-09-06-campaign-vt-slice1-files-and-columns.md
View file

@ -126,3 +126,4 @@ change in combat/buff/loot/nav (slices 2-6).
- 2026-09-06 Part A landed on `worktree-agent-a4e93dac28a3d6f36` at `17f2143a7` (4 commits; MossTank suite 345 → 424). Implementer deviations: A2 "foundation-only" (stores still JSON-primary with an `.af` sidecar export), a raw-path `IPluginHost.VtankProfileDirectory`, `-text` gitattributes for fixtures. Opus fidelity lens: REJECT — 20/137 settings written with the wrong `gy` type tag (VTank unboxes → crash), `UseArcs` 3-value enum collapsed to bool with the byte-identity test edited to hide it, `ptl`/`tlk` approach coordinates lost on save, meta/route exports collide, `ba` blobs and void tags mis-parsed, `CreateNew` emits a schema VTank would overwrite, no metaf header emitted, `mineOnly` wrong, `.cdf`/`.ast` absent. Opus architecture lens: APPROVE-WITH-FIXES — the raw path violates the architecture doc's storage invariant and is not forwarded by `ScopedPluginHost` (dead on arrival), the new engines have zero production callers, the recharge replica was not replaced, the binary nav writer survived inside `MetafSerializer`, `.met` reader tests deleted with the writer tests, tautological Linux-path pin, `G15` formatting. Fix round 1 (fidelity blockers + host contract: `IPluginStorage VtankProfiles` composed by the host, `ACDREAM_VTANK_PROFILE_DIR`) dispatched on the same worktree; fix round 2 = the store cutover (JSON → `.usd`/`.af` primary with one-time migration, Profiles tab, `/vt` save commands) follows.
- 2026-09-06 Part B fix round landed (`fd521f781`…`026b51207`, 11 commits; column tests 27 → 46, contract tests 6 → 8). Narrow Opus re-review: all eleven findings CLOSED with mutation-sensitive evidence, legacy path proven byte-identical, verdict MERGE-READY. Merged into the campaign branch at `da0fcb374`. Carry-forwards for the owner's next visual gate: a check column shorter than the list draws unchecked lamps that ignore clicks (documented; author bug in practice); `UiMarkupList.Columns` is sized once at assignment (mutating the list afterwards is unsupported; no in-repo caller does).
- 2026-09-06 full App suite on the merged branch: 7,411 passed / 36 failed / 97 skipped. The 36 are the same environment-gated lanes the Part A architecture reviewer saw on the base commit (installed-DAT physics/streaming/walk-trace, live-mount UI probes, Linux-only pacing/credential tests, the fixture regenerator) — none in markup or plugin code.
- 2026-09-06 Part A fix round 1 landed 3 of 12 items (`9c34b6074` declared-type tags + G15 + per-tag compare; `74283e111` `UseArcs` 3-way enum, test normalizer deleted; `07664b199` character-oriented `ba`/void-tag cursor). MossTank suite 424 → 562. The agent kept a float tolerance for `tDouble` settings stored in `float` fields (root cause deferred to round 1b item I: widen the fields). Round 1b dispatched on the same worktree for the remaining nine items (two-triple `ptl`/`tlk`, typed embedded routes, export collision, full `CreateNew` schema + replica deletion, metaf header, `IPluginStorage VtankProfiles` host contract, `mineOnly`/`.cdf`/`.ast`, restored tests, nits). Round 2 (store cutover) still follows.