erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(render): Phase U.2b — resolve reciprocal portal by other_portal_id (retail 433557)

Browse source 
Code review caught a CRITICAL under-inclusion: ApplyReciprocalClip scanned for the
first OtherCellId match, so a cell with two portals to the same neighbour clipped both
near-side openings against the FIRST reciprocal polygon — hiding geometry through the
second opening (real on Holtburg cellar cells 0x148<->0x149). Plumb the dat's
OtherPortalId back-link through CellPortalInfo + BuildLoadedCell and index the reciprocal
directly (retail arg2->other_portal_id, 433557). Skip (degrade to over-include) when the
index is unresolvable — never clip against a guessed polygon. Adds a disjoint two-back-
portal regression test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Erik 2026-05-30 16:56:00 +02:00
parent 3916b2b23e
commit 65781f5768
7 changed files with 184 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/AcDream.App.Tests/Rendering/CellVisibilityPortalPolygonsTests.cs
View file

@ -30,8 +30,8 @@ public class CellVisibilityPortalPolygonsTests
{
Portals = new()
{
new CellPortalInfo(0xFFFF, 100, 0), // exit portal, has geometry
new CellPortalInfo(0x0102, 101, 0), // inner portal, no geometry resolved
new CellPortalInfo(0xFFFF, 100, 0, 0), // exit portal, has geometry
new CellPortalInfo(0x0102, 101, 0, 0), // inner portal, no geometry resolved
},
ClipPlanes = new() { default, default },
PortalPolygons = new()