feat(net) Campaign CA CA2 #431: parse the inbound attribute/skill update family
The server's authoritative answers to a raise were dropped on the floor: only the vitals pair (0x02E7/0x02E9) had parsers, so after any RaiseAttribute/RaiseSkill/TrainSkill the client's stat model stayed frozen at login's PlayerDescription — the root cause of #431's stale derived skills and run speed. The GUI looked alive only because the panel applies optimistic local raises. New parsers with three-source-verified layouts (CA1 research doc §2.5/ §2.8): PrivateUpdateAttribute (0x02E3) and PrivateUpdateSkill (0x02DD — the wire's ushort ranks + hardcoded adjustPP=1 pair and f64 lastUsedTime preserved exactly). WorldSession dispatches both as typed events; LiveSessionEventRouter routes them into the J4 character owner's LocalPlayerState like every other private update. The vestigial PrivateUpdateSkillLevel (0x02DF) is deliberately unparsed — ACE has no producer (verified). OnAttributeUpdate now fans out to the derived-value observers, mirroring retail's live-at-inquiry model (CACQualities::InqSkill 0x00592660 — Set* writes raw, Inq* recomputes, notification carries no value): an Endurance write notifies the Health AND Stamina vital observers (ACE pushes only a Health record and its own comment says the client must refresh both), Self notifies Mana, and every attribute write notifies character-sheet consumers whose formula contributions just changed. OnSkillWireUpdate preserves the login FormulaBonus — the wire record carries no attribute contribution; CA3 replaces the cached field with the live computation. Also corrected while in the neighborhood: PropertyString.cs's comment claimed opcode 0x02DD for PrivateUpdatePropertyString; ACE's enum says 0x02D5/0x02D6 (doc-only — nothing dispatched on either). Conformance tests cover both layouts (including holtburger's golden skill fixture with adjustPP=1), truncation/wrong-opcode rejection, the Endurance/Self/Quickness fan-out contract, and FormulaBonus preservation. Full hermetic suite 15,333 passed / 0 failed (one load-sensitive transport flake observed on the first run, passed alone and on the clean re-run — filed as #439 rather than chased). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
1fc64984c9
commit
65430d4c7c
9 changed files with 474 additions and 4 deletions
|
|
@ -500,6 +500,21 @@ public sealed class WorldSession : IDisposable
|
|||
/// </summary>
|
||||
public event Action<PrivateUpdateVital.ParsedCurrent>? VitalCurrentUpdated;
|
||||
|
||||
/// <summary>
|
||||
/// Campaign CA CA2 (#431): fires when a
|
||||
/// <c>PrivateUpdateAttribute (0x02E3)</c> arrives — the authoritative
|
||||
/// primary-attribute record after a raise. Subscribers typically feed
|
||||
/// <see cref="AcDream.Core.Player.LocalPlayerState.OnAttributeUpdate"/>.
|
||||
/// </summary>
|
||||
public event Action<PrivateUpdateAttribute.Parsed>? AttributeUpdated;
|
||||
|
||||
/// <summary>
|
||||
/// Campaign CA CA2 (#431): fires when a
|
||||
/// <c>PrivateUpdateSkill (0x02DD)</c> arrives — the authoritative skill
|
||||
/// record after raise / train / specialize / untrain / reset.
|
||||
/// </summary>
|
||||
public event Action<PrivateUpdateSkill.Parsed>? SkillUpdated;
|
||||
|
||||
/// <summary>
|
||||
/// Phase 6 — server-broadcast PhysicsScript trigger. Fires when the
|
||||
/// server sends a <c>PlayScriptId</c> (opcode 0xF754) packet —
|
||||
|
|
@ -2257,6 +2272,24 @@ public sealed class WorldSession : IDisposable
|
|||
if (parsed is not null)
|
||||
VitalCurrentUpdated?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == PrivateUpdateAttribute.Opcode)
|
||||
{
|
||||
// Campaign CA CA2 (#431): authoritative attribute record
|
||||
// after RaiseAttribute. Wire per ACE
|
||||
// GameMessagePrivateUpdateAttribute (3-source agreement).
|
||||
var parsed = PrivateUpdateAttribute.TryParse(body);
|
||||
if (parsed is not null)
|
||||
AttributeUpdated?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == PrivateUpdateSkill.Opcode)
|
||||
{
|
||||
// Campaign CA CA2 (#431): authoritative skill record after
|
||||
// raise/train/specialize/untrain/reset. Wire per ACE
|
||||
// GameMessagePrivateUpdateSkill (3-source agreement).
|
||||
var parsed = PrivateUpdateSkill.TryParse(body);
|
||||
if (parsed is not null)
|
||||
SkillUpdated?.Invoke(parsed.Value);
|
||||
}
|
||||
else if (op == PublicUpdatePropertyInt.Opcode)
|
||||
{
|
||||
var p = PublicUpdatePropertyInt.TryParse(body);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue