Record final lighting and portal gates; bound stale test expectations
This commit is contained in:
Erik
parent
0ae2666ef0
commit
6349f0911e
7 changed files with 146 additions and 7 deletions
|
|
@ -87,7 +87,11 @@ No ambient/formula change. All11Town cell sets now receive the previously
|
|||
omitted room lights. Unchanged Town High/off/High plus0125/8C04/Holtburg controls
|
||||
produced eight inspected narrow PASS PNGs, both clients exited0/gracefully.
|
||||
`research/2026-09-01-overhaul/478-repaired-lighting-graphical.md` records proof
|
||||
and limits. Temporary observer cleanup and observer-free re-gate are in flight.
|
||||
and limits. Observer cleanup integrated0ae2666ef; final unchanged routes also
|
||||
produced eight inspected provisional PASS PNGs with both clients exiting0
|
||||
gracefully. `research/2026-09-01-overhaul/478-observer-removal-verification.md`.
|
||||
Two stale full-lane checksum/count test expectations are being reconciled;
|
||||
owner brightness acceptance and G4 remain owed.
|
||||
Original owner report during the `de427d2c0` gate on2026-09-05:
|
||||
Town Network was barely visible; the run includes indoor00070143. The current
|
||||
High-profile indoor authored-light/material path needs comparison with retail.
|
||||
|
|
|
|||
|
|
@ -821,6 +821,16 @@ removed. Full scratch Release0W0E, App180/Core69/native2 PASS, lead independent
|
|||
`478-observer-removal-verification.md`. Fresh integrated Release and unchanged
|
||||
Town/control re-gate next; FPS deferred, no owner acceptance or main merge.
|
||||
|
||||
**#478 final narrow gate / #474 correctness repeat:** cleanup0ae2666ef,
|
||||
Release0W0E/106PASS, final Town/control8PNGs PASS provisional; actual validation
|
||||
loaded, graceful exits. Unchanged nine-hop route9materializations/reveals and
|
||||
7arrival PNGs PASS provisional; settled completion/cuefalse/zero transit debt.
|
||||
See `478-observer-removal-verification.md` and `474-final-reveal-regression.md`
|
||||
for limits (arrival caption still present; not every generation waited to
|
||||
complete). Literal-hermetic17026pass/2stale checksum-count failures/0skip.
|
||||
Test-only `478-stale-expectations-contract.md` next, then final correctness
|
||||
lanes. FPS/C2 comparison deferred; G4 still FAIL/no main merge.
|
||||
|
||||
## 14. Risk register (condensed)
|
||||
|
||||
- **R1 second scene graph.** Graph records own only topology/membership facts;
|
||||
|
|
|
|||
|
|
@ -0,0 +1,41 @@
|
|||
# #474/#475 final nine-hop reveal regression
|
||||
|
||||
Clean binary `0ae2666ef0824a7d2771111d66e695920822d54e`; green Release and
|
||||
DLL hashes in `478-observer-removal-verification.md`. Unchanged
|
||||
`route-474-portal-reveal.txt`, v10 session/package, High/1024x768. ACE UDP9000
|
||||
PID13340 confirmed and both client names absent before launch. Run:
|
||||
`logs/selfgate-20260905-151950-474-final-reveal-0ae2666ef/`, PID31044.
|
||||
Actual Khronos validation DLL observed loaded; no VUID/SYNC/device-lost,
|
||||
unhandled exception or probe abort found. Graceful logout confirmed, exit0.
|
||||
|
||||
**PASS provisional for nine fresh materializations and world reveals, not
|
||||
owner G4 or FPS/timing acceptance.** Twenty checkpoint records include all
|
||||
nine `after` destinations with distinct generations2..10, visible=true and
|
||||
zero invariant failures. This route deliberately proceeds on world-visible,
|
||||
not completed: every immediate after checkpoint has completed=false;
|
||||
generations2/5/7 are superseded by the next command after revealing. Do not
|
||||
claim ten complete events. Final settled generation10 has completed=true,
|
||||
visible=true, waitCueShown=false, materialization count9, all transit ownership
|
||||
counters0/isSessionIdle=true, and zero pending publications, retirements,
|
||||
uploads and warmup. Immediate Holtburg after had4staged uploads, settled0.
|
||||
|
||||
All seven PNGs were opened; each is PASS provisional for destination world
|
||||
visible, **not** a portal-caption-cleared still. Every captured arrival still
|
||||
shows the temporary portal-space caption; the later settled JSON says the
|
||||
wait cue is false, but the unchanged route does not capture a settled PNG.
|
||||
No Rynthid part-placement acceptance is inferred from these views. Paths below
|
||||
are relative to this run's `artifacts/screenshots/`:
|
||||
|
||||
| PNG (each narrow PASS provisional) | SHA256 |
|
||||
| --- | --- |
|
||||
| 474-00-login.png | DA745BDD46FB1E3CFB7F58D3A4E1F06820F72C004F7519520885E0C5E9ED7258 |
|
||||
| 474-02-source-3032.png | BE23F632AA5CCEBE12AECE38F5733B4DD6D70C5D71B842FE247A9102ED153AEA |
|
||||
| 474-03-destination-3031.png | 68A85BA976BFC65E458D6A6876251841C61DE87DAA240BBD7FB171100EAFC120 |
|
||||
| 474-05-destination-revisit.png | BC99A75EF63D8B5E7BE3B008DBB52B690FE76C66EBBD081D3C3A72096544DB9E |
|
||||
| 474-07-destination-third.png | 078189FA515BB2A1D241F123E16B94F46905E0C6B30D1FB65F812F9849E40661 |
|
||||
| 474-08-facility-control.png | F55F4339F9DB3187B0FF8FF196B6452A275589AD1E27B2544D8F2BBA5A137071 |
|
||||
| 474-09-holtburg-control.png | 9F43902661A7069E8147D8DF2314F3669E1931135B302233FE6A423740F0C2D8 |
|
||||
|
||||
No route edits, timing comparisons, FPS analysis or quality reduction.
|
||||
This closes the owed unchanged route's correctness repeat, not its deferred
|
||||
performance comparison or the broader G4 gate. All own clients closed.
|
||||
|
|
@ -1,7 +1,7 @@
|
|||
# #478 temporary lighting observer removal
|
||||
|
||||
IMPLEMENTED and lead-reviewed at scratch ed2c8b12c; integration's fresh Release
|
||||
and final graphical repeat are pending. See `478-observer-removal-verification.md`.
|
||||
COMPLETE at integration0ae2666ef: fresh Release green, final eight-PNG narrow
|
||||
graphical repeat PASS provisional. See `478-observer-removal-verification.md`.
|
||||
Activated after candidatea5debaca2: unchanged Town High/off/High and0125/8C04
|
||||
control PNGs inspected, eight provisional lighting/reveal PASS frames,
|
||||
`478-repaired-lighting-graphical.md`. Both own clients exited0/gracefully.
|
||||
|
|
|
|||
|
|
@ -45,7 +45,47 @@ tests, not the full solution test lane or an FPS benchmark.
|
|||
|
||||
## Final graphical gate
|
||||
|
||||
Pending fresh Release on the integrated observer-free commit and the unchanged
|
||||
Town High/off/High plus 0125/8C04/Holtburg control routes. Candidate consumed-
|
||||
light measurements remain evidence only for `a5debaca2`, not for this binary.
|
||||
Owner acceptance remains owed; G4 FAIL/unpassed, no main merge. FPS deferred.
|
||||
Integrated `0ae2666ef0824a7d2771111d66e695920822d54e`, clean tree. Full Release
|
||||
0 warnings/errors and lead affected/native106/106 under
|
||||
`artifacts/478-final-0ae2666ef/`. App DLL SHA256
|
||||
2EA01E0F29484CAE9DBD0C5FC909C19BD15AF69B132A92234DB1E83FD2A6E198;
|
||||
Core DLL47443B1D036E99BB6CAD2F73903B61C90B5E2EF1F2371F7E4BFC113488CEF281.
|
||||
|
||||
Unchanged v10 session/package and routes,1600x900 High/off; ACE UDP9000
|
||||
PID13340 and both clients absent checked before each launch. Lead observed
|
||||
`C:/VulkanSDK/1.4.350.0/Bin/VkLayer_khronos_validation.dll` loaded in BOTH
|
||||
clients. No VUID/SYNC/device-lost/unhandled/probe-abort found. Both own clients
|
||||
exited0 with graceful logout confirmed and both client names absent afterward.
|
||||
|
||||
Town run `logs/selfgate-20260905-151709-478-final-town-0ae2666ef/`, PID17744:
|
||||
all three PNGs opened, PASS provisional for retained room-light repair.
|
||||
Walls, floor tiles and distant room remain illuminated in all three frames.
|
||||
Paths below are relative to this run's `artifacts/screenshots/`:
|
||||
|
||||
| PNG (each PASS provisional) | SHA256 |
|
||||
| --- | --- |
|
||||
| 478-00-town-high.png | AE18000FFD0BD77CF2EE2C38BFA46E484D6BFAD0B96AF1D99D2371F545221EEC |
|
||||
| 478-01-town-retail.png | FD11F386A288E574E97B09F3214DB6817783700AD53324600783B8D47461E358 |
|
||||
| 478-02-town-high-repeat.png | BE569AAAE929D02112065490548A09EE195A84182CB3EA90461F6C01F527C94D |
|
||||
|
||||
Controls run `logs/selfgate-20260905-151804-478-final-controls-0ae2666ef/`,
|
||||
PID32340: all five PNGs opened. Both indoor rooms remain legible, with visible
|
||||
masonry/floors/furnishings in High/off; Holtburg reveals foreground buildings
|
||||
and terrain. Narrow lighting/reveal smoke PASS provisional, not full dungeon
|
||||
movement/stairs/camera seams or exterior geometry acceptance. Paths relative
|
||||
to this run's `artifacts/screenshots/`:
|
||||
|
||||
| PNG (each PASS provisional) | SHA256 |
|
||||
| --- | --- |
|
||||
| 478-control-0125-high.png | 5192C277EC7229E4A7998601FB1FBB14E4BC660E7B354DF007A6843BC02BE75D |
|
||||
| 478-control-0125-retail.png | 3A5F3C64E68C9BC1C9D60B1BB61C3C788505368CD77BA48E83B2A41A1EF50A3E |
|
||||
| 478-control-8c04-high.png | 765A053A9FB10FB94CA8F7F05332414EE5DF585984E3EEABF9C4E4863F39DC9D |
|
||||
| 478-control-8c04-retail.png | 01CFD8DE8415053E86F83155ACB3785C6124EE2B71BED0577E98E4CFA86C61F6 |
|
||||
| 478-control-holtburg-return.png | B12DB1BF721481AE8122130DE9AB6EEE5EA946B34E682675C74CA664ADA7E91F |
|
||||
|
||||
All eight checkpoints: reveal complete/visible,0invariant failures,0pending
|
||||
publication/retirement/landblock retirement/live teardown/upload/warmup, and
|
||||
no `envCellLighting` property. Candidate consumed-light measurements remain
|
||||
evidence only for `a5debaca2`, not measurements of this observer-free binary.
|
||||
Cleanup and its final narrow gate are COMPLETE. Owner brightness acceptance
|
||||
and G4 remain owed; no main merge, no FPS work.
|
||||
|
|
|
|||
|
|
@ -0,0 +1,31 @@
|
|||
# #478 final-lane expectation correction — bounded test-only contract
|
||||
|
||||
At clean0ae2666ef the literal-hermetic lane completed once with17026pass,
|
||||
2fail,0skip,14assemblies. Artifact `artifacts/s5-final-hermetic-0ae2666ef/`.
|
||||
Both failures are stale batch-scope assertions invalidated by reviewed
|
||||
#478, not evidence of a new renderer defect:
|
||||
|
||||
1. `WalkStaticStreamPopulatorTests.WorldAlphaCyptDocumentationAndRegister_PinPerCellTruthAndThreeResiduals`
|
||||
still expects160active AP rows and the corresponding prose. Lead counted
|
||||
159actual active rows: AP-68 was properly retired by #478. Change exactly
|
||||
the two160 expectations to159; preserve all row/alpha semantics checks.
|
||||
2. `AtmosphericLightingDirectionSpirvTests.ParentPlainShadersAndReceiverSelectionSourcesRemainByteExact`
|
||||
still pins the pre-#478 plain mesh vertex source/module. Lead inspected
|
||||
the exacta5debaca2 diff: only the light-index comment and EnvCell47/object8
|
||||
stride/loop changed. Source normalized SHA256 is
|
||||
33d5563db8bcd7dc74e4836df2c6064cbd5112d074da5380b0bab333f1d7ece7;
|
||||
committed module9909ca4729dbE4fc7fbffb11c73481977d8f593d37f130fcdd44a7803b47944f.
|
||||
Update only those two expected hashes and the method name/comment to state
|
||||
the reviewed #478 amendment. Preserve all other unchanged-file hashes and
|
||||
semantic SPIR-V direction tests. This is not blind golden regeneration:
|
||||
actual 47/8 RHI/native-pixel witnesses already pass on these exact shaders.
|
||||
|
||||
One OpenAI implementer, fresh exact-base scratch, only the two named test
|
||||
files. No production, shader, generated, package, fixture, register, architecture
|
||||
or FPS changes. Do not retry/relax unrelated failures. Return exact diff/hash
|
||||
freeze and both whole test classes plus two retained native-pixel witnesses.
|
||||
Lead verifies the change and unchanged assertions, commits with the ledger,
|
||||
then repeats the literal-hermetic lane and canonical InstalledDat lane with
|
||||
unchanged filters. Existing failed evidence is retained. No new deviation or
|
||||
retail algorithm; no full implementation re-review is required for literal
|
||||
expected-value maintenance. Owner G4 still FAIL; no main merge.
|
||||
|
|
@ -4990,3 +4990,16 @@ match. Full scratch Release0W0E, App180/Core69/native2 PASS; lead independent
|
|||
affected/native106/106. `478-observer-removal-verification.md` records scope
|
||||
and actual reports. No new deviation, retail algorithm or FPS edit. Fresh
|
||||
integrated Release and unchanged final graphical repeats remain next.
|
||||
|
||||
Cleanup0ae2666ef is complete: integrated Release0W0E/106PASS; final Town17744
|
||||
and controls32340 exited0/gracefully, actual validation DLL observed in both,
|
||||
all8PNGs opened/PASS provisional with0pending work and observer field absent.
|
||||
`478-observer-removal-verification.md`. Unchanged nine-hop reveal route31044
|
||||
also exited0/gracefully,9distinct materializations/reveals;7PNG narrowPASS,
|
||||
final settled complete/cuefalse/zero transit debt. Arrival PNGs still show
|
||||
the temporary caption; generations2/5/7 are superseded after reveal, not full
|
||||
complete events. `474-final-reveal-regression.md`; no FPS/timing comparisons.
|
||||
Literal-hermetic at0ae2666ef:17026pass/2fail/0skip,14assemblies. Failures are
|
||||
the stale160AP count and pre-#478 plain-vertex hashes. Lead checked159active
|
||||
rows and exact reviewed shader diff. `478-stale-expectations-contract.md`
|
||||
authorizes only two test files. Full final lanes remain next; G4FAIL.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue