erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore: #163 strip R4-V5 temp diagnostics; docs: close #162 (no adaptation)

Browse source 
#163: remove [autowalk-gate] (+ _lastAutowalkGateLogTime throttle clock,
PlayerMovementController), [autowalk-feed] (GameWindow player tracker
feed), and the short-lived [MOVETO-CANCEL] #162 capture probe. The
durable ProbeAutoWalk family (PhysicsDiagnostics owner + DebugPanel
toggle + the permanent [autowalk] probe sites) stays.

#162 closed WITHOUT adaptation: user A/B says retail does not glide, and
post-#161 acdream matches (user-verified walk/run-by-distance movetos +
clean mid-chain key takeover). Head-interrupt + CancelMoveTo re-audited
retail-verbatim against the raw (unpack_movement 0x00524440,
interrupt_current_movement 0x005101f0, MoveToManager::CancelMoveTo
0x00529930 armed-gate); the launch-162 capture shows ACE's mt-0
reflections carry the mover's real locomotion, so cancels never strand
the legs. The old glide was killed by the R4-V5 stack + #161's
apply-pass params fix. Evidence trail in ISSUES Recently-closed #162.

Suite 3,964 green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-07-03 17:38:41 +02:00
parent 584ad0a8f6
commit 5ebe2be38e
4 changed files with 47 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

55
docs/ISSUES.md
View file

@ -85,28 +85,15 @@ R5/R6 touches the action list. **Where:**
`MotionInterpreter.MoveToInterpretedState` action loop /
`DispatchInterpretedMotion` (doc comment marks the gap).
## #162 — Observer-side moveto cancelled by ACE's autonomous MTS reflections (the "glide" class)
**Status:** OPEN — adjudication PENDING USER (2026-07-03)
**Finding (ACE-source-verified):** ACE re-broadcasts every inbound
MoveToState to all observers as an autonomous mt-0 UM (MovementData.cs:162
hardcoded IsAutonomous=true — ACE's own comment: "this is a hack ...
investigate this"; GameActionMoveToState.cs:36 unconditional), and sends a
chain exactly ONE mt-6 (no re-emit; no arrival broadcast). Retail's
unpack head-interrupt (verbatim in acdream) cancels the observer-side
moveto on each reflection → glide when the mover's client emits MTS
mid-chain. A retail observer on ACE should glide identically (parity).
**Pending:** the user's retail-observing-retail A/B; if parity confirmed,
EITHER accept, OR ship a narrow registered ACE-compat adaptation (e.g.
command-less autonomous reflection doesn't cancel an armed remote moveto)
— requires explicit user approval per the no-workarounds rule.
## #163 — Strip the R4-V5 stall-investigation diagnostics
**Status:** OPEN (2026-07-03) — remove `[autowalk-gate]` (
PlayerMovementController, + `_lastAutowalkGateLogTime`) and
`[autowalk-feed]` (GameWindow player tracker feed) once #160-#162 close;
they're TEMPORARY-tagged in-code.
**Status:** IN-PROGRESS (2026-07-03) — `[autowalk-gate]` (+
`_lastAutowalkGateLogTime`), `[autowalk-feed]`, and the short-lived
`[MOVETO-CANCEL]` #162 probe all stripped from source; build+commit
pending the running client's close (file locks). The durable
`ProbeAutoWalk` family (PhysicsDiagnostics flag + DebugPanel toggle +
the `[autowalk]` probe sites) stays — that's the promoted diagnostic
owner, not a temp diag.
## #159 — CombatAnimationPlanner uses 2013-decomp command numbering, not ACE/DRW
@ -5745,6 +5732,34 @@ outdoors at the angle that previously erased it.
# Recently closed
## #162 — Observer-side moveto cancelled by ACE's autonomous MTS reflections (the "glide" class)
**Status:** DONE (2026-07-03) — resolved WITHOUT adaptation; user-verified.
The user's A/B came back **retail does NOT glide** (new-fact branch), and
the follow-up acdream capture (launch-162, post-#161) showed acdream now
matches: walk/run by distance on mt-6 movetos (retail
`MovementParameters.GetCommand` threshold), clean takeover on a mid-chain
key press. Three-part evidence:
1. **Mechanism re-audit vs raw:** the head-interrupt IS unconditional
(`unpack_movement` 0x00524440 → `interrupt_current_movement` 0x005101f0
→ `MovementManager::CancelMoveTo(0x36)`), and `MoveToManager::CancelMoveTo`
(0x00529930) is gated on an ARMED moveto (drain + CleanUp +
StopCompletely; no-op otherwise). Our ports are verbatim — retail's
observer loses its armed moveto on the first reflection TOO.
2. **Wire capture:** ACE's mt-0 reflections carry the mover's REAL
locomotion (WalkForward @ -2.92 backward, RunForward @ 4.50, turns) —
so a cancel is always followed by correct legs; the no-glide outcome
needs no moveto protection. The `[MOVETO-CANCEL]` probe showed zero
mover-side cancels in normal use-walks (the mover's client doesn't emit
MTS mid-chain unless keys are pressed) and retail-correct
replace-cancels on an NPC's own successive TurnToObject UMs.
3. **The originally-observed glide is no longer reproducible** — killed by
the R4-V5 fix stack (un-ticked remote MoveToManagers `006cf659`, TS-40
link-strip `350fb5e3`, #160 run-rate `41006e79`) + #161's apply-pass
params fix `b1cf0102` (ModifyInterpretedState=true corrupted interpreted
state on EVERY UM apply, not just landings).
The theorized "narrow ACE-compat adaptation" is dead — nothing to adapt.
## #161 — Remote jump landing holds the falling pose (no landing anim)
**Status:** DONE (2026-07-03, `b1cf0102`) — user live-verified ("Yes works!").