docs(vt): slice 1 closeout — Part A merged at f680bf234; owner items; next = slice 7

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-09-07 02:26:46 +02:00
parent b71bbe82f4
commit 55e0f12ae6

View file

@ -131,3 +131,7 @@ change in combat/buff/loot/nav (slices 2-6).
- 2026-09-07 Part A round 2 (store cutover) landed: `479495ecc` settings → real `.usd` (load/save/create/clear through the serializer, listing + `.cdf` binding through `VtankProfileDirectory`, `SetOptionInAll` patches every `.usd`), `a5d52bfb0` metas and routes → `.af` (sole storage; `WriteLegacyExport` deleted; named routes carry the owner's own `nav_` prefix), `e5c4912b6` migration pins, `8a146aa8c` Profiles-tab Delete through the markup contract. One-time JSON migration per store (idempotent, counterpart-exists tests); disabled-rule saves refused with a notice. MossTank suite 585 → 595. Left in JSON as MossTank-only state: item/consumable name lists, no-buff names, attack power, scan intervals, meta state, dynamic settings, the monster-rule and loot-rule tables, the buff category bools, vitals enabled, the loot classifier id, and a `MineOnly` preference. Flagged: `MyMonsters``MonsterRule` not parsed (slice 3/7 scope); `.utl` loot profile store still JSON-indexed with its own legacy export (round-2 scope question for the re-review). Narrow re-reviews (both lenses) dispatched.
- 2026-09-07 Part A narrow re-reviews at `8a146aa8c`: architecture lens 13/15 closed, NOT merge-ready — the JSON side-car still duplicates `EnableLooting` and overwrites the `.usd` on load (a drop-in profile loads with looting off), the legacy roster is orphaned (only the selected profile migrates), `MyMonsters` divergence unrecorded, stale references, Delete only for settings, KB 07 row 6 stale. Fidelity lens 19/22 closed, NOT merge-ready — `nav_--Name_Server.af` defeats the `--` hidden filter (a private route leaks into every picker), meta/route pickers still enumerate the same `.af` set, the 2000 ms jump clamp was applied at file load instead of execution (rewrites authored values), `SetOptionInAll` skips absent rows where `bk.a` appends, `.cdf` names `.af` files a real VTank cannot load (register row owed), nav byte identity covers one fixture. Round 3 dispatched with all of it plus the `.utl` store cutover and Delete for the other three families. Then one final narrow re-check on both lists, merge, suites, hand over.
- 2026-09-07 Part A round 3 landed all twelve items (`b6d642c9b``f58e997b1`; MossTank suite 595 → 623): side-car overlap removed with an empty-intersection pin and a drop-in regression test, full legacy-roster sweep, `--nav_Name_Server.af` (hidden prefix first) with disjoint pickers, jump ceiling moved to execution, `SetOptionInAll` appends like `bk.a` with VTank's texts, register row for `.af` names in `.cdf` + launch-options warning, nav/`.ast` byte identity widened, loot store cut over to real `.utl` (a MossTank-owned unknown block preserves rule expressions VTClassic would drop), Delete for all four families, `MyMonsters` gap recorded as TS-86, cleanup. Final narrow re-check (both lists in one pass) dispatched.
- 2026-09-07 Part A final re-check: all twelve round-3 items CLOSED with failable tests, VTClassic confirmed to skip the MossTank expression block by length, byte-identity theories run with zero normalization, plugin has no file access outside embedded resources — MERGE-READY. Three non-blocking findings: #488 (latent newline/length mismatch in the `.utl` expression block), dead `remaining` branches in two sweeps, the meta Delete notice text. **Merged into the campaign branch at `f680bf234`.** Merged-branch gates: build 0/0, MossTank 625/625, Core plugin 50/50, App plugin+markup 238/238; full App suite run separately (known env-gated lanes only).
## Closeout
Slice 1 is COMPLETE on `claude/latest-main-sync-497549` (Part B `da0fcb374`, Part A `f680bf234`). Nothing merged to main, nothing pushed. Owner items: (1) the binary `.met`/`.nav` readers survive as one-shot import only (writers deleted) — say if they should go entirely; (2) `bore_quest.af`/`bore_enhanced.af` are hand-edited and excluded from byte identity; (3) a check column shorter than its list draws inert lamps; (4) pointing `ACDREAM_VTANK_PROFILE_DIR` at a real VirindiTank folder writes `.cdf` lines naming `.af` files that real VTank cannot load (AD-122). Next slice per the VT2 order and the owner's "looks like VTank" priority: slice 7 (tabs on the new columns; visual gate), then slice 2 (scheduler).