docs(hygiene): reconcile CLAUDE.md + roadmap; triage 16 → 12 open issues
CLAUDE.md: - "Currently in flight" (was NONE) → C.1.5b with pickup-doc link - Added C.1.5a + N.6 slice 1 + post-A.5 polish ship paragraphs - "Next planned phase" (was N.6) → ranked candidate list - Collapsed Tier 1 + 4 historical phase paragraphs into roadmap-table pointer (signal density +; line count ~net zero) - Fixed broken project_ui_architecture.md Memory-crib reference Roadmap header: dated 2026-05-10 → 2026-05-11 with "since the last update" delta. New Phase C.1.5 sliced sub-piece in Phases ahead. ISSUES.md triage: - Closed #37 (humanoid coat — resolved by #47 GfxObjDegradeResolver), #49 + #50 (scenery placement — accepted WB-vs-retail divergence). - Promoted #36 (sky-PES dispatch) to Phase C.1.5c; #2/#28/#29 auto-close when that phase ships. - Downgraded #39 (Run↔Walk cycle) to LOW + VERIFY-PENDING. - Cross-referenced #41 + #46 to Phase L.2 motion conformance. - Anti-coupling note on #4 (NOT in C.1.5c cluster). - Chore tag on #3 (single-commit clock-drift fix). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Erik
parent
ad261539d6
commit
55dc861724
3 changed files with 159 additions and 72 deletions
|
|
@ -111,13 +111,25 @@ settle at any radius/motion combination, not stay at ~1.45M/5s indefinitely at s
|
|||
|
||||
---
|
||||
|
||||
## #50 — Road-edge tree at 0xA9B1 visible in acdream but not retail
|
||||
## #50 — [DONE 2026-05-11 · accepted WB divergence] Road-edge tree at 0xA9B1 visible in acdream but not retail
|
||||
|
||||
**Status:** OPEN
|
||||
**Status:** DONE
|
||||
**Closed:** 2026-05-11
|
||||
**Severity:** LOW (cosmetic; one spawned tree near the road in Holtburg)
|
||||
**Filed:** 2026-05-08
|
||||
**Component:** scenery placement / Phase N (WorldBuilder rendering migration)
|
||||
|
||||
**Resolution:** Same disposition as #49 — accepted as WB-upstream
|
||||
divergence from retail. The earlier fix attempt (`e279c46`, ACME-style
|
||||
per-vertex road check) successfully removed this specific tree but
|
||||
over-suppressed scenery elsewhere; revert at `677a726` stood. Without
|
||||
a coherent port of ACME's full per-vertex filter set, piecemeal
|
||||
patching is net-negative. Left as a documented WB divergence.
|
||||
|
||||
---
|
||||
|
||||
**Original investigation (kept for reference):**
|
||||
|
||||
**Description:** With `ACDREAM_USE_WB_SCENERY=1` (default since commit `b84ecbd`),
|
||||
a tree at landblock 0xA9B1 around `(lx=85.08, ly=190.97)` appears in acdream but
|
||||
neither retail nor ACME WorldBuilder render it. Upstream Chorizite/WorldBuilder
|
||||
|
|
@ -155,13 +167,33 @@ other Phase N work catches a similar issue and a coherent fix becomes obvious.
|
|||
|
||||
---
|
||||
|
||||
## #49 — Scenery (X, Y) placement drifts from retail at some landblocks
|
||||
## #49 — [DONE 2026-05-11 · accepted WB divergence] Scenery (X, Y) placement drifts from retail at some landblocks
|
||||
|
||||
**Status:** OPEN
|
||||
**Severity:** MEDIUM (visible misplacement; species-specific or per-cell, not a global offset)
|
||||
**Status:** DONE
|
||||
**Closed:** 2026-05-11
|
||||
**Severity:** LOW (minor cosmetic placement difference)
|
||||
**Filed:** 2026-05-06
|
||||
**Component:** scenery placement / `SceneryGenerator`
|
||||
|
||||
**Resolution:** Accepted as WB-upstream divergence from retail. Since
|
||||
the N.1 phase (WorldBuilder-backed scenery, see roadmap), acdream
|
||||
defers scenery placement math to the WB fork; retail and WB diverge
|
||||
slightly here on some landblocks. Piecemeal patching against WB
|
||||
upstream would create a maintenance burden disproportionate to the
|
||||
visible impact (a handful of trees positioned a few meters off across
|
||||
the world). Left as-is; revisit only if WB upstream patches the
|
||||
divergence or if a coherent ACME-style filter port (see issue body
|
||||
below) becomes worthwhile.
|
||||
|
||||
The original investigation plan (cdb trace of retail's
|
||||
`CLandBlock::get_land_scenes` for diff against acdream's
|
||||
`SceneryGenerator` output) is preserved below for historical
|
||||
reference if anyone picks this up.
|
||||
|
||||
---
|
||||
|
||||
**Original investigation (kept for reference):**
|
||||
|
||||
**Description:** While verifying the `#48` Z fix at Holtburg
|
||||
landblock `0xA9B30001`, the user spotted a scenery tree placed at
|
||||
the **wrong (X, Y)** in acdream relative to retail at the same
|
||||
|
|
@ -362,8 +394,8 @@ regression on the species that already render correctly.
|
|||
|
||||
## #39 — Run↔Walk cycle transition not visible on observed player remotes (acdream-as-observer)
|
||||
|
||||
**Status:** OPEN
|
||||
**Severity:** MEDIUM (visible animation desync; not a correctness/wire bug)
|
||||
**Status:** OPEN — VERIFY-PENDING (cases #1/#2/#4/#5 user-verified working 2026-05-06; cases #3/#6/#7 unverified in live test)
|
||||
**Severity:** LOW (most cases now visibly correct after the 2026-05-06 fix sequence; remaining unverified cases are direction-flip — believed to work via direct UM but not explicitly exercised)
|
||||
**Filed:** 2026-05-03
|
||||
**Component:** physics / motion / animation
|
||||
|
||||
|
|
@ -678,6 +710,7 @@ the local terrain normal, not the actor's facing.
|
|||
**Severity:** LOW (within retail's own DesiredDistance / MinDistance tolerances; visible only on close inspection)
|
||||
**Filed:** 2026-05-05
|
||||
**Component:** physics / motion / animation (per-tick remote prediction)
|
||||
**Phase:** L.2 (Movement & Collision Conformance) — inbound-motion fidelity sub-piece. Blocked on cdb-trace of `CSequence::velocity` for Humanoid running cycle, then porting `add_motion @ 0x005224b0`'s `style_speed × MotionData.velocity` chain.
|
||||
|
||||
**Description:** With the L.3 M3 path live (queue catch-up + animation
|
||||
root motion fallback), observed player remotes chase server position
|
||||
|
|
@ -926,13 +959,35 @@ collision fixes.)
|
|||
still resolve correctly)
|
||||
- Observer view from a parallel retail client unchanged
|
||||
|
||||
## #37 — Humanoid coat doesn't extend up to neck (visible "skin stub" between hair and coat)
|
||||
## #37 — [DONE 2026-05-11 · resolved by `0bd9b96`] Humanoid coat doesn't extend up to neck (visible "skin stub" between hair and coat)
|
||||
|
||||
**Status:** OPEN
|
||||
**Status:** DONE
|
||||
**Closed:** 2026-05-11
|
||||
**Commit:** `0bd9b96` (the #47 humanoid degrade-resolver fix, 2026-05-06)
|
||||
**Severity:** LOW (cosmetic; doesn't affect gameplay)
|
||||
**Filed:** 2026-05-01
|
||||
**Component:** rendering / clothing / textures
|
||||
|
||||
**Resolution:** Closed by the same mesh-fidelity work that resolved #47.
|
||||
The `GfxObjDegradeResolver` (commit `0bd9b96`, 2026-05-06) swapped
|
||||
humanoid parts to their higher-detail `Degrade[0].Id` meshes (e.g.
|
||||
upper arm `0x01000055 → 0x01001795`, lower arm `0x01000056 → 0x0100178F`).
|
||||
The higher-detail meshes include the coat-collar polygons that the
|
||||
low-detail meshes were missing — which is what was exposing the
|
||||
skin-toned palette indices in the upper-coat region. With the
|
||||
correct mesh resolution, those polygons cover the previously-visible
|
||||
"skin stub". User confirmed visually 2026-05-11.
|
||||
|
||||
The original 2026-05-01/2026-05-04 investigation work (palette range
|
||||
analysis, SubPalette overlay tracing) is preserved below for
|
||||
historical reference; it was a correct read of *what* was rendering,
|
||||
but the root cause was the missing collar polygons, not the palette
|
||||
gap.
|
||||
|
||||
---
|
||||
|
||||
**Original investigation (kept for reference):**
|
||||
|
||||
**Description:** Every humanoid character (player + NPCs) wearing a coat
|
||||
shows a visible skin-colored region at the top of the coat where retail
|
||||
shows continuous coat fabric. From the back view: hair → skin stub →
|
||||
|
|
@ -1276,13 +1331,29 @@ in under 5 minutes by following the CLAUDE.md workflow.
|
|||
|
||||
---
|
||||
|
||||
## #36 — Sky-PES dispatch port (consolidates #2 / #28 / #29 visual gaps)
|
||||
## #36 — [DONE 2026-05-11 · promoted to Phase C.1.5c] Sky-PES dispatch port (consolidates #2 / #28 / #29 visual gaps)
|
||||
|
||||
**Status:** OPEN
|
||||
**Status:** DONE (promoted to Phase C.1.5c)
|
||||
**Closed:** 2026-05-11
|
||||
**Promoted to:** Phase C.1.5c (Sky-PES dispatch chain) — see roadmap `docs/plans/2026-04-11-roadmap.md`
|
||||
**Severity:** MEDIUM (aesthetic feature-parity, but addresses a cluster of bugs)
|
||||
**Filed:** 2026-04-30
|
||||
**Component:** sky / weather / particles
|
||||
|
||||
**Resolution:** Promoted to a roadmap phase (C.1.5c) — the work is
|
||||
multi-commit (decomp dive + persistent-emitter creation + PES timeline
|
||||
driver + PES script execution + live-trace verification) and warrants
|
||||
a named phase rather than living forever as an "open issue." The
|
||||
decomp anchors, live-trace evidence (24,576-frame `GameSky::Draw`
|
||||
trace), and 6-step implementation outline in the body below remain
|
||||
the authoritative implementation reference; the roadmap phase entry
|
||||
is the schedule/scope tracker. **Issues #2 (lightning), #28 (aurora),
|
||||
and #29 (cloud thinness) auto-close when C.1.5c ships.**
|
||||
|
||||
---
|
||||
|
||||
**Original investigation (kept as implementation reference):**
|
||||
|
||||
**Description:** Three open sky bugs (#2 lightning, #28 aurora, #29 cloud
|
||||
density) all trace back to the same missing infrastructure: retail's
|
||||
sky-PES (Particle Effect Script) dispatch chain. We have it now from a
|
||||
|
|
@ -1427,6 +1498,7 @@ one live creature case no longer use the single-cylinder fallback.
|
|||
**Severity:** MEDIUM
|
||||
**Filed:** 2026-04-25
|
||||
**Component:** net / sky
|
||||
**Chore tag:** Single-commit fix — well-scoped ~10-line wiring. `WorldTimeService.SyncFromServer(double)` already exists; just needs `WorldSession` to detect header-flag `0x1000000` and call it. Pickup at any opportunistic session.
|
||||
|
||||
**Description:** Our `WorldTimeService.DayFraction` syncs with the server once at login via `ConnectRequest + TimeSync`, then advances from the local wall-clock. Retail receives periodic `TimeSync` refreshes (header flag `0x1000000`) carrying a fresh `PortalYearTicks double` and re-anchors its clock. Without those, acdream's keyframe state drifts from retail's over 10+ minutes — observed during the 2026-04-24 sky-color debug sessions where retail was at DayFraction 0.976 while acdream was at 0.634.
|
||||
|
||||
|
|
@ -1456,6 +1528,8 @@ one live creature case no longer use the single-cylinder fallback.
|
|||
|
||||
**Root cause / status:** Three competing hypotheses, none pinned down: (a) retail uses a **different** fog range for sky than terrain; (b) retail applies fog with an **elevation-angle** weighting rather than linear distance; (c) retail's sky meshes **don't participate** in the global fog and the "horizon glow" comes from a different atmospheric-scatter path. Need to identify retail's actual sky-fog behaviour before re-enabling with correct parameters.
|
||||
|
||||
**Not in the Phase C.1.5c (Sky-PES) cluster.** Unlike #2/#28/#29 — all PES-driven sky visuals consolidated under the C.1.5c phase via former issue #36 — this is a fragment-shader fog-mix problem. Addressing C.1.5c will NOT resolve #4, and #4 should NOT be bundled into Phase C.1.5c scope. The fix likely needs its own decomp dive into retail's sky-fog math + shader work.
|
||||
|
||||
**Files:**
|
||||
- `src/AcDream.App/Rendering/Shaders/sky.frag` — line ~55, `rgb = mix(uFogColor.rgb, rgb, vFogFactor)` currently commented out
|
||||
- `src/AcDream.App/Rendering/Shaders/sky.vert` — lines 109-114, `vFogFactor` computation
|
||||
|
|
@ -1686,6 +1760,7 @@ retail show matching silhouette and shape definition.
|
|||
**Severity:** MEDIUM (degrades external perception of acdream-driven characters)
|
||||
**Filed:** 2026-05-06
|
||||
**Component:** net / motion (acdream's outbound path: `PlayerMovementController` → `MoveToState` (0xF61C) / `AutonomousPosition` heartbeat → ACE → retail observer)
|
||||
**Phase:** L.2 (Movement & Collision Conformance) — outbound-motion fidelity sub-piece. Counterpart to #41 (which is the inbound side); both are L.2 conformance work. If outbound fidelity grows into multi-commit work, consider carving "L.2e — Outbound motion fidelity" as a named sub-piece on the roadmap.
|
||||
|
||||
**Description:** When viewing acdream's local +Acdream character through a parallel retail acclient.exe, the retail observer sees the character's movement as visibly blippy and laggy — position appears to step in discrete jumps rather than translating smoothly. The local acdream view of the same character looks fine, and acdream observing a retail-driven character (after #39 / #45) also looks fine. The degradation is specifically on the **outbound** side: what acdream sends to ACE for relay to other clients.
|
||||
|
||||
|
|
|
|||
|
|
@ -1,6 +1,6 @@
|
|||
# acdream — strategic roadmap
|
||||
|
||||
**Status:** Living document. Updated 2026-05-10 for Phase A.5 shipping (two-tier streaming N₁=4/N₂=12 + QualityPreset system + Bug A/B fixes; closes the two-tier streaming spec). Post-A.5 polish (Tier 1 retry + lifestone fix + JobKind plumbing) is now the in-flight work.
|
||||
**Status:** Living document. Updated 2026-05-11. **In flight: Phase C.1.5b** (issue #56 per-part transforms for multi-emitter PES + EnvCell static-object `DefaultScript` walker); pickup at [`docs/plans/2026-05-12-phase-c1.5b-handoff.md`](2026-05-12-phase-c1.5b-handoff.md). **Since the last header update:** post-A.5 polish completed (#52 lifestone, #54 JobKind, #53 Tier 1 cache); N.6 slice 1 shipped (gpu_us fix + radius=12 perf baseline, conclusion CPU dominates GPU 30–50×); C.1.5a shipped (portal PES wiring; surfaced #56 for C.1.5b to resolve).
|
||||
**Purpose:** One source of truth for where the project is and where it's going. Every observed defect or missing feature has a named phase that owns it; when something looks wrong in-game, look here to find the phase that'll address it. Implementation details live in per-phase specs under `docs/superpowers/specs/`, not in this file.
|
||||
|
||||
---
|
||||
|
|
@ -122,6 +122,10 @@ Plus polish that doesn't get its own phase number:
|
|||
|
||||
**Sub-pieces:**
|
||||
- **✓ SHIPPED — C.1 — VFX / particle system + sky-pass refinements.** Retail-faithful `ParticleEmitterInfo` runtime + 13-type motion integrator port + `PhysicsScript` runner + instanced billboard renderer with material-derived blend + global back-to-front sort + AttachLocal live-parent follow. Sky-pass refinements: Translucent+ClipMap alpha-blend, raw-Additive fog-skip, per-keyframe SkyObjectReplace divide-by-100, sampler-object wrap selection (ported from WorldBuilder), gated post-scene Z-offset. Sky-PES disabled by default — named-retail decomp proves `GameSky` drops `pes_id`. **Portal swirls, chimney smoke, fireplace flames** still need a Phase C.1.5 follow-up to wire entity-attached emitters to retail effect IDs (the data layer is ready; only the wiring is deferred). Lands as merge `feat(vfx): Phase C.1 — PES particle renderer + post-review fixes` (`ec1bbb4`) + `refactor(sky): replace per-frame wrap-mode mutation with persistent samplers` (`3d21c13`).
|
||||
- **C.1.5 — entity-attached PES wiring (sliced).** Three sub-slices wiring `PhysicsScript` / `DefaultScript` dispatch to the entity lifecycle so portals, chimneys, fireplaces, and sky effects animate per retail:
|
||||
- **✓ SHIPPED — C.1.5a (portals)** — 2026-05-11 (merge `88bda12`). `EntityScriptActivator` fires `Setup.DefaultScript` on every server-spawned `WorldEntity` via `PhysicsScriptRunner`. Visual-verified at Holtburg Town network portal. Surfaced known limitation as issue #56 (per-part transform handling) — addressed in C.1.5b. Plan archived at [`docs/superpowers/plans/2026-05-12-phase-c1.5a-portals.md`](../superpowers/plans/2026-05-12-phase-c1.5a-portals.md).
|
||||
- **IN FLIGHT — C.1.5b (per-part transforms + EnvCell static walker).** Fix issue #56 first (every multi-emitter PES on a multi-part entity — portals, chimneys, fireplaces — currently collapses to entity root because `ParticleHookSink` ignores `CreateParticleHook.PartIndex`), then add EnvCell static-object `DefaultScript` walker for chimney smoke + fireplace flames. Pickup at [`docs/plans/2026-05-12-phase-c1.5b-handoff.md`](2026-05-12-phase-c1.5b-handoff.md).
|
||||
- **PLANNED — C.1.5c (sky-PES dispatch chain).** Promoted from former issue #36 (2026-05-11 triage). Ports retail's persistent-emitter creation on celestial / sky objects + the PES timeline driver (`CallPESHook::Execute` → `CPhysicsObj::CallPES` → `create_particle_emitter`) that drives them ~150×/min. Decomp anchors + live-trace evidence + 6-step impl outline in closed issue [#36](../ISSUES.md#36). **Closes #2 (lightning), #28 (aurora), #29 (cloud thinness) when shipped.** Does NOT close #4 (sky horizon-glow fog) — that's shader work, not PES.
|
||||
- **C.2 — Dynamic point lights.** Fireplaces and lamps need local lighting; small upgrade to the mesh shader to accumulate N (e.g., 4) nearest point lights per draw. Uniform-buffer or UBO-friendly layout.
|
||||
- **C.3 — Palette range tuning.** Small per-range offset/length tweaks to match retail skin/hair/eye colors. Mostly diff and verify work, no architecture change.
|
||||
- **C.4 — Double-sided translucent polys.** Edge case left by Phase 9.2: neg-side translucent polys are culled because cull is always BACK. Fix by tracking per-sub-mesh `CullMode` and flipping GL state per draw (or drawing twice with opposite cull). Minor.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue