refactor(app): make session start terminal
Move live-session startup and its existing diagnostics into the typed Phase-9 owner. GameWindow.OnLoad now ends immediately after that phase, so no callback binding, publication, or allocation can occur after the session becomes active. Co-authored-by: Codex <codex@openai.com>
This commit is contained in:
parent
3628aeb520
commit
54244d31f1
11 changed files with 139 additions and 39 deletions
|
|
@ -35,9 +35,10 @@ What does NOT go here:
|
|||
every late edge explicitly. I.8a now owns the focused session factory,
|
||||
command targets, and sole gameplay input subscriber before frame publication.
|
||||
I.8b now owns the complete update/render construction, exact atomic frame
|
||||
publication, and lifecycle resource snapshot source. `GameWindow.OnUpdate`
|
||||
and `GameWindow.OnRender` are typed orchestration handoffs and the class is
|
||||
1,919 raw lines. I.8c–I.9 plus the remaining
|
||||
publication, and lifecycle resource snapshot source. I.8c makes session
|
||||
start the terminal `OnLoad` operation. `GameWindow.OnUpdate` and
|
||||
`GameWindow.OnRender` are typed orchestration handoffs and the class is
|
||||
1,910 raw lines. I.9 plus the remaining
|
||||
shutdown/closeout
|
||||
cleanup is active in
|
||||
[`docs/architecture/code-structure.md`](architecture/code-structure.md).
|
||||
|
|
|
|||
|
|
@ -739,10 +739,11 @@ diagnostic command targets, and sole gameplay input subscriber into Phase 7
|
|||
before frame publication. I.8b moves the complete update/render construction
|
||||
body into `FrameRootCompositionPhase`, publishes the pair through an exact
|
||||
lease, and gives lifecycle resource sampling a focused source. `GameWindow` is
|
||||
1,919 raw lines. I.8c–L remain active, with terminal session start next. The
|
||||
App gate passes 3,429 tests / 3 intentional skips and the complete Release suite
|
||||
passes 7,801 tests / 5 intentional skips. The clean solution build retains only
|
||||
the 17 test-project warnings tracked by #228; the I.8b corrected-diff review is
|
||||
1,910 raw lines after I.8c makes live-session start the terminal `OnLoad`
|
||||
operation. I.9–L remain active, with the complete Checkpoint-I audit next. The
|
||||
App gate passes 3,430 tests / 3 intentional skips and the complete Release suite
|
||||
passes 7,802 tests / 5 intentional skips. The clean solution build retains only
|
||||
the 17 test-project warnings tracked by #228; the I.8c corrected-diff review is
|
||||
clean.
|
||||
|
||||
### 4.4 Exit criteria
|
||||
|
|
|
|||
|
|
@ -104,11 +104,11 @@ controllers, selection/radar, landblock publishers, and portal/sky/particle
|
|||
resources have transactional phase ownership and exact-owner late bindings.
|
||||
I.7 adds the complete streaming/session/hydration/local-player/teleport phase,
|
||||
including explicit reversible ownership for every late edge. `GameWindow` is
|
||||
now 1,919 raw lines after I.8b, which also composes and atomically publishes the
|
||||
complete update/render pair and extracts lifecycle resource sampling. I.8c–I.9,
|
||||
shutdown, canonical soak snapshots, and closeout checkpoints J–L remain. The
|
||||
App gate passes 3,429 tests / 3 intentional skips, the complete Release suite
|
||||
passes 7,801 tests / 5 skips, and the I.8b corrected-diff review is clean.
|
||||
now 1,910 raw lines after I.8c, which makes session start the terminal `OnLoad`
|
||||
operation. I.9, shutdown, canonical soak snapshots, and closeout checkpoints
|
||||
J–L remain. The App gate passes 3,430 tests / 3 intentional skips, the complete
|
||||
Release suite passes 7,802 tests / 5 skips, and the I.8c corrected-diff review
|
||||
is clean.
|
||||
|
||||
This is a behavior-preserving structural program. Severe regressions still get
|
||||
root-cause fixes in separate commits; ordinary feature work resumes with M4
|
||||
|
|
|
|||
|
|
@ -62,11 +62,12 @@ session, hydration, local-player, combat, and teleport startup graph, including
|
|||
named reversible late edges. I.8a adds the focused live-session runtime factory
|
||||
and attaches command/input owners before frame publication. I.8b composes and
|
||||
atomically publishes the complete frame pair and extracts lifecycle resource
|
||||
sampling. `GameWindow` is 1,919 raw lines. I.8c–I.9 and checkpoints J–L remain
|
||||
active. Issue #232 tracks
|
||||
sampling. I.8c makes session start the terminal `OnLoad` operation.
|
||||
`GameWindow` is 1,910 raw lines. I.9 and checkpoints J–L remain active. Issue
|
||||
#232 tracks
|
||||
process-residency variance in the soak without loosening its leak threshold.
|
||||
The App gate passes 3,429 tests / 3 skips, the complete Release suite passes
|
||||
7,801 tests / 5 skips, and the I.8b corrected-diff review is clean.
|
||||
The App gate passes 3,430 tests / 3 skips, the complete Release suite passes
|
||||
7,802 tests / 5 skips, and the I.8c corrected-diff review is clean.
|
||||
|
||||
Carried:
|
||||
#153 far-teleport residual, #116 slide-response, the remaining R6 ownership cleanup plus
|
||||
|
|
|
|||
|
|
@ -297,8 +297,10 @@ ledger only after the complete pipeline is live.
|
|||
input subscriber now belong to Phase 7 and publish before any frame root.
|
||||
I.8b composes the unchanged update/render graph in a focused phase, publishes
|
||||
the pair through an exact owned slot lease, and moves lifecycle resource
|
||||
sampling out of the window. `GameWindow.cs` is 1,919 raw lines. I.8c terminal
|
||||
session start is the active cut.
|
||||
sampling out of the window. I.8c makes the exact session start and its
|
||||
existing diagnostics the terminal `OnLoad` operation. `GameWindow.cs` is
|
||||
1,910 raw lines. I.9 corrected-diff review and documentation closeout is the
|
||||
active cut.
|
||||
Checkpoint I remains active until I.9 closes the complete nine-phase pipeline.
|
||||
|
||||
## 6. Automated acceptance
|
||||
|
|
|
|||
|
|
@ -1,6 +1,6 @@
|
|||
# GameWindow Slice 8 — Checkpoint I.8 Frame Roots and Session Start
|
||||
|
||||
**Status:** Active — I.8a–I.8b complete; I.8c terminal start next
|
||||
**Status:** Complete 2026-07-22
|
||||
|
||||
**Parent:** `2026-07-22-gamewindow-slice-8-checkpoint-i-ordered-composition.md`
|
||||
|
||||
|
|
@ -144,6 +144,12 @@ shutdown. Replacement is rejected atomically.
|
|||
|
||||
## 4. I.8c — terminal start and window cutover
|
||||
|
||||
**Completed 2026-07-22.** `SessionStartCompositionPhase` invokes the exact
|
||||
Phase-7 host through the Phase-8 result and owns the existing missing-credential
|
||||
and failed-start diagnostics. The phase call is the final statement in
|
||||
`GameWindow.OnLoad`; no binding, publication, allocation, or diagnostics setup
|
||||
follows it.
|
||||
|
||||
Add `SessionStartCompositionPhase` implementing
|
||||
`ISessionStartCompositionPhase<FrameRootResult>`. It invokes only
|
||||
`LiveSessionHost.Start(RuntimeOptions)` and preserves the existing diagnostics
|
||||
|
|
|
|||
|
|
@ -29,8 +29,8 @@ audit.
|
|||
- [x] H — give terrain atlas, sky shader, retained `UiHost`, and both frame roots
|
||||
explicit single ownership and transfer seams.
|
||||
- [ ] I — group `OnLoad` into small ordered, fakeable composition phases with
|
||||
transactional partial-acquisition rollback. I.1–I.8b are complete; I.8c
|
||||
terminal session start is active. Detailed plan:
|
||||
transactional partial-acquisition rollback. I.1–I.8 are complete; I.9
|
||||
corrected-diff review and checkpoint closeout is active. Detailed plan:
|
||||
[`2026-07-22-gamewindow-slice-8-checkpoint-i-ordered-composition.md`](2026-07-22-gamewindow-slice-8-checkpoint-i-ordered-composition.md).
|
||||
- [ ] J — move the exact retryable shutdown manifest to a focused lifetime
|
||||
owner and prove all partial-load/reentrant/retry paths.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue