test: remove final campaign labels
This commit is contained in:
parent
088add2fac
commit
53b6841c5a
8 changed files with 44 additions and 11 deletions
|
|
@ -95,7 +95,7 @@ override, no `ClickThrough` write, no `ConsumesDatChildren` override, and its
|
|||
**Do the new pins assert failure modes rather than class names?** Yes, on three
|
||||
of the four axes, with one weaker:
|
||||
|
||||
- **Media drawn** — `OP2ReworkBlastRadiusConformanceTests.cs:48-49`:
|
||||
- **Media drawn** — `DormantDatWidgetConformanceTests.cs:48-49`:
|
||||
`(uint file, int _) = backdrop.ActiveMedia(); Assert.NotEqual(0u, file);`
|
||||
This is the actual draw input, not a class name. ✅
|
||||
- **Click-through** — `:47`, `:67`, `:90`, `:106`, `:155`: `Assert.True(...ClickThrough)`
|
||||
|
|
@ -189,7 +189,7 @@ Three independent checks, all measured:
|
|||
new members are public *fields* (`ElementReader.cs:192`, `:199`, `:207`) and
|
||||
`FixtureLoader` deserializes with `IncludeFields = true`
|
||||
(`FixtureLoader.cs:14-17`), so the fixture path now reads real projected
|
||||
values. Concretely: `OP2ReworkBlastRadiusConformanceTests.cs:64` asserts
|
||||
values. Concretely: `DormantDatWidgetConformanceTests.cs:64` asserts
|
||||
`host.Tabs.Count == 3` and `:127` asserts `== 8` — values that were empty
|
||||
under the stale fixtures. The structural false negative is gone.
|
||||
|
||||
|
|
@ -387,7 +387,7 @@ dat children of their own"), and I verified it — all 16 Type-5 elements, all 3
|
|||
fixtures, zero children.
|
||||
|
||||
**No test pins it.** Worse, the closest pin cannot distinguish the two outcomes:
|
||||
`OP2ReworkBlastRadiusConformanceTests.cs:153` asserts
|
||||
`DormantDatWidgetConformanceTests.cs:153` asserts
|
||||
`Assert.Empty(host.Children)` on effects `0x10000123`, which passes both when no
|
||||
viewport was injected (intended) *and* when authored children were silently
|
||||
consumed (the failure). A future dat/importer change that gives any of the ten a
|
||||
|
|
@ -406,7 +406,7 @@ defensible for the child-count premise, which is per-element.
|
|||
|
||||
### NOTE 1 — the state-propagation pin is a capability assertion
|
||||
|
||||
`OP2ReworkBlastRadiusConformanceTests.cs:91`, `:107` assert
|
||||
`DormantDatWidgetConformanceTests.cs:91`, `:107` assert
|
||||
`IsAssignableFrom<IUiDatStateful>`, not that a `PassToChildren` state actually
|
||||
reached a child. Sound in practice because `TrySetRetailState` is non-virtual
|
||||
(`UiDatElement.cs:86`), so no subclass can diverge — but it is the one MUST-FIX-1
|
||||
|
|
|
|||
|
|
@ -201,7 +201,7 @@ Gap (NOTE, not a miss of the round-1 finding): none of the five exercises
|
|||
`ReadStructMemberId`'s `Enum`/`DataId`/`Integer` kind coercion — every test uses
|
||||
`Enum`. A regression narrowing that coercion would still slip through.
|
||||
|
||||
The blast-radius pins (`OP2ReworkBlastRadiusConformanceTests.cs`) are the other half
|
||||
The blast-radius pins (`DormantDatWidgetConformanceTests.cs`) are the other half
|
||||
of the answer: six built-widget tests across the five pre-existing Type-8 elements and
|
||||
one representative Type-5, asserting `BehaviorActive == false`,
|
||||
`ActivePageElementId == 0`, `ClickThrough == true`, non-zero `ActiveMedia()` on the
|
||||
|
|
|
|||
|
|
@ -334,7 +334,7 @@ makes expression and doc agree by construction.
|
|||
|
||||
### R3 — SHOULD-FIX: the dormant-`ActivePageChanged` pin applies no stimulus
|
||||
|
||||
`tests/AcDream.App.Tests/UI/Layout/OP2ReworkBlastRadiusConformanceTests.cs:83-93`:
|
||||
`tests/AcDream.App.Tests/UI/Layout/DormantDatWidgetConformanceTests.cs:83-93`:
|
||||
|
||||
```csharp
|
||||
var host = Assert.IsType<UiTabPanel>(layout.FindElement(0x100000B8u));
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue