fix(ui): OP2 re-review closure (coordinator pass) — AP-195, tooltip port, zero-children pin
Closes the mechanism lens's REOPEN (one MUST-FIX) and both lenses' small
residuals on the OP2 rework (b236a442); the blast lens re-review was
CLOSED outright. Fable-direct per the two-failure escalation rule.
- AP-195 filed: UIOption_CheckboxBitfield64 ports HALF of Refresh
@0x004859C0 — the ANY-set checkbox predicate is exact, but the ALL-set
LED media swap (P0x10000082=0x06004D17 / P0x10000083=0x06004D19) and
the ListBox self-sizing tail (ResizeTo/CalculatePaperSize — the block
IS a UIElement_ListBox in retail) are unported, and the block's row
stacking is a second divergent implementation beside UiTemplateListBox.
All due at OP5 before the Chat tab's connected gate; the IsSet doc
comment now names both halves instead of quoting only the ported one.
- Row tooltips: UiButton gains settable TooltipText surfaced through the
shared GetTooltipText hover pipeline (UiCatalogSlot's pattern);
UiCheckboxBitfield64.AddChild applies the row tooltip retail stamps in
CreateChildren @0x00485DF0, and documents that the 0x10000084 row-index
attribute stamp is deliberately replaced by the typed mask closure.
- AD-73 addendum: UiTemplateListBox.ConsumesDatChildren=true is inert
only while no authored Type-5 element carries children — that premise
is now conformance-PINNED across all 32 fixtures (a future DAT
regeneration surfacing an authored child fails the build instead of
silently dropping it).
- Plan doc: OP2's contract names UiTabPanel.cs (retail UIElement_Panel),
not the fictional-class-named UiTabControl.cs; ledger records OP1 and
OP2 both CLOSED.
Full Release suite: 12,871 passed / 4 skipped / 0 failed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
6f48e34152
commit
5242de9f15
7 changed files with 943 additions and 6 deletions
|
|
@ -178,7 +178,9 @@ byte-exact; both adapters share one code path for the local write.
|
|||
`0x2E` (struct array `{0x30 button, 0x31 page, 0x32 isDefault}`) and
|
||||
ListBox template-list property `0x64` (entries `{0x63 layout DID,
|
||||
0x62 element id}`) into `ElementInfo`.
|
||||
- Create `src/AcDream.App/UI/UiTabControl.cs` (element Type 8): tab-button
|
||||
- Create `src/AcDream.App/UI/UiTabPanel.cs` (element Type 8 — retail
|
||||
`UIElement_Panel`; renamed from this plan's original `UiTabControl` at the
|
||||
OP2 rework, and a dormant `UiDatElement` subclass per AD-73): tab-button
|
||||
↔ page-slot switching per lane A §5; default tab honoured.
|
||||
- Create `src/AcDream.App/UI/UiTemplateListBox.cs` (element Type 5 with
|
||||
authored template list): `AddItemFromTemplateList(index)` instantiates a
|
||||
|
|
@ -415,8 +417,8 @@ before anything builds on them.
|
|||
|
||||
| Slice | Status | Commit(s) | Review | Gate |
|
||||
|---|---|---|---|---|
|
||||
| OP1 | CLOSED (residuals R1/R2 owed to a coordinator pass) | `86c0a7e0` + fixes `09029f9f` | dual APPROVE-WITH-FIXES (`2026-08-10-op1-review-{mechanism,blast}.md`) → re-review CLOSED (`2026-08-11-op1-rereview.md`) | automated only — n/a |
|
||||
| OP2 | REWORK round 1 in flight | `df9c7a35` (REJECTED) | dual REJECT (`2026-08-11-op2-review-{mechanism,blast}.md`) | |
|
||||
| OP1 | CLOSED | `86c0a7e0` + fixes `09029f9f` + residuals `6f48e341` | dual APPROVE-WITH-FIXES (`2026-08-10-op1-review-{mechanism,blast}.md`) → re-review CLOSED (`2026-08-11-op1-rereview.md`); residuals R1/R2/R3 landed | automated only — n/a |
|
||||
| OP2 | CLOSED | `df9c7a35` (REJECTED) → rework `b236a442` → closure (this commit) | dual REJECT (`2026-08-11-op2-review-{mechanism,blast}.md`) → re-review blast CLOSED / mechanism REOPEN-on-one (`2026-08-11-op2-rereview-{mechanism,blast}.md`) → coordinator closure: AP-195 filed, AD-73 addendum, tooltip port, zero-children pin | automated only — n/a |
|
||||
| OP3 | — | | | |
|
||||
| OP4 | — | | | |
|
||||
| OP5 | — | | | |
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue