refactor(render): remove Campaign FW probes

This commit is contained in:
Erik 2026-08-31 09:14:47 +02:00
parent b8befded8b
commit 4808d4d10b
10 changed files with 1 additions and 241 deletions

View file

@ -160,43 +160,6 @@ public static class RenderingDiagnostics
public static bool ProbeClipRouteEnabled { get; set; } =
Environment.GetEnvironmentVariable("ACDREAM_PROBE_CLIPROUTE") == "1";
/// <summary>
/// Campaign FW3.2b-2 flip apparatus (2026-08-30): when true and the walk
/// registries are wired, RetailPViewRenderer runs the PRODUCTION retail
/// frame walk per frame in SHADOW (no draws change) and emits one
/// [walk-shadow] line per frame whose cell/building sets diverge from the
/// old visibility path — the I5 dual-shadow pattern applied to the FW3
/// static cutover. Throwaway apparatus — dies with the flip commit.
/// </summary>
public static bool ProbeWalkShadowEnabled { get; set; } =
Environment.GetEnvironmentVariable("ACDREAM_PROBE_WALK_SHADOW") == "1";
/// <summary>
/// FW3 visual-gate apparatus (2026-08-30, throwaway — dies with the
/// stairwell-transition fix): when true, RetailPViewRenderer prints one
/// <c>[walk-root]</c> line per frame for the 8 frames after every
/// interior/outdoor ROOT flip — viewer cell, resolution, slice count,
/// and the walk's visited cell list — pinning which frames draw grass
/// over floor openings during a doorway crossing and why.
/// </summary>
public static bool ProbeWalkRootEnabled { get; set; } =
Environment.GetEnvironmentVariable("ACDREAM_PROBE_WALK_ROOT") == "1";
/// <summary>Companion scratch for <see cref="ProbeWalkRootEnabled"/>
/// (throwaway, same investigation): the frame phase relative to the
/// interior depth clear ("pre"/"post"), stamped by the pass executor so
/// particle/alpha probe lines can tag WHEN a submission or drain ran.
/// Written only while the probe is on.</summary>
public static string WalkRootPhase = "";
/// <summary>Companion scratch for <see cref="ProbeWalkRootEnabled"/>
/// (throwaway, same investigation): true on the frames (~every 90th)
/// where the walk's PView logs its per-portal seen/in-view/clip
/// decisions as <c>[walk-portal]</c> lines — pins WHY an exit view
/// collapses at a given camera pose. Set by the renderer before
/// Collect; read by WalkPView.</summary>
public static bool WalkPortalProbeThisFrame;
/// <summary>
/// Bounded-propagation port apparatus (2026-06-08). When true, PortalVisibilityBuilder.Build emits
/// one [portal-churn] summary line per call: per-cell pop count (re-pops = churn), total re-enqueues,

View file

@ -321,9 +321,6 @@ public sealed class ParticleSystem : IParticleSystem
rangeMultiplier = 1f;
LastRetailViewEmitterVisitCount = 0;
_probeAdmissionDumpThisCall =
AcDream.Core.Rendering.RenderingDiagnostics.ProbeWalkRootEnabled
&& ++_probeAdmissionCallCounter % 120 == 0;
foreach (int handle in _worldSimulationHandles)
{
if (!_byHandle.TryGetValue(handle, out ParticleEmitter? emitter))
@ -349,33 +346,9 @@ public sealed class ParticleSystem : IParticleSystem
|| float.IsNaN(maxDistance)
|| distance <= maxDistance);
RefreshRenderableIndex(emitter, wasRenderable);
// ACDREAM_PROBE_WALK_ROOT companion (Phase I cathedral
// instrumentation, throwaway): admission verdicts for the F418
// watch set — the real falls owners 0xCF418000-13 and every
// F418-cell emitter — every ~120th ApplyRetailView pass.
if (_probeAdmissionDumpThisCall
&& AcDream.Core.Rendering.RenderingDiagnostics.ProbeWalkRootEnabled
&& ((emitter.AttachedObjectId >= 0xCF418000u
&& emitter.AttachedObjectId <= 0xCF418014u)
|| (emitter.OwnerCellId >> 16) == 0xF418u))
{
Console.WriteLine(
$"[falls-adm] owner={emitter.AttachedObjectId:x} "
+ $"cell={emitter.OwnerCellId:x8} "
+ $"pos=({emitter.OwnerPosition.X:F1},{emitter.OwnerPosition.Y:F1},{emitter.OwnerPosition.Z:F1}) "
+ $"dist={distance:F1} max={maxDistance:F1} "
+ $"inSet={(visibleCellIds.Contains(emitter.OwnerCellId) ? 1 : 0)} "
+ $"eligible={(emitter.ViewEligible ? 1 : 0)} "
+ $"active={emitter.ActiveCount} pass={emitter.RenderPass}");
}
}
}
// Phase I instrumentation rate limiter (see the probe block above).
private static uint _probeAdmissionCallCounter;
private static bool _probeAdmissionDumpThisCall;
/// <summary>
/// Changes only render presentation. Logical lifetime is unaffected.
/// </summary>