docs(vt): slice 7 ledger — Monsters landed; fix round A dispatched

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-09-07 08:20:10 +02:00
parent cfa7030659
commit 47a1fe555c

View file

@ -94,3 +94,4 @@ re-review, merge to the campaign branch, then the owner's visual gate.
- 2026-09-07 S7.1/S7.2 landed on `worktree-agent-a46673911c3cc2a31` (`e72a64a31` slider min/max + menu scroll, `f6eebf8c5` TryLoadNav refuses STATE:, `a7b132282` window + Options/Profiles/Vitals; MossTank suite 640 → 645). Lead's note for the review: the implementer made the panel 856×350 to fit the Advanced Options / Loot Editor groups in-panel; VTank's main window is 856×210 with those two as SEPARATE popups. Fix-round candidate: register them as separate plugin panels (own windows via `IUiRegistry`) so the main panel returns to 210 tall. Screenshots not captured — the implementer (and the lead) probed 127.0.0.1:9000 over TCP; ACE listens on UDP and was up the whole time. Lesson: never probe ACE with `Test-NetConnection`/TCP — launch the client and read its log. Screenshots are owed at the next worktree boundary. S7.3 (Monsters) dispatched on the same worktree.
- 2026-09-07 07:55 live screenshots of `89a49836c` captured (gate worktree, ACE up — the earlier "ACE down" was a TCP probe against a UDP server) → `docs/research/2026-09-07-slice7-screenshots/` (cropped to the panel, 864×360). Lead's read for the review + fix round: (1) Vitals reads like VTank; (2) Options has the right arrangement but VTank's literal `L,T,W,H` do not fit our DAT font — captions overlap the next row ("Follow/Nav Min Distance" over "Enable Navigation"): scale VTank's geometry to our font (row pitch from the DAT font's line height instead of VVS's 16 px; widths likewise), keep the proportions, never pixel-match; (3) Profiles still shows legacy controls (three stacked "New" buttons, the Loot engine row, the macro-profile path string drawn twice) — delete them; (4) the window is 856×350 with ~180 px of dead space below the content: bring the main panel back to VTank's 210-tall proportion (scaled) and make Advanced Options / Loot Editor their own plugin panels (separate windows, like VTank's popups) instead of in-panel groups; (5) the Route, Meta and Loot-editor pages show blank trailing button slots.
- 2026-09-07 08:05 owner looked at the live gate build: (a) "The Options tab labels overlap, fix that"; (b) "Those BIG gold/yellow buttons HAS to go. That is not how vtank looks." — the plugin `<menu>` renders retail's gold pushbutton art; VTank's combos are plain (flat dark box, thin border, value text, small arrow at right — the same look as its lists). Fix round: plugin-markup `<menu>` draws the plain combo by default (a `style="retail"` opt-in keeps the gold art for anyone who wants it), plus the geometry scaling, the Profiles leftovers, the 210-tall main window and the two popups as separate panels.
- 2026-09-07 09:10 S7.3 Monsters landed on the panel worktree (`57ced0aff`, `c3b4f7862`; MossTank suite 645 → 651): the 23-column grid with VTank's exact cycle lists (P 1…4; Dmg type 14 values; Ex. Vuln 9; PetDmg 10; name click deletes; arrows reorder with DEFAULT pinned). Implementer deviations for the review: Weapon/Offhand cycle MossTank's registered item roster instead of VTank's opaque weapon-type ids (MossTank models concrete owned items); the move-up/down DEFAULT guard is symmetric. Fix round A (grid scaling, Profiles leftovers, 260-tall window, Advanced Options / Loot Editor as their own panels, blank trailing slots, fresh screenshots) dispatched on the same worktree after merging the plain-menu style in. S7.4S7.6 follow.