From 3f17c9131d449a6c5b9a0766498e8edc3ef7316b Mon Sep 17 00:00:00 2001 From: Erik Date: Fri, 4 Sep 2026 16:40:09 +0200 Subject: [PATCH] docs(overhaul): contract S5 c1 final review fix --- .../s5-consumers-material-closeout-packet.md | 39 +++++++++++++++---- 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md index 77762cc6..5870852f 100644 --- a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md +++ b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md @@ -364,11 +364,34 @@ passes. A third fix round still stops the chunk. ### 10.1 Fix-round-1 implementation result The three stale descriptions are corrected without behavior or assertion -changes. `UseWorldView` now names only the completed retail PView and explicitly -excludes the null-root safety draw. `CopyVisibleCellsTo` describes a diagnostic -union and names the distinct particle, point-light, and future directional- -shadow consumers. `ParticleSystem` scopes the logarithmic lifecycle statement -to its `SortedSet` indexes and records the sorted list's binary-search plus -linear-shift insertion and linear search/compaction removal costs. Focused gate -results: Core `ParticleSystemTests` 47/47, App visibility/terrain/frame/renderer -38/38, and AP-116 settings/live-object 3/3; `git diff --check` is clean. +changes. `CopyVisibleCellsTo` describes a diagnostic union and names the +distinct particle, point-light, and future directional-shadow consumers. +`ParticleSystem` scopes the logarithmic lifecycle statement to its `SortedSet` +indexes and records the sorted list's binary-search plus linear-shift insertion +and linear search/compaction removal costs. Focused gate results: Core +`ParticleSystemTests` 47/47, App visibility/terrain/frame/renderer 38/38, and +AP-116 settings/live-object 3/3; `git diff --check` is clean. The first narrow +re-review found the `UseWorldView` result sentence still misstated null-root +transaction state; fix round 2 below supersedes that sentence. + +## 11. Retail narrow re-review — fix round 2 (last allowed) + +The narrow retail re-review passed the four-file scope, behavior/test/register +invariance, diagnostic-union wording, sorted-list cost wording, diff check, and +the focused 47 + 41 tests. It found one remaining **MINOR** comment-truth error: +`ParticleVisibilityController.UseWorldView` and §10.1 say the null-root safety +draw omits/excludes the completed product. Production begins visibility before +root resolution and calls `UseWorldView` for every non-login built frame, so a +null-root safety frame completes `hasCompletedView=true` with an empty landscape +set. Login/portal frames carry `hasCompletedView=false`. This distinction is +already the bound §3 behavior: null-root invents no fallback cells. + +Fix round 2 is the last allowed round and is prose-only. It may change exactly +the `UseWorldView` XML comment in `ParticleVisibilityController.cs` and this +packet's result prose. State that non-login world frames participate in the +completed transaction; the retail walk publishes its exact landscape set when +present, while null-root completes an empty set without reconstruction. Do not +change code behavior, tests, register/architecture prose, or any other file. +Run `git diff --check`, Core particle 47/47, and the combined App/AP-116 41/41; +commit once and return to the same narrow retail lens. Any further finding that +would require a third fix round stops S5-c1 and is written up.