feat(ui): Display tab + settings.json persistence — first non-keybind tab lands
Phase L.0 (cont.) — first concrete tab on the new Settings shell, in the Easy-wins build order agreed in the brainstorm (Display → Audio → Gameplay → Chat → Character). DisplaySettings (immutable record): Resolution / Fullscreen / VSync / FieldOfView (30-120°) / Gamma (0.5-2.0) / ShowFps. Six common 16:9 resolutions in the dropdown. Defaults: 1920×1080, windowed, vsync on, 75° FOV, gamma 1.0, FPS off — matches the brainstorm UX agreement. SettingsStore: JSON persistence at %LOCALAPPDATA%\acdream\settings.json (coexists with keybinds.json — own load/save path stays put, no migration needed). LoadDisplay falls back per-field when keys are missing (partial-file tolerant) and falls back to defaults when the file is corrupt or the JSON is unparseable. SaveDisplay round-trips preserved — unknown top-level keys (e.g. an `audio` section written by a future client) are kept on save so older builds don't silently drop newer-tab data. SettingsVM gains a parallel display-state machine: persistedDisplay + draftDisplay, SetDisplay mutator, HasUnsavedChanges checks both keybinds and display deltas, Save/Cancel/ResetAll cover both atomically from the user's POV (one Save commits everything, one Cancel reverts everything). Constructor signature extends with two new params; existing keybinds-only callers updated. SettingsPanel.RenderDisplayTab replaces the L.0-shell placeholder — Combo for resolution, Checkboxes for fullscreen/vsync/show-fps, SliderFloat for FOV + gamma. Live-preview note in the panel body matches the agreed UX: FOV + gamma update visibly while the user drags; resolution / fullscreen / vsync apply on Save (live preview would be too jarring). GameWindow wires SettingsStore into the existing SettingsVM construct site — load on startup, save on each tab Save. Errors print to console and don't crash the panel. 19 new tests: · DisplaySettings record (4) — defaults pinned, value equality, with- expressions, AvailableResolutions sorted ascending · SettingsStore (6) — round trip, missing-file → defaults, corrupt- file → defaults, partial-file → per-field fallback, unknown-key preservation, DefaultPath shape · SettingsVM display (6) — initial draft tracks persisted, SetDisplay marks dirty, Save invokes display callback, Cancel reverts, ResetAllToDefaults covers display, Save-then-Cancel is no-op · SettingsPanel display tab (3) — widgets render only when active, resolution combo uses AvailableResolutions, no Combo emitted on inactive tabs dotnet build green (0 warnings); dotnet test 1,246 / 1,246 green (243 Core.Net + 330 UI.Abstractions + 673 Core). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Erik
parent
7665cdf642
commit
382f0ad3fa
9 changed files with 653 additions and 33 deletions
|
|
@ -0,0 +1,67 @@
|
|||
using AcDream.UI.Abstractions.Panels.Settings;
|
||||
|
||||
namespace AcDream.UI.Abstractions.Tests.Panels.Settings;
|
||||
|
||||
/// <summary>
|
||||
/// L.0: <see cref="DisplaySettings"/> is the immutable record of
|
||||
/// display-tab preferences. Defaults are pinned here so a regression
|
||||
/// (e.g. someone changing the default FOV out from under users)
|
||||
/// surfaces immediately.
|
||||
/// </summary>
|
||||
public sealed class DisplaySettingsTests
|
||||
{
|
||||
[Fact]
|
||||
public void Default_values_match_brainstorm_agreement()
|
||||
{
|
||||
var d = DisplaySettings.Default;
|
||||
Assert.Equal("1920x1080", d.Resolution);
|
||||
Assert.False(d.Fullscreen);
|
||||
Assert.True(d.VSync);
|
||||
Assert.Equal(75f, d.FieldOfView);
|
||||
Assert.Equal(1.0f, d.Gamma);
|
||||
Assert.False(d.ShowFps);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AvailableResolutions_includes_common_16_9_options()
|
||||
{
|
||||
var list = DisplaySettings.AvailableResolutions;
|
||||
Assert.Contains("1280x720", list);
|
||||
Assert.Contains("1920x1080", list);
|
||||
Assert.Contains("2560x1440", list);
|
||||
Assert.Contains("3840x2160", list);
|
||||
// List should be ascending so the dropdown reads naturally.
|
||||
for (int i = 1; i < list.Count; i++)
|
||||
{
|
||||
int prevW = ParseWidth(list[i - 1]);
|
||||
int curW = ParseWidth(list[i]);
|
||||
Assert.True(curW >= prevW, $"Resolutions not sorted: {list[i - 1]} >= {list[i]}");
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Equality_is_value_based()
|
||||
{
|
||||
var a = DisplaySettings.Default;
|
||||
var b = DisplaySettings.Default with { ShowFps = true };
|
||||
var c = DisplaySettings.Default with { ShowFps = true };
|
||||
Assert.NotEqual(a, b);
|
||||
Assert.Equal(b, c);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void With_expression_clones_one_field()
|
||||
{
|
||||
var d = DisplaySettings.Default with { FieldOfView = 90f };
|
||||
Assert.Equal(90f, d.FieldOfView);
|
||||
// Other fields untouched.
|
||||
Assert.Equal("1920x1080", d.Resolution);
|
||||
Assert.True(d.VSync);
|
||||
}
|
||||
|
||||
private static int ParseWidth(string res)
|
||||
{
|
||||
int x = res.IndexOf('x');
|
||||
return int.Parse(res.AsSpan(0, x));
|
||||
}
|
||||
}
|
||||
|
|
@ -29,7 +29,9 @@ public sealed class SettingsPanelTests
|
|||
persisted.Add(new Binding(new KeyChord(Key.W, ModifierMask.None), InputAction.MovementForward));
|
||||
persisted.Add(new Binding(new KeyChord(Key.A, ModifierMask.None), InputAction.MovementTurnLeft));
|
||||
var dispatcher = new InputDispatcher(kb, mouse, persisted);
|
||||
var vm = new SettingsVM(persisted, dispatcher, _ => { });
|
||||
var vm = new SettingsVM(
|
||||
persisted, dispatcher, _ => { },
|
||||
DisplaySettings.Default, _ => { });
|
||||
var panel = new SettingsPanel(vm);
|
||||
return (panel, vm, kb, dispatcher);
|
||||
}
|
||||
|
|
@ -234,6 +236,54 @@ public sealed class SettingsPanelTests
|
|||
Assert.Contains(wrapped, t => t.Contains("Audio settings coming soon"));
|
||||
}
|
||||
|
||||
// -- Display tab content ---------------------------------------------
|
||||
|
||||
[Fact]
|
||||
public void Display_tab_when_active_renders_resolution_combo_plus_sliders()
|
||||
{
|
||||
var (panel, _, _, _) = Build();
|
||||
var r = new FakePanelRenderer { ActiveTabLabel = "Display" };
|
||||
|
||||
panel.Render(new PanelContext(0.016f, new NullBus()), r);
|
||||
|
||||
var combos = r.Calls.Where(c => c.Method == "Combo").Select(c => (string)c.Args[0]!).ToList();
|
||||
var checks = r.Calls.Where(c => c.Method == "Checkbox").Select(c => (string)c.Args[0]!).ToList();
|
||||
var sliders = r.Calls.Where(c => c.Method == "SliderFloat").Select(c => (string)c.Args[0]!).ToList();
|
||||
|
||||
Assert.Contains("Resolution", combos);
|
||||
Assert.Contains("Fullscreen", checks);
|
||||
Assert.Contains("V-Sync", checks);
|
||||
Assert.Contains("Show FPS", checks);
|
||||
Assert.Contains("Field of View", sliders);
|
||||
Assert.Contains("Gamma", sliders);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Display_tab_does_not_render_when_a_different_tab_is_active()
|
||||
{
|
||||
var (panel, _, _, _) = Build();
|
||||
var r = new FakePanelRenderer { ActiveTabLabel = "Audio" };
|
||||
|
||||
panel.Render(new PanelContext(0.016f, new NullBus()), r);
|
||||
|
||||
var combos = r.Calls.Where(c => c.Method == "Combo").Select(c => (string)c.Args[0]!).ToList();
|
||||
Assert.DoesNotContain("Resolution", combos);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Display_tab_resolution_combo_uses_AvailableResolutions_list()
|
||||
{
|
||||
var (panel, _, _, _) = Build();
|
||||
var r = new FakePanelRenderer { ActiveTabLabel = "Display" };
|
||||
|
||||
panel.Render(new PanelContext(0.016f, new NullBus()), r);
|
||||
|
||||
var resCall = r.Calls.First(c => c.Method == "Combo" && (string)c.Args[0]! == "Resolution");
|
||||
var items = (string[])resCall.Args[2]!;
|
||||
Assert.Contains("1920x1080", items);
|
||||
Assert.Contains("3840x2160", items);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Save_Cancel_buttons_render_outside_the_tab_bar()
|
||||
{
|
||||
|
|
|
|||
|
|
@ -0,0 +1,119 @@
|
|||
using System.IO;
|
||||
using AcDream.UI.Abstractions.Panels.Settings;
|
||||
|
||||
namespace AcDream.UI.Abstractions.Tests.Panels.Settings;
|
||||
|
||||
/// <summary>
|
||||
/// L.0: <see cref="SettingsStore"/> reads / writes <c>settings.json</c>.
|
||||
/// Tests use a temp-file path so they don't touch the user's
|
||||
/// %LOCALAPPDATA% file.
|
||||
/// </summary>
|
||||
public sealed class SettingsStoreTests : System.IDisposable
|
||||
{
|
||||
private readonly string _tempPath;
|
||||
|
||||
public SettingsStoreTests()
|
||||
{
|
||||
// Unique per-test file under the system temp dir so parallel test
|
||||
// runners don't clobber each other.
|
||||
_tempPath = Path.Combine(
|
||||
Path.GetTempPath(),
|
||||
$"acdream-settings-test-{System.Guid.NewGuid():N}.json");
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (File.Exists(_tempPath)) File.Delete(_tempPath);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadDisplay_returns_defaults_when_file_is_missing()
|
||||
{
|
||||
var store = new SettingsStore(_tempPath);
|
||||
var loaded = store.LoadDisplay();
|
||||
Assert.Equal(DisplaySettings.Default, loaded);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SaveDisplay_then_LoadDisplay_round_trips_all_fields()
|
||||
{
|
||||
var store = new SettingsStore(_tempPath);
|
||||
var original = new DisplaySettings(
|
||||
Resolution: "2560x1440",
|
||||
Fullscreen: true,
|
||||
VSync: false,
|
||||
FieldOfView: 100f,
|
||||
Gamma: 1.4f,
|
||||
ShowFps: true);
|
||||
|
||||
store.SaveDisplay(original);
|
||||
var loaded = store.LoadDisplay();
|
||||
|
||||
Assert.Equal(original, loaded);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadDisplay_falls_back_to_defaults_when_file_is_corrupt()
|
||||
{
|
||||
File.WriteAllText(_tempPath, "{ this is not valid json");
|
||||
var store = new SettingsStore(_tempPath);
|
||||
|
||||
var loaded = store.LoadDisplay();
|
||||
|
||||
Assert.Equal(DisplaySettings.Default, loaded);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadDisplay_falls_back_per_field_when_keys_missing()
|
||||
{
|
||||
// Partial file — only resolution set; everything else should
|
||||
// pick up DisplaySettings.Default values.
|
||||
File.WriteAllText(_tempPath, """
|
||||
{
|
||||
"version": 1,
|
||||
"display": { "resolution": "1366x768" }
|
||||
}
|
||||
""");
|
||||
var store = new SettingsStore(_tempPath);
|
||||
|
||||
var loaded = store.LoadDisplay();
|
||||
|
||||
Assert.Equal("1366x768", loaded.Resolution);
|
||||
Assert.Equal(DisplaySettings.Default.Fullscreen, loaded.Fullscreen);
|
||||
Assert.Equal(DisplaySettings.Default.VSync, loaded.VSync);
|
||||
Assert.Equal(DisplaySettings.Default.FieldOfView, loaded.FieldOfView);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SaveDisplay_preserves_unknown_top_level_keys()
|
||||
{
|
||||
// Forward-compat: a newer client may have written sections we
|
||||
// don't know about (audio, gameplay). Saving display must not
|
||||
// delete those, otherwise running an older client would silently
|
||||
// drop the user's other-tab preferences.
|
||||
File.WriteAllText(_tempPath, """
|
||||
{
|
||||
"version": 1,
|
||||
"display": { "resolution": "1280x720" },
|
||||
"audio": { "master": 0.5, "music": 0.7 }
|
||||
}
|
||||
""");
|
||||
var store = new SettingsStore(_tempPath);
|
||||
|
||||
store.SaveDisplay(DisplaySettings.Default with { Resolution = "1920x1080" });
|
||||
|
||||
var raw = File.ReadAllText(_tempPath);
|
||||
Assert.Contains("\"audio\"", raw);
|
||||
Assert.Contains("\"master\"", raw);
|
||||
Assert.Contains("0.5", raw);
|
||||
// And the new display value did get written.
|
||||
Assert.Contains("1920x1080", raw);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void DefaultPath_is_under_LocalAppData_acdream()
|
||||
{
|
||||
var path = SettingsStore.DefaultPath();
|
||||
Assert.EndsWith("acdream" + Path.DirectorySeparatorChar + "settings.json", path);
|
||||
}
|
||||
}
|
||||
|
|
@ -16,16 +16,21 @@ namespace AcDream.UI.Abstractions.Tests.Panels.Settings;
|
|||
/// </summary>
|
||||
public sealed class SettingsVMTests
|
||||
{
|
||||
private static (SettingsVM vm, FakeKeyboardSource kb, InputDispatcher dispatcher, KeyBindings persisted, System.Collections.Generic.List<KeyBindings> savedHistory)
|
||||
Build(KeyBindings? persisted = null)
|
||||
private static (SettingsVM vm, FakeKeyboardSource kb, InputDispatcher dispatcher, KeyBindings persisted, System.Collections.Generic.List<KeyBindings> savedHistory, System.Collections.Generic.List<DisplaySettings> savedDisplayHistory)
|
||||
Build(KeyBindings? persisted = null, DisplaySettings? persistedDisplay = null)
|
||||
{
|
||||
persisted ??= MakeMinimalBindings();
|
||||
var kb = new FakeKeyboardSource();
|
||||
var mouse = new FakeMouseSource();
|
||||
var dispatcher = new InputDispatcher(kb, mouse, persisted);
|
||||
var savedHistory = new System.Collections.Generic.List<KeyBindings>();
|
||||
var vm = new SettingsVM(persisted, dispatcher, b => savedHistory.Add(b));
|
||||
return (vm, kb, dispatcher, persisted, savedHistory);
|
||||
var savedDisplayHistory = new System.Collections.Generic.List<DisplaySettings>();
|
||||
var vm = new SettingsVM(
|
||||
persisted, dispatcher,
|
||||
b => savedHistory.Add(b),
|
||||
persistedDisplay ?? DisplaySettings.Default,
|
||||
d => savedDisplayHistory.Add(d));
|
||||
return (vm, kb, dispatcher, persisted, savedHistory, savedDisplayHistory);
|
||||
}
|
||||
|
||||
private static KeyBindings MakeMinimalBindings()
|
||||
|
|
@ -40,7 +45,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void Constructor_clones_persisted_into_draft()
|
||||
{
|
||||
var (vm, _, _, persisted, _) = Build();
|
||||
var (vm, _, _, persisted, _, _) = Build();
|
||||
Assert.Equal(persisted.All.Count, vm.Draft.All.Count);
|
||||
Assert.False(vm.HasUnsavedChanges);
|
||||
}
|
||||
|
|
@ -48,7 +53,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void BeginRebind_enters_capture_mode()
|
||||
{
|
||||
var (vm, _, dispatcher, _, _) = Build();
|
||||
var (vm, _, dispatcher, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
|
|
@ -61,7 +66,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void BeginRebind_then_chord_with_no_conflict_applies_rebind()
|
||||
{
|
||||
var (vm, kb, _, _, _) = Build();
|
||||
var (vm, kb, _, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
|
|
@ -79,7 +84,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void BeginRebind_then_Escape_cancels_with_no_change()
|
||||
{
|
||||
var (vm, kb, _, _, _) = Build();
|
||||
var (vm, kb, _, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
|
|
@ -96,7 +101,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void BeginRebind_with_conflict_surfaces_PendingConflict()
|
||||
{
|
||||
var (vm, kb, _, _, _) = Build();
|
||||
var (vm, kb, _, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
|
||||
// Bind chord that conflicts with MovementTurnLeft (which has Key.A).
|
||||
|
|
@ -116,7 +121,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void ResolveConflict_replace_true_removes_conflict_and_applies_rebind()
|
||||
{
|
||||
var (vm, kb, _, _, _) = Build();
|
||||
var (vm, kb, _, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
|
|
@ -137,7 +142,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void ResolveConflict_replace_false_cancels_rebind()
|
||||
{
|
||||
var (vm, kb, _, _, _) = Build();
|
||||
var (vm, kb, _, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
|
|
@ -159,7 +164,7 @@ public sealed class SettingsVMTests
|
|||
{
|
||||
// Build a draft that's been mutated for MovementForward; ensure
|
||||
// ResetActionToDefault restores W (and Up-arrow per retail).
|
||||
var (vm, kb, _, _, _) = Build(KeyBindings.RetailDefaults());
|
||||
var (vm, kb, _, _, _, _) = Build(KeyBindings.RetailDefaults());
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
// F7 is unbound in retail-default (only Ctrl+F7 is acdream debug);
|
||||
|
|
@ -179,7 +184,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void ResetAllToDefaults_replaces_entire_draft()
|
||||
{
|
||||
var (vm, _, _, _, _) = Build();
|
||||
var (vm, _, _, _, _, _) = Build();
|
||||
vm.ResetAllToDefaults();
|
||||
|
||||
// Should now include retail-default size set (~149 bindings).
|
||||
|
|
@ -190,7 +195,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void Save_invokes_callback_with_draft()
|
||||
{
|
||||
var (vm, kb, _, _, savedHistory) = Build();
|
||||
var (vm, kb, _, _, savedHistory, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
kb.EmitKeyDown(Key.Q, ModifierMask.None);
|
||||
|
|
@ -206,7 +211,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void Cancel_reverts_draft_to_persisted()
|
||||
{
|
||||
var (vm, kb, _, _, _) = Build();
|
||||
var (vm, kb, _, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
kb.EmitKeyDown(Key.Q, ModifierMask.None);
|
||||
|
|
@ -222,7 +227,7 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void Cancel_during_active_capture_clears_dispatcher_capture_state()
|
||||
{
|
||||
var (vm, _, dispatcher, _, _) = Build();
|
||||
var (vm, _, dispatcher, _, _, _) = Build();
|
||||
var original = vm.Draft.ForAction(InputAction.MovementForward).First();
|
||||
vm.BeginRebind(InputAction.MovementForward, original);
|
||||
|
||||
|
|
@ -235,7 +240,84 @@ public sealed class SettingsVMTests
|
|||
[Fact]
|
||||
public void HasUnsavedChanges_false_initially_and_after_save_sync()
|
||||
{
|
||||
var (vm, _, _, _, _) = Build();
|
||||
var (vm, _, _, _, _, _) = Build();
|
||||
Assert.False(vm.HasUnsavedChanges);
|
||||
}
|
||||
|
||||
// -- Display tab state ------------------------------------------------
|
||||
|
||||
[Fact]
|
||||
public void DisplayDraft_initial_value_matches_persisted()
|
||||
{
|
||||
var custom = DisplaySettings.Default with { FieldOfView = 90f, ShowFps = true };
|
||||
var (vm, _, _, _, _, _) = Build(persistedDisplay: custom);
|
||||
Assert.Equal(custom, vm.DisplayDraft);
|
||||
Assert.False(vm.HasUnsavedChanges);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SetDisplay_marks_unsaved_changes()
|
||||
{
|
||||
var (vm, _, _, _, _, _) = Build();
|
||||
vm.SetDisplay(vm.DisplayDraft with { ShowFps = true });
|
||||
Assert.True(vm.HasUnsavedChanges);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Save_invokes_display_callback_with_draft()
|
||||
{
|
||||
var (vm, _, _, _, _, savedDisplayHistory) = Build();
|
||||
vm.SetDisplay(vm.DisplayDraft with { Resolution = "2560x1440", FieldOfView = 100f });
|
||||
|
||||
vm.Save();
|
||||
|
||||
Assert.Single(savedDisplayHistory);
|
||||
Assert.Equal("2560x1440", savedDisplayHistory[0].Resolution);
|
||||
Assert.Equal(100f, savedDisplayHistory[0].FieldOfView);
|
||||
Assert.False(vm.HasUnsavedChanges);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Cancel_reverts_display_draft_to_persisted()
|
||||
{
|
||||
var custom = DisplaySettings.Default with { FieldOfView = 90f };
|
||||
var (vm, _, _, _, _, _) = Build(persistedDisplay: custom);
|
||||
vm.SetDisplay(vm.DisplayDraft with { FieldOfView = 30f, ShowFps = true });
|
||||
Assert.True(vm.HasUnsavedChanges);
|
||||
|
||||
vm.Cancel();
|
||||
|
||||
Assert.Equal(custom, vm.DisplayDraft);
|
||||
Assert.False(vm.HasUnsavedChanges);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ResetAllToDefaults_resets_display_to_default()
|
||||
{
|
||||
var custom = DisplaySettings.Default with { FieldOfView = 30f, ShowFps = true };
|
||||
var (vm, _, _, _, _, _) = Build(persistedDisplay: custom);
|
||||
Assert.NotEqual(DisplaySettings.Default, vm.DisplayDraft);
|
||||
|
||||
vm.ResetAllToDefaults();
|
||||
|
||||
Assert.Equal(DisplaySettings.Default, vm.DisplayDraft);
|
||||
Assert.True(vm.HasUnsavedChanges);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Save_then_Cancel_does_not_revert()
|
||||
{
|
||||
// After Save the persisted snapshot equals the draft, so Cancel
|
||||
// is a no-op. This guards the Save/Cancel ordering — a regression
|
||||
// would surface as Cancel reverting to pre-Save values.
|
||||
var (vm, _, _, _, _, _) = Build();
|
||||
vm.SetDisplay(vm.DisplayDraft with { ShowFps = true });
|
||||
vm.Save();
|
||||
Assert.False(vm.HasUnsavedChanges);
|
||||
|
||||
vm.Cancel();
|
||||
|
||||
Assert.True(vm.DisplayDraft.ShowFps);
|
||||
Assert.False(vm.HasUnsavedChanges);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue