feat(launcher): Campaign LA LA3 — AcDream.Launcher.Core profile store, composer, supervisor, status tailer
New AcDream.Launcher.Core (BCL-only, ProjectReference: AcDream.Platform
ONLY) plus tests/AcDream.Launcher.Core.Tests, both registered in
AcDream.slnx. This is the file-contract orchestrator core the Avalonia
launcher (LA4) will bind to — the game solution (Core/Runtime/App/
Headless) stays entirely out of this dependency graph, so the launcher
can never accidentally grow a game-protocol coupling.
- Profiles/: LauncherProfileStore owns launcher-profiles.json (spec §5
schema: version 1, servers[]/accounts[]/characters[]), strict
camelCase System.Text.Json (UnmappedMemberHandling.Disallow), typed
CRUD (add/edit/remove server; add/edit/remove account; edit character
settings), and MergeRoster (fold a reported roster into an account's
characters[] while preserving user-owned launchMode/plugins/
loginCommands, adding new rows with default guiSelect, and retaining
rows absent from the roster — they may be pending-delete). 0600 on
Linux via File.SetUnixFileMode after save.
- Launching/: SessionConfigComposer builds the pinned session-config
contract (Headless K1 shape + plugins/loginCommands/
loginCommandDelayMs/statusFile) from a profile character + install
record — character selector omitted entirely for guiSelect, policy
{id:"idle"} only for headless, credential always standardInput/
session. Passwords never enter this document (proven by a dedicated
test). LauncherProcessSupervisor spawns a host, feeds the password to
stdin then closes it, and exposes Starting/Running/Exited lifecycle;
Stop calls CloseMainWindow falling back to Kill after a timeout, both
reachable through an injectable ILauncherChildProcess/factory seam so
the state machine is unit-testable without real OS process timing.
- Status/: StatusEventParser decodes the v1 status.jsonl vocabulary
(started/connected/characterList/enteredWorld/pluginLoaded/
pluginFailed/disconnected/exited); an unrecognized "e" or a malformed
line degrades to a typed Unknown event rather than throwing.
StatusFileTailer incrementally reads new lines, tolerating a
not-yet-existing file and a partial trailing line (only advances its
read position past confirmed '\n' boundaries; a truncated tail is
simply re-read next poll, never parsed early).
- Integrity/: streaming SHA-256 + hex verify for later pak/download
checks (LA9/LA10).
Tests: 71 passed (profile CRUD + roster-merge matrix + strict-schema
rejection; composer golden-shape tests for gui/guiSelect/headless +
password-absence; supervisor tests against both an injected fake child
(state-machine determinism) and a real spawned `dotnet --version`
child (genuine cross-platform stdin/exit-code proof); tailer tests
incl. partial-line and not-yet-existing-file; SHA-256 tests). Verified
green on Windows (Release) and native WSL/Linux (Release) — the Linux
0600 test executes its real assertion body under WSL rather than
early-returning.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik
parent
cb6502c8a5
commit
37d74e4402
31 changed files with 3131 additions and 0 deletions
|
|
@ -0,0 +1,269 @@
|
|||
using System.Text.Json.Nodes;
|
||||
using AcDream.Launcher.Core.Launching;
|
||||
using AcDream.Launcher.Core.Profiles;
|
||||
using AcDream.Platform;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Launching;
|
||||
|
||||
/// <summary>
|
||||
/// Golden-shape tests for <see cref="SessionConfigComposer"/> against the
|
||||
/// Campaign LA plan §LA3 pinned contract: exactly the listed keys, exact
|
||||
/// camelCase names, character/policy presence rules per launch mode, and
|
||||
/// (critically) no password anywhere in the document.
|
||||
/// </summary>
|
||||
public sealed class SessionConfigComposerTests
|
||||
{
|
||||
private static readonly ApplicationPathSet Paths = new(
|
||||
ConfigDirectory: "/cfg/acdream",
|
||||
DataDirectory: "/data/acdream",
|
||||
CacheDirectory: "/cache/acdream",
|
||||
LegacyConfigDirectory: null);
|
||||
|
||||
private static readonly LauncherInstallRecord Install = new(
|
||||
DatDirectory: "/dats",
|
||||
PreparedAssetPath: "/data/acdream/pak/acdream.pak");
|
||||
|
||||
private static ServerProfile Server() =>
|
||||
new() { Name = "Local ACE", Host = "127.0.0.1", Port = 9000 };
|
||||
|
||||
private static AccountProfile Account() =>
|
||||
new() { Account = "testaccount", Password = "S3cretPassw0rd!" };
|
||||
|
||||
private static CharacterProfile Character(LaunchMode mode, string? id = "0x5000000A") =>
|
||||
new()
|
||||
{
|
||||
Name = "+Acdream",
|
||||
Id = id,
|
||||
LaunchMode = mode,
|
||||
Plugins = ["ExamplePlugin"],
|
||||
LoginCommands = ["/tell someone, hi"],
|
||||
};
|
||||
|
||||
[Fact]
|
||||
public void GuiModeIncludesCharacterSelectorAndOmitsPolicy()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-gui");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
|
||||
AssertKeys(
|
||||
session,
|
||||
"id", "endpoint", "account", "character", "credential",
|
||||
"plugins", "loginCommands", "statusFile");
|
||||
|
||||
Assert.Equal("session-gui", (string?)session["id"]);
|
||||
Assert.Equal("testaccount", (string?)session["account"]);
|
||||
Assert.Equal(0x5000000Au, (uint?)session["character"]!["id"]);
|
||||
Assert.Null(session["character"]!["name"]);
|
||||
Assert.Null(session["character"]!["index"]);
|
||||
Assert.Equal("standardInput", (string?)session["credential"]!["provider"]);
|
||||
Assert.Equal("session", (string?)session["credential"]!["reference"]);
|
||||
Assert.Equal(
|
||||
new[] { "ExamplePlugin" },
|
||||
session["plugins"]!.AsArray().Select(n => (string?)n));
|
||||
Assert.Equal(
|
||||
new[] { "/tell someone, hi" },
|
||||
session["loginCommands"]!.AsArray().Select(n => (string?)n));
|
||||
Assert.Equal(
|
||||
Path.Combine(Paths.CacheDirectory, "launcher", "sessions", "session-gui", "status.jsonl"),
|
||||
(string?)session["statusFile"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void GuiSelectModeOmitsCharacterFieldEntirely()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.GuiSelect),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-guiselect");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
|
||||
AssertKeys(
|
||||
session,
|
||||
"id", "endpoint", "account", "credential",
|
||||
"plugins", "loginCommands", "statusFile");
|
||||
Assert.False(session.ContainsKey("character"));
|
||||
Assert.False(session.ContainsKey("policy"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void HeadlessModeIncludesCharacterAndIdlePolicy()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Headless),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-headless",
|
||||
loginCommandDelayMs: 750);
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
|
||||
AssertKeys(
|
||||
session,
|
||||
"id", "endpoint", "account", "character", "policy", "credential",
|
||||
"plugins", "loginCommands", "loginCommandDelayMs", "statusFile");
|
||||
Assert.Equal(0x5000000Au, (uint?)session["character"]!["id"]);
|
||||
Assert.Equal("idle", (string?)session["policy"]!["id"]);
|
||||
Assert.Equal(750, (int?)session["loginCommandDelayMs"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void GuiModeFallsBackToNameSelectorWhenIdIsMissing()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui, id: null),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-gui-name");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
Assert.Null(session["character"]!["id"]);
|
||||
Assert.Equal("+Acdream", (string?)session["character"]!["name"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PluginsAndLoginCommandsAreOmittedWhenEmptyRatherThanEmptyArrays()
|
||||
{
|
||||
CharacterProfile character = Character(LaunchMode.Gui);
|
||||
character.Plugins = [];
|
||||
character.LoginCommands = [];
|
||||
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
character,
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-empty-lists");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
Assert.False(session.ContainsKey("plugins"));
|
||||
Assert.False(session.ContainsKey("loginCommands"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ProcessContentCarriesInstallRecordAndPathsIsAlwaysPresent()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-content");
|
||||
|
||||
JsonObject root = ParseRoot(composed);
|
||||
Assert.Equal(1, (int?)root["version"]);
|
||||
JsonObject process = root["process"]!.AsObject();
|
||||
AssertKeys(process, "paths", "content");
|
||||
|
||||
// Paths is always present as an object; every member is omitted
|
||||
// when unset (hosts resolve their own default ApplicationPathSet).
|
||||
Assert.Empty(process["paths"]!.AsObject());
|
||||
|
||||
JsonObject content = process["content"]!.AsObject();
|
||||
AssertKeys(content, "datDirectory", "preparedAssetPath");
|
||||
Assert.Equal(Install.DatDirectory, (string?)content["datDirectory"]);
|
||||
Assert.Equal(Install.PreparedAssetPath, (string?)content["preparedAssetPath"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComposedDocumentNeverContainsThePassword()
|
||||
{
|
||||
AccountProfile account = Account();
|
||||
|
||||
foreach (LaunchMode mode in new[] { LaunchMode.Gui, LaunchMode.GuiSelect, LaunchMode.Headless })
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
account,
|
||||
Character(mode),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: $"session-{mode}");
|
||||
|
||||
string json = SessionConfigComposer.Serialize(composed.Document);
|
||||
Assert.DoesNotContain(account.Password, json, StringComparison.Ordinal);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComposeAndWriteWritesSessionJsonUnderTheExpectedPath()
|
||||
{
|
||||
string root = Path.Combine(
|
||||
Path.GetTempPath(),
|
||||
"acdream-launcher-composer-tests",
|
||||
Guid.NewGuid().ToString("N"));
|
||||
try
|
||||
{
|
||||
var paths = new ApplicationPathSet(
|
||||
Path.Combine(root, "cfg"),
|
||||
Path.Combine(root, "data"),
|
||||
Path.Combine(root, "cache"),
|
||||
null);
|
||||
|
||||
ComposedSessionConfig composed = SessionConfigComposer.ComposeAndWrite(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui),
|
||||
Install,
|
||||
paths,
|
||||
sessionId: "session-write");
|
||||
|
||||
string expectedPath = Path.Combine(
|
||||
paths.CacheDirectory, "launcher", "sessions", "session-write", "session.json");
|
||||
Assert.Equal(expectedPath, composed.ConfigFilePath);
|
||||
Assert.True(File.Exists(expectedPath));
|
||||
|
||||
string text = File.ReadAllText(expectedPath);
|
||||
Assert.DoesNotContain(Account().Password, text, StringComparison.Ordinal);
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (Directory.Exists(root))
|
||||
{
|
||||
Directory.Delete(root, recursive: true);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private static JsonObject ParseRoot(ComposedSessionConfig composed)
|
||||
{
|
||||
string json = SessionConfigComposer.Serialize(composed.Document);
|
||||
return JsonNode.Parse(json)!.AsObject();
|
||||
}
|
||||
|
||||
private static JsonObject SingleSession(ComposedSessionConfig composed)
|
||||
{
|
||||
JsonObject root = ParseRoot(composed);
|
||||
JsonArray sessions = root["sessions"]!.AsArray();
|
||||
return Assert.Single(sessions)!.AsObject();
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Asserts the object's property set is EXACTLY the given keys — no
|
||||
/// more, no fewer — without depending on reflection-based member
|
||||
/// enumeration order (only the presence/absence of each pinned-
|
||||
/// contract key is a guarantee this slice makes).
|
||||
/// </summary>
|
||||
private static void AssertKeys(JsonObject obj, params string[] expectedKeys)
|
||||
{
|
||||
var actual = new HashSet<string>(obj.Select(kv => kv.Key), StringComparer.Ordinal);
|
||||
var expected = new HashSet<string>(expectedKeys, StringComparer.Ordinal);
|
||||
Assert.Equal(expected, actual);
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue