feat(launcher): Campaign LA LA3 — AcDream.Launcher.Core profile store, composer, supervisor, status tailer
New AcDream.Launcher.Core (BCL-only, ProjectReference: AcDream.Platform
ONLY) plus tests/AcDream.Launcher.Core.Tests, both registered in
AcDream.slnx. This is the file-contract orchestrator core the Avalonia
launcher (LA4) will bind to — the game solution (Core/Runtime/App/
Headless) stays entirely out of this dependency graph, so the launcher
can never accidentally grow a game-protocol coupling.
- Profiles/: LauncherProfileStore owns launcher-profiles.json (spec §5
schema: version 1, servers[]/accounts[]/characters[]), strict
camelCase System.Text.Json (UnmappedMemberHandling.Disallow), typed
CRUD (add/edit/remove server; add/edit/remove account; edit character
settings), and MergeRoster (fold a reported roster into an account's
characters[] while preserving user-owned launchMode/plugins/
loginCommands, adding new rows with default guiSelect, and retaining
rows absent from the roster — they may be pending-delete). 0600 on
Linux via File.SetUnixFileMode after save.
- Launching/: SessionConfigComposer builds the pinned session-config
contract (Headless K1 shape + plugins/loginCommands/
loginCommandDelayMs/statusFile) from a profile character + install
record — character selector omitted entirely for guiSelect, policy
{id:"idle"} only for headless, credential always standardInput/
session. Passwords never enter this document (proven by a dedicated
test). LauncherProcessSupervisor spawns a host, feeds the password to
stdin then closes it, and exposes Starting/Running/Exited lifecycle;
Stop calls CloseMainWindow falling back to Kill after a timeout, both
reachable through an injectable ILauncherChildProcess/factory seam so
the state machine is unit-testable without real OS process timing.
- Status/: StatusEventParser decodes the v1 status.jsonl vocabulary
(started/connected/characterList/enteredWorld/pluginLoaded/
pluginFailed/disconnected/exited); an unrecognized "e" or a malformed
line degrades to a typed Unknown event rather than throwing.
StatusFileTailer incrementally reads new lines, tolerating a
not-yet-existing file and a partial trailing line (only advances its
read position past confirmed '\n' boundaries; a truncated tail is
simply re-read next poll, never parsed early).
- Integrity/: streaming SHA-256 + hex verify for later pak/download
checks (LA9/LA10).
Tests: 71 passed (profile CRUD + roster-merge matrix + strict-schema
rejection; composer golden-shape tests for gui/guiSelect/headless +
password-absence; supervisor tests against both an injected fake child
(state-machine determinism) and a real spawned `dotnet --version`
child (genuine cross-platform stdin/exit-code proof); tailer tests
incl. partial-line and not-yet-existing-file; SHA-256 tests). Verified
green on Windows (Release) and native WSL/Linux (Release) — the Linux
0600 test executes its real assertion body under WSL rather than
early-returning.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik
parent
cb6502c8a5
commit
37d74e4402
31 changed files with 3131 additions and 0 deletions
|
|
@ -0,0 +1,23 @@
|
|||
<Project Sdk="Microsoft.NET.Sdk">
|
||||
<PropertyGroup>
|
||||
<TargetFramework>net10.0</TargetFramework>
|
||||
<ImplicitUsings>enable</ImplicitUsings>
|
||||
<Nullable>enable</Nullable>
|
||||
<IsPackable>false</IsPackable>
|
||||
<LangVersion>latest</LangVersion>
|
||||
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
|
||||
</PropertyGroup>
|
||||
<ItemGroup>
|
||||
<PackageReference Include="coverlet.collector" Version="6.0.4" />
|
||||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
|
||||
<PackageReference Include="xunit" Version="2.9.3" />
|
||||
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.4" />
|
||||
</ItemGroup>
|
||||
<ItemGroup>
|
||||
<Using Include="Xunit" />
|
||||
</ItemGroup>
|
||||
<ItemGroup>
|
||||
<ProjectReference Include="..\..\src\AcDream.Launcher.Core\AcDream.Launcher.Core.csproj" />
|
||||
<ProjectReference Include="..\..\src\AcDream.Platform\AcDream.Platform.csproj" />
|
||||
</ItemGroup>
|
||||
</Project>
|
||||
|
|
@ -0,0 +1,98 @@
|
|||
using System.Security.Cryptography;
|
||||
using System.Text;
|
||||
using AcDream.Launcher.Core.Integrity;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Integrity;
|
||||
|
||||
public sealed class FileIntegrityTests : IDisposable
|
||||
{
|
||||
private readonly string _root;
|
||||
|
||||
public FileIntegrityTests()
|
||||
{
|
||||
_root = Path.Combine(
|
||||
Path.GetTempPath(),
|
||||
"acdream-launcher-integrity-tests",
|
||||
Guid.NewGuid().ToString("N"));
|
||||
Directory.CreateDirectory(_root);
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (Directory.Exists(_root))
|
||||
{
|
||||
Directory.Delete(_root, recursive: true);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComputeSha256HexMatchesTheFrameworkHasher()
|
||||
{
|
||||
string path = Path.Combine(_root, "file.bin");
|
||||
byte[] content = Encoding.UTF8.GetBytes("acdream launcher integrity fixture");
|
||||
File.WriteAllBytes(path, content);
|
||||
string expected = Convert.ToHexStringLower(SHA256.HashData(content));
|
||||
|
||||
string actual = FileIntegrity.ComputeSha256Hex(path);
|
||||
|
||||
Assert.Equal(expected, actual);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ComputeSha256HexAsyncMatchesTheSyncResult()
|
||||
{
|
||||
string path = Path.Combine(_root, "file.bin");
|
||||
File.WriteAllBytes(path, Encoding.UTF8.GetBytes("async path fixture"));
|
||||
|
||||
string sync = FileIntegrity.ComputeSha256Hex(path);
|
||||
string asyncResult = await FileIntegrity.ComputeSha256HexAsync(path);
|
||||
|
||||
Assert.Equal(sync, asyncResult);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void VerifySucceedsForAMatchingDigestRegardlessOfCase()
|
||||
{
|
||||
string path = Path.Combine(_root, "file.bin");
|
||||
File.WriteAllBytes(path, Encoding.UTF8.GetBytes("case-insensitive fixture"));
|
||||
string lower = FileIntegrity.ComputeSha256Hex(path);
|
||||
|
||||
Assert.True(FileIntegrity.Verify(path, lower));
|
||||
Assert.True(FileIntegrity.Verify(path, lower.ToUpperInvariant()));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void VerifyFailsForAMismatchedDigest()
|
||||
{
|
||||
string path = Path.Combine(_root, "file.bin");
|
||||
File.WriteAllBytes(path, Encoding.UTF8.GetBytes("original content"));
|
||||
|
||||
Assert.False(FileIntegrity.Verify(path, new string('0', 64)));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void DifferentContentProducesDifferentDigests()
|
||||
{
|
||||
string pathA = Path.Combine(_root, "a.bin");
|
||||
string pathB = Path.Combine(_root, "b.bin");
|
||||
File.WriteAllBytes(pathA, Encoding.UTF8.GetBytes("content A"));
|
||||
File.WriteAllBytes(pathB, Encoding.UTF8.GetBytes("content B"));
|
||||
|
||||
Assert.NotEqual(
|
||||
FileIntegrity.ComputeSha256Hex(pathA),
|
||||
FileIntegrity.ComputeSha256Hex(pathB));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void EmptyFileHashesToTheWellKnownSha256OfEmptyInput()
|
||||
{
|
||||
string path = Path.Combine(_root, "empty.bin");
|
||||
File.WriteAllBytes(path, []);
|
||||
|
||||
string actual = FileIntegrity.ComputeSha256Hex(path);
|
||||
|
||||
Assert.Equal(
|
||||
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
|
||||
actual);
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,246 @@
|
|||
using System.Threading;
|
||||
using AcDream.Launcher.Core.Launching;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Launching;
|
||||
|
||||
public sealed class LauncherProcessSupervisorTests
|
||||
{
|
||||
[Fact]
|
||||
public void StartWritesPasswordThenClosesStdinAndTransitionsToRunning()
|
||||
{
|
||||
var factory = new FakeChildProcessFactory(exitsWithinStopTimeout: true);
|
||||
using var supervisor = new LauncherProcessSupervisor(factory);
|
||||
var states = new List<LauncherSessionState>();
|
||||
supervisor.StateChanged += (_, s) => states.Add(s);
|
||||
|
||||
supervisor.Start(Spec(), "S3cretPassw0rd!");
|
||||
|
||||
FakeChildProcess fake = factory.LastCreated!;
|
||||
Assert.True(fake.Started);
|
||||
Assert.Equal("S3cretPassw0rd!\n", fake.StandardInputText);
|
||||
Assert.True(fake.StandardInputClosed);
|
||||
Assert.Equal(LauncherSessionState.Running, supervisor.State);
|
||||
Assert.Equal(
|
||||
[LauncherSessionState.Starting, LauncherSessionState.Running],
|
||||
states);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void StartWithNullPasswordClosesStdinWithoutWriting()
|
||||
{
|
||||
var factory = new FakeChildProcessFactory(exitsWithinStopTimeout: true);
|
||||
using var supervisor = new LauncherProcessSupervisor(factory);
|
||||
|
||||
supervisor.Start(Spec(), password: null);
|
||||
|
||||
FakeChildProcess fake = factory.LastCreated!;
|
||||
Assert.Equal(string.Empty, fake.StandardInputText);
|
||||
Assert.True(fake.StandardInputClosed);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void StartTwiceOnTheSameSupervisorThrows()
|
||||
{
|
||||
var factory = new FakeChildProcessFactory(exitsWithinStopTimeout: true);
|
||||
using var supervisor = new LauncherProcessSupervisor(factory);
|
||||
supervisor.Start(Spec(), "pw");
|
||||
|
||||
Assert.Throws<InvalidOperationException>(() => supervisor.Start(Spec(), "pw"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void StopCallsCloseMainWindowAndSucceedsWithoutKillWhenTheProcessExitsInTime()
|
||||
{
|
||||
var factory = new FakeChildProcessFactory(exitsWithinStopTimeout: true);
|
||||
using var supervisor = new LauncherProcessSupervisor(factory);
|
||||
supervisor.Start(Spec(), "pw");
|
||||
|
||||
supervisor.Stop(TimeSpan.FromMilliseconds(50));
|
||||
|
||||
FakeChildProcess fake = factory.LastCreated!;
|
||||
Assert.True(fake.CloseMainWindowCalled);
|
||||
Assert.Equal(0, fake.KillCallCount);
|
||||
Assert.Equal(LauncherSessionState.Exited, supervisor.State);
|
||||
Assert.Equal(0, supervisor.ExitCode);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void StopFallsBackToKillWhenTheProcessDoesNotExitWithinTheTimeout()
|
||||
{
|
||||
var factory = new FakeChildProcessFactory(exitsWithinStopTimeout: false);
|
||||
using var supervisor = new LauncherProcessSupervisor(factory);
|
||||
supervisor.Start(Spec(), "pw");
|
||||
|
||||
supervisor.Stop(TimeSpan.FromMilliseconds(50));
|
||||
|
||||
FakeChildProcess fake = factory.LastCreated!;
|
||||
Assert.True(fake.CloseMainWindowCalled);
|
||||
Assert.Equal(1, fake.KillCallCount);
|
||||
Assert.Equal(LauncherSessionState.Exited, supervisor.State);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void StopIsANoOpBeforeStart()
|
||||
{
|
||||
var factory = new FakeChildProcessFactory(exitsWithinStopTimeout: true);
|
||||
using var supervisor = new LauncherProcessSupervisor(factory);
|
||||
|
||||
supervisor.Stop(TimeSpan.FromMilliseconds(50));
|
||||
|
||||
Assert.Null(factory.LastCreated);
|
||||
Assert.Equal(LauncherSessionState.Starting, supervisor.State);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void StopIsANoOpAfterTheProcessHasAlreadyExited()
|
||||
{
|
||||
var factory = new FakeChildProcessFactory(exitsWithinStopTimeout: true);
|
||||
using var supervisor = new LauncherProcessSupervisor(factory);
|
||||
supervisor.Start(Spec(), "pw");
|
||||
supervisor.Stop(TimeSpan.FromMilliseconds(50));
|
||||
FakeChildProcess fake = factory.LastCreated!;
|
||||
Assert.Equal(0, fake.KillCallCount);
|
||||
|
||||
supervisor.Stop(TimeSpan.FromMilliseconds(50));
|
||||
|
||||
// CloseMainWindow was called exactly once (the first Stop) —
|
||||
// Stop after exit does not re-invoke the graceful/kill dance.
|
||||
Assert.Equal(1, fake.CloseMainWindowCallCount);
|
||||
Assert.Equal(0, fake.KillCallCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LauncherProcessSpecCarriesNoCredentialLikeMember()
|
||||
{
|
||||
// Defense in depth: the password must never be able to reach
|
||||
// process arguments or environment (Campaign LA plan §LA3). This
|
||||
// guards against a future field addition accidentally widening
|
||||
// that surface.
|
||||
System.Reflection.PropertyInfo[] properties =
|
||||
typeof(LauncherProcessSpec).GetProperties();
|
||||
Assert.DoesNotContain(
|
||||
properties,
|
||||
p => p.Name.Contains("password", StringComparison.OrdinalIgnoreCase)
|
||||
|| p.Name.Contains("credential", StringComparison.OrdinalIgnoreCase));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RealProcessSpawnFeedsStdinAndCapturesExitCode()
|
||||
{
|
||||
// The "trivial cross-platform fake child" (plan §LA3 acceptance):
|
||||
// `dotnet --version` is guaranteed present (we're running under
|
||||
// `dotnet test`) on both Windows and Linux/WSL, ignores stdin
|
||||
// entirely, and reliably exits 0 — proving the REAL
|
||||
// SystemChildProcessFactory spawn/stdin-feed/exit-code-capture
|
||||
// path end to end without any OS-specific script branching.
|
||||
string dotnet = FindDotnetExecutable();
|
||||
using var supervisor = new LauncherProcessSupervisor();
|
||||
var exited = new ManualResetEventSlim(false);
|
||||
supervisor.StateChanged += (_, s) =>
|
||||
{
|
||||
if (s == LauncherSessionState.Exited)
|
||||
exited.Set();
|
||||
};
|
||||
|
||||
supervisor.Start(
|
||||
new LauncherProcessSpec(dotnet, ["--version"]),
|
||||
"unused-password-ignored-by-dotnet");
|
||||
|
||||
bool completed = exited.Wait(TimeSpan.FromSeconds(30));
|
||||
|
||||
Assert.True(completed, "the real dotnet --version child did not exit within 30s");
|
||||
Assert.Equal(0, supervisor.ExitCode);
|
||||
}
|
||||
|
||||
private static LauncherProcessSpec Spec() =>
|
||||
new("fake-host", ["--session-config", "session.json"]);
|
||||
|
||||
private static string FindDotnetExecutable() =>
|
||||
// PATH-based resolution: .NET Core's Process.Start searches PATH
|
||||
// for a bare filename when UseShellExecute is false, on both
|
||||
// Windows and Unix, and `dotnet` is guaranteed on PATH here
|
||||
// because this test is itself running under `dotnet test`.
|
||||
OperatingSystem.IsWindows() ? "dotnet.exe" : "dotnet";
|
||||
|
||||
private sealed class FakeChildProcessFactory(bool exitsWithinStopTimeout)
|
||||
: ILauncherChildProcessFactory
|
||||
{
|
||||
public FakeChildProcess? LastCreated { get; private set; }
|
||||
|
||||
public ILauncherChildProcess Create(LauncherProcessSpec spec)
|
||||
{
|
||||
LastCreated = new FakeChildProcess(spec, exitsWithinStopTimeout);
|
||||
return LastCreated;
|
||||
}
|
||||
}
|
||||
|
||||
private sealed class FakeChildProcess(LauncherProcessSpec spec, bool exitsWithinStopTimeout)
|
||||
: ILauncherChildProcess
|
||||
{
|
||||
private readonly RecordingTextWriter _standardInput = new();
|
||||
|
||||
public LauncherProcessSpec Spec { get; } = spec;
|
||||
|
||||
public bool Started { get; private set; }
|
||||
|
||||
public string StandardInputText => _standardInput.ToString();
|
||||
|
||||
public bool StandardInputClosed => _standardInput.IsClosed;
|
||||
|
||||
public bool CloseMainWindowCalled => CloseMainWindowCallCount > 0;
|
||||
|
||||
public int CloseMainWindowCallCount { get; private set; }
|
||||
|
||||
public int KillCallCount { get; private set; }
|
||||
|
||||
public bool HasExited { get; private set; }
|
||||
|
||||
public int ExitCode { get; private set; }
|
||||
|
||||
public TextWriter StandardInput => _standardInput;
|
||||
|
||||
public event EventHandler? Exited;
|
||||
|
||||
public void Start() => Started = true;
|
||||
|
||||
public bool CloseMainWindow()
|
||||
{
|
||||
CloseMainWindowCallCount++;
|
||||
return true;
|
||||
}
|
||||
|
||||
public void Kill()
|
||||
{
|
||||
KillCallCount++;
|
||||
HasExited = true;
|
||||
ExitCode = -1;
|
||||
Exited?.Invoke(this, EventArgs.Empty);
|
||||
}
|
||||
|
||||
public bool WaitForExit(TimeSpan timeout)
|
||||
{
|
||||
if (!exitsWithinStopTimeout)
|
||||
return false;
|
||||
|
||||
HasExited = true;
|
||||
ExitCode = 0;
|
||||
Exited?.Invoke(this, EventArgs.Empty);
|
||||
return true;
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
}
|
||||
}
|
||||
|
||||
private sealed class RecordingTextWriter : StringWriter
|
||||
{
|
||||
public bool IsClosed { get; private set; }
|
||||
|
||||
protected override void Dispose(bool disposing)
|
||||
{
|
||||
IsClosed = true;
|
||||
base.Dispose(disposing);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,269 @@
|
|||
using System.Text.Json.Nodes;
|
||||
using AcDream.Launcher.Core.Launching;
|
||||
using AcDream.Launcher.Core.Profiles;
|
||||
using AcDream.Platform;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Launching;
|
||||
|
||||
/// <summary>
|
||||
/// Golden-shape tests for <see cref="SessionConfigComposer"/> against the
|
||||
/// Campaign LA plan §LA3 pinned contract: exactly the listed keys, exact
|
||||
/// camelCase names, character/policy presence rules per launch mode, and
|
||||
/// (critically) no password anywhere in the document.
|
||||
/// </summary>
|
||||
public sealed class SessionConfigComposerTests
|
||||
{
|
||||
private static readonly ApplicationPathSet Paths = new(
|
||||
ConfigDirectory: "/cfg/acdream",
|
||||
DataDirectory: "/data/acdream",
|
||||
CacheDirectory: "/cache/acdream",
|
||||
LegacyConfigDirectory: null);
|
||||
|
||||
private static readonly LauncherInstallRecord Install = new(
|
||||
DatDirectory: "/dats",
|
||||
PreparedAssetPath: "/data/acdream/pak/acdream.pak");
|
||||
|
||||
private static ServerProfile Server() =>
|
||||
new() { Name = "Local ACE", Host = "127.0.0.1", Port = 9000 };
|
||||
|
||||
private static AccountProfile Account() =>
|
||||
new() { Account = "testaccount", Password = "S3cretPassw0rd!" };
|
||||
|
||||
private static CharacterProfile Character(LaunchMode mode, string? id = "0x5000000A") =>
|
||||
new()
|
||||
{
|
||||
Name = "+Acdream",
|
||||
Id = id,
|
||||
LaunchMode = mode,
|
||||
Plugins = ["ExamplePlugin"],
|
||||
LoginCommands = ["/tell someone, hi"],
|
||||
};
|
||||
|
||||
[Fact]
|
||||
public void GuiModeIncludesCharacterSelectorAndOmitsPolicy()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-gui");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
|
||||
AssertKeys(
|
||||
session,
|
||||
"id", "endpoint", "account", "character", "credential",
|
||||
"plugins", "loginCommands", "statusFile");
|
||||
|
||||
Assert.Equal("session-gui", (string?)session["id"]);
|
||||
Assert.Equal("testaccount", (string?)session["account"]);
|
||||
Assert.Equal(0x5000000Au, (uint?)session["character"]!["id"]);
|
||||
Assert.Null(session["character"]!["name"]);
|
||||
Assert.Null(session["character"]!["index"]);
|
||||
Assert.Equal("standardInput", (string?)session["credential"]!["provider"]);
|
||||
Assert.Equal("session", (string?)session["credential"]!["reference"]);
|
||||
Assert.Equal(
|
||||
new[] { "ExamplePlugin" },
|
||||
session["plugins"]!.AsArray().Select(n => (string?)n));
|
||||
Assert.Equal(
|
||||
new[] { "/tell someone, hi" },
|
||||
session["loginCommands"]!.AsArray().Select(n => (string?)n));
|
||||
Assert.Equal(
|
||||
Path.Combine(Paths.CacheDirectory, "launcher", "sessions", "session-gui", "status.jsonl"),
|
||||
(string?)session["statusFile"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void GuiSelectModeOmitsCharacterFieldEntirely()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.GuiSelect),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-guiselect");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
|
||||
AssertKeys(
|
||||
session,
|
||||
"id", "endpoint", "account", "credential",
|
||||
"plugins", "loginCommands", "statusFile");
|
||||
Assert.False(session.ContainsKey("character"));
|
||||
Assert.False(session.ContainsKey("policy"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void HeadlessModeIncludesCharacterAndIdlePolicy()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Headless),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-headless",
|
||||
loginCommandDelayMs: 750);
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
|
||||
AssertKeys(
|
||||
session,
|
||||
"id", "endpoint", "account", "character", "policy", "credential",
|
||||
"plugins", "loginCommands", "loginCommandDelayMs", "statusFile");
|
||||
Assert.Equal(0x5000000Au, (uint?)session["character"]!["id"]);
|
||||
Assert.Equal("idle", (string?)session["policy"]!["id"]);
|
||||
Assert.Equal(750, (int?)session["loginCommandDelayMs"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void GuiModeFallsBackToNameSelectorWhenIdIsMissing()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui, id: null),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-gui-name");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
Assert.Null(session["character"]!["id"]);
|
||||
Assert.Equal("+Acdream", (string?)session["character"]!["name"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PluginsAndLoginCommandsAreOmittedWhenEmptyRatherThanEmptyArrays()
|
||||
{
|
||||
CharacterProfile character = Character(LaunchMode.Gui);
|
||||
character.Plugins = [];
|
||||
character.LoginCommands = [];
|
||||
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
character,
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-empty-lists");
|
||||
|
||||
JsonObject session = SingleSession(composed);
|
||||
Assert.False(session.ContainsKey("plugins"));
|
||||
Assert.False(session.ContainsKey("loginCommands"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ProcessContentCarriesInstallRecordAndPathsIsAlwaysPresent()
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: "session-content");
|
||||
|
||||
JsonObject root = ParseRoot(composed);
|
||||
Assert.Equal(1, (int?)root["version"]);
|
||||
JsonObject process = root["process"]!.AsObject();
|
||||
AssertKeys(process, "paths", "content");
|
||||
|
||||
// Paths is always present as an object; every member is omitted
|
||||
// when unset (hosts resolve their own default ApplicationPathSet).
|
||||
Assert.Empty(process["paths"]!.AsObject());
|
||||
|
||||
JsonObject content = process["content"]!.AsObject();
|
||||
AssertKeys(content, "datDirectory", "preparedAssetPath");
|
||||
Assert.Equal(Install.DatDirectory, (string?)content["datDirectory"]);
|
||||
Assert.Equal(Install.PreparedAssetPath, (string?)content["preparedAssetPath"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComposedDocumentNeverContainsThePassword()
|
||||
{
|
||||
AccountProfile account = Account();
|
||||
|
||||
foreach (LaunchMode mode in new[] { LaunchMode.Gui, LaunchMode.GuiSelect, LaunchMode.Headless })
|
||||
{
|
||||
ComposedSessionConfig composed = SessionConfigComposer.Compose(
|
||||
Server(),
|
||||
account,
|
||||
Character(mode),
|
||||
Install,
|
||||
Paths,
|
||||
sessionId: $"session-{mode}");
|
||||
|
||||
string json = SessionConfigComposer.Serialize(composed.Document);
|
||||
Assert.DoesNotContain(account.Password, json, StringComparison.Ordinal);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComposeAndWriteWritesSessionJsonUnderTheExpectedPath()
|
||||
{
|
||||
string root = Path.Combine(
|
||||
Path.GetTempPath(),
|
||||
"acdream-launcher-composer-tests",
|
||||
Guid.NewGuid().ToString("N"));
|
||||
try
|
||||
{
|
||||
var paths = new ApplicationPathSet(
|
||||
Path.Combine(root, "cfg"),
|
||||
Path.Combine(root, "data"),
|
||||
Path.Combine(root, "cache"),
|
||||
null);
|
||||
|
||||
ComposedSessionConfig composed = SessionConfigComposer.ComposeAndWrite(
|
||||
Server(),
|
||||
Account(),
|
||||
Character(LaunchMode.Gui),
|
||||
Install,
|
||||
paths,
|
||||
sessionId: "session-write");
|
||||
|
||||
string expectedPath = Path.Combine(
|
||||
paths.CacheDirectory, "launcher", "sessions", "session-write", "session.json");
|
||||
Assert.Equal(expectedPath, composed.ConfigFilePath);
|
||||
Assert.True(File.Exists(expectedPath));
|
||||
|
||||
string text = File.ReadAllText(expectedPath);
|
||||
Assert.DoesNotContain(Account().Password, text, StringComparison.Ordinal);
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (Directory.Exists(root))
|
||||
{
|
||||
Directory.Delete(root, recursive: true);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private static JsonObject ParseRoot(ComposedSessionConfig composed)
|
||||
{
|
||||
string json = SessionConfigComposer.Serialize(composed.Document);
|
||||
return JsonNode.Parse(json)!.AsObject();
|
||||
}
|
||||
|
||||
private static JsonObject SingleSession(ComposedSessionConfig composed)
|
||||
{
|
||||
JsonObject root = ParseRoot(composed);
|
||||
JsonArray sessions = root["sessions"]!.AsArray();
|
||||
return Assert.Single(sessions)!.AsObject();
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Asserts the object's property set is EXACTLY the given keys — no
|
||||
/// more, no fewer — without depending on reflection-based member
|
||||
/// enumeration order (only the presence/absence of each pinned-
|
||||
/// contract key is a guarantee this slice makes).
|
||||
/// </summary>
|
||||
private static void AssertKeys(JsonObject obj, params string[] expectedKeys)
|
||||
{
|
||||
var actual = new HashSet<string>(obj.Select(kv => kv.Key), StringComparer.Ordinal);
|
||||
var expected = new HashSet<string>(expectedKeys, StringComparer.Ordinal);
|
||||
Assert.Equal(expected, actual);
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,43 @@
|
|||
using AcDream.Launcher.Core.Profiles;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Profiles;
|
||||
|
||||
public sealed class CharacterIdFormatTests
|
||||
{
|
||||
[Fact]
|
||||
public void ToHexStringFormatsEightDigitUppercaseWithPrefix()
|
||||
{
|
||||
Assert.Equal("0x5000000A", CharacterIdFormat.ToHexString(0x5000000Au));
|
||||
Assert.Equal("0x00000001", CharacterIdFormat.ToHexString(1u));
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("0x5000000A", 0x5000000Au)]
|
||||
[InlineData("0x5000000a", 0x5000000Au)]
|
||||
[InlineData("5000000A", 0x5000000Au)]
|
||||
public void TryParseAcceptsWithAndWithoutPrefixAndCase(string text, uint expected)
|
||||
{
|
||||
Assert.True(CharacterIdFormat.TryParse(text, out uint id));
|
||||
Assert.Equal(expected, id);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(null)]
|
||||
[InlineData("")]
|
||||
[InlineData(" ")]
|
||||
[InlineData("not-hex")]
|
||||
public void TryParseRejectsNullEmptyOrNonHex(string? text)
|
||||
{
|
||||
Assert.False(CharacterIdFormat.TryParse(text, out uint id));
|
||||
Assert.Equal(0u, id);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RoundTripsThroughToHexStringAndTryParse()
|
||||
{
|
||||
const uint original = 0x5000000Au;
|
||||
string text = CharacterIdFormat.ToHexString(original);
|
||||
Assert.True(CharacterIdFormat.TryParse(text, out uint parsed));
|
||||
Assert.Equal(original, parsed);
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,287 @@
|
|||
using AcDream.Launcher.Core.Profiles;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Profiles;
|
||||
|
||||
public sealed class LauncherProfileStoreTests : IDisposable
|
||||
{
|
||||
private readonly string _root;
|
||||
private readonly string _filePath;
|
||||
|
||||
public LauncherProfileStoreTests()
|
||||
{
|
||||
_root = Path.Combine(
|
||||
Path.GetTempPath(),
|
||||
"acdream-launcher-profile-tests",
|
||||
Guid.NewGuid().ToString("N"));
|
||||
Directory.CreateDirectory(_root);
|
||||
_filePath = Path.Combine(_root, "launcher-profiles.json");
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (Directory.Exists(_root))
|
||||
{
|
||||
Directory.Delete(_root, recursive: true);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadOnMissingFileYieldsEmptyDocumentWithoutTouchingDisk()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
|
||||
bool loaded = store.Load();
|
||||
|
||||
Assert.False(loaded);
|
||||
Assert.False(File.Exists(_filePath));
|
||||
Assert.Equal(1, store.Document.Version);
|
||||
Assert.Empty(store.Document.Servers);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AddServerThenSaveThenReloadRoundTrips()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
store.Save();
|
||||
|
||||
Assert.True(File.Exists(_filePath));
|
||||
|
||||
var reloaded = new LauncherProfileStore(_filePath);
|
||||
reloaded.Load();
|
||||
|
||||
ServerProfile server = Assert.Single(reloaded.Document.Servers);
|
||||
Assert.Equal("Local ACE", server.Name);
|
||||
Assert.Equal("127.0.0.1", server.Host);
|
||||
Assert.Equal(9000, server.Port);
|
||||
Assert.Empty(server.Accounts);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AddServerRejectsDuplicateName()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
|
||||
var ex = Assert.Throws<LauncherProfileException>(
|
||||
() => store.AddServer("Local ACE", "127.0.0.1", 9001));
|
||||
Assert.Contains("Local ACE", ex.Message);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(0)]
|
||||
[InlineData(65536)]
|
||||
[InlineData(-1)]
|
||||
public void AddServerRejectsOutOfRangePort(int port)
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
|
||||
Assert.Throws<LauncherProfileException>(
|
||||
() => store.AddServer("Local ACE", "127.0.0.1", port));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void EditServerRenamesAndUpdatesHostAndPort()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
|
||||
store.EditServer("Local ACE", newName: "Home ACE", newHost: "10.0.0.5", newPort: 9001);
|
||||
|
||||
ServerProfile server = Assert.Single(store.Document.Servers);
|
||||
Assert.Equal("Home ACE", server.Name);
|
||||
Assert.Equal("10.0.0.5", server.Host);
|
||||
Assert.Equal(9001, server.Port);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void EditServerOnUnknownNameThrows()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
|
||||
Assert.Throws<LauncherProfileException>(
|
||||
() => store.EditServer("Nope", newHost: "1.2.3.4"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RemoveServerRemovesIt()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
|
||||
store.RemoveServer("Local ACE");
|
||||
|
||||
Assert.Empty(store.Document.Servers);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AddEditRemoveAccountRoundTrip()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
|
||||
store.AddAccount("Local ACE", "testaccount", "testpassword");
|
||||
AccountProfile account = Assert.Single(
|
||||
store.Document.Servers.Single().Accounts);
|
||||
Assert.Equal("testaccount", account.Account);
|
||||
Assert.Equal("testpassword", account.Password);
|
||||
|
||||
store.EditAccount(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
newAccount: "renamed",
|
||||
newPassword: "newpass");
|
||||
account = Assert.Single(store.Document.Servers.Single().Accounts);
|
||||
Assert.Equal("renamed", account.Account);
|
||||
Assert.Equal("newpass", account.Password);
|
||||
|
||||
store.RemoveAccount("Local ACE", "renamed");
|
||||
Assert.Empty(store.Document.Servers.Single().Accounts);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AddAccountRejectsDuplicateAccountOnSameServer()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
store.AddAccount("Local ACE", "testaccount", "pw");
|
||||
|
||||
Assert.Throws<LauncherProfileException>(
|
||||
() => store.AddAccount("Local ACE", "testaccount", "pw2"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void EditCharacterUpdatesLaunchModePluginsAndLoginCommandsOnly()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
store.AddAccount("Local ACE", "testaccount", "pw");
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(0x5000000A, "+Acdream", 0)]);
|
||||
|
||||
store.EditCharacter(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
"+Acdream",
|
||||
launchMode: LaunchMode.Headless,
|
||||
plugins: ["ExamplePlugin"],
|
||||
loginCommands: ["/tell someone, hi"]);
|
||||
|
||||
CharacterProfile character = Assert.Single(
|
||||
store.Document.Servers.Single().Accounts.Single().Characters);
|
||||
Assert.Equal(LaunchMode.Headless, character.LaunchMode);
|
||||
Assert.Equal(["ExamplePlugin"], character.Plugins);
|
||||
Assert.Equal(["/tell someone, hi"], character.LoginCommands);
|
||||
Assert.Equal("0x5000000A", character.Id);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FullProfileWithServersAccountsAndCharactersRoundTripsThroughDisk()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
store.AddAccount("Local ACE", "testaccount", "testpassword");
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(0x5000000A, "+Acdream", 0)]);
|
||||
store.EditCharacter(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
"+Acdream",
|
||||
launchMode: LaunchMode.Gui,
|
||||
plugins: ["ExamplePlugin"],
|
||||
loginCommands: ["/vt start"]);
|
||||
store.Save();
|
||||
|
||||
// Direct proof of the on-disk enum casing — a round-trip alone
|
||||
// could mask a PascalCase regression if the reader ever became
|
||||
// case-insensitive on enum values.
|
||||
string text = File.ReadAllText(_filePath);
|
||||
Assert.Contains("\"launchMode\":\"gui\"", text.Replace(" ", string.Empty));
|
||||
|
||||
var reloaded = new LauncherProfileStore(_filePath);
|
||||
reloaded.Load();
|
||||
|
||||
ServerProfile server = Assert.Single(reloaded.Document.Servers);
|
||||
AccountProfile account = Assert.Single(server.Accounts);
|
||||
CharacterProfile character = Assert.Single(account.Characters);
|
||||
Assert.Equal("+Acdream", character.Name);
|
||||
Assert.Equal("0x5000000A", character.Id);
|
||||
Assert.Equal(LaunchMode.Gui, character.LaunchMode);
|
||||
Assert.Equal(["ExamplePlugin"], character.Plugins);
|
||||
Assert.Equal(["/vt start"], character.LoginCommands);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadRejectsUnsupportedVersion()
|
||||
{
|
||||
File.WriteAllText(_filePath, """{"version":2,"servers":[]}""");
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
|
||||
Assert.Throws<LauncherProfileException>(() => store.Load());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadRejectsUnmappedMembersStrictly()
|
||||
{
|
||||
File.WriteAllText(
|
||||
_filePath,
|
||||
"""{"version":1,"servers":[],"unexpectedField":true}""");
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
|
||||
Assert.Throws<LauncherProfileException>(() => store.Load());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SaveWritesCamelCaseJson()
|
||||
{
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
store.Save();
|
||||
|
||||
string text = File.ReadAllText(_filePath);
|
||||
Assert.Contains("\"version\"", text);
|
||||
Assert.Contains("\"servers\"", text);
|
||||
Assert.Contains("\"host\"", text);
|
||||
Assert.DoesNotContain("\"Version\"", text);
|
||||
Assert.DoesNotContain("\"Servers\"", text);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SaveSetsOwnerOnlyPermissionsOnLinux()
|
||||
{
|
||||
// Linux-conditional: 0600 is a Linux-only hygiene step (spec §5,
|
||||
// decisions log item "Windows profile-file permissions"). A no-op
|
||||
// pass on Windows/macOS, matching the repo's established
|
||||
// OperatingSystem.IsLinux() early-return pattern (e.g.
|
||||
// HeadlessCredentialResolverTests.LinuxRejectsGroupOrOtherCredentialPermissions).
|
||||
if (!OperatingSystem.IsLinux())
|
||||
return;
|
||||
|
||||
var store = new LauncherProfileStore(_filePath);
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
store.AddAccount("Local ACE", "testaccount", "testpassword");
|
||||
store.Save();
|
||||
|
||||
UnixFileMode mode = File.GetUnixFileMode(_filePath);
|
||||
Assert.Equal(
|
||||
UnixFileMode.UserRead | UnixFileMode.UserWrite,
|
||||
mode);
|
||||
}
|
||||
}
|
||||
146
tests/AcDream.Launcher.Core.Tests/Profiles/RosterMergeTests.cs
Normal file
146
tests/AcDream.Launcher.Core.Tests/Profiles/RosterMergeTests.cs
Normal file
|
|
@ -0,0 +1,146 @@
|
|||
using AcDream.Launcher.Core.Profiles;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Profiles;
|
||||
|
||||
/// <summary>
|
||||
/// The roster-merge matrix (Campaign LA plan §LA3 acceptance): a new
|
||||
/// character, an existing character keeping its user settings, and a
|
||||
/// character absent from a later roster snapshot being retained
|
||||
/// (possibly pending-delete).
|
||||
/// </summary>
|
||||
public sealed class RosterMergeTests
|
||||
{
|
||||
private static LauncherProfileStore NewStoreWithServerAndAccount()
|
||||
{
|
||||
var store = new LauncherProfileStore(
|
||||
Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString("N") + ".json"));
|
||||
store.Load();
|
||||
store.AddServer("Local ACE", "127.0.0.1", 9000);
|
||||
store.AddAccount("Local ACE", "testaccount", "testpassword");
|
||||
return store;
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FirstMergeAddsNewCharactersWithDefaultLaunchModeGuiSelect()
|
||||
{
|
||||
LauncherProfileStore store = NewStoreWithServerAndAccount();
|
||||
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[
|
||||
new CharacterRosterEntry(0x5000000A, "+Acdream", 0),
|
||||
new CharacterRosterEntry(0x5000000B, "+Second", 0),
|
||||
]);
|
||||
|
||||
List<CharacterProfile> characters =
|
||||
store.Document.Servers.Single().Accounts.Single().Characters;
|
||||
Assert.Equal(2, characters.Count);
|
||||
|
||||
CharacterProfile first = characters.Single(c => c.Name == "+Acdream");
|
||||
Assert.Equal("0x5000000A", first.Id);
|
||||
Assert.Equal(LaunchMode.GuiSelect, first.LaunchMode);
|
||||
Assert.Empty(first.Plugins);
|
||||
Assert.Empty(first.LoginCommands);
|
||||
|
||||
CharacterProfile second = characters.Single(c => c.Name == "+Second");
|
||||
Assert.Equal("0x5000000B", second.Id);
|
||||
Assert.Equal(LaunchMode.GuiSelect, second.LaunchMode);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SecondMergePreservesUserSettingsOnAnExistingCharacter()
|
||||
{
|
||||
LauncherProfileStore store = NewStoreWithServerAndAccount();
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(0x5000000A, "+Acdream", 0)]);
|
||||
store.EditCharacter(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
"+Acdream",
|
||||
launchMode: LaunchMode.Headless,
|
||||
plugins: ["ExamplePlugin"],
|
||||
loginCommands: ["/vt start"]);
|
||||
|
||||
// A later probe reports the same character again (same id), with
|
||||
// a renamed display — settings must survive untouched.
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(0x5000000A, "+Acdream", 0)]);
|
||||
|
||||
CharacterProfile character = Assert.Single(
|
||||
store.Document.Servers.Single().Accounts.Single().Characters);
|
||||
Assert.Equal(LaunchMode.Headless, character.LaunchMode);
|
||||
Assert.Equal(["ExamplePlugin"], character.Plugins);
|
||||
Assert.Equal(["/vt start"], character.LoginCommands);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeUpdatesNameWhenIdMatchesButDisplayNameChanged()
|
||||
{
|
||||
LauncherProfileStore store = NewStoreWithServerAndAccount();
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(0x5000000A, "+OldName", 0)]);
|
||||
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(0x5000000A, "+NewName", 0)]);
|
||||
|
||||
CharacterProfile character = Assert.Single(
|
||||
store.Document.Servers.Single().Accounts.Single().Characters);
|
||||
Assert.Equal("+NewName", character.Name);
|
||||
Assert.Equal("0x5000000A", character.Id);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CharacterAbsentFromALaterRosterSnapshotIsRetained()
|
||||
{
|
||||
LauncherProfileStore store = NewStoreWithServerAndAccount();
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[
|
||||
new CharacterRosterEntry(0x5000000A, "+Acdream", 0),
|
||||
new CharacterRosterEntry(0x5000000B, "+PendingDelete", 1),
|
||||
]);
|
||||
|
||||
// A later probe's roster only reports one of the two — e.g. the
|
||||
// other was deleted and is now in ACE's grace window / a
|
||||
// partial snapshot. The store never removes rows on the
|
||||
// caller's behalf.
|
||||
store.MergeRoster(
|
||||
"Local ACE",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(0x5000000A, "+Acdream", 0)]);
|
||||
|
||||
List<CharacterProfile> characters =
|
||||
store.Document.Servers.Single().Accounts.Single().Characters;
|
||||
Assert.Equal(2, characters.Count);
|
||||
Assert.Contains(characters, c => c.Name == "+Acdream");
|
||||
Assert.Contains(characters, c => c.Name == "+PendingDelete");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeThrowsForUnknownServerOrAccount()
|
||||
{
|
||||
LauncherProfileStore store = NewStoreWithServerAndAccount();
|
||||
|
||||
Assert.Throws<LauncherProfileException>(
|
||||
() => store.MergeRoster(
|
||||
"Nope",
|
||||
"testaccount",
|
||||
[new CharacterRosterEntry(1, "x", 0)]));
|
||||
|
||||
Assert.Throws<LauncherProfileException>(
|
||||
() => store.MergeRoster(
|
||||
"Local ACE",
|
||||
"nope",
|
||||
[new CharacterRosterEntry(1, "x", 0)]));
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,125 @@
|
|||
using AcDream.Launcher.Core.Status;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Status;
|
||||
|
||||
public sealed class StatusEventParserTests
|
||||
{
|
||||
[Fact]
|
||||
public void ParsesStarted()
|
||||
{
|
||||
var e = StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"started","t":"2026-08-14T12:00:00Z","sessionId":"s1"}""");
|
||||
|
||||
var started = Assert.IsType<StartedStatusEvent>(e);
|
||||
Assert.Equal(1, started.V);
|
||||
Assert.Equal("started", started.E);
|
||||
Assert.Equal("s1", started.SessionId);
|
||||
Assert.Equal(
|
||||
DateTimeOffset.Parse("2026-08-14T12:00:00Z"),
|
||||
started.T);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParsesConnected()
|
||||
{
|
||||
var e = StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"connected","t":"2026-08-14T12:00:01Z","sessionId":"s1"}""");
|
||||
Assert.IsType<ConnectedStatusEvent>(e);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParsesCharacterListWithMultipleCharacters()
|
||||
{
|
||||
var e = StatusEventParser.Parse(
|
||||
"""
|
||||
{"v":1,"e":"characterList","t":"2026-08-14T12:00:02Z","sessionId":"s1",
|
||||
"accountName":"testaccount","slotCount":6,
|
||||
"characters":[
|
||||
{"id":1342177290,"name":"+Acdream","secondsGreyedOut":0},
|
||||
{"id":1342177291,"name":"+Second","secondsGreyedOut":1}
|
||||
]}
|
||||
""");
|
||||
|
||||
var list = Assert.IsType<CharacterListStatusEvent>(e);
|
||||
Assert.Equal("testaccount", list.AccountName);
|
||||
Assert.Equal(6, list.SlotCount);
|
||||
Assert.Equal(2, list.Characters.Count);
|
||||
Assert.Equal(1342177290u, list.Characters[0].Id);
|
||||
Assert.Equal("+Acdream", list.Characters[0].Name);
|
||||
Assert.Equal(0, list.Characters[0].SecondsGreyedOut);
|
||||
Assert.Equal(1342177291u, list.Characters[1].Id);
|
||||
Assert.Equal(1, list.Characters[1].SecondsGreyedOut);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParsesEnteredWorld()
|
||||
{
|
||||
var e = StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"enteredWorld","t":"2026-08-14T12:00:03Z","sessionId":"s1","characterId":1342177290,"characterName":"+Acdream"}""");
|
||||
|
||||
var entered = Assert.IsType<EnteredWorldStatusEvent>(e);
|
||||
Assert.Equal(1342177290u, entered.CharacterId);
|
||||
Assert.Equal("+Acdream", entered.CharacterName);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParsesPluginLoadedAndPluginFailed()
|
||||
{
|
||||
var loaded = Assert.IsType<PluginLoadedStatusEvent>(
|
||||
StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"pluginLoaded","t":"2026-08-14T12:00:04Z","sessionId":"s1","plugin":"ExamplePlugin"}"""));
|
||||
Assert.Equal("ExamplePlugin", loaded.Plugin);
|
||||
|
||||
var failed = Assert.IsType<PluginFailedStatusEvent>(
|
||||
StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"pluginFailed","t":"2026-08-14T12:00:05Z","sessionId":"s1","plugin":"BadPlugin","error":"boom"}"""));
|
||||
Assert.Equal("BadPlugin", failed.Plugin);
|
||||
Assert.Equal("boom", failed.Error);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParsesDisconnectedAndExited()
|
||||
{
|
||||
var disconnected = Assert.IsType<DisconnectedStatusEvent>(
|
||||
StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"disconnected","t":"2026-08-14T12:00:06Z","sessionId":"s1","reason":"serverClosed"}"""));
|
||||
Assert.Equal("serverClosed", disconnected.Reason);
|
||||
|
||||
var exited = Assert.IsType<ExitedStatusEvent>(
|
||||
StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"exited","t":"2026-08-14T12:00:07Z","sessionId":"s1","code":0,"reason":"graceful"}"""));
|
||||
Assert.Equal(0, exited.Code);
|
||||
Assert.Equal("graceful", exited.Reason);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void UnknownEValueSurfacesAsUnknownEventRatherThanThrowing()
|
||||
{
|
||||
var e = StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"someFutureEvent","t":"2026-08-14T12:00:08Z","sessionId":"s1","extra":true}""");
|
||||
|
||||
var unknown = Assert.IsType<UnknownStatusEvent>(e);
|
||||
Assert.Equal("someFutureEvent", unknown.E);
|
||||
Assert.Equal("s1", unknown.SessionId);
|
||||
Assert.Contains("someFutureEvent", unknown.RawJson);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MalformedJsonSurfacesAsUnknownEventRatherThanThrowing()
|
||||
{
|
||||
var e = StatusEventParser.Parse("{not json");
|
||||
|
||||
Assert.IsType<UnknownStatusEvent>(e);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void KnownEValueWithMissingRequiredFieldSurfacesAsUnknownEventRatherThanThrowing()
|
||||
{
|
||||
// characterList without "characters" — a shape mismatch, not
|
||||
// just an unrecognized e value.
|
||||
var e = StatusEventParser.Parse(
|
||||
"""{"v":1,"e":"characterList","t":"2026-08-14T12:00:09Z","sessionId":"s1","accountName":"a","slotCount":6}""");
|
||||
|
||||
Assert.IsType<UnknownStatusEvent>(e);
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,172 @@
|
|||
using System.Text;
|
||||
using AcDream.Launcher.Core.Status;
|
||||
|
||||
namespace AcDream.Launcher.Core.Tests.Status;
|
||||
|
||||
public sealed class StatusFileTailerTests : IDisposable
|
||||
{
|
||||
private readonly string _root;
|
||||
private readonly string _path;
|
||||
|
||||
public StatusFileTailerTests()
|
||||
{
|
||||
_root = Path.Combine(
|
||||
Path.GetTempPath(),
|
||||
"acdream-launcher-tailer-tests",
|
||||
Guid.NewGuid().ToString("N"));
|
||||
Directory.CreateDirectory(_root);
|
||||
_path = Path.Combine(_root, "status.jsonl");
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (Directory.Exists(_root))
|
||||
{
|
||||
Directory.Delete(_root, recursive: true);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ReturnsNoEventsWhenTheFileDoesNotExistYet()
|
||||
{
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
|
||||
IReadOnlyList<StatusEvent> events = tailer.ReadNewEvents();
|
||||
|
||||
Assert.Empty(events);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ReturnsNoEventsWhenNothingHasBeenAppendedSinceTheLastPoll()
|
||||
{
|
||||
AppendShared(Line("started", "s1"));
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
Assert.Single(tailer.ReadNewEvents());
|
||||
|
||||
IReadOnlyList<StatusEvent> events = tailer.ReadNewEvents();
|
||||
|
||||
Assert.Empty(events);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ReadsMultipleCompleteLinesInOnePoll()
|
||||
{
|
||||
AppendShared(Line("started", "s1") + Line("connected", "s1"));
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
|
||||
IReadOnlyList<StatusEvent> events = tailer.ReadNewEvents();
|
||||
|
||||
Assert.Equal(2, events.Count);
|
||||
Assert.IsType<StartedStatusEvent>(events[0]);
|
||||
Assert.IsType<ConnectedStatusEvent>(events[1]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void TolerateAPartialLastLineAndCompletesItOnALaterPoll()
|
||||
{
|
||||
string full = Line("started", "s1");
|
||||
int splitAt = full.Length - 10; // cut mid-object, before the closing brace/newline
|
||||
AppendShared(full[..splitAt]);
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
|
||||
IReadOnlyList<StatusEvent> firstPoll = tailer.ReadNewEvents();
|
||||
Assert.Empty(firstPoll);
|
||||
|
||||
AppendShared(full[splitAt..]);
|
||||
IReadOnlyList<StatusEvent> secondPoll = tailer.ReadNewEvents();
|
||||
|
||||
StatusEvent onlyEvent = Assert.Single(secondPoll);
|
||||
Assert.IsType<StartedStatusEvent>(onlyEvent);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void APartialLineFollowedByAFullLineOnlyEmitsTheCompleteOne()
|
||||
{
|
||||
AppendShared(Line("started", "s1"));
|
||||
string partial = """{"v":1,"e":"connected","t":"2026-08-14T12:00:00Z","sessionId":"s1"""; // no closing
|
||||
AppendShared(partial);
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
|
||||
IReadOnlyList<StatusEvent> events = tailer.ReadNewEvents();
|
||||
|
||||
StatusEvent onlyEvent = Assert.Single(events);
|
||||
Assert.IsType<StartedStatusEvent>(onlyEvent);
|
||||
|
||||
// Completing the second line on a later poll produces exactly
|
||||
// one more event, proving the partial bytes were retained (not
|
||||
// dropped and not double-counted).
|
||||
AppendShared("\"}\n");
|
||||
IReadOnlyList<StatusEvent> secondPoll = tailer.ReadNewEvents();
|
||||
StatusEvent completed = Assert.Single(secondPoll);
|
||||
Assert.IsType<ConnectedStatusEvent>(completed);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SkipsBlankLines()
|
||||
{
|
||||
AppendShared("\n" + Line("started", "s1") + "\n" + Line("connected", "s1"));
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
|
||||
IReadOnlyList<StatusEvent> events = tailer.ReadNewEvents();
|
||||
|
||||
Assert.Equal(2, events.Count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ReadsWithAWriterHoldingTheFileOpenForAppend()
|
||||
{
|
||||
// Share-tolerant reads: the writer's handle stays open the whole
|
||||
// time (FileShare.ReadWrite on both sides), matching a live host
|
||||
// process appending status.jsonl while the launcher tails it.
|
||||
using var writer = new FileStream(
|
||||
_path,
|
||||
FileMode.Create,
|
||||
FileAccess.Write,
|
||||
FileShare.ReadWrite | FileShare.Delete);
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
|
||||
byte[] first = Encoding.UTF8.GetBytes(Line("started", "s1"));
|
||||
writer.Write(first, 0, first.Length);
|
||||
writer.Flush();
|
||||
|
||||
IReadOnlyList<StatusEvent> firstPoll = tailer.ReadNewEvents();
|
||||
Assert.Single(firstPoll);
|
||||
|
||||
byte[] second = Encoding.UTF8.GetBytes(Line("connected", "s1"));
|
||||
writer.Write(second, 0, second.Length);
|
||||
writer.Flush();
|
||||
|
||||
IReadOnlyList<StatusEvent> secondPoll = tailer.ReadNewEvents();
|
||||
Assert.Single(secondPoll);
|
||||
Assert.IsType<ConnectedStatusEvent>(secondPoll[0]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RestartsFromTheTopWhenTheFileIsTruncatedOrReplaced()
|
||||
{
|
||||
AppendShared(Line("started", "s1") + Line("connected", "s1"));
|
||||
var tailer = new StatusFileTailer(_path);
|
||||
Assert.Equal(2, tailer.ReadNewEvents().Count);
|
||||
|
||||
File.Delete(_path);
|
||||
AppendShared(Line("started", "s2"));
|
||||
|
||||
IReadOnlyList<StatusEvent> events = tailer.ReadNewEvents();
|
||||
StatusEvent onlyEvent = Assert.Single(events);
|
||||
Assert.Equal("s2", onlyEvent.SessionId);
|
||||
}
|
||||
|
||||
private static string Line(string e, string sessionId) =>
|
||||
$$"""{"v":1,"e":"{{e}}","t":"2026-08-14T12:00:00Z","sessionId":"{{sessionId}}"}""" + "\n";
|
||||
|
||||
private void AppendShared(string text)
|
||||
{
|
||||
using var stream = new FileStream(
|
||||
_path,
|
||||
FileMode.Append,
|
||||
FileAccess.Write,
|
||||
FileShare.ReadWrite | FileShare.Delete);
|
||||
byte[] bytes = Encoding.UTF8.GetBytes(text);
|
||||
stream.Write(bytes, 0, bytes.Length);
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue