feat(launcher): Campaign LA LA3 — AcDream.Launcher.Core profile store, composer, supervisor, status tailer

New AcDream.Launcher.Core (BCL-only, ProjectReference: AcDream.Platform
ONLY) plus tests/AcDream.Launcher.Core.Tests, both registered in
AcDream.slnx. This is the file-contract orchestrator core the Avalonia
launcher (LA4) will bind to — the game solution (Core/Runtime/App/
Headless) stays entirely out of this dependency graph, so the launcher
can never accidentally grow a game-protocol coupling.

- Profiles/: LauncherProfileStore owns launcher-profiles.json (spec §5
  schema: version 1, servers[]/accounts[]/characters[]), strict
  camelCase System.Text.Json (UnmappedMemberHandling.Disallow), typed
  CRUD (add/edit/remove server; add/edit/remove account; edit character
  settings), and MergeRoster (fold a reported roster into an account's
  characters[] while preserving user-owned launchMode/plugins/
  loginCommands, adding new rows with default guiSelect, and retaining
  rows absent from the roster — they may be pending-delete). 0600 on
  Linux via File.SetUnixFileMode after save.
- Launching/: SessionConfigComposer builds the pinned session-config
  contract (Headless K1 shape + plugins/loginCommands/
  loginCommandDelayMs/statusFile) from a profile character + install
  record — character selector omitted entirely for guiSelect, policy
  {id:"idle"} only for headless, credential always standardInput/
  session. Passwords never enter this document (proven by a dedicated
  test). LauncherProcessSupervisor spawns a host, feeds the password to
  stdin then closes it, and exposes Starting/Running/Exited lifecycle;
  Stop calls CloseMainWindow falling back to Kill after a timeout, both
  reachable through an injectable ILauncherChildProcess/factory seam so
  the state machine is unit-testable without real OS process timing.
- Status/: StatusEventParser decodes the v1 status.jsonl vocabulary
  (started/connected/characterList/enteredWorld/pluginLoaded/
  pluginFailed/disconnected/exited); an unrecognized "e" or a malformed
  line degrades to a typed Unknown event rather than throwing.
  StatusFileTailer incrementally reads new lines, tolerating a
  not-yet-existing file and a partial trailing line (only advances its
  read position past confirmed '\n' boundaries; a truncated tail is
  simply re-read next poll, never parsed early).
- Integrity/: streaming SHA-256 + hex verify for later pak/download
  checks (LA9/LA10).

Tests: 71 passed (profile CRUD + roster-merge matrix + strict-schema
rejection; composer golden-shape tests for gui/guiSelect/headless +
password-absence; supervisor tests against both an injected fake child
(state-machine determinism) and a real spawned `dotnet --version`
child (genuine cross-platform stdin/exit-code proof); tailer tests
incl. partial-line and not-yet-existing-file; SHA-256 tests). Verified
green on Windows (Release) and native WSL/Linux (Release) — the Linux
0600 test executes its real assertion body under WSL rather than
early-returning.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-14 15:49:13 +02:00
parent cb6502c8a5
commit 37d74e4402
31 changed files with 3131 additions and 0 deletions

View file

@ -0,0 +1,120 @@
using System.Diagnostics;
namespace AcDream.Launcher.Core.Launching;
/// <summary>
/// Thin seam over <see cref="System.Diagnostics.Process"/> so
/// <see cref="LauncherProcessSupervisor"/>'s lifecycle and Stop
/// (CloseMainWindow, falling back to Kill after a timeout) state machine
/// can be unit-tested against an in-memory fake without spawning a real
/// OS process or depending on real window-message timing — both
/// "injectable for tests" per Campaign LA spec §3.
/// </summary>
public interface ILauncherChildProcess : IDisposable
{
bool HasExited { get; }
int ExitCode { get; }
/// <summary>The child's redirected stdin. The supervisor writes the
/// account password here (followed by a newline) and then closes it —
/// never anywhere else.</summary>
TextWriter StandardInput { get; }
/// <summary>Fires exactly once, when the child process terminates
/// (mirrors <see cref="Process.Exited"/> with
/// <c>EnableRaisingEvents</c> on).</summary>
event EventHandler? Exited;
void Start();
/// <summary>Mirrors <see cref="Process.CloseMainWindow"/> — requests
/// a graceful close via WM_CLOSE. Returns false for a console/no-
/// window process (never throws), matching the real API.</summary>
bool CloseMainWindow();
/// <summary>Mirrors <see cref="Process.Kill(bool)"/> with
/// <c>entireProcessTree: true</c>.</summary>
void Kill();
bool WaitForExit(TimeSpan timeout);
}
/// <summary>Creates <see cref="ILauncherChildProcess"/> instances from a
/// <see cref="LauncherProcessSpec"/>.</summary>
public interface ILauncherChildProcessFactory
{
ILauncherChildProcess Create(LauncherProcessSpec spec);
}
/// <summary>Real-process implementation used in production.</summary>
public sealed class SystemChildProcessFactory : ILauncherChildProcessFactory
{
public ILauncherChildProcess Create(LauncherProcessSpec spec) =>
new SystemChildProcess(spec);
}
internal sealed class SystemChildProcess : ILauncherChildProcess
{
private readonly Process _process;
private bool _raisingEnabled;
internal SystemChildProcess(LauncherProcessSpec spec)
{
ArgumentNullException.ThrowIfNull(spec);
var startInfo = new ProcessStartInfo
{
FileName = spec.ExecutablePath,
RedirectStandardInput = true,
UseShellExecute = false,
};
foreach (string argument in spec.Arguments)
{
startInfo.ArgumentList.Add(argument);
}
if (!string.IsNullOrEmpty(spec.WorkingDirectory))
{
startInfo.WorkingDirectory = spec.WorkingDirectory;
}
_process = new Process { StartInfo = startInfo };
}
public bool HasExited => _process.HasExited;
public int ExitCode => _process.ExitCode;
public TextWriter StandardInput => _process.StandardInput;
public event EventHandler? Exited;
public void Start()
{
_process.EnableRaisingEvents = true;
_process.Exited += OnExited;
_raisingEnabled = true;
_process.Start();
}
public bool CloseMainWindow() => _process.CloseMainWindow();
public void Kill() => _process.Kill(entireProcessTree: true);
public bool WaitForExit(TimeSpan timeout) => _process.WaitForExit(timeout);
public void Dispose()
{
if (_raisingEnabled)
{
_process.Exited -= OnExited;
}
_process.Dispose();
}
private void OnExited(object? sender, EventArgs e) =>
Exited?.Invoke(this, EventArgs.Empty);
}