erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

fix #436: combat no-target refusal reaches the SpewBox with retail's exact text

Browse source 
Attacking with no valid target has told the player nothing since Campaign V
slice V11 orphaned the DebugVM toast the message was wired to (#434 found
the drop; this closes it retail-faithfully).

Ground truth from the Ghidra decompile of
ClientCombatSystem::ExecuteAttack (0x0056bb70): retail writes
"You must select a valid combat target before attacking" via
ClientSystem::AddTextToScroll(..., 0x1A, true, 0) — the ClientLocal
SpewBox channel this codebase already routes every other client-local
refusal through. And retail has ONE message, not the two we carried:
attacking outside melee/missile modes is silent (ExecuteAttack is
unreachable there), so the invented "Enter melee or missile combat first"
text is deleted rather than rerouted, and the invented "No monster
target" is replaced by the retail string, which joins ClientTextRefusals
with its decomp citation.

Wiring: CombatFeedbackSlot gains the sibling BindOwned session-lifetime
shape, and SessionPlayerComposition.CompleteSessionPlayer binds it to
RuntimeCommunicationState.AddText(ClientLocal) with session-owned
teardown — a torn-down session's slot returns to its silent unbound
state. A binding-seam test
(CompleteSessionPlayerBindsCombatFeedbackToTheClientLocalSpewBoxRoute)
inspects the compiled composition for the BindOwned call and its
AddText-routing lambda, so the slot can never again pass its unit tests
while production leaves it unbound — the exact failure mode that hid
this defect. The two tests that pinned the invented strings now pin the
retail contract (exact string; silence for the unsupported-mode case).

Full hermetic suite 15,325 passed / 0 failed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-24 12:53:11 +02:00
parent 7969a20c8c
commit 35454a9f58
7 changed files with 157 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/AcDream.App.Tests/Combat/LiveCombatAttackOperationsTests.cs
View file

@ -54,13 +54,18 @@ public sealed class LiveCombatAttackOperationsTests
}
[Fact]
public void UnsupportedCombatModeUsesTypedFeedbackSink()
public void UnsupportedCombatModeRefusesSilently()
{
// #436: retail emits NO text for this case —
// ClientCombatSystem::ExecuteAttack (0x0056bb70) is unreachable
// outside melee/missile modes, so there is no retail string to show.
// The pre-#436 "Enter melee or missile combat first" message was
// invented dev text and is deleted, not rerouted.
Harness harness = CreateHarness(inWorld: true);
Assert.False(harness.Owner.CanStartAttack());
Assert.Equal(["Enter melee or missile combat first"], harness.Feedback.Messages);
Assert.Empty(harness.Feedback.Messages);
Assert.Equal(0, harness.Targets.ResolveCount);
}
@ -88,7 +93,11 @@ public sealed class LiveCombatAttackOperationsTests
Assert.False(harness.Owner.CanStartAttack());
Assert.Equal(["No monster target"], harness.Feedback.Messages);
// Retail's exact string — ClientCombatSystem::ExecuteAttack's
// no-valid-target branch (0x0056bc05), AddTextToScroll(0x1A).
Assert.Equal(
[AcDream.Core.Chat.ClientTextRefusals.MustSelectCombatTarget],
harness.Feedback.Messages);
}
private static Harness CreateHarness(bool inWorld = false)