fix #436: combat no-target refusal reaches the SpewBox with retail's exact text
Attacking with no valid target has told the player nothing since Campaign V slice V11 orphaned the DebugVM toast the message was wired to (#434 found the drop; this closes it retail-faithfully). Ground truth from the Ghidra decompile of ClientCombatSystem::ExecuteAttack (0x0056bb70): retail writes "You must select a valid combat target before attacking" via ClientSystem::AddTextToScroll(..., 0x1A, true, 0) — the ClientLocal SpewBox channel this codebase already routes every other client-local refusal through. And retail has ONE message, not the two we carried: attacking outside melee/missile modes is silent (ExecuteAttack is unreachable there), so the invented "Enter melee or missile combat first" text is deleted rather than rerouted, and the invented "No monster target" is replaced by the retail string, which joins ClientTextRefusals with its decomp citation. Wiring: CombatFeedbackSlot gains the sibling BindOwned session-lifetime shape, and SessionPlayerComposition.CompleteSessionPlayer binds it to RuntimeCommunicationState.AddText(ClientLocal) with session-owned teardown — a torn-down session's slot returns to its silent unbound state. A binding-seam test (CompleteSessionPlayerBindsCombatFeedbackToTheClientLocalSpewBoxRoute) inspects the compiled composition for the BindOwned call and its AddText-routing lambda, so the slot can never again pass its unit tests while production leaves it unbound — the exact failure mode that hid this defect. The two tests that pinned the invented strings now pin the retail contract (exact string; silence for the unsupported-mode case). Full hermetic suite 15,325 passed / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
7969a20c8c
commit
35454a9f58
7 changed files with 157 additions and 19 deletions
|
|
@ -144,4 +144,19 @@ public static class ClientTextRefusals
|
|||
/// SpewBox-only channel every other refusal in this file uses.
|
||||
/// </summary>
|
||||
public const string CantLogOffMidAir = "Cannot log off while in mid-air.";
|
||||
|
||||
/// <summary>
|
||||
/// #436 — attack pressed with no valid combat target. Inline literal in
|
||||
/// <c>ClientCombatSystem::ExecuteAttack</c> (<c>0x0056bb70</c>; the
|
||||
/// refusal branch at <c>0x0056bc05</c>), routed via
|
||||
/// <c>ClientSystem::AddTextToScroll(..., 0x1A, true, 0)</c> — the same
|
||||
/// <c>RetailLogTextType.ClientLocal</c> SpewBox channel as the rest of
|
||||
/// this file, though unlike the 11 globals above it is not one of
|
||||
/// <c>ClientCommunicationSystem</c>'s static-ctor strings. Retail shows
|
||||
/// ONLY this message here: attacking while not in melee/missile mode is
|
||||
/// silent (that path is unreachable in retail's dispatch), so acdream
|
||||
/// deliberately emits nothing for that case either.
|
||||
/// </summary>
|
||||
public const string MustSelectCombatTarget =
|
||||
"You must select a valid combat target before attacking";
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue