From 2f1e625fea54ba24f1403a95bd59ad9136ea8eaf Mon Sep 17 00:00:00 2001 From: Erik Date: Sat, 5 Sep 2026 03:23:55 +0200 Subject: [PATCH] docs(overhaul): close issue 470 --- docs/ISSUES.md | 23 ++++--- ...-09-01-campaign-overhaul-world-solidity.md | 4 +- .../s5-consumers-material-closeout-packet.md | 67 +++++++++++++++++++ 3 files changed, 83 insertions(+), 11 deletions(-) diff --git a/docs/ISSUES.md b/docs/ISSUES.md index 845a12d0..2a73ddff 100644 --- a/docs/ISSUES.md +++ b/docs/ISSUES.md @@ -66,16 +66,13 @@ recipe-10 graphical route captured 13/13 intact frames at `logs/selfgate-20260905-020703-s5c4-onepass-detail` (provisional until owner inspection). -## #470 — Atmospheric ordered world draws use absolute transform indices for local sidecars +## #470 — Ordered world draws use absolute transform indices for local sidecars -**Status:** FIX ROUND 2 — renderer repair `51f974da4` is correct and evidence- -lane fix `2cad9c84` passed narrow review pass 2/10. Full production review pass -3/10 found one harness-only P2: the offscreen image-to-buffer readback has no -transfer-write -> host-read memory dependency before mapping. The bounded -barrier/test contract is S5 packet §29; landing and graphical A/B remain -locked. Campaign OVERHAUL v2 renderer-solid/G4 scope. The production residual -predates S5-c3 and is present at least as far back as landed S4-c2 -`252886e84`. +**Status:** DONE 2026-09-05 — campaign implementation `15a796c3a`, Vulkan-lane +fix `7506e5f14`, readback-barrier fix `b333edb4f`; sequential reviews PASS +through pass 4/10; lead graphical A/B PROVISIONAL PASS at +`logs/selfgate-20260905-032132-s5-470-pinned-shadow-ab-r1`. Full landing and +evidence record: S5 packet §§27–30. G4 remains unpassed. **Evidence/mechanism:** `WbDrawDispatcher.PrepareOrderedStream` writes instance transforms into the shared directional-shadow transform arena and offsets every @@ -115,6 +112,14 @@ record an exact readback-buffer barrier from `CopyBit`/`TransferWriteBit` to descriptor and copy -> barrier -> end order without initializing Vulkan. No renderer, shader, lane, recipe, or graphical policy changes. +**Closeout:** ordinary shader transforms now use the shared absolute index and +all five live sidecars use the exact local index. The real production SPIR-V +pixel witness runs in the explicit Vulkan-capability lane with a specification- +correct host-read dependency. Exact scratch proof: hermetic 16,976/16,976, +canonical InstalledDat 386/10/1, manifests 30/30. The fixed-pose retail/off -> +High -> retail/off route captured 3/3 intact frames, exited 0/gracefully, and +left no client. The separate #469 lighting-direction transition remains open. + ## #469 — Atmospheric shadow-gate transition switches the whole outdoor lighting direction abruptly and can darken the world **Status:** OPEN — found 2026-09-04 by the S5-c2 lead graphical gate; Campaign diff --git a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md index 0f922b09..efc1bd38 100644 --- a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md +++ b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md @@ -693,8 +693,8 @@ Update immediately when a slice changes state. Chat is not the ledger. | S5-c2 | **LANDED + REVIEW-CLOSED 2026-09-04; lead graphical gate PROVISIONAL PASS.** Campaign stack `a4de2efc4` -> `048027e71` -> `ef819eedf`; reviewed scratch tip `521f5edda54`; packet §§14–16. The opt-in IA-24 path borrows the exact prior-completed landscape set/flag, selects world casters through S2 CELLARRAY or building `EffectCellId`, selects authored terrain slots, and projects exact active instance runs without rebuilding retained topology. Pack-off remains unchanged. | G4 UNPASSED | Retail/deviation PASS; production's documentation-only fix round 1 narrowly re-reviewed PASS. Fresh campaign Release 0W/0E and affected 137/137. Official evidence: hermetic 16,768/16,768; broader InstalledDat 468 pass / 10 fail / 1 skip; canonical 385 pass / the same 10 fail / 1 skip; manifests and nonpassing identities exact. Valid lead gate `logs/selfgate-20260904-183925-s5c2-candidate-shadow-ab`: seven PNGs, exit 0, graceful logout, no fatal match, no client left. Exact parent `5c106bcdf` A/B at `s5-c2-ab-parent/logs/selfgate-20260904-183815-s5c2-parent-shadow-ab` proves the gate-visible dark lighting switch predates c2; #469/IA-24 carry it for resolution or explicit owner acceptance before G4. Owner PNG inspection pending. | | S5-c3 | **LANDED + REVIEW-CLOSED 2026-09-04** at `c673f767e` (reviewed scratch `01e5a15d0`; packet §§17–21). | **C3 SCOPE SELF-GATE PROVISIONAL PASS; whole-renderer finding #470 OPEN. G4 UNPASSED.** | OpenAI retail pass 3/10 PASS and production narrow re-review pass 5/10 PASS. Fix round 3 added ordinary landblock-lifetime ownership for every unique nonzero ladder GfxObj, rearmed walk-frame miss requests, and made the one-tick-before-BeginFrame proof discriminating. Fresh clean campaign: Release 0W/0E; focused 101/101; hermetic 16,811/16,811; InstalledDat 469 pass / the unchanged documented 10 fail / 1 skip; manifests 30/30. Self-gate `logs/selfgate-20260904-223345-s5c3-building-degrade` produced five PNGs, exited 0/gracefully, and left no client. The selected building shells are complete; the Holtburg frame also exposed pre-existing atmospheric ordered-draw sidecar defect #470, which is not a c3 regression and blocks renderer-solid/G4 until repaired. | | S5-c4 | **LANDED + REVIEW-CLOSED 2026-09-05; LEAD GRAPHICAL GATE PROVISIONAL PASS.** Campaign stack `75664805f` -> `15ed57a1e` -> `d5cfd1c91` -> `03a108ffa`; reviewed scratch tip `db8136448`; packet §§22–26. | G4 UNPASSED | Retail/material pass 3/10 PASS. Full production pass 4/10 found one classic/private detail-off regression; fix round 3 restored the prior AlphaBlend/coalescing path, and narrow production pass 5/10 PASS reproduced all three mutations. Fresh campaign Release 0W/0E, App 245/245, Content 71/71; scratch hermetic 16,971/16,971 and InstalledDat 469/10/1 with both manifests 32/32. Full recipe-10 bake: 2,237,865 keys, zero failures, SHA `4E0FA6C5…29B59B`. Gate `logs/selfgate-20260905-020703-s5c4-onepass-detail`: 13/13 PNGs, exit 0, graceful, no client left; visual PASS provisional. #471 DONE; #470 narrowed to local-sidecar indexing. | -| S5-#470 | **FIX ROUND 2 IN FLIGHT.** Renderer implementation `51f974da4` is correct. Evidence-lane fix `2cad9c84` passed narrow retail/gate-honesty pass 2/10. Full production pass 3/10 found one harness-only P2: the image-to-buffer readback lacks the required transfer-write -> host-read dependency. Fix contract = packet §29. | G4 UNPASSED | Add the exact post-copy/pre-end buffer barrier and a live descriptor/order guard; no renderer/shader/lane change. Then narrow production re-review pass 4/10. Landing and the pinned graphical A/B remain locked until PASS. | -| S5 | IN FLIGHT — c1–c4 landed/review-closed/provisionally self-gated; #470 fix round 2 contracted; #469, c5, closeout, and G4 remain | G4 | Packet §§7 and 12–29 are binding. Next: close #470's readback synchronization finding, narrow production re-review, land, and run its pinned graphical A/B; after that #469, c5 cleanup, closeout, and G4. Never merge main before G4. | +| S5-#470 | **LANDED + REVIEW-CLOSED 2026-09-05; LEAD GRAPHICAL A/B PROVISIONAL PASS.** Campaign implementation stack `15a796c3a` -> `7506e5f14` -> `b333edb4f`; route `19b44e5e3`; reviewed scratch `51f974da4` -> `2cad9c84` -> `98c004aa7`; packet §§27–30. | G4 UNPASSED | Retail/behavior pass 2/10 and production pass 4/10 closed the two evidence-only findings. Fresh campaign Release 0W/0E and focused 48/48; exact scratch hermetic 16,976/16,976 and canonical InstalledDat 386/10/1, manifests 30/30. Pinned gate `logs/selfgate-20260905-032132-s5-470-pinned-shadow-ab-r1`: retail/off -> High -> retail/off, 3/3 PNGs, exit 0, graceful, no client; visual PASS provisional. The stale recipe-8 pre-route launch is excluded and recorded in §30. | +| S5 | IN FLIGHT — c1–c4 plus #470 landed/review-closed/provisionally self-gated; #469, c5, closeout, and G4 remain | G4 | Packet §§7 and 12–30 are binding. Next: bound, implement, review, and graphically gate #469's lighting-direction repair; then c5 cleanup, closeout, and G4. Never merge main before G4. | --- diff --git a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md index 0b2bd2f0..6c7208ce 100644 --- a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md +++ b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md @@ -2620,3 +2620,70 @@ proofs remain intact, and verify exact clean artifact provenance. A PASS unlocks landing and the pinned graphical A/B. A FAIL receives the next bounded contract within the owner-authorized ten-pass ceiling. Nothing lands or launches before PASS. + +## 30. S5-#470 landing, review closeout, and lead graphical A/B — 2026-09-05 + +S5 issue #470 is **LANDED + REVIEW-CLOSED**. Reviewed scratch implementation +`51f974da4`, evidence-lane fix `2cad9c84`, and readback-barrier fix +`98c004aa7` map to campaign commits `15a796c3a`, `7506e5f14`, and +`b333edb4f`. Lead contracts are campaign `67a8bc21f`, `011ab1c18`, and +`56837f547`; fixed-pose gate route commit is `19b44e5e3`. + +Retail/behavior pass 1/10 found no renderer or retail-policy defect and found +the hardware witness incorrectly owned by the portable lane. The evidence- +lane repair then passed narrow pass 2/10. Full production pass 3/10 verified +the complete transform/sidecar/descriptor/push/SPIR-V path but found one P2 in +the witness: coherent memory plus queue idle did not replace a transfer-write +to host-read dependency. Fix round 2 added that exact live buffer barrier and +a portable descriptor/order guard. Narrow production pass 4/10 returned +**PASS with no remaining finding**, independently reproduced all three +barrier mutations, ran the physical pixel witness, and confirmed every +renderer/shader/lane byte outside the bounded stack stayed unchanged. + +Exact reviewed evidence at scratch `98c004aa7`: + +- Release solution build 0 warnings / 0 errors; +- portable Vulkan set 228/228, ordered/receiver set 41/41, and physical + `Lane=Vulkan` witness 1/1; +- reviewer-focused Vulkan/transform/ordered/receiver set 258/258 and the + restored witness 1/1; +- `artifacts/s5-470-fix2-hermetic-clean-98c004aa7`: 16,976 passed / 0 failed / + 0 skipped, exact clean tip, manifest 30/30; and +- `artifacts/s5-470-fix2-installeddat-inclusive-clean-98c004aa7`: canonical + `Lane=InstalledDat&Purpose!=Diagnostic`, 386 passed / the unchanged 10 + accepted failures / 1 accepted skip, exact clean tip, manifest 30/30. + +Fresh campaign verification after integration: `src`, `tests`, workflow, +release-gate tool/doc, GLSL, generated SPIR-V, and shader manifest were +byte-identical to reviewed scratch; Release built at 0 warnings / 0 errors; +and the combined transform/sidecar, barrier, lane, ordered-stream, and receiver +set passed 48/48. No recipe or bake changed. + +The lead graphical gate is **PROVISIONAL PASS pending owner inspection**. The +first launch attempt at +`logs/selfgate-20260905-032058-s5-470-pinned-shadow-ab` failed before the route +and produced zero PNGs because the default session named a stale recipe-8 +package while the build requires recipe 10. It exited with the managed- +exception code, left no client, and is excluded from renderer acceptance. + +The corrected one-run gate used the already verified recipe-10 package +`artifacts/s5-c4-recipe10-full-20260905/acdream.pak`, SHA-256 +`4E0FA6C589ECE12E13099A56385077964961EC52F888BC9161C6F5D34829B59B`. +Before launch, Release was green, the campaign tree at `19b44e5e3` was clean, +ACE listened on UDP 9000 as PID 13340, and neither acdream nor retail client +was running. `tools/overhaul-selfgate/route-s5-470-shadow-ab.txt` established +the framebuffer and camera before acceptance, then captured retail/off -> High +-> retail/off without movement or resize. The run exited 0, confirmed graceful +logout, and left no client: + +- `logs/selfgate-20260905-032132-s5-470-pinned-shadow-ab-r1/artifacts/screenshots/s5-470-retail-before.png`; +- `logs/selfgate-20260905-032132-s5-470-pinned-shadow-ab-r1/artifacts/screenshots/s5-470-high.png`; +- `logs/selfgate-20260905-032132-s5-470-pinned-shadow-ab-r1/artifacts/screenshots/s5-470-retail-after.png`. + +Lead inspection finds the player and ordinary scene geometry present in all +three frames with no disappearing/corrupted static, transform displacement, +alpha/selection/detail sidecar corruption, or failure to restore the retail +frame. High retains the separately registered #469 lighting-direction shift; +that known blocker is neither waived nor attributed to #470. #470 changes no +retail-visible policy and requires no divergence-register row. Next is #469, +then S5-c5, closeout, and G4. Nothing has merged to `main`.